ipf(8): document all -l options

References to "none", "state", and "nat" were missing in places.
Addresses PR bin/36763 from Wolfgang Stukenbrock.

(gutteridge)

optimize. reduce 2 instructions.

(ryo)

remove reference to gatekeeper.dec.com ftp.

(andvar)

some srm firmware (including legacy platforms) still available at hp ftp.
not sure if HPE selling firmware CDs, but it is definitely not Compaq anymore.

(andvar)

fix link to pkgsrc.tar.gz file in postinstall section.

(andvar)

fix the title of the boot tape creation section.

(andvar)

fix folloing->following typos in more files.
also s/begginning/beginning/.

(andvar)

Restore (again) support for grant tables v1: pvshim doesn't support
v2 (it doesn't even support GNTTABOP_set_version) some setups will
likely require pvshim in the future.

(bouyer)

typo in comment

(dholland)

Modify comment. ixgbe_enable_queue() can be used on both MSI-X and legacy intr.

(msaitoh)

KNF. Modify comment. No functional change.

(msaitoh)

check platform-do-*-mute properties to find out the resp. GPIO's polarity
now this works properly on pmac7,3

(macallan)

If we get the disk description via device properties, the strings may
have arbitrary length - make sure the "available disks" menu fits
on the current screen.

(martin)

Increase the resource limit so these tests pass on hppa.

LGTM from Roland

(skrll)

Trailing whitespace

(skrll)

add timeout period to timeout message.

seen on radeon 5450 on an asrock m/b with ryzen 5600g cpu.

(mrg)

regen.

(mrg)

add some AMD zen2/3 devices.

(mrg)

tidy up backtrace from crash(9) on aarch64

- fix to dump trapframe when backtracing from crash(8).
- use db_read_bytes() when reading kernel memory.

(ryo)

KNF. No functional change.

(msaitoh)

As a tiny optimization, rearrange cases as follows:

(1) load/store of format D (base + disp)
(2) load/store of format X (base + index)
(3) lmw and stmw

For clang-compiled userland (*), their frequencies are roughly,
(1) > (2) >> (3) ~ 0.

Improvement should be minor; we are already trapped in the alignment
fault handler.

(*) clang unconditionally emits unaligned memory access for powerpc.
    Undocumented -disable-ppc-unaligned option does not work...

(rin)

Localize one more variable to NPCI > 0 block. Fix ia64 build.

(rin)

tmux 3.3 out.

(wiz)

cprng(9): cprng_fast is no longer used from interrupt context.

Rip out logic to defer reseeding to softint.

(riastradh)

mvxpsec(4): Fix missing change to freesession return type.

Not sure how this didn't get committed before -- it was supposed to be
part of this change:

https://mail-index.netbsd.org/source-changes/2022/05/22/msg138764.html

(riastradh)

tmpfs_read: respect MNT_NOATIME.

(hannken)

delay slot indentation

(skrll)

Revert previous, the mask is intented to be like sc_output_mask, a bitmask
of active ports.

(martin)

In SNAPPER_OUTPUT_SELECT the "mask" is a bitmap of muted outputs, not
active outputs.

(martin)

Recognize the OF labels used for line output and headphone output on a
G5 powermac 7,3.

(martin)

Correctly enter the recovery mode. Not tested.

(msaitoh)

Correctly re-enable queue interrupt in ixgbe_legacy_irq().

- Don't enable queue 1-15 interrupt.
- Don't enable queue 0 interrupt when the queue work is being scheduled.
- OK'd by knakahara.

(msaitoh)

Simplify ixgbe_msix_que(). No functional change.

(msaitoh)

add now required pci.h / NPCI.  (the ia64 version builds with PCI
enabled, but i guess it won't be usable.)

XXX:  enable this on evbarm*?  it is x86/ia64 only currently.

(mrg)

reorganise most of the NetBSD portion of nvkm_mem_dtor().

when nvkm_mem_new_host() is called via the in-kernel ioctl method,
we copy the supplied dmamap, use it's dm_nsegs value for allocation
of "mem->dma", and assume it remains valid until we're done.

when this path is taken "mem->mem" remains NULL so all the code in
nvkm_mem_dtor() is ignored, and the "mem->dma" is leaked.  this is
one leak seen in PR#56826.  as "dmamap->dm_nsegs" can become invalid
before the dtor call, store the value in "mem->nseg" for use in the
dtor, and convert the dtor to free "mem->dma" if "mem->dma" is set.
additionally, "mem->pages" should end up being the same value as
"nseg" here, ASSERT() this.

while here properly mark NetBSD specific code in nvkm_mem_new_host().

additionally, destroy the dmamap created in the non-ioctl path of
nvkm_mem_new_host().  this is another leak seen in PR#56826.

with both of these fixes my "kmem-04096" pool does not grow rapidly
while using "mpv -vo gpu".  infact, once i loaded the relevant file
into memory, this pool remains stable after at least one minute of
video playback.

ok riastradh@

(mrg)

allow ACPI to compile without PCI support.  fixes ia64 build.

(mrg)

document gomoku

(christos)

Elide vax breakage

(christos)

For some reason on my system, the guest starts with a pending event in
the shared structure. On i386, this cause hypervisor_callback to be
entered before cpu_info_primary is fully initialised, especially on i386
ci_intrstack is still NULL, which cause a crash when we try to use it.
Work around by recycling the boot's tmp stack for this until cpu_attach()
is called.

(bouyer)

When we have pending events in stipending(), evt_set_pending() has to set
the ih_pending flag for each handler too. Xen/i386 should be stable again.

(bouyer)

fix lint build on vax

(christos)

Restore NULL pointer checks lost in rev 1.16.

Fixes PR port-atari/56859, ok'ed mlelstv@, and confirmed on TT030.
Should be pulled up to netbsd-9 and netbsd-8.

(tsutsui)

libpthread(3): Fix a marvellous interaction with rtld.

Patch from chs@.  Comment explaining the story by me.  This patch may
not be optimal -- maybe it would be better in pthread__init, or
better for rtld to call _lwp_unpark after _lwp_park in the contened
case -- but we've tested this version and it's annoying to reproduce,
so let's take this version and worry about testing improvements
later.

(riastradh)

Revert previous; evt_set_pending() will set ret to 1 if needed to this was
not our bug.

(bouyer)

vnd(4): Work around deadlock in VNDIOCCLR.

Since the changes this year to eliminate a host of races and
deadlocks in open, close, revoke, attach, and detach, closing the
last instance of a device special node has the side effect of waiting
for all concurrent I/O operations (read, write, ioctl, strategy, &c.)
on the device to complete.

Unfortunately, while this works for physical devices which revoke
open device nodes in their autoconf detach functions, as invoked by
some hardware interrupt indicating that the device is no longer
present, pseudo-devices like vnd(4) work differently -- or, work by
luck, or don't work any more.

VNDIOCCLR acts kind of like an autoconf detach function in that it
revokes open device nodes, which closes the last instance.  But
VNDIOCCLR is itself called via ioctl, which is an I/O operation that
close waits for.  So we end up with a deadlock, spec_io_drain waiting
for spec_close lower down in the call stack:

> spec_io_drain() at netbsd:spec_io_drain+0x84
> spec_close() at netbsd:spec_close+0x1c6
> VOP_CLOSE() at netbsd:VOP_CLOSE+0x38
> spec_node_revoke() at netbsd:spec_node_revoke+0x14d
> vcache_reclaim() at netbsd:vcache_reclaim+0x4e7
> vgone() at netbsd:vgone+0xcd
> vrevoke() at netbsd:vrevoke+0xfa
> genfs_revoke() at netbsd:genfs_revoke+0x13
> VOP_REVOKE() at netbsd:VOP_REVOKE+0x35
> vdevgone() at netbsd:vdevgone+0x64
> vnddoclear.part.0() at netbsd:vnddoclear.part.0+0xaa
> vndioctl() at netbsd:vndioctl+0x78c
> bdev_ioctl() at netbsd:bdev_ioctl+0x91
> spec_ioctl() at netbsd:spec_ioctl+0xa5
> VOP_IOCTL() at netbsd:VOP_IOCTL+0x41
> vn_ioctl() at netbsd:vn_ioctl+0xb3
> sys_ioctl() at netbsd:sys_ioctl+0x555

In the past, there was a workaround for what was presumably a crash
instead of a deadlock here: don't issue revoke (vdevgone) on the open
character devices for the minor number in use by the ioctl.  If you
use, e.g., `vnconfig -u vnd0', and vnconfig(8) picks /dev/rvnd0c or
/dev/rvnd0d, that special case kicks in.  But if you use `vnconfig -u
/dev/vnd0d', the ioctl will be issued on the block device instead, so
the special case doesn't kick in, so the operation deadlocks.

It is actually probably safe not to revoke the block device if what
the ioctl caller holds open is that, because specfs(9) forbids more
than one open of a block device, so nothing else can have it open
anyway.

Unclear what the consequences of failing to revoke the character
device are -- but this is what vnd(4) has done all along.  cgd(4) and
ccd(4) also don't bother to revoke.  We don't have a notion of
`revoke every file descriptor _except_ this one'; only a vnode as a
whole can be revoked, including all references to it.

This is a stop-gap measure to avoid a deadlock we are definitely
hitting on some users.  A slightly better measure would be to revoke
the block or character device according to which one is being used,
but that requires a little more work with two different d_ioctl
functions -- and wouldn't address isues with the character device.  A
proper solution requires identifying the appropriate protocol for all
of these pseudo-device disk drivers and using it uniformly for them.

Reported on current-users:
https://mail-index.netbsd.org/current-users/2022/05/27/msg042437.html

(riastradh)

libc: Reintroduce getentropy.

This was introduced two years ago when the getrandom/getentropy API
question was still open, and removed because the discussion was
ongoing.  Now getentropy is more widely adopted and soon to be in
POSIX.  So reintroduce the symbol into libc since we'll be keeping it
anyway.  Discussion of details of the semantics, as interpreted by
NetBSD, is ongoing, but the symbol needs to get in before the
netbsd-10 branch.  The draft POSIX text is
(https://www.opengroup.org/austin/docs/austin_1110.pdf):

    SYNOPSIS
        #include <unistd.h>

        int getentropy(void *buffer, size_t length);

    DESCRIPTION
        The getentropy() function shall write length bytes of data
        starting at the location pointed to by buffer. The output
        shall be unpredictable high quality random data, generated by
        a cryptographically secure pseudo-random number
        generator. The maximum permitted value for the length
        argument is given by the {GETENTROPY_MAX} symbolic constant
        defined in <limits.h>.

    RETURN VALUES
        Upon successful completion, getentropy() shall return 0;
        otherwise, -1 shall be retunred and errno set to indicate the
        error.

    ERRORS
        The getentropy() function shall fail if:

        [EINVAL]        The value of length is greater than
                        {GETENTROPY_MAX}.

        The getentropy() function may fail if:

        [ENOSYS]        The system does not provide the necessary
                        source of entropy.

    RATIONALE
        The getentropy() function is not a cancellation point.

Minor changes from the previous introduction of getentropy into libc:

- Return EINVAL, not EIO, on buflen > 256.
- Define GETENTROPY_MAX in limits.h.

The declaration of getentropy in unistd.h and definition of
GETENTROPY_MAX in limits.h are currently conditional on
_NETBSD_SOURCE.  When the next revision of POSIX is finalized, we can
expose them also under _POSIX_C_SOURCE > 20yymmL as usual -- and this
can be done as a pullup without breaking existing compiled programs.

(riastradh)

s/longeset/longest/ and s/collsion/collision/ in comments.

(andvar)

stipending(): if we're going to process some interrupts don't return 0.
Hopefully fixes random hang seen in i386 Xen PV.

The bug has been there ~forever but was masked by the fact that spllower()
did call event handlers much more often.

(bouyer)

s/disbale/disable/ and s/enbale/enable/ in comments. also one more typo fix.

(andvar)

fix various typos in comments, documentation and messages.

(andvar)

make a frame pointer to show a backtrace correctly.

(ryo)

Avoid plabels on hppa to make some tests not crash

(skrll)

whitespace including space before delay slot instruction.

(skrll)

add .mobi / application/x-mobipocket-ebook.

(mrg)

lint: fix null pointer dereference after syntax error

Found by afl, starting with the malformed input '/**/f=({;/**/};}' that
no longer crashes.  This input led to 'f=({L:;}', which is at least a
syntactically valid prefix of a translation unit, containing a GCC
statement expression with an unused label.  The error message for this
unused label assumed that it would always be inside a function
definition.

While here, document incomplete recovery after syntax errors, in
msg_249.c.

(rillig)

nouveau(4): Fix error branches in nouveau_gem_new.

PR kern/56804

(riastradh)

lint: prevent assertion failure after parse error from grammar

Instead of running into an assertion failure, the malformed input
'f=({;};}' now generates:

malformed.c(1): error: syntax error ';' [249]
malformed.c(1): warning: ({ }) is a GCC extension [320]
malformed.c(1): warning: ({ }) is a GCC extension [320]
malformed.c(1): error: cannot recover from previous errors [224]

(rillig)

re-do previous - it likely broke kmem cache init.

use {0} for zero sentinel.

(mrg)

lint: clean up comments

No binary change.

(rillig)

lint: clean up usage messages

The two synopsis forms differed in the spelling of 'file ...'.

The options string for getopt does not start with ':', which led to a
duplicate message 'unknown option -- ?' followed by 'Unknown flag ?'.

Be more specific when calling 'lint file.c -u'; the message 'Unknown
argument' was not helpful as it didn't pinpoint that there are two
different phases for parsing options.  In the second phase, only the
options '-L' and '-l' are recognized.

In the manual page, mention the difference between the two synopsis
forms as early as possible.  The two synopsis forms are very similar and
both have far to many options to see the difference at a glance.

(rillig)

apply some missing #ifn?def KDTRACE_HOOKS from the previous.

(mrg)

Use the ABI value for 'R_AARCH64_TLSLD_LDST128_DTPREL_LO12_NC'.

(jkoshy)

kmem(9): Create dtrace sdt probes for each kmem cache size.

The names of the probes correspond to the names shown in vmstat -m.
This should make it much easier to track down who's allocating memory
when there's a leak, e.g. by getting a histogram of stack traces for
the matching kmem cache pool:

  # vmstat -m
  Memory resource pool statistics
  Name        Size Requests Fail Releases Pgreq Pgrel Npage Hiwat Minpg Maxpg Idle
  ...
  kmem-00128  256    62242    0        0  3891    0  3891  3891    0  inf    0
  ...
  # dtrace -n 'sdt:kmem:*:kmem-00128 { @[probefunc, stack()] = count() }'
  ^C

When there's no leak, the allocs and frees (probefunc) will be roughly
matched; when there's a leak, the allocs will far outnumber the frees.

(riastradh)

virtio at pci: Provide attribution in debug message.

Also make it only happen in the error case so success doesn't clutter
up the console output.

(riastradh)

Set DP early so that any binary functions that override others get the
right value if they're called before _start.  This is true of bash where
it provides its own getenv.

Part of port-hppa/56118: sporadic app crashes in HPPA -current

(skrll)

Fix dates for previous; it is still 20220530 for UTC ;)

(rin)

Remove comment-outed garbage.

(rin)

lint: report proper file name in assertion failures

When given the (obviously malformed) translation unit 'f=({;};}', lint
runs into an assertion failure.  It reported this as occurring near
':1'.  This location was missing a filename since the input didn't
contain a GCC line number directive such as '# 2 "input.c"'.  In GCC mode,
the GCC builtins are loaded first, in which case the reported location
was ':9'.

Fix this by providing proper location information, even for input that
does not come from the GCC C preprocessor.

(rillig)

Document changes for powerpc:
- Fix userland unaligned memory access for 403.
- Unify libc binaries among all 32-bit ppc ports.

(rin)

Introduce libc_aligned.so for evbppc-powerpc32, which provides
strictly-aligned versions of memcmp(3), bcopy(3), memcpy(3), and
memmove(3).

This is used for 403 by ld.so.conf with machdep.no_unaligned variable.

With this library, unaligned memory accesses are significantly reduced
for 403 (from several hundreds to few tens per sec under heavy load);
only ld.elf_so (typically few times per fork) and statically-linked
binaries do such access.

(rin)

Export CPU capability of unaligned memory access to userland
as machdep.no_unaligned sysctl(7) variable.

This will be used for ld.so.conf in order to provide strictly-
aligned versions of libc routines.

(rin)

Obsolete hack for evbppc to replace memcmp(9), memcpy(9), and memmove(9)
with strictly-aligned versions.

Now all 32-bit powerpc ports share the same libc binary.

This change together with the preceding similar change in libkern slightly
improve performance for DHT (ibm4xx/405GP) and RB800 (MPC8533E).

See changes in bytebench scores:

- DHT https://gist.github.com/rokuyama/301063355de9733bea515b84ef574c0a
- RB800 https://gist.github.com/rokuyama/60ad665d367d6d110b79ec44707f39ff

Improvements may be negligible, but this does not cause performance
regressions at least.

This hack was for 403, but unaligned memory access is now emulated by
kernel. This should result in serious performance regression for 403.
We will provide strictly-aligned versions by ld.so.conf.

(rin)

More factoring of common code.  NFCI

(pgoyette)

Restrict strictly-aligned versions of memcmp(9), memcpy(9), and
memmove(9) to 403, instead of all evbppc machines.

Introduce strict-align LIBKERN_MD_FLAGS for this purpose.

(rin)

Introduce LIBKERN_MD_FLAGS to pass some MD flags for libkern.

This is necessary since libkern is built by coprocess, and
threfore subsets of make(1) variables are passed.

(rin)

For IBM_PPC403, emulate unaligned memory access for userland process.

(rin)

Introduce PPC_NO_UNALIGNED flag to indicate that CPU cannot handle
unaligned memory access, and emulation should be provided to userland.

(rin)

Add routines to fix unaligned memory access for userland process.

Mainly intended for 403, which cannot handle unaligned memory access
at all (not only ones across page boundaries like 601).

For more details, see comments in fix_unaligned.c.

(rin)

s/identifing/identifying/ and s/multipler/multiplier/ in comments.

(andvar)

tests/lint: explain how lint represents pointer addition

(rillig)

lint: revert 'do not pre-multiply pointer expressions' from 2022-05-26

In tree.c 1.448, removing the pre-multiplication generated wrong
warnings about out-of-bounds array access.

(rillig)

tests/lint: demonstrate wrong warning 'array subscript cannot be'

Since tree.c 1.448 from 2022-05-26.

(rillig)

lint: fix assertion failure in '(unsigned long)(ptr) >> 12'

Since tree.c 1.449 from 2022-05-26.

(rillig)

Remove unused adapter->msix_mem.

(msaitoh)

Fix a bug that the legacy interrupt doesn't work when MSI-X allocation failed.
Fixes PR kern/56857.

(msaitoh)

Update test so all four combinations of update_{upper, lower} x
monitor_{upper, lower}} can be verified.  Currently update_upper
is expected to fail regardless of which file is being monitored.

PR kern/56713

(pgoyette)

Display the trap type of trapframe when backtracing.

(ryo)

ESR_EL1 and FAR_EL1 are not required in interrupt trapframe and their values are meaningless.
To identify it as an interrupt trap frame, store -1 and 0.

(ryo)

lint: fix wrong errors about sizeof of a bit-field (since 2022-05-26)

(rillig)

tests/lint: demonstrate wrong errors 'size/alignment of bit-field'

Since tree.c 1.444 from 2022-05-26, which added range and bit checks for
integer expressions, not taking into account that querying for the size
of a bit-field type triggers an error message.

(rillig)

Apply extra delay quirk for

- Intel 7 Series (mobile) SATA Controller (AHCI):
  rev. 0x04 sometimes fails to probe Seagate ST500LT012.

Reported by RVP. Thanks!

(rin)

gomoku: clean up variable names, add empty lines

No binary change.

(rillig)

gomoku: clean up color handling in 'pickmove'

Instead of searching for the best black and white moves, search instead
for our and their best moves. This makes the code simpler and more
uniform, as the strategy is the same for Black and White.

No functional change.

(rillig)

gomoku: clean up 'pickmove' stylistically

No functional change.

(rillig)

gomoku: migrate remaining functions to type player_color

No functional change.

(rillig)

gomoku: make parsing of the debug command 'o' robust

Previously, the (invalid) debug command 'o,' succeeded to parse and led
to out-of-bounds memory access. Add proper parsing for the arguments of
that debug command. Add a short usage for that debug command, as
guessing the usage from the previous code was time-consuming due to the
large amount of ad-hoc low-level parsing code.

When leaving debug mode, clear the debug prompt.

(rillig)

gomoku: clean up overlap info in 'checkframes'

In 2009, GCC had complained that the overlap_info might only be
partially filled. All possible code paths are sane though, so that was
probably a bug in GCC.

Remove the comment and the unnecessary initialization, rename the
variable since it doesn't match its behavior anymore. Sync nearby
comments with reality; there is no array anywhere near.

No functional change.

(rillig)

gomoku: do not scan the upper border for combos

Adding the '+ 1' to the row coordinate added an offset of 20, while the
intended offset was 1.

No functional change, just a bit faster.

(rillig)

gomoku: refine the type of some functions and variables

Assisted by WARNS=6. At that level, there are several warnings about
type conversion between small integer types that would only clutter the
code, therefore stay at WARNS=5. Same for lint's -aa option.

No functional change.

(rillig)

- Display "cpu[<CPUINDEX>]" instead of "cpu[<CPUID>]".
- Also add cpu_info->ci_onproc to display.

(ryo)

Use the PAR register to check for accessibility in db_(read|write)_bytes().

db_(read|write)_bytes() uses the TTBR[01] at that time, so it must check
if it is accessible in context at that time, not pmap_extract()
which uses the struct pmap of the process.

- It also checks if the address is writable.
- db_write_bytes() also requires ARMV81_PAN control.

(ryo)

gomoku: when starting a new game, start in the middle of the board

Previously, when starting a new game, the user coordinate was kept at
the previously selected spot. Since playing in the center is common
sense, reset the coordinate.

(rillig)

gomoku: after accepting a spot via the mouse, clear current coordinate

(rillig)

fix build without options DDB

(ryo)

Simplified termination conditions for ddb backtrace.

Exit backtrace when the user trapframe is invalid. (Mainly in kernel threads).

(ryo)

gomoku: add type player_color

No functional change.

(rillig)

mk: Add MKTIMED and MKMOUSED flags for compiling NetBSD without timed
and moused

(nia)

gomoku: use unsigned integers for bit sets

As all access to the bit sets happens through the unsigned spot_index
type, drop the type casts in the macros.

No functional change on 2s complement machines.

(rillig)

gomoku: provide a more gentle introduction to the code

No binary change.

(rillig)

gomoku: don't use 'i' as special-purpose variable name

No binary change.

(rillig)

gomoku: consistently name the offset of a spot in a frame 'off'

Leave 'i' for general purpose loops.

No functional change.

(rillig)

gomoku: add data type for one of the 4 directions of a frame

No functional change.

(rillig)

gomoku: clean up four_in_a_row

No functional change.

(rillig)

Expand and escape comments. One minor change to variable expansion
as requested by uwe.

(nia)

gomoku: extract quick_check from scanframes

No functional change.

(rillig)

Make it compile again

(martin)

Fix insn field definitions for MD and MDS formats.

No one uses these yet.

(rin)

gomoku: use proper types when indexing 'board' and 'frames'

No functional change.

(rillig)

Apply extra delay quirk for followings:

- Intel Braswell AHCI: rev. 0x35 fails for Seagate ST2000LX001.

- Intel 8 Series (desktop) SATA Controller (AHCI): rev. 0x04 fails for
  Seagate ST1000LX015 and WD WD10JPVX, whereas it works without the
  quirk for some SSD models...

Reported by Matthias Petermann. Thanks!

(rin)

Avoid null SEGV if libargon passed string with too few $

Seen on netbsd-9 built xscreensaver running on a current system.
Whatever triggered this should also be fixed, but in the meantime
we can improve the behaviour from "Segmentation Fault"

(abs)

Regen for GENERIC.in rev. 1.149.

(rin)

Free strdup'd value in libargon decode_option error paths

If its worth freeing in the success path, its worth freeing in the
error path... (given we don't _exit or similar)

(abs)

fix various typos in comments and log messages.

(andvar)

le(4): Fix resource leaks for error paths.

XXX
Compile test only (at least one arch per driver).

(rin)

Audit unload/unmap v.s. free against DMA buffer for sys/dev;
make sure that bus_dmamap_unload(9) [or bus_dmamap_destroy(9)] or
bus_dmamem_unmap(9) are preceding to freeing DMA buffer, if it is
loaded or mapped, respectively.

This is mandatory for some archs. See, e.g.:

http://www.nerv.org/netbsd/?q=id:20210511T013030Z.013443cc790088147e4beed43f53dedabeaf9312
http://www.nerv.org/netbsd/?q=id:20220511T172220Z.561179f0b6fcc5b9cd73e274f69d74e2ce9e4c93

For some drivers, resource leaks for error paths are fixed at
the same time.

XXX XXX XXX
Compile test only (at least one arch per driver).

(rin)

s/littel/little/ mainly in copy pasted comments.

(andvar)

gomoku: turn spotstr.s_frame into a frame index

Most calculations are done on the frame index, not the pointer. This
avoids dealing with ptrdiff_t conversion to int.

Changing the type of s_frame changes the size of struct spotstr, it is
now 56 bytes on LP64 and 48 bytes on ILP32, neither of which is a power
of two. Remove the dummy padding since compilers no longer generate
division instructions for divisions by small integer constants, so that
optimization is no longer necessary.

No functional change.

(rillig)

gomoku: document where to fix the unnecessarily long thinking time

(rillig)

Document MKPPP

(nia)

One more typo; this is called _atomic_swap_64, not _8.

(rin)

mk: Add a MKPPP flag to exclude pppd(8) and related utilities from
the build

(nia)

Fix typo; this is "and", not "add".

(rin)

Add missing Hyper-V devices from GENERIC.

(rin)

Avoid exec'ing bc. Pointed out by uwe.

(nia)

Explanations requested by uwe...

(nia)

CHANGES: minor grammar fixes

(gutteridge)

gomoku: migrate 'makemove' to using spot_index instead of pointer

No functional change.

(rillig)

gomoku: migrate pickmove to use spot_index instead of pointers

Using spot_index instead of pointers leads to simpler code since there
is no need to deal with conversion from ptrdiff_t to spot_index.

No functional change.

(rillig)

gomoku: migrate spot_index from int to unsigned short

This matches the type of 'intersect'.

No functional change.

(rillig)

gomoku: use consistent variable names

Previously, the name 's' was used for the index of a spot on the board,
as well as for the value of a combo, and for a few other purposes. Use
different names and mark the spot indexes using a custom type.

No binary change.

(rillig)

gomoku: use custom magic value for end of file input

This allows the type for a spot index to be changed to an unsigned type.

No functional change.

(rillig)

s/heigth/height/ in a function argument name.

(andvar)

fix various typos in comments.

(andvar)

s/grabing/grabbing/ in comments.

(andvar)

s/hidding/hiding/

(andvar)

s/hierach/hierarch/

(andvar)

s/knowlege/knowledge/

(andvar)

gomoku: use unsigned arithmetic for bitboard

No functional change.

(rillig)

gomoku: document that 'whatsup' is called on ^C as well

(rillig)

fix various typos in comments, mainly origional->original,
extened->extended, incomming->incoming.

(andvar)

gomoku: allow saving a finished game without pressing Shift

(rillig)

gomoku: remove redundant parentheses, braces, newlines, clean up get_key

No functional change.

(rillig)

gomoku: clean up initialization of overlap information

Fix variable names 'ia' and 'ib', which I forgot in the previous commit.

Move the documentation in the right places.

Split off another part of init_overlap, to make each function fit on a
single screen. Reducing the number of nested 'for' loops allows the
indentation to follow the NetBSD style.

No functional change.

(rillig)

gomoku: clean up local variable names in init_overlap

By clearly associating each variable to either frame A or frame B,
suddenly the code becomes understandable. For the benefit of future
readers, explain the naming scheme.

No functional change.

(rillig)

gomoku: split initialization of the board into smaller functions

The comments about the "top border" and "bottom border" had been wrong
all the time. Mention the corners in the comments, to remove the magic
from the various '+ 1' in the code.

No functional change.

(rillig)

fixed typo with another typo in my last commit. fixing it again.

(andvar)