Link [ NetBSD | NetBSD OpenGrok source search | PR fulltext-search | Summary of daily snapshot builds | history of daily build result | pkgsrc commit viewer ]


   
        usage: [branch:branch] [user:user] [path@revision] keyword [... [-excludekeyword [...]]] (e.g. branch:MAIN sys/arch/arm, if_wm.c@1.234 )




switch to index mode

recent branches: MAIN (4h)  netbsd-10 (17d)  netbsd-9 (17d)  netbsd-8 (22d) 

2024-06-03 07:03:05 UTC Now

2022-09-04 21:37:50 UTC MAIN commitmail json YAML

2022-09-04 20:06:26 UTC MAIN commitmail json YAML

2022-09-04 17:34:44 UTC MAIN commitmail json YAML

In pktq_flush():
- Run a dummy softint at IPL_SOFTNET on all CPUs to ensure that the
  ISR for this pktqueue is not running (addresses a pre-existing XXX).
- Hold the barrier lock around the critical section to ensure that
  implicit pktq_barrier() calls via pktq_ifdetach() are held off during
  the critical section.
- Ensure the critical section completes in minimal time by not freeing
  memory during the critical section; instead, just build a list of the
  packets pulled out of the per-CPU queues and free them after the critical
  section is over.

(thorpej)

2022-09-04 16:01:25 UTC MAIN commitmail json YAML

Revert previous

kern/56994: wm(4) panic on attach in interrupt_distribute, sometimes

(skrll)

2022-09-04 15:59:08 UTC MAIN commitmail json YAML

Add standard inet headers.

(rjs)

2022-09-04 13:32:14 UTC MAIN commitmail json YAML

2022-09-04 13:18:33 UTC MAIN commitmail json YAML

Simplify; no need to override ``type'' here. NFC.

(rin)

2022-09-04 13:17:33 UTC MAIN commitmail json YAML

Simplify logic to remove needless goto. NFC.

(rin)

2022-09-04 13:16:47 UTC MAIN commitmail json YAML

Update FR and FI (and undefined FPRF) for ``round to integer'' insns.

(rin)

2022-09-04 13:14:57 UTC MAIN commitmail json YAML

Fix logic for FI, FR, and FPRF fields of FPSCR.

They are not sticky bits and updated by arithmetic and round
insns at the same time.

Comparison insns update only FPCC sub-field of FPRF.

For other insns, these field are left untouched.

Also, for single-precision insns, exception bits should be set by
the first fpu_implode(), which rounds the value to float.

(rin)

2022-09-04 11:20:33 UTC MAIN commitmail json YAML

Release mutexes earlier in xenevt_free(), to call *destroy and kmem_free
without holding spin locks. Fixes an occasional deadlock seen when the qemu
backing a HVM domU exits.

(bouyer)

2022-09-04 10:20:33 UTC MAIN commitmail json YAML

pcihost: Don't call fdtbus_intr_disestablish for MSI/MSI-X interrupts.

This avoids a KASSERT firing when using 'drvctl -d' on a pci device that
uses MSI/MSI-X interrupts.

(skrll)

2022-09-04 09:23:07 UTC MAIN commitmail json YAML

Fix debug printf. Unbreak DEBUG build.

(rin)

2022-09-04 09:20:55 UTC MAIN commitmail json YAML

2022-09-04 08:55:43 UTC MAIN commitmail json YAML

bge(4): Use BUS_DMA_WAITOK in ring initilization now that it's safe

(skrll)

2022-09-04 08:50:26 UTC MAIN commitmail json YAML

bge(4): fix the MP improvements and improve some more.

- Have two locks sc_core_lock at IPL_NONE and sc_intr_lock at IPL_NET and
  use appropriately.

- Use stopping flags instead of bge_if_flags so that bge_if_flags only
  needs to be protected by the sc_core_lock

- Use ifmedia_init_with_lock and provide the sc_intr_lock. mii operatiions
  are done from the interrupt handler.

- Fixup locking in bge_detach.

- Rename bge_watchdog to bge_watchdog_tick to avoid confusion with the
  if_watchdog method.

- Sprinkle some more asserts.

(skrll)

2022-09-04 08:42:02 UTC MAIN commitmail json YAML

bge(4): use a local variable to make bge_ifmedia initialization pretty.

NFC

(skrll)

2022-09-03 20:29:31 UTC MAIN commitmail json YAML

2022-09-03 15:03:32 UTC MAIN commitmail json YAML

Only update distrib/sets/lists/tests/mi with valid files

sync-mi: use CVS/Entries to ensure we only update
distrib/sets/lists/tests/mi with files known to CVS.

Reviewed by: rillig

(sjg)

2022-09-03 10:03:20 UTC MAIN commitmail json YAML

bpf(4): Reject bogus timeout values before arithmetic overflows.

Reported-by: syzbot+fbd86bdf579944b64a98@syzkaller.appspotmail.com
https://syzkaller.appspot.com/bug?id=60d46fd4863952897cbf67c6b1bcc8b20ec7bde6

XXX pullup-8
XXX pullup-9

(riastradh)

2022-09-03 09:41:24 UTC MAIN commitmail json YAML

2022-09-03 08:41:07 UTC MAIN commitmail json YAML

make: untangle output handling in jobs mode, remove redundant braces

No functional change.

(rillig)

2022-09-03 08:03:27 UTC MAIN commitmail json YAML

make: fix handling of null bytes in the output in jobs mode

The test job-output-null failed occasionally, depending on the exact
timing of the child's write and make's read.

(rillig)

2022-09-03 07:45:08 UTC MAIN commitmail json YAML

2022-09-03 04:54:47 UTC MAIN commitmail json YAML

Localize addr and buf. NFC.

(rin)

2022-09-03 04:54:08 UTC MAIN commitmail json YAML

Fix weird logic. NFC.

Set both type and size to double by default, and change both to
single if required.

(rin)

2022-09-03 04:52:50 UTC MAIN commitmail json YAML

Do not use ``cond'' for two purposes: flag and bit field.
For the latter, use ``bits'' instead. Switch ``cond'' to int.
NFC.

(rin)

2022-09-03 03:33:37 UTC MAIN commitmail json YAML

tests/make: remove nonexistent file from file list

The file had been added accidentally, it never existed in distdir.

(rillig)

2022-09-03 03:11:56 UTC MAIN commitmail json YAML

2022-09-03 02:53:18 UTC MAIN commitmail json YAML

Garbage-collect everything related to struct domain::dom_ifqueues
(except dom_ifqueues itself, until the next kernel version bump).
It's no longer used now that nothing uses the legacy netisr mechanism.

(thorpej)

2022-09-03 02:48:01 UTC MAIN commitmail json YAML

2022-09-03 02:25:00 UTC MAIN commitmail json YAML

2022-09-03 02:07:33 UTC MAIN commitmail json YAML

2022-09-03 01:48:22 UTC MAIN commitmail json YAML

2022-09-03 01:35:04 UTC MAIN commitmail json YAML

2022-09-03 00:50:07 UTC MAIN commitmail json YAML

make: clean up handling of .break in .for loops

Move For_Break further up, as the functions in that file are sorted from
small to big.  The cast from size_t to unsigned int is required by lint.

In parse.c, move the code into a separate function to keep
ParseDirective small.  Its only job is to parse the directive and then
delegate to another function doing the actual work.

In the manual page, remove empty lines.

In the test, ensure that .break stops processing of the .for loop
immediately; anything after the .break is not processed anymore.
Replace ':=' with '=', as there is no need to evaluate '$i' early.
Check the expected value in the .mk file instead of the .exp file, to
keep the reading scope as small as possible.

(rillig)

2022-09-03 00:31:02 UTC MAIN commitmail json YAML

Only use configured RPS hash functions for IPv4 and IPv6 packets.

This is NFC change now because only IPv4 and IPv6 use pktqueue,
but that will change in future commits.

(thorpej)

2022-09-02 23:48:11 UTC MAIN commitmail json YAML

2022-09-02 18:54:25 UTC MAIN commitmail json YAML

Enable make/unit-tests/directive-for-break

Also ensure MAKE_VERSION is ignored.

(sjg)

2022-09-02 16:24:31 UTC MAIN commitmail json YAML

make: add .break to terminate .for loop early

When .break is encountered within a .for loop
it causes immediate termination.

Outside of a .for loop .break causes a parse error.

Reviewed by: christos

(sjg)

2022-09-02 12:48:05 UTC MAIN commitmail json YAML

fpu_implode(): Clear lower word for float just for sure.

(rin)

2022-09-02 12:47:10 UTC MAIN commitmail json YAML

Fix fres and frsqrte.
- Pass correct fp to succeeding fpu_implode().
- fres calculates 1 / frB; not 1 / sqrt(frB).

(rin)

2022-09-02 12:40:49 UTC MAIN commitmail json YAML

2022-09-02 12:30:48 UTC MAIN commitmail json YAML

Use hi and lo for higher and lower words, instead of i and j.
No binary changes.

(rin)

2022-09-02 12:29:58 UTC MAIN commitmail json YAML

fpu_subr.c: Convert #ifdef DIAGNOSTIC panic() --> KASSERT{,MSG}().

(rin)

2022-09-02 12:24:54 UTC MAIN commitmail json YAML

Fix off-by-one error in exponent when round a double to the
largest normalized value; QNaN was wrongly generated here.

(rin)

2022-09-02 12:22:50 UTC MAIN commitmail json YAML

Make fpu_ftod() return uint64_t value. NFC.

(rin)

2022-09-02 11:03:50 UTC MAIN commitmail json YAML

dtrace_fbt: Allow tracing names that start with `__'.

This was never relevant on FreeBSD and I don't think it is relevant on
NetBSD either.  The FreeBSD change to lift this restriction had the
following comment:

    r306570 | markj | 2016-10-02 00:35:00 +0000 (Sun, 02 Oct 2016) | 7 lines

    Allow tracing of functions prefixed by "__".

    This restriction was inherited from upstream but is not relevant on FreeBSD.
    Furthermore, it hindered the tracing of locking primitive subroutines.

(riastradh)

2022-09-02 06:51:24 UTC MAIN commitmail json YAML

Whitespace - mostly align the line continutation characters

(skrll)

2022-09-02 06:25:43 UTC MAIN commitmail json YAML

2022-09-02 06:01:38 UTC MAIN commitmail json YAML

Fix "error: cast from pointer to integer of different size" on
sparc build.

(nakayama)

2022-09-02 05:50:36 UTC MAIN commitmail json YAML

Re-factor how pktq_barrier() is issued by if_detach().

Rather than excplicitly referencing ip_pktq and ip6_pktq in if_detach(),
instead add all pktqueues to a global list.  This list is then used in
the new pktq_ifdetach() function to issue a barrier on all pktqueues.

Note that the performance of this list is not critical; it will seldom
be accessed (then pktqueues are created/destroyed and when network
interfaces are detached), and so a simple synchronization strategy using
a rwlock is sufficient.

(thorpej)

2022-09-02 05:09:49 UTC MAIN commitmail json YAML

Fix the syntax of the non _LP64 code fragment to match that in the
_LP64 fragment, so hopefully 32 bit ports with XEN (i386) will
build again.

(kre)

2022-09-02 04:34:58 UTC MAIN commitmail json YAML

f_detach(): Drain the protocol input queues before the pr_purgeif()
calls; pktq_barrier() doesn't remove packets from the queue, it waits
for the packets enqueued before the barrier to drain.  This, in turn,
may cause the protocols to gain additional references to the interface
that's detaching.  By draining the queues first, we ensure that no
additional references will be taken after calling pr_purgeif().

(thorpej)

2022-09-02 03:50:00 UTC MAIN commitmail json YAML

pktqueue: Re-factor sysctl handling.

Provide a new pktq_sysctl_setup() function that attaches standard
pktq sysctl nodes below a specified parent node, with either a
fixed node ID or CTL_CREATE to dynamically assign node IDs.  Make
all of the sysctl handlers private to pktqueue.c, and remove the
INET- and INET6-specific pktqueue sysctl code from net/if.c.

(thorpej)

2022-09-02 03:43:53 UTC MAIN commitmail json YAML

ktrace.1: correct historical reference and minor grammar tweak

(gutteridge)

2022-09-02 03:39:29 UTC MAIN commitmail json YAML

kdump.1: use past tense for history

(gutteridge)

2022-09-01 18:32:25 UTC MAIN commitmail json YAML

cprng_fast(9): Assert not in pserialize read section.

This may sleep to take the global entropy lock in case it needs to be
reseeded.  If that happens we can't be in a pserialize read section.

(riastradh)

2022-09-01 18:32:17 UTC MAIN commitmail json YAML

nd6: Take ifnet psref around cprng_fast in nd6_slowtimo.

This may sleep on an adpative mutex, the global entropy lock, so
pserialize is forbidden.

(riastradh)

2022-09-01 18:09:45 UTC MAIN commitmail json YAML

xhci(4): Make sure to destroy sc_rhlock on detach.

(riastradh)

2022-09-01 17:54:48 UTC MAIN commitmail json YAML

drmfb: Rework console detection and takeover.

While here, simplify logic by removing an unreachable error branch so
we never have to contemplate unwinding claiming of the console.

(riastradh)

2022-09-01 16:28:08 UTC MAIN commitmail json YAML

Call extent_alloc_subregion() with EX_MALLOCOK; under heavy I/O load we need
lots of them and the preallocatted extent descriptors are not enough.

(bouyer)

2022-09-01 16:25:18 UTC MAIN commitmail json YAML

process_msg() is called from thread context, so malloc() can wait for
memory. Should avoids occasional ENOMEM reading messages

(bouyer)

2022-09-01 15:33:23 UTC MAIN commitmail json YAML

in backend drivers, use xen_shm_(un)map for the rings instead of inline,
mostly duplicate code.

(bouyer)

2022-09-01 15:32:16 UTC MAIN commitmail json YAML

Redo previous; kill the right printf()

(bouyer)

2022-09-01 12:36:14 UTC MAIN commitmail json YAML

xen: Add experimental support for PVH dom0.

(bouyer)

2022-09-01 12:35:02 UTC MAIN commitmail json YAML

Add commented out experimental PVH dom0 options and pseudo-device

(bouyer)

2022-09-01 12:31:26 UTC MAIN commitmail json YAML

Remove a noisy printf; HVM guests triggers it (a lot) and it seems to be
expected.

(bouyer)

2022-09-01 12:29:00 UTC MAIN commitmail json YAML

2022-09-01 12:26:00 UTC MAIN commitmail json YAML

Adjust privcmd_notify() so it has a chance to work in a PVH environnement too.

(bouyer)

2022-09-01 12:01:36 UTC MAIN commitmail json YAML

drmfb: Take is_console property from parent, not from self.

The parent is the pci or platform device that firmware knows about.
The `drmfb' device is more of a fictitious invention of the drm stack
that exists for the convenience of the genfb abstraction which needs
device_private to be a struct genfb_softc.

Let's see if this does any better than the last attempt to rework the
logic here.

(riastradh)

2022-09-01 11:49:23 UTC MAIN commitmail json YAML

i915: Stop pretending the GTT size is zero as workaround.

Whatever bug this was I don't know how to reproduce any more.
Convinces Mesa iris_dri.so to work on this kernel.

(riastradh)

2022-09-01 11:48:59 UTC MAIN commitmail json YAML

drm_mm: Give up on trying to phrase find_hole with public rbtree API.

Firefox works with WebGL on Mesa iris_dri.so now.

(riastradh)

2022-09-01 10:10:20 UTC MAIN commitmail json YAML

2022-09-01 09:37:06 UTC MAIN commitmail json YAML

drm: Fix dma fence stub fix so the lock is actually initialized.

Tested but forgot to amend change before exporting to CVS again.

(riastradh)

2022-09-01 06:10:58 UTC MAIN commitmail json YAML

2022-09-01 06:08:16 UTC MAIN commitmail json YAML

Set FPSCR[FPRF] for calculated result, for all instructions
that are documented to update this field.

Exceptions are fcti{w,d}{,z}; FPSCR[FPRF] becomes undefined,
according to Power ISA. We do not overwrite this field for
these insns at the moment.

(rin)

2022-09-01 05:58:19 UTC MAIN commitmail json YAML

2022-09-01 05:56:52 UTC MAIN commitmail json YAML

Further fix for fcti{w,d}{,z}.

- Treat {Q,S}NaN correctly.
- Set exception bits appropriately.
- Introduce round_int().

(rin)

2022-09-01 05:51:51 UTC MAIN commitmail json YAML

2022-09-01 05:04:22 UTC MAIN commitmail json YAML

pktq_rps_hash(): Make the "funcp" argument const.

(thorpej)

2022-09-01 02:35:06 UTC MAIN commitmail json YAML

pktq_dequeue(): Prevent packets from getting stuck beind barrier markers.

pktq_barrier() ensures that all packets enqueued before the barrier have
been dequeued before the barrier returns.  However, previously, pktq_dequeue()
would return NULL when a barrier marker was encountered.  If there were
packets queued up behind the marker and no additional softint were scheduled
for the pktqueue, those packets would end up stranded.  pktq_dequeue() now
continues to the next slot after the marker, ensuring that processing can
continue after the barrier has been signaled.

(thorpej)

2022-09-01 01:54:38 UTC MAIN commitmail json YAML

2022-09-01 01:54:28 UTC MAIN commitmail json YAML

drm_mm: Match __drm_mm_interval_first semantics.

- Use the right search criterion.
- Return &mm->head_node, not NULL, if not found.

(riastradh)

2022-08-31 14:00:44 UTC MAIN commitmail json YAML

If we check XENPV, make sure to #include "opt_xen.h"

(bouyer)

2022-08-31 12:53:27 UTC MAIN commitmail json YAML

Remove XENPV support from xenmem; it's only used for !XENPV at this time.

(bouyer)

2022-08-31 12:51:56 UTC MAIN commitmail json YAML

Work in progress on dom0 PVH support: ioctl support for tools.
Basically, in PVH mode (where XENFEAT_auto_translated_physmap is enabled),
the hypervisor will not map foreing ressources in our virtual address
space for us. Instead, we have to pass it an address in our physical
address space (but not mapped to some RAM) where the ressource will show up
and then enter this PA in pour page table.

For this, introduce xenmem_* which manage the PA space. In PVH mode this
is just allocated from the iomem_ex extent.

With this, I can start a PV domU, and the guest's kernel boots (and
the console works). It hangs because the backend driver can't map the
frontend ressources (yet).

Note that, per https://xenbits.xen.org/docs/unstable/support-matrix.html,
dom0 PVH support is still considered experimental by Xen.

(bouyer)

2022-08-31 12:34:04 UTC MAIN commitmail json YAML

dtrace_sdt: Fix bug in builtin module reference counting.

Don't module_hold(NULL)!  This mistake was introduced in my attempt
to get dtrace working for sdt probes defined in non-builtin modules
like zfs.

(riastradh)

2022-08-31 12:18:41 UTC MAIN commitmail json YAML

reallocarr(3): Touch up xrefs.

(riastradh)

2022-08-31 12:17:14 UTC MAIN commitmail json YAML

reallocarr(3): Bump date.  Note overflow is handled internally.

(riastradh)

2022-08-31 12:10:05 UTC MAIN commitmail json YAML

reallocarr(3): Clarify semantics.

(riastradh)

2022-08-31 05:24:41 UTC MAIN commitmail json YAML

Fix previous to make it compile again.

(msaitoh)

2022-08-30 22:38:27 UTC MAIN commitmail json YAML

crashme(9): New debug.crashme.mutex_recursion method.

Takes a lock twice.  Set it to 1 for adaptive lock, 2 for spin lock.

(riastradh)

2022-08-30 22:38:17 UTC MAIN commitmail json YAML

lockdebug(9): Try to show symbol names if possible.

Also print the possible owner in ddb/crash `show lock' even if the
kernel is built without LOCKDEBUG.

Output may not be as pretty before with two neatly aligned columns,
but that can be changed; for now the value of having the symbols
printed instead of just obscure hex addresses (which one's an lwp
address and which one's a code pointer? can never remember!) should
outweigh the prettiness temporarily lost.

(riastradh)

2022-08-30 22:38:01 UTC MAIN commitmail json YAML

ddb(9): Make db_symstr safe to use concurrently with pserialize(9).

(riastradh)

2022-08-30 22:37:36 UTC MAIN commitmail json YAML

ddb(4): Use db_num_to_strbuf in db_symstr.

Simplifies it and will make safer to use.

(riastradh)

2022-08-30 22:37:03 UTC MAIN commitmail json YAML

ddb(9): New db_num_to_strbuf.

Like db_num_to_str, but writes to caller-provided buffer instead of
returning pointer to static storage.

(riastradh)

2022-08-30 22:36:48 UTC MAIN commitmail json YAML

/etc/ssh: Install ssh_known_hosts with mode 644.

Makes it agree with the mtree and more convenient for admin to edit.

XXX pullup-8
XXX pullup-9

(riastradh)

2022-08-30 18:36:21 UTC netbsd-9 commitmail json YAML

2022-08-30 18:35:20 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by tsutsui in ticket #1514):

distrib/atari/floppies/common/dot.profile: revision 1.9
distrib/vax/inst-common/dot.commonutils: revision 1.6
distrib/amiga/miniroot/dot.profile: revision 1.11
distrib/utils/script-installer/dot.commonutils: revision 1.8
distrib/amiga/floppies/inst-common/dot.commonutils: revision 1.9

Fix yet another "[: SMALL test, no fallback usage" error on installation.

The same problem as PR/54835 of the miniroot scripts, i.e.
avoid and replace use of -o binary primary marked obsolescent
by POSIX.1-2017:
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html#tag_20_12
8_16

Noticed on installation of NetBSD 9.3 on TT030, and
maybe should be pulled up to netbsd-9.

Avoid more obsolescent binary primaries not supported by crunched test(1).

See PR/54835 and PR/56983 for details.

(martin)

2022-08-30 18:31:49 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by tsutsui in ticket #1513):

sys/arch/m68k/m68k/m68k_trap.c: revision 1.3

Minimal (but hackish) change to make a DEBUG kernel compilable.

(martin)

2022-08-30 18:28:42 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by tsutsui in ticket #1512):

sys/dev/ata/ata.c: revision 1.163

Output missing '\n' for capability list when DMA support is not compiled in.

(martin)

2022-08-30 15:40:57 UTC netbsd-8 commitmail json YAML

2022-08-30 15:40:03 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by rin in ticket #1758):

external/mit/xorg/server/drivers/xf86-video-wsfb/Makefile: revision 1.6

wsfb: Disable broken DGA support:
  - dga(1) crashes X server since pScrn->AdjustFrame is NULL.
  - If nop is provided as pScrn->AdjustFrame, dga(1) crashes X server *AND*
    kernel. This is because DGA uses physical address of framebuffer via
    /dev/mem (oops!), but we provide only mmap(2)'ed virtual address.

(martin)

2022-08-30 15:38:22 UTC netbsd-9 commitmail json YAML

2022-08-30 15:37:27 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by rin in ticket #1511):

external/mit/xorg/server/drivers/xf86-video-wsfb/Makefile: revision 1.6

wsfb: Disable broken DGA support:
  - dga(1) crashes X server since pScrn->AdjustFrame is NULL.
  - If nop is provided as pScrn->AdjustFrame, dga(1) crashes X server *AND*
    kernel. This is because DGA uses physical address of framebuffer via
    /dev/mem (oops!), but we provide only mmap(2)'ed virtual address.

(martin)

2022-08-30 15:27:37 UTC MAIN commitmail json YAML

Simplify name trimming following a suggestion from rillig.

(martin)

2022-08-30 15:09:51 UTC MAIN commitmail json YAML

wsfb: add 8bpp planar support for LUNA using amiga's Afb.

Reviewed on tech-x11@:
https://mail-index.netbsd.org/tech-x11/2022/08/23/msg002311.html

Confirmed on my LUNA-II with 8bpp board.

(tsutsui)

2022-08-30 15:08:49 UTC MAIN commitmail json YAML

wsfb: fix mmap size in Afb planar case.

Reviewed on tech-x11@:
https://mail-index.netbsd.org/tech-x11/2022/08/23/msg002311.html

"Looks like good improvement" from jandberg@ and also confirmed by rin@.

(tsutsui)

2022-08-30 15:05:21 UTC MAIN commitmail json YAML

wsfb: reorganize implementation of Afb support.

- use XORG_VERSION_NUMERIC() to check if Afb is avaiable and
  define and use explicit HAVE_SHADOW_AFB macro
- disable all Afb references if it is not available

Reviewed on tech-x11@:
https://mail-index.netbsd.org/tech-x11/2022/08/23/msg002311.html

"Looks like good improvement" from jandberg@ and also confirmed by rin@.

(tsutsui)

2022-08-30 13:40:37 UTC MAIN commitmail json YAML

etc: Fix permissions of various editable configuration files.

This way they match the mtree and make sense and don't cause editors
to ask to override read-only files when editing them.

Exception: Not sure /etc/bluetooth/protocols makes as much sense to
edit, but the mtree says 644, so if you want to change it, make sure
to change it in both places -- Makefile and mtree.

XXX pullup-8
XXX pullup-9

(riastradh)

2022-08-30 13:14:48 UTC MAIN commitmail json YAML

/root: Install .cshrc and .profile links with the same mode.

Previously we would:

1. Install /root/.cshrc and /root/.profile with mode FILESMODE=644 as
  requested in src/etc/root/Makefile and as echoed in
  /etc/mtree/special.

2. Create hard links at /.cshrc and /.profile through CONFIGLINKS.

3. Because LINKSMODE was unset and defaults to NOBINMODE=444, change
  the mode to 444.

This scenario is confusing, and mtree objects to it, which is bad for
warning fatigue in a security-relevant mechanism.  (There are also
several other files mtree objects to out of the box -- we should fix
those too.)

With this change we install the links with the same mode as the
original files, in agreement with the mtree.  The files, .cshrc and
.profile, are intended to be editable configuration files, so 644
makes sense while 444 makes no sense and gets in the way of editors
like vi.

Discussed on tech-userlevel:
https://mail-index.netbsd.org/tech-userlevel/2022/08/29/msg013498.html

XXX pullup-8
XXX pullup-9

(riastradh)

2022-08-30 11:45:29 UTC MAIN commitmail json YAML

Fix typo (pointed out by rillig)

(martin)

2022-08-30 11:44:15 UTC MAIN commitmail json YAML

Invoke magic C promotion rules as originally intended - oops!
Pointed out by rillig@

(martin)

2022-08-30 11:09:34 UTC MAIN commitmail json YAML

Fix fcti{w,d}{,z}.

- Treat 64-bit integer correctly for fctid{,z}.
- Respect round mode specified by FPSCR[RN].

XXX
- Set FPSCR[FR] and [FI] appropriately.
- Also set FPSCR[FPRF]?
- fctid{,z} traps on powerpc32 (confirmed on 603e and G4).

(rin)

2022-08-30 11:05:59 UTC MAIN commitmail json YAML

Move FTYPE_* definitions from instr.h to fpu_emu.h.

They are not defined by architecture, and used only for FPU emulation.

(rin)

2022-08-30 11:03:36 UTC MAIN commitmail json YAML

x86: Rename x86/efi.c -> x86/efi_machdep.c.

Avoid collision with dev/efi.c.

(riastradh)

2022-08-30 11:00:49 UTC MAIN commitmail json YAML

Do not assert FPSCR[UX] when overflow.

(rin)

2022-08-30 10:59:43 UTC MAIN commitmail json YAML

Fix fsel; frB is chosen when frA is negative or NaN.

For fpu_emu.c rev 1.41 or prior, wrong register was chosen for
NaN with sign bit being cleared.

(rin)

2022-08-30 10:55:06 UTC MAIN commitmail json YAML

Fix mcrfs; Clear copied exception bits, and do not raise any exception.

(rin)

2022-08-30 10:53:12 UTC MAIN commitmail json YAML

Misc clean up for mtfsf{,i}. NFC.

(rin)

2022-08-30 10:50:56 UTC MAIN commitmail json YAML

Fix mtfsb[01]; these can clear/set any FPSCR bits other than FEX and VX.

(rin)

2022-08-30 10:48:31 UTC MAIN commitmail json YAML

Fix logic for FPSCR[FEX].

It is logical OR (similar to FPSCR[VX]) of raised exception bits for
enabled exceptions.

(rin)

2022-08-30 10:43:38 UTC MAIN commitmail json YAML

Revert rev 1.29:

http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/arch/powerpc/fpu/fpu_emu.c#rev1.29

> FPSCR[FEX] is not a sticky bit; it is always cleared when read from
> userland via mffs on real hardware.

This turned out to be wrong. FEX is actually observed for 603e.

(rin)

2022-08-30 08:51:28 UTC MAIN commitmail json YAML

Add cert verification, together with an environment variable "NO_CERT_VERIFY",
to turn it off.

(christos)

2022-08-30 08:48:42 UTC MAIN commitmail json YAML

cgdconfig(8): Gracefully handle failed verification with shared keys.

The first time each key is verified, if verification fails, we chuck
the failed key and try again with passphrase re-entry.

But if a key has already been verified, and verification fails,
assume something is wrong with the disk and fail.

(riastradh)

2022-08-30 08:48:24 UTC MAIN commitmail json YAML

nvme(4): Actually check if bp is null as commented previously.

I had tested this change, but forgot to amend the commit before
exporting to CVS.

(riastradh)

2022-08-30 08:17:16 UTC MAIN commitmail json YAML

Document SCSI sync transfer support for AV Macs.

(rin)

2022-08-30 07:29:45 UTC MAIN commitmail json YAML

Fix capitalization of NetBSD.org

Noticed via htutils/scripts/case-netbsd script.

(leot)

2022-08-30 01:48:09 UTC MAIN commitmail json YAML

2022-08-30 01:13:10 UTC MAIN commitmail json YAML

nvme(4): If bp is null or bp->b_ci is not assigned, use curcpu().

curcpu() might be stale by the time we're done, but it's still safe
to pass it to cpu_index, and this is just used as a best-effort
mechanism to keep I/O on queues handled by the same CPU.

bp is not always provided, and bp->b_ci is not always assigned,
e.g. when dumping.  (If bp->b_ci is supposed to be always assigned,
then we need to audit all the paths into it to assign it in those
where it's not.)

Fixes dump on nvme.

(riastradh)

2022-08-29 23:48:18 UTC MAIN commitmail json YAML

Fix build failure when no options INET6.

(knakahara)

2022-08-29 17:35:15 UTC MAIN commitmail json YAML

Trim trailing whitespace from disk names we got via drvctl.

(martin)

2022-08-29 16:22:05 UTC netbsd-9 commitmail json YAML

2022-08-29 16:20:45 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by nia in ticket #1510):

external/mit/xorg/bin/xdm/Makefile.xdm: revision 1.11
external/mit/xorg/bin/xdm/Makefile: revision 1.18
external/mit/xorg/bin/xdm/Makefile: revision 1.19

fix the man page generation, noted by uwe@

xdm: Include "sbin" directories (and games) in DEF_USER_PATH.
Upstream's configure.ac picks a DEF_USER_PATH on a per-OS basis.
Most of these include the "sbin" directories, with NetBSD being the
(only?) exception.

However, this is inconsistent with the way a typical login shell is
initialized (when using the default skeleton files).  To avoid user
confusion, harmonize DEF_USER_PATH with our other defaults and with
other OSes.

PR xsrc/54851

(martin)

2022-08-29 16:18:10 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by mlelstv in ticket #1509):

sys/dev/scsipi/sdvar.h: revision 1.40
sys/dev/scsipi/sd.c: revision 1.335

Don't fetch data beyond end of inquiry buffer, which, here, is not
NUL-terminated.

Reduce target buffer to needed size (product name + NUL terminator).

(martin)

2022-08-29 16:15:42 UTC netbsd-8 commitmail json YAML

2022-08-29 16:14:57 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by dholland in ticket #1757):

libexec/telnetd/telnetd.c: revision 1.58 (via patch)

telnetd: fix the crash that's been talked about the past couple days.

(Move initialization of the slc table earlier so it doesn't get
accessed before that happens.)

Calling the crash a DoS or security problem is a bit overwrought; it's
just a bug.

(martin)

2022-08-29 16:13:25 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by dholland in ticket #1508):

libexec/telnetd/telnetd.c: revision 1.58 (via patch)

telnetd: fix the crash that's been talked about the past couple days.

(Move initialization of the slc table earlier so it doesn't get
accessed before that happens.)

Calling the crash a DoS or security problem is a bit overwrought; it's
just a bug.

(martin)

2022-08-29 16:04:26 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by dholland in ticket #1507):

bin/test/test.c: revision 1.45

PR 56983 Izumi Tsutsui: fix confusing message in test(1) with -DSMALL

(martin)

2022-08-29 16:02:34 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by oster in ticket #1506):

sys/dev/raidframe/rf_netbsdkintf.c: revision 1.409

RAIDframe must be initialized for the RAIDFRAME_SET_LAST_UNIT
and RAIDFRAME_SHUTDOWN ioctls.

(martin)

2022-08-29 15:48:31 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by riastradh in ticket #1505):

sys/dev/isa/tpm_isa.c: revision 1.8
sys/dev/ic/tpm.c: revision 1.20

Add missing printing-of-newlines in the attach routine.

Remove extra newline from boot messages (isa and acpi front-ends
already provide the newline).

(martin)

2022-08-29 15:45:10 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by riastradh in ticket #1504):

sys/fs/ptyfs/ptyfs_vnops.c: revision 1.69

ptyfs: Don't copy out cookies past end of buffer.

(martin)

2022-08-29 15:39:40 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by riastradh in ticket #1503):

external/cddl/osnet/dist/lib/libzfs/common/libzfs_import.c: revision 1.7
external/cddl/osnet/dist/lib/libzfs/common/libzfs_import.c: revision 1.6

When collecting zpool devices, skip disks with wedges so that a
concurrent test of a wedge on that disk doesn't fail.

libzfs: Zero DIOCLWEDGES input before ioctl.

Otherwise we ask the kernel to write over whatever random pointer was
in the stack garbage here, when all we wanted was to learn whether
dkwl_nwedges is zero or nonzero.

XXX pullup-9

(martin)

2022-08-29 15:39:19 UTC MAIN commitmail json YAML

wscons.conf: add commented out config examples for the Terminus font

(uwe)

2022-08-29 14:54:04 UTC MAIN commitmail json YAML

add -N option to override the font's name

(macallan)

2022-08-29 09:14:02 UTC MAIN commitmail json YAML

Add sysctl entry to control to send routing message for RTM_DYNAMIC.

Some routing daemons require such routing message to keep coherency.

If we want to let kernel send such message, set net.inet.icmp.dynamic_rt_msg=1
for IPv4, net.inet6.icmp6.dynamic_rt_msg=1 for IPv6.
Default(=0) is the same as before, that is, not send such routing message.

(knakahara)

2022-08-29 09:04:27 UTC MAIN commitmail json YAML

emuxki(4): add support for the Sound Blaster Audigy Rx

This is as per kern/56980. Confirmed working on one out of two different
computers, albeit with a strong hissing noise (same card, different
mainboard). The mixer settings seem to be irrelevant or not supported
though.

Original support inspired by the Linux driver, and confirmed with the
OpenBSD driver, itself originally from NetBSD.

Tested on NetBSD/amd64.

(khorben)

2022-08-29 07:32:46 UTC MAIN commitmail json YAML

Make this build again.  Sorry about that.

(skrll)

2022-08-29 01:48:34 UTC MAIN commitmail json YAML

2022-08-28 22:22:41 UTC MAIN commitmail json YAML

2022-08-28 22:09:26 UTC MAIN commitmail json YAML

2022-08-28 21:24:09 UTC MAIN commitmail json YAML

s_rint.c: weak-alias rintl -> rint for ports without __HAVE_LONG_DOUBLE.

(he)

2022-08-28 19:09:12 UTC MAIN commitmail json YAML

lint: inline previous_declaration for nonconstant message IDs

This adds back the compile-time printf validation in debug mode that was
missing before.

(rillig)

2022-08-28 16:07:58 UTC MAIN commitmail json YAML

s_sincos.c: use correct order of __weak_alias() arguments...

(he)

2022-08-28 14:30:41 UTC MAIN commitmail json YAML

s_sincos.c: use __weak_alias and not __weak_reference.

Fixes build on NetBSD/macppc, thanks to hint from riastradh@

(he)

2022-08-28 14:29:05 UTC MAIN commitmail json YAML

options(4): Clarify MSGBUFSIZE units: bytes.

(riastradh)

2022-08-28 13:56:56 UTC MAIN commitmail json YAML

Choose a proper kernel set per a running kernel during installation.

Mostly taken from sgimips.
This avoids users from overwriting by the default ATARITT kernel on
non TT machines like Falcon, Hades, and Milan etc.

(tsutsui)

2022-08-28 13:50:50 UTC MAIN commitmail json YAML

sys/disklabel_gpt.h: Fix description of name encoding.

The encoding is UCS-2 from Unicode 2.1 or ISO/IEC 10646.  This is not
to be confused with UTF-16, which encodes code points outside the BMP
(Basic Multilingual Plane, ~16-bit space) with pairs of surrogate
code points.

(riastradh)

2022-08-28 13:32:34 UTC netbsd-8 commitmail json YAML

2022-08-28 13:31:40 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by hgutch in ticket #1756):

libexec/telnetd/utility.c: revision 1.34

Fix CVE-2020-10188

(martin)

2022-08-28 13:30:53 UTC netbsd-9 commitmail json YAML

2022-08-28 13:29:40 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by hgutch in ticket #1502):

libexec/telnetd/utility.c: revision 1.34

Fix CVE-2020-10188

(martin)

2022-08-28 12:59:50 UTC MAIN commitmail json YAML

re_format(7): Use dagger, not double dagger.  Make it superscript.

(uwe)

2022-08-28 12:44:01 UTC MAIN commitmail json YAML

2022-08-28 12:24:39 UTC MAIN commitmail json YAML

devsw(9): Clarify to match loop condition.  NFCI.

(riastradh)

2022-08-28 12:04:48 UTC MAIN commitmail json YAML

2022-08-28 11:32:19 UTC MAIN commitmail json YAML

2022-08-28 11:17:38 UTC MAIN commitmail json YAML

devsw(9): Fix case of existing conv in devsw_attach.

- Fix sense of conditional: if we found a conv, i < max_devsw_convs.
- Make sure to initialize error on the way out.

PR kern/56962: Incorrect behavior of the devsw_attach function

(riastradh)

2022-08-28 10:48:17 UTC MAIN commitmail json YAML

2022-08-28 10:43:19 UTC MAIN commitmail json YAML

lint: rename functions to be clearer

No need anymore to keep external identifiers at the "6 significant
initial characters" mandated by C90.

(rillig)

2022-08-28 10:26:37 UTC MAIN commitmail json YAML

Don't fetch data beyond end of inquiry buffer, which, here, is not
NUL-terminated.

Reduce target buffer to needed size (product name + NUL terminator).

(mlelstv)

2022-08-28 10:20:25 UTC MAIN commitmail json YAML

Fix writing of corrected fsinfo.
Continue when fsinfo has been rewritten.

(mlelstv)

2022-08-28 09:52:43 UTC MAIN commitmail json YAML

cons(9): Need sys/types.h for dev_t, u_int.

(riastradh)

2022-08-28 09:48:12 UTC MAIN commitmail json YAML

se(4): don't set if_watchdog as it's not used.

if_timer is never set in this driver and so if_watchdog will never be
called.

(skrll)

2022-08-28 08:41:06 UTC MAIN commitmail json YAML

2022-08-28 08:40:56 UTC MAIN commitmail json YAML

2022-08-28 07:54:03 UTC MAIN commitmail json YAML

Empty if_watchdog functions are useless and now waste resources. Let's
remove them.

(skrll)

2022-08-28 07:44:23 UTC MAIN commitmail json YAML

Trailing whitespace

(skrll)

2022-08-28 07:30:41 UTC MAIN commitmail json YAML

2022-08-28 07:29:05 UTC MAIN commitmail json YAML

only alias sincos to sincosl when we don't have long doubles

(christos)

2022-08-28 00:37:41 UTC MAIN commitmail json YAML

Simplify the check for what ioctls can be done in raidioctl() without
the device being initialized.

(oster)

2022-08-28 00:26:04 UTC MAIN commitmail json YAML

RAIDframe must be initialized for the RAIDFRAME_SET_LAST_UNIT
and RAIDFRAME_SHUTDOWN ioctls.

XXX Pullup-9

Reported-by: syzbot+1c20fcbe34d72cd7fbda@syzkaller.appspotmail.com

(oster)

2022-08-27 23:24:37 UTC MAIN commitmail json YAML

tests/lint: add more information to test for __attribute__((aligned))

Declaring an array type having a negative dimension is the simplest way
to embed an integer into a lint diagnostic, thereby revealing what size
and alignment lint has calculated for a struct.

While here, move these "compile-time assertions" closer to their
corresponding struct, to make reading easier.

(rillig)

2022-08-27 21:59:41 UTC MAIN commitmail json YAML

tests/lint: add another test for aligned struct member

In the kernel, several structs have this attribute, and running lint on
them runs into a compile-time assertion.  Typical error messages are:

* error: illegal bit-field size: 255 [36]
* error: integral constant expression expected [55]

(rillig)

2022-08-27 21:53:39 UTC MAIN commitmail json YAML

2022-08-27 21:49:33 UTC MAIN commitmail json YAML

sys/conf/link.mk: clean up

The modifier ':C' did not need the modifier 'g', as there couldn't ever
be more than one match per word. Using the modifier ':from=to' is easier
to read.

Align the variable assignments. There was no point in having 3 different
alignment styles in the same file.

Remove underscore from .for iteration variable, as it is not needed.

No functional change.

(rillig)

2022-08-27 21:24:15 UTC MAIN commitmail json YAML

drm: Make sure ioctl buffer is aligned on stack.

(riastradh)

2022-08-27 21:18:39 UTC MAIN commitmail json YAML

PR 56983 Izumi Tsutsui: fix confusing message in test(1) with -DSMALL

(dholland)

2022-08-27 20:42:16 UTC MAIN commitmail json YAML

sys/conf: fix typo in comment

(rillig)

2022-08-27 20:40:03 UTC MAIN commitmail json YAML

x86/db_memrw.c: Mark db_read_bytes, db_write_bytes __noubsan.

These intentionally do loads and stores that may be misaligned, which
are fine on this x86-specific code.  Should avoid double-panic in
disassembler on panic with UBSan enabled.

(riastradh)

2022-08-27 20:39:54 UTC MAIN commitmail json YAML

x86/db_memrw.c: Use uint64_t, not long, for 8-byte r/w.

This is shared with amd64 and i386, and while long works on amd64,
not so much on i386.

While here, use uint32_t intead of int and uint16_t instead of short
for clarity.

(riastradh)

2022-08-27 20:37:49 UTC MAIN commitmail json YAML

sys: document how to run lint on the kernel code (experimental)

(rillig)

2022-08-27 19:25:35 UTC MAIN commitmail json YAML

Ensure that all queues passed to ifq_enqueue2() have a valid ifq_lock.

(thorpej)

2022-08-27 19:21:23 UTC MAIN commitmail json YAML

Use IFQ_SET_MAXLEN() rather than open-coding it.

(thorpej)

2022-08-27 19:19:10 UTC MAIN commitmail json YAML

Ensure that all queues passed to ifq_enqueue2() have a valid ifq_lock.

(thorpej)

2022-08-27 19:17:09 UTC MAIN commitmail json YAML

Use IFQ_SET_MAXLEN() rather than open-coding it.

(thorpej)

2022-08-27 19:15:00 UTC MAIN commitmail json YAML

Ensure that all queues passed to ifq_enqueue2() have a valid ifq_lock.

(thorpej)

2022-08-27 19:04:43 UTC MAIN commitmail json YAML

Consistently use IFQ_SET_MAXLEN(), rather than open-coding it.  NFC.

(thorpej)

2022-08-27 17:15:52 UTC MAIN commitmail json YAML

tuck in k_sincosl.h include inside __HAVE_LONG_DOUBLE

(christos)