ESR_EL1 and FAR_EL1 are not required in interrupt trapframe and their values are meaningless.
To identify it as an interrupt trap frame, store -1 and 0.

(ryo)

lint: fix wrong errors about sizeof of a bit-field (since 2022-05-26)

(rillig)

tests/lint: demonstrate wrong errors 'size/alignment of bit-field'

Since tree.c 1.444 from 2022-05-26, which added range and bit checks for
integer expressions, not taking into account that querying for the size
of a bit-field type triggers an error message.

(rillig)

Apply extra delay quirk for

- Intel 7 Series (mobile) SATA Controller (AHCI):
  rev. 0x04 sometimes fails to probe Seagate ST500LT012.

Reported by RVP. Thanks!

(rin)

gomoku: clean up variable names, add empty lines

No binary change.

(rillig)

gomoku: clean up color handling in 'pickmove'

Instead of searching for the best black and white moves, search instead
for our and their best moves. This makes the code simpler and more
uniform, as the strategy is the same for Black and White.

No functional change.

(rillig)

gomoku: clean up 'pickmove' stylistically

No functional change.

(rillig)

gomoku: migrate remaining functions to type player_color

No functional change.

(rillig)

gomoku: make parsing of the debug command 'o' robust

Previously, the (invalid) debug command 'o,' succeeded to parse and led
to out-of-bounds memory access. Add proper parsing for the arguments of
that debug command. Add a short usage for that debug command, as
guessing the usage from the previous code was time-consuming due to the
large amount of ad-hoc low-level parsing code.

When leaving debug mode, clear the debug prompt.

(rillig)

gomoku: clean up overlap info in 'checkframes'

In 2009, GCC had complained that the overlap_info might only be
partially filled. All possible code paths are sane though, so that was
probably a bug in GCC.

Remove the comment and the unnecessary initialization, rename the
variable since it doesn't match its behavior anymore. Sync nearby
comments with reality; there is no array anywhere near.

No functional change.

(rillig)

gomoku: do not scan the upper border for combos

Adding the '+ 1' to the row coordinate added an offset of 20, while the
intended offset was 1.

No functional change, just a bit faster.

(rillig)

gomoku: refine the type of some functions and variables

Assisted by WARNS=6. At that level, there are several warnings about
type conversion between small integer types that would only clutter the
code, therefore stay at WARNS=5. Same for lint's -aa option.

No functional change.

(rillig)

- Display "cpu[<CPUINDEX>]" instead of "cpu[<CPUID>]".
- Also add cpu_info->ci_onproc to display.

(ryo)

Use the PAR register to check for accessibility in db_(read|write)_bytes().

db_(read|write)_bytes() uses the TTBR[01] at that time, so it must check
if it is accessible in context at that time, not pmap_extract()
which uses the struct pmap of the process.

- It also checks if the address is writable.
- db_write_bytes() also requires ARMV81_PAN control.

(ryo)

gomoku: when starting a new game, start in the middle of the board

Previously, when starting a new game, the user coordinate was kept at
the previously selected spot. Since playing in the center is common
sense, reset the coordinate.

(rillig)

gomoku: after accepting a spot via the mouse, clear current coordinate

(rillig)

fix build without options DDB

(ryo)

Simplified termination conditions for ddb backtrace.

Exit backtrace when the user trapframe is invalid. (Mainly in kernel threads).

(ryo)

gomoku: add type player_color

No functional change.

(rillig)

mk: Add MKTIMED and MKMOUSED flags for compiling NetBSD without timed
and moused

(nia)

gomoku: use unsigned integers for bit sets

As all access to the bit sets happens through the unsigned spot_index
type, drop the type casts in the macros.

No functional change on 2s complement machines.

(rillig)

gomoku: provide a more gentle introduction to the code

No binary change.

(rillig)

gomoku: don't use 'i' as special-purpose variable name

No binary change.

(rillig)

gomoku: consistently name the offset of a spot in a frame 'off'

Leave 'i' for general purpose loops.

No functional change.

(rillig)

gomoku: add data type for one of the 4 directions of a frame

No functional change.

(rillig)

gomoku: clean up four_in_a_row

No functional change.

(rillig)

Expand and escape comments. One minor change to variable expansion
as requested by uwe.

(nia)

gomoku: extract quick_check from scanframes

No functional change.

(rillig)

Make it compile again

(martin)

Fix insn field definitions for MD and MDS formats.

No one uses these yet.

(rin)

gomoku: use proper types when indexing 'board' and 'frames'

No functional change.

(rillig)

Apply extra delay quirk for followings:

- Intel Braswell AHCI: rev. 0x35 fails for Seagate ST2000LX001.

- Intel 8 Series (desktop) SATA Controller (AHCI): rev. 0x04 fails for
  Seagate ST1000LX015 and WD WD10JPVX, whereas it works without the
  quirk for some SSD models...

Reported by Matthias Petermann. Thanks!

(rin)

Avoid null SEGV if libargon passed string with too few $

Seen on netbsd-9 built xscreensaver running on a current system.
Whatever triggered this should also be fixed, but in the meantime
we can improve the behaviour from "Segmentation Fault"

(abs)

Regen for GENERIC.in rev. 1.149.

(rin)

Free strdup'd value in libargon decode_option error paths

If its worth freeing in the success path, its worth freeing in the
error path... (given we don't _exit or similar)

(abs)

fix various typos in comments and log messages.

(andvar)

le(4): Fix resource leaks for error paths.

XXX
Compile test only (at least one arch per driver).

(rin)

Audit unload/unmap v.s. free against DMA buffer for sys/dev;
make sure that bus_dmamap_unload(9) [or bus_dmamap_destroy(9)] or
bus_dmamem_unmap(9) are preceding to freeing DMA buffer, if it is
loaded or mapped, respectively.

This is mandatory for some archs. See, e.g.:

http://www.nerv.org/netbsd/?q=id:20210511T013030Z.013443cc790088147e4beed43f53dedabeaf9312
http://www.nerv.org/netbsd/?q=id:20220511T172220Z.561179f0b6fcc5b9cd73e274f69d74e2ce9e4c93

For some drivers, resource leaks for error paths are fixed at
the same time.

XXX XXX XXX
Compile test only (at least one arch per driver).

(rin)

s/littel/little/ mainly in copy pasted comments.

(andvar)

gomoku: turn spotstr.s_frame into a frame index

Most calculations are done on the frame index, not the pointer. This
avoids dealing with ptrdiff_t conversion to int.

Changing the type of s_frame changes the size of struct spotstr, it is
now 56 bytes on LP64 and 48 bytes on ILP32, neither of which is a power
of two. Remove the dummy padding since compilers no longer generate
division instructions for divisions by small integer constants, so that
optimization is no longer necessary.

No functional change.

(rillig)

gomoku: document where to fix the unnecessarily long thinking time

(rillig)

Document MKPPP

(nia)

One more typo; this is called _atomic_swap_64, not _8.

(rin)

mk: Add a MKPPP flag to exclude pppd(8) and related utilities from
the build

(nia)

Fix typo; this is "and", not "add".

(rin)

Add missing Hyper-V devices from GENERIC.

(rin)

Avoid exec'ing bc. Pointed out by uwe.

(nia)

Explanations requested by uwe...

(nia)

CHANGES: minor grammar fixes

(gutteridge)

gomoku: migrate 'makemove' to using spot_index instead of pointer

No functional change.

(rillig)

gomoku: migrate pickmove to use spot_index instead of pointers

Using spot_index instead of pointers leads to simpler code since there
is no need to deal with conversion from ptrdiff_t to spot_index.

No functional change.

(rillig)

gomoku: migrate spot_index from int to unsigned short

This matches the type of 'intersect'.

No functional change.

(rillig)

gomoku: use consistent variable names

Previously, the name 's' was used for the index of a spot on the board,
as well as for the value of a combo, and for a few other purposes. Use
different names and mark the spot indexes using a custom type.

No binary change.

(rillig)

gomoku: use custom magic value for end of file input

This allows the type for a spot index to be changed to an unsigned type.

No functional change.

(rillig)

s/heigth/height/ in a function argument name.

(andvar)

fix various typos in comments.

(andvar)

s/grabing/grabbing/ in comments.

(andvar)

s/hidding/hiding/

(andvar)

s/hierach/hierarch/

(andvar)

s/knowlege/knowledge/

(andvar)

gomoku: use unsigned arithmetic for bitboard

No functional change.

(rillig)

gomoku: document that 'whatsup' is called on ^C as well

(rillig)

fix various typos in comments, mainly origional->original,
extened->extended, incomming->incoming.

(andvar)

gomoku: allow saving a finished game without pressing Shift

(rillig)

gomoku: remove redundant parentheses, braces, newlines, clean up get_key

No functional change.

(rillig)

gomoku: clean up initialization of overlap information

Fix variable names 'ia' and 'ib', which I forgot in the previous commit.

Move the documentation in the right places.

Split off another part of init_overlap, to make each function fit on a
single screen. Reducing the number of nested 'for' loops allows the
indentation to follow the NetBSD style.

No functional change.

(rillig)

gomoku: clean up local variable names in init_overlap

By clearly associating each variable to either frame A or frame B,
suddenly the code becomes understandable. For the benefit of future
readers, explain the naming scheme.

No functional change.

(rillig)

gomoku: split initialization of the board into smaller functions

The comments about the "top border" and "bottom border" had been wrong
all the time. Mention the corners in the comments, to remove the magic
from the various '+ 1' in the code.

No functional change.

(rillig)

fixed typo with another typo in my last commit. fixing it again.

(andvar)

mk: Add MKFINGER, MKTALK flags for not building
talk, talkd, finger, fingerd.

(nia)

Fix typo. Hopefully this didn't break anyone's build, sorry.

(nia)

mk: Add MKNTP, MKTCPDUMP knobs.

(nia)

fix various typos, mainly in comments.

(andvar)

doc/CHANGES: summarize latest changes to gomoku

(rillig)

gomoku: highlight the winning frame

(rillig)

gomoku: group movelog and nmoves into a game struct

No functional change.

(rillig)

gomoku: split makemove into smaller functions

No functional change.

(rillig)

gomoku: announce tie as early as possible

(rillig)

gomoku: extract update_overlap_different_direction

No functional change.

(rillig)

gomoku: extract separate function update_overlap_same_direction

No functional change.

(rillig)

gomoku: reduce number of variables in update_overlap

No functional change.

(rillig)

gomoku: reduce scope of local variable

No functional change.

(rillig)

Let radeon DRM driver build on ports that lack ACPI

(manu)

Document hw.wmX.txex_workqueue sysctl

(manu)

gomoku: reduce variable reuse, make code more uniform

No functional change.

(rillig)

gomoku: reduce scope of local variables

No binary change.

(rillig)

gcc 9.5.0 out.

(wiz)

i915: Fix missing newlines in custom warning message macros.

(riastradh)

gomoku: allow Black to win the game in the very last move

(rillig)

gomoku: fix off-by-one error when deciding that the game is a tie

(rillig)

gomoku: replace 1-based movenum with 0-based nmoves

No functional change, not even the TIE that is wrongly announced when
the very last spot on the board is yet to be filled by Black.  Even
without this off-by-one error, it could be that filling the very last
spot completes a frame, so that code has been wrong all the time.

In practical terms, this situation only arises when the human player is
unconcentrated or the computer player has a bad strategy.  The latter
may well be, as the computer moves in the (boring) endgame are not
directed towards winning -- they fill irrelevant spots before relevant
ones.

(rillig)

gomoku: split local variable into separate variables

No binary change.

(rillig)

Only set dpi when necessary to avoid divide by zero on very small screens

(nia)

xenevt_setipending(): also increase xenevt_ih->ih_pending, so that
the handler will be called when the IPL is lowered.

(bouyer)

More DPI magic... allow most modern GTK and Qt apps to automatically scale

(nia)

ctwmrc: Use a slightly more muted orange color.

(nia)

Specify -fno-unwind-tables to shrink binaries.

(tsutsui)

In xterm, use TrueType fonts rather than Spleen at higher DPIs.

Requested by jmcneill.

(nia)

... and more MKLFS here

(nia)

Document MKLFS

(nia)

mk: Add a MKLFS flag for excluding the log-structured filesystem userspace
tools from the build.

(nia)

lint: do not warn about 'uint32_t = uint64_t >> 32'

If all possible values fit into the destination type, there is no
possibility of losing accuracy.

Enhances PR 36668.

(rillig)

tests/lint: demonstrate wrong warnings about loss of accuracy

(rillig)

lint: do not pre-multiply pointer expressions 'ptr + int'

In the AST, it is confusing to see that 'stderr == __sF + 304', it
should rather be 'stderr == __sF + 2'.

No functional change.

(rillig)

lint: improve local variable and function names

No functional change.

(rillig)

In ddb, fixed "trace/u" and user process memory read/write to work correctly.

In the softint context, curlwp points the kernel lwp, so to get the pmap
of a user process, we had to use curcpu()->ci_onproc->l_proc instead of
curproc (curlwp->l_proc). Adviced by ad@.

(ryo)

lint: reduce scope of local variables in build_plus_minus

No functional change.

(rillig)

lint: fix spacing and line breaks in debug logging

The spacing between function arguments in a declaration info was too
big, it was the indentation level instead of a single space.

The function debug_sym is used for two purposes: own-line and in-line,
which coincidentally are distinguished by whether the suffix string is
"\n".

(rillig)

libc/ptree: remove CONSTCOND comments

Since 2021-01-31, lint does not need them anymore.

(rillig)

Remove duplicated function declarations.

(tsutsui)

altq.9: remove CONSTCOND comment from example code

Since 2021-01-31, lint no longer needs CONSTCOND in a do-while loop.

(rillig)

Explicitly include "ioconf.h" for struct cfdriver.

(tsutsui)

KNF a bit.

(tsutsui)

Make a readonly array const.

(tsutsui)

Make readonly keymap data const.

(tsutsui)

Make local functions and variable static.

(tsutsui)

mk.conf(5): Don't make "experimental" comment stand out.

(uwe)

lint: rename olwarn and LWARN_BAD to be more expressive

No functional change.

(rillig)

Use CPUID_PERF_* macros defined in specialreg.h. No functional change.

(msaitoh)

lint: merge debug and non-debug code for saving and restoring warnings

No functional change.

(rillig)

lint: remove assertion about saving and restoring warning flags

The assertion only triggers in debug mode, which is generally not used
as it adds lots of debug logging.  In production mode, the assumption
didn't hold for many years now, so remove the assertion.

(rillig)

lint: improve debug logging for NAME expressions

In a NAME expression, the name is an essential part, so put it to the
front, in natural reading order.

(rillig)

lint: add missing newlines in debug_node

(rillig)

aprint_debug(): if a hypercall fail, print the return code.

(bouyer)

lint: re-order conditions for lossy conversions

Now that can_represent does more work, put it at the end of the
conditions.

No functional change.

(rillig)

sys/common_int_const.h: fix typo in error message

(rillig)

lint: do not warn about loss in accuracy if the actual value fits

The expression 'any & 0xff' can always be assigned to 'uint8_t' without
loss of any value bits.  In the same way, '(any & 0xff) << 8' can always
be assigned to 'uint16_t'.

Previously, lint warned about these cases.  Fix these wrong warnings by
tracking the possible values of integer expressions across a single
expression.

Fixes PR 36668, so that <sys/endian.h> does not need to be cluttered
with useless casts anymore.

(rillig)

Literal backslashes need to be quoted for roff.

(mlelstv)

tests/lint: demonstrate wrong 'may lose accuracy' warning

Reported in PR 36668, fixed in sys/sys/endian.h 1.26 from 2007-07-20,
unfixed in sys/sys/endian.h 1.29 from 2014-03-18.

(rillig)

w: add -A to usage

(wiz)

lint: remove long list of node types in switch statement

No functional change.

(rillig)

Document some more build options. Delint.

(nia)

mk: Document that some options were enabled by default on aarch64

(nia)

port-hppa/56849: Wacko kernel memory accounting in current/hppa

Two fixes:
- Don't include direct mapped memory in pmap statistics
- Decrement pmap statistics counts in pmap_kremove

(skrll)

default to not sorting tty names with alphabetical sort and add
a new -A switch to sort them again.

enable the sorting code if either utmp or utmpx are enabled,
not just both.  shouldn't matter as we enable both.

(mrg)

only link acpi_pci*.c if acpi & pci, not just acpi.

(mrg)

mk: Rename the MKMBONE option to MKMROUTING for greater accuracy and
to match the related kernel config option.

(nia)

be lazy about clearing the cursor since most likely we're going to overwrite
it anyway. Same logic as in cgsix.

(macallan)

mk: Allow setting MKDHCPD=no to build base without the ISC DHCP server,
useful for embedded images that don't need to act as one.

(nia)

Move <xen/include/public/vcpu.h> so it's always inclued. Fixes Xen PV builds.

(bouyer)

PVH and HVM guests can easily have more than XEN_LEGACY_MAX_VCPUS (32) cpus.
Support up to HVM_MAX_VCPUS (256). This requires resizing a few arrays in
evtchn.c, and using
VCPUOP_register_vcpu_info for vcpuid >= XEN_LEGACY_MAX_VCPUS
Tested with 96 vCPUs.

(bouyer)

debug pieces should also be installed conditionally based on MKMBONE

(nia)

mk: Allow building base without the MBONE applications by setting
MKMBONE=no in mk.conf

(nia)

stray .

(nia)

doc: GPU driver update

(nia)

doc: More miscellaneous changes by other developers

(nia)

x86: Reserve device major for VirtualBox Guest Additions

(uwe)