tests/lint: sort multiple diagnostics per line chronologically

For now, the chronologic order is not enforced but has to be established
manually, for example by removing all 'expect' comment lines and
regenerating them with 'accept.sh -u'.

While here, clean up a few instances that came up when regenerating the
'expect' comments, such as wrong indentation or needless deviation from
the 'expect+1' form.

(rillig)

tests/lint: fix tests for integer constants on ILP32 platforms

The comment in msg_218 was both off-topic and wrong, so remove it.

(rillig)

Also put back libfb.a in xorg_server_ver=110 case.

It looks required only on building Xorg server binary and
unnecessary for release (actually marked as obsolete only on vax),
but no simple settings to "build static libraries without installation"
and most ports will be switched to Xorg 1.20 soon.

(tsutsui)

tests/libutil/snprintb: remove redundant integer constant suffixes

I added these because lint told me so. Lint was wrong though, as it had
not implemented the C99 rules for integer constants.

(rillig)

NetBSD.dist.base: Nix /var/run/named.

/var/run is emptied at boot time by /etc/rc.d/mountcritlocal, so
there's no point in creating this at install time -- it has to be
created on the fly after /var/run is cleared on every boot anyway.

Mark /var/run/named obsolete in the set lists.  XXX This isn't quite
right, because it is legitimate for /var/run/named to exist in a
running installation, but it doesn't exist in a freshly installed
system any more.  Maybe we should just remove the entry from the set
lists and add a note to UPDATING about deleting it manually from the
destdir in incremental builds.

PR misc/57877

(riastradh)

NetBSD.dist.base: Fix permissions on /dev/pts.

No reason to write to this -- it's expected to have ptyfs mounted,
and ptyfs doesn't allow changing the directory.  So use 0555
(-r-xr-xr-x) instead of 0755 (-rwxr-xr-x), like it is by default with
ptyfs mounted.

PR misc/57877

(riastradh)

terminfo: Our local changes are now upstream; reduce diff to upstream.

The changes look bigger than they are, this also removes some
settings that are inherited from the vt220 entry.

(wiz)

lint: fix type of large integer constants

(rillig)

Add missing comma. Noted by Thomas E. Dickey.

(wiz)

fix i386 lint

(christos)

Add support for "PAL" (576i) mode on Wii.

(hgutch)

PR/57875: Jason Bacon: Try again without an _ for portability.

(christos)

new terminfo

(christos)

fix quotes

(christos)

merge changes, but keep our old wscons description

(christos)

lint: split determining the type of an integer constant

No functional change.

(rillig)

tests/lint: test integer constants in different language levels

(rillig)

lint: extract signedness detection from lexing an integer constant

An integer constant that is signed in traditional C but unsigned since
C90 is an edge case that should not clutter the main code of determining
the resulting type of the constant.

The code for lexing an integer constant doesn't implement the C99 rules
yet, which convert a constant to the 'long long' types if the 'long'
types don't suffice.

(rillig)

Revert previous (stop building static libfb.a module for Xorg 1.10).

It breaks builds in xorg-server.old/hw/xfree86/Xorg on alpha,
netwinder, and sgimips (but not vax).

>> dependall ===> external/mit/xorg/server/xorg-server.old/hw/xfree86/Xorg
>> nbmake[13]: don't know how to make [...]/xorg-server.old/hw/xfree86/dixmods/fb/libfb.a. Stop

(tsutsui)

tests/libutil/snprintb: fix test for 32-bit platforms

(rillig)

tests/libutil/snprintb: add more tests

Test all number bases (octal, decimal, hexadecimal), in both old-style
and new-style formats, as well as small buffer sizes.

Document working edge cases such as empty descriptions or descriptions
containing spaces, as well as situations that invoke undefined behavior.

Add comments to the individual test cases, as reading the actual format
strings takes more time.

(rillig)

Enable asinl, acosl, logl, coshl, tanhl, atanhl, asinhl and acoshl

* Fix pkgsrc/math/py-numpy and pkgsrc/graphics/py-matplotlib, for example.

(ryoon)

Fix typo

(wiz)

add some missing changes and bump the version.

(mrg)

sinhf is in the same manual page as sinh not sin

(nros)

move MD2Transform first.

(christos)

Add the long double math functions recently added from FreeBSD to their related man pages

(nros)

Handle "LSBit is left" bitorder VRAM of smg(4) and qv(4) on VAXen.

Confirmed on smg(4) on my VAXstation 3100/30.
Should be pulled up to netbsd-10.

(tsutsui)

Put back xorg_server_ver=110 specific files lost in 21.1.3 updates.

Also fix syspkg names and reorder entries for readabilities.
Fixes "fail to load libfb.so" errors in case of HAVE_XORG_SERVER_VER=110.
(Note these ports have been switched to HAVE_XORG_SERVER_VER=120)

Ok'ed by mrg@ on tech-x11@:
https://mail-index.netbsd.org/tech-x11/2024/01/24/msg002434.html

(tsutsui)

Put back xorg_server_ver=110 specific files lost in 21.1.3 updates.

Also fix syspkg names and reorder entries for readabilities.
Fixes "fail to load libfb.so" errors on X.org 1.10 server ports.

Ok'ed by mrg@ on tech-x11@:
https://mail-index.netbsd.org/tech-x11/2024/01/24/msg002434.html

Should be pulled up to netbsd-10.

(tsutsui)

Fix inverted logic for weak alias

* Fix gfortran from pkgsrc/lang/gcc10 and pkgsrc/math/coinmp, for example.

(ryoon)

Stop building static libfb.a module for Xorg server 1.10 ports.

It looks unused and marked as obsolete in
src/distrib/sets/lists/xserver/md.* list files since netbsd-8.

(tsutsui)

tweak wii entry

(jmcneill)

Add wsvt25 entries (off by default) for ttyE0-ttyE3.

(jmcneill)

Don't use the signal handler to terminate when nothing is to do (count=0, files=0).

The signal handler tries to raise the signal again, so that a parent can retrieve
the signal from the exit code. Calling the terminate handler with signal code 0
doesn't raise a signal and dd continues with exit(127) making this case an error.

(mlelstv)

wm(4): Print RX packet buffer size.

(msaitoh)

wii: Remove objcopy after kernel build.

HBC will do the right thing.

(jmcneill)

tests/usr.bin/mtree: xfail PR 57877; omit needless debug print.

(riastradh)

Note that in both :U and :D newval may be empty

(sjg)

Fix mmap(2) address for smg(4) as other framebuffers.

Now X.org server can render onto framebuffer (but inverted bitorder).
Should be pulled up to netbsd-10 and netbsd-9.

(tsutsui)

tests/libutil/snprintb: clean up and extend tests

In case of a failure, print the details of the test case, including file
and line number of the actual test data. Do not write the format strings
directly to the output, as they contain non-printable bytes and embedded
null bytes.

After a failed test case, continue with the others.

Lay out the format strings according to their structure, to make them
more readable. Remove redundant "\0" at the end of the new-style format
strings.

Fix an off-by-one error in the test data: 0xf is FIFTEEN, not SIXTEEN.

Add a test for performing a restricted subset of rot13 in the format
string, to explore the limits of snprintb formatting.

What's still missing are tests for edge cases and error cases.

(rillig)

wii: Add External interface bus and RTC support

(jmcneill)

Indicate that for :U newval is optional

(sjg)

igc(4): Count iqdrops.

TODO: RQDPC should be visible via evcnt(9).

(msaitoh)

blkdiscard: avoid asserting when passed a bsd disklabel raw device

PR#57856 shows when using blkdiscard on eg, /dev/ld0 it asserts because
'0' is not between 'a' and 'p'.  switch this to using DISKPART() on the
returned st_rdev, so it works on 'ld0c' or 'ld0' (rawpart=2.)

(mrg)

determine the tty width instead off writing 100 chars before a new line.

(mrg)

add missing mtree subdir and it's Atffile.

(mrg)

mtree(8): Test the installed sets.

Except etc and xetc, which likely won't match for reasons that aren't
great, like etc including empty log files which in an installed
system have probably changed.

This test will probably fail, but we should make sure it doesn't!

PR misc/57877

(riastradh)

wii: Add support for passing boot options to the kernel.

(jmcneill)

space -> tab cleanup

(wiz)

zlib-1.3.1 out

(wiz)

Unbreak sched_m2 (died because lwp_eproc() KASSERT in DIAGNOSTIC) and explain
what is going on. This has been broken since the introduction of l_mutex
5 months ago.

(christos)

ixgbe: Add QPRDC into iqdrops.

A receive packet might drop at two different locations.
One is the packet buffer that packets are received into the chip first.
If the packet buffer is overflowed, the MPC register is incremented.
It's currently added to iqdrops. It's no problem.
Another is descriptor ring(s). A packet from the packet buffer is DMA'ed
into main memory base on the descriptor ring. If the ring is full, the packet
is dropped and the QPRDC register is incremented. It should be added to
iqdrops but it was not done. Fix it.
Reported by ozaki-r@.

(msaitoh)

add the script I used to convert the FreeBSD code.

(christos)

style: Fix typo, NFC

"it it" --> "it is" (across a newline)

(rin)

ld@sdmmc(4): Hack around deadlock in cache sync on detach.

Yanking a card triggers the sdmmc discovery task, which runs in the
sdmmc task thread, to detach any attached child devices.

Detaching ld@sdmmc triggers a cache flush (via ldbegindetach ->
disk_begindetach -> ld_lastclose -> ld_flush -> ioctl DIOCCACHESYNC),
which is implemented by scheduling a task to do sdmmc_mem_flush_cache
and then waiting for it to complete.

The sdmmc_mem_cache_flush is done by an sdmmc task so it happens
after all previously scheduled I/O operations -- that way the cache
flush doesn't complete until the previously scheduled I/O operations
are complete.

However, when the cache flush task is issued from the discovery task,
this doesn't work, because the cache flush task can't start until the
discovery task has returned -- but the discovery task won't return
until the cache flush task has completed.

To work around this deadlock, which usually happens only when the
device has been yanked anyway so further I/O would be lost anyway,
just do the cache flush synchronously in DIOCCACHESYNC if we're
running in the task thread.

This isn't quite right -- implementation details of the task thread
shouldn't bleed into ld@sdmmc, and running the cache sync _before_
any subsequently scheduled I/O tasks is asking for trouble -- but it
should serve to avoid the deadlock in PR kern/57870 until we can fix
a host of concurrency bugs in sdmmc by fixing the locking scheme and
running discovery in a separate thread from tasks.

XXX pullup-10

(riastradh)

tests/lint: revert accidental addition of test for lint message 356

(rillig)

wii: provide device names to intr_establish

wii$ intrctl list
interrupt id      CPU0  device name(s)
pi irq 14        64769* hollywood0
hollywood irq 36  5872* ehci0
hollywood irq 39 58907* sdhc0
hollywood irq 40    4* sdhc1
hollywood irq 49    0* resetbtn0
pi irq 5            0* bwai0

(jmcneill)

wii: Simply DSP driver - no interrupt handler required.

(jmcneill)

wii: Use A/V encoder volume controls instead of using a software filter.

(jmcneill)

wii: Add GPIO, I2C, and basic A/V encoder driver.

(jmcneill)

lint: unconst parameters

These were leftovers from earlier refactorings and are no longer needed.

No binary change.

(rillig)

lint: rename symt_t to symbol_kind

It was confusing to have two kinds of "symbol type" (s_type and s_symt),
so rename all related identifiers to be more distinctive.

No functional change.

(rillig)

fix nested extern warnings

(christos)

+HNDL  harvest now, decrypt later

(jschauma)

move inclusion of <machine/ieee.h> to the ieee source files instead of
including it in math_private.h which is also used by the vax which is not ieee.

(christos)

handle sizeof(off_t) > sizeof(size_t)

(christos)

Add vax

(christos)

fix vax build (unused variable)

(christos)

more annotation for powerpc

(christos)

indent

(nia)

doc: Changes for January

(nia)

powerpc/ieee.h: Protect from multiple includes

Fix build failure triggered by import of libm long-double functions.

(rin)

wii: Use screen dimming register for screen blanking.

(jmcneill)

wii: Add screenblank support.

(jmcneill)

wii: Add drivers for Broadway DSP and Audio interface.

0: [*] audio0 @ bwdsp0: Broadway DSP
      playback: 16, 2ch, 48000Hz
      record:  unavailable
      (P-) slinear_be 16/16, 2ch, { 48000 }

(jmcneill)

wii: Fix a comment

(jmcneill)

xf86-video-wsfb: Add support for Nintendo Wii

The Wii's framebuffer is YUY2, so add a custom shadowproc that converts
from RGB565 to YUY2 on the fly.

(jmcneill)

fix M_CSUM_BITS bitfield for M_CSUM_BLANK - \37 is the bit before \40

noticed by rillig@ thanks

(jdolecek)

PR/57871: Haelwenn Monnier: Don't use u_char because it is not defined in with
POSIX_C_SOURCE

(christos)

Bump libm minor rev (libm.so.0.13 -> libm.so.0.14) after addition of
all the long double functions (with actual implementations).

(kre)

Add multiple inclusion protection guard - the long double math routines
have a tendency to sometimes make that happen.

This seems to fix the sun3 build, and probably other m68k builds which
were working before the libm upgrades (it will do nothing for any that
were failing before that).

(kre)

postfix-3.8.5 is out

(wiz)

Simply an overly complex way of saying "0 or 1" into a cleaner version.

While here add a commment about how the __i386__ magic LD80C macro
might no longer work on all other arch's as well (if someone can verify
that it still does, or can fix it so that it still works on i386, but
also works everywhere else, then please remove that XXX comment.
The issue I am (perhaps imagining) is the (uint32_t) cast.

(kre)

It seems that we need prototypes for long double math functions, even
when !__HAVE_LONG_DOUBLE -- they still exist, but just aren't...

This might unbreak several more builds.

(kre)

This set of changes seem to be sufficient to make at least the
amd64 port build again after the long double math function infusion
from yesterday.

Feel free (without consulting me, I'm just hacking about) to revert
any of this and do it a better way.

Note: this is not intended to be complete, in particular, in <math.h>
I added prototypes only for the functions that are needed for a
successful build, not all of the new ones...

(kre)

Fix column alignment in ps/w output

(skrll)

Don't duplicate PIM_CPU_BITS in one printf.

PIM_CPU_HPMC_BITS already includes PIM_CPU_HPMC_BITS

(skrll)

Fix one by one bugs I committed back in 2009.  Spotted by rillig@.

(skrll)

Missing '\'

Many thnanks rillig@

XXX-pullup10.

(nat)

snprintb(3): restore empty string in snprintb_m example

Restore the empty string at the end of snprintb_m output that was
accidentally removed along with empty string placeholders in the
format strings.  While here, move that example to be next to its
snprintb counterpart.

(uwe)

snprintb(3): update mmap example

Bring over the prettier version of the mmap format string that we have
in the header file for some time now.  Clarify that the final NUL of
the new format string is supplied by the compiler, g/c explicit final
\0 from the example that had it.

(uwe)

snprintb(3): try to improve narration

Try to make the narration more coherent.  Make the old and new
syntaxes easy to distinguish and go out of our way to highlight that
the old syntax uses 1-based bit positions.

(uwe)

snprintb.3: remove empty string literals from examples

Suggested by uwe@, as gaps in bitmasks are quite common and thus
shouldn't clutter the code.

(rillig)

snprintb.3: fix examples

The first example broke the format string at boundaries that didn't
highlight the structure of the format string and also didn't make it
clear that a few bits were omitted from having descriptions.

The second example contained an off-by-one error for SIXTEEN, which was
actually FIFTEEN.

The snprintb_m example repeated the above off-by-one error, and its
output was shown wrong, due to concatenated escape sequences.

(rillig)

Bring in more long double functions from FreeBSD.

(christos)

Handle -d %Y%m%d in the tools version. This is used in the release notes
Makefile.inc when BUILDID is specified. Consider providing parsedate(3)
in libcompat, but then we'd need yacc...

(christos)

make: refactor CondParser_Term to be inlinable

No functional change.

(rillig)

make: clean up parsing of conditions

No functional change.

(rillig)

Include <sys/bootblock.h> for struct mbr_sector

(kre)

make: clean up redundant 'const' from automatic variables

No binary change.

(rillig)

lint: on lint itself, disable query for const variables again

It suffixes to perform this check on demand.

(rillig)

lint: clean up redundant const from parameters and local variables

These were leftovers from splitting large functions into smaller
functions, to ensure that variables were not unintentionally reassigned.
Those refactorings are finished, and the extra help from the compiler is
no longer necessary.

No binary change.

(rillig)

lint: create .ln output file even when queries are enabled

This allows to configure lint flags in mk.conf globally for a whole
NetBSD build.  Previously, this would have made the build fail due to
missing .ln files.

The previous use case of rerunning lint with or without queries is easy
enough to achieve by doing a 'make clean', in the same way as for lint
warnings.

(rillig)

wii: Add 128x48 icon to SD card image

(jmcneill)

wii: Add NTSC 480p support.

In addition to this, add VIIO_{GET,SET}REGS ioctl support to allow for
poking at video interface registers from userland. This is helpful for
debugging display issues.

(jmcneill)

Unwrap a line which wasn't wrapped before it had an __UNCONST() added
to it, and now that that is gone again, doesn't need wrapping any more.

That line is now unaltered from what it was 3 revs ago (bit for bit).

NFC.

(kre)

build fix: use dd with count=1 for compat with NetBSD dd(1)

(jmcneill)

Make this compile without MULTIPROCESSOR

(skrll)

Remove an empty line

(skrll)

spaces -> tab

(skrll)

Catch up with revision 1.5 of atomic_init_cas.c.  Fixes building libc
on sun2, and probably others.

(thorpej)

wii: support RB_POWERDOWN

(jmcneill)

fix more alpha

(christos)

fix alpha, grr.

(christos)

evbppc: Add initial support for the Nintendo Wii

(jmcneill)

usb: increase USB_PORT_RESET_RECOVERY from 10ms to 20ms

I changed this from 250ms to 10ms back in 2021 based on a similar FreeBSD
change, but it seems to be a bit too aggressive for some platforms.

(jmcneill)

powerpc: fix delay for large (> ~5sec) values

When calculating the target timebase, promote '1000' on the RHS to ULL
to force 64-bit calculation, otherwise 'n * 1000' will overflow.

(jmcneill)

Create some more nodes.

(skrll)

Add range tests with trailing characters.

(christos)

generate strtou.3 from strtoi.3, grammar police

(christos)

add compat decls

(christos)

Make the first argument of ip6_str2scopeid const, instead of __UNCONST.
Thanks kre@. While here s/u_int32_t/uint32_t/

(christos)

PR/57828: Alejandro Colomar: Prioritize test for ERANGE before testing for
fully consuming the string. Adjust strtonum(3) to behave as before. Document
the order of the tests and sync the man pages (I should really autogenerate
one of the two man pages...)

(christos)

Add __UNCONST

(christos)

move local decls to headers

(christos)

Catch up with all the lint warnings since exit on warning was disabled.
Disable 'missing header declaration' and 'nested extern' warnings for now.

(christos)

Don't put big structures on stack.
Should fix PR 57859.

(mlelstv)

Make __learn_tree always visible. It starts with __ anyway.

(christos)

lint: clean up

(rillig)

Compensate for src/common/lib/libc/atomic/atomic_init_cas.c losing
the extern declaration of __libc_atomic_init() and instead using a
new one added to src/lib/libc/include/extern.h

That file is outside src/common and src/sys so is unavailable to
kernel builds, so instead make a new include file in src/common
which the kernel can read which contains the needed extern decl
for __libc_atomic_init()

This seems to fix the evbarm builds (maybe others) - but it is
all MUCH TOO UGLY to keep.  Someone please make a better fix,
even if that just means reverting rev 1.5 of
src/common/lib/libc/atomic/atomic_init_cas.c
and all of the changes here (the addition to libc/include/extern.h
should be harmless to keep).

(kre)

lint: unclutter conditional compilation

(rillig)

lint: only define xcalloc if actually used

(rillig)

lint: add query for const automatic variables

(rillig)

fix comments: HID0 ICFI/DCFI are "flash invalidate", not "flush invalidate"

(jmcneill)

Now that rusage_to_rusage50() has switched from being an external
function, to a static inline, we need <resource.h> for it to work.
Not all callers provide that (and nor should they need to), so include
it here.

Should unbreak the builds.

(kre)

risc-v: Add bwfm(4) firmware files to release image

Create the correct link for beagle,beaglev-starlight-jh7100-r0.txt NVRAM
config file.

(skrll)

Add bwfm* at sdmmc? for the Broadcom BCM43xxx WiFi Interface

(skrll)

Add DesignWare SD/MMC attachment.

(skrll)

What good are comments, really, if you can't have a little color?  Add
a note above CLKF_INTR() about why NetBSD will likely never switch to
using the "master" stack for the kernel, and thus why the not-enabled
version of CLKF_INTR() will never be enabled.

(Adding the comment here, rather than just deleting the code, has value,
I think, for future retrocomputing archeologists.)

(thorpej)

Hygiene.

(thorpej)