lagg: clear I/G bitg and set G/L bit in a generated MAC address

(yamaguchi)

Add a bit more debug.

(blymn)

Fix for PR pkg/55931
Don't move the cursor when getch is called if input is not going to
be echoed.  Lynx uses the cursor to mark the current selection in a
pop-up, previously the cursor was being relocated when getch was called
which broke the Lynx item marking.

(blymn)

Revert previous:

http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/arch/mips/mips/vm_machdep.c#rev1.163

> cpu_uarea_alloc: For ILP32, do not try to allocate physical memory above
> pmap_limits.avail_end.
>
> Fix NULL dereference in uvm_pglistalloc_contig_aggressive().

"high" argument larger than pmap_limits.avail_end is just legal for
uvm_pglistalloc(); uvm_pglistalloc_contig_aggressive() and friends
allocate memory between uvm_physseg_get_avail_start() and
uvm_physseg_get_avail_end().

It turned out that the NULL dereference took place as PHYS_TO_VM_PAGE()
aka uvm_phys_to_vm_page() returns NULL for a valid pa. I've not figured
out why...

Thanks chs@ for correcting my misunderstanding.

(rin)

tests/indent: remove redundant tests for '-ncs' and '-pcs'

These tests are already covered by opt_cs.c and opt_pcs.c.

(rillig)

tests/indent: condense test for indentation level, add missing files

(rillig)

tests/indent: condense the token tests

This reduces the number of files in the test directory. It also allows
the tests to be read from top to bottom, looking at only a single file.

Since t_options.awk complains about files that don't have any test case
at all, add some test for each token kind. Most of the tests had
previously been effectively empty.

(rillig)

tests/indent: extend tests for labels, extract test driver

Having the test driver in a separate file allows to run it on its own,
as 'awk -f t_options.awk label.c'. When the test driver warns, exit 1;
this is only needed for the standalone version, when run from inside ATF
the warnings on stderr already suffice to make the test fail in the end.

(rillig)

tests/indent: consolidate tests for comments

These tests have been the motivation for t_options.sh, which allows to
run indent with various command line options on the same input, without
having to create 3 files per test case.

A test file actually contains several tests, all separated by '#indent'
directives. Isolating each of these tests is simpler than having to pick
up the corresponding sections from 3 separate files. Running indent on
each small test case isolates the test cases from each other, preventing
them to influence later test cases. Exactly this had happened when
support for C99 comments was added in March 2021, which later turned
out to be done wrong.

(rillig)

tests/indent: merge tests for numbers into token_ident

The previous tests 'binary' and 'float' not only test binary and
floating point numbers, making their names too specific. Move them into
a new test token_ident that covers all "identifier-like" tokens, just as
in the code.

The test cases for the option '-cs' are already covered more
systematically in opt_cs.c, so remove that test.

(rillig)

Explicitly cast the long->float conversion since it is value-changing and
produces clang warnings.

(christos)

Fix llvm build: error: equality comparison with extraneous parentheses
[-Werror,-Wparentheses-equality]

(christos)

Whitespace nits.

(simonb)

Only print an error about missing I/O BARs for chips that need it.

(jmcneill)

Replace @dirrm to @pkgdir in packing list of syspkg

(uki)

Use a local static variable to hold "pktq_rps_hash_default"
like the other devices do.

Kernel ALL/amd64 compiles again.

OK: Kengo NAKAHARA <knakahara@netbsd.org>

(hannken)

tests/indent: merge duplicate input/output and output/output

No functional change.

(rillig)

When booted with "boot netbsd -1" (disable multiprocessor boot),
"ddb>continue" didn't work when ddb was started by breakpoint trap.

(ryo)

plcom: speed up close with HUPCL set

Instead of incurring a 1s penalty on close of a plcom device with HUPCL set,
defer the sleep until the next open, and only sleep if necessary.

(jmcneill)

regen

(andvar)

s/Techonology/Technology/

(andvar)

regen

(andvar)

s/Versin/Version/

(andvar)

make: fix order of parameters in function comments

No functional change.

(rillig)

indent: parse int command line options strictly

On i386 and other platforms where LONG_MAX == INT_MAX, the test
t_errors/option_tabsize_very_large failed since the behavior on integer
overflow differs between ILP32 and LP64 platforms. Noticed by gson@.

Avoid this unintended difference by adding reasonable limits for each of
the integer options and by replacing atoi with strtol.

(rillig)

tests/lint: use zero-indexed array in awk test program

No functional change.

(rillig)

tests/indent: remove redundant test output for -nbap

(rillig)

Upgrade self-test passed messages from verbose to debug.

(jmcneill)

Upgrade cgd self-test output from verbose to debug.

(jmcneill)

Honour the timeout= entry in boot.cfg

(jmcneill)

Only define DEFAULT_TIMEOUT if it is not already defined.

(jmcneill)

Fix primary CPU detection in cpu_acpi_tprof_intr_establish

(jmcneill)

Teach argon2 about explicit_memset(3). Should be upstreamed.

(nia)

su: Use consttime_memequal instead of strcmp.

This only affects the non-PAM case.

(nia)

Trailing whitespace

(skrll)

Trailing whitespace

(skrll)

Remove some newlines

(skrll)

To an alias address, or in a multihoming environment, the internal dgram
server may respond from a different address than the destination address
sent by the client.
To solve this problem, I introduce sendfromto() and recvfromto() so that
the server can reply from the correct address, i.e., the destination address
used in the request.

This change also has the aspect of a reference implementation using the
RECVDSTADDR and PKTINFO socket options.

(ryo)

tests/lint: document and extend the tests for options

(rillig)

Background dhcpcd if ec2_init is not enabled to speed up boot.

(jmcneill)

Skip legacy device detection for VMware guests with ACPI enabled.

(jmcneill)

Enable com and lpt at ACPI attachments.

(jmcneill)

libcrypt: Hide more private symbols by default. Fix style.

(nia)

tests/indent: clean up tests for '-bad' and '-badp'

(rillig)

tests/indent: add newly added t_options to file list

(rillig)

Spinkle some KNF spaces after commas.

(simonb)

Remove funny straggling blank line.

(simonb)

pm_remove_all is a shared field so move it out the #ifdefs

(skrll)

Move tsan entries marked machine=amd64 from .mi files into md.amd64

(skrll)

fix non-MULTIPROCESSOR build

Build tested only.

(ryo)

fix non-MULTIPROCESSOR build

(ryo)

tests/indent: restructure test for '-bacc' and '-nbacc'

To see the effects of the options, group the tests into sections, each
containing a small piece of code followed by the output of the two
options.

(rillig)

apply always-open quirk for logitech B100 mouse.

(mrg)

tests/indent: remove duplicate data from options tests

(rillig)

regen.

(mrg)

add logitech B100 mouse

(mrg)

tests/indent: remove accidentally added file from the mi list

(rillig)

tests/indent: condense tests for bool options

Previously, each bool option such as '-bacc/-nbacc' had 6 test files:
input, options, output for the positive and negative option. Splitting
this test data into separate files made it harder than necessary to
quickly compare the test output from '-bacc' with that of '-nbacc'.

Have a single test for the positive and negative option, allowing
several tests to run on the same input with different options.

This commit only contains the rather mechanic changes of concatenating
the previous test files and inserting the '#indent' directives, which
are documented in t_options.sh. Removing duplicate input sections, as
well as other cleanups will follow soon.

No functional change.

(rillig)

fix typos in comments.

(andvar)

Swap fdc@isa for fdc@acpi as the former takes over a second to probe.

(jmcneill)

Convert some debug messages to aprint_debug

(jmcneill)

Add missing acpi include

(jmcneill)

Disable MSI and MSI-X support if IAPC_BOOT_ARCH reports that MSI is not
supported.

(jmcneill)

If ACPI indicates that there are no user visible devices on the LPC or ISA
bus, set the "no-legacy-devices" property on isa to bypass indirect
configuration of ISA devices.

(jmcneill)

Fix typo in comment: "porniters" -> "pointers"

(jmcneill)

Handle restoring keyboard state via AbortDevices() rather than AbortDDX().

Tested on 3/60.  Note AbortDevices() and DEVICE_ABORT in deviceProc
functions were introduced after Xorg 1.14.0:
https://gitlab.freedesktop.org/xorg/xserver/-/commit/9f79e93b6b3416055d08a0e8f9f16d5fd0649e36

(tsutsui)

Ticket #1360

(martin)

Pull up following revision(s) (requested by maya in ticket #1360):

distrib/amd64/installimage-bios/etc.ttys: revision 1.1
distrib/amd64/installimage-bios/Makefile: revision 1.1
distrib/amd64/Makefile: revision 1.15
distrib/amd64/installimage-bios/boot.cfg.in: revision 1.1
distrib/amd64/installimage-bios/spec.inst: revision 1.1
distrib/amd64/installimage-bios/etc.rc: revision 1.1
distrib/amd64/installimage-bios/install.sh: revision 1.1

Restore having a BIOS-only amd64 USB image.

Several people reported having hardware that struggles booting the mix
EFI+BIOS image, and it's better to offer them a working image.

Keeping the EFI image as having the obvious name, this is going to become
more likely to work by default as newer hardware may not support BIOS boot.

(XXX pullup-9)

(martin)

Revert "usb: uhub: remove unnecessary delays when powering on ports"

syzbot says that the change exposes UB in usb_free_device and I can't
see how, so revert until I have a better understanding of what's going on.

Reported-by: syzbot+c445f7149cce07d4c252@syzkaller.appspotmail.com
Reported-by: syzbot+a2ae42f37de765a54b20@syzkaller.appspotmail.com

(jmcneill)

New sentence, new line.

(wiz)

doc: MKPIE/MKRELRO for aarch64

(nia)

indent: clarify that 25 is a magic number

The extra line width for comments to the very right is just that, an
arbitrarily chosen number. It neither has to be a multiple of 8, nor of
the tabsize nor of the indentation. Since 25 is neither of these, this
makes it a perfect choice, allowing these extreme comments to have 22
characters per line with -sc (leading asterisks in comment
continuations, the default) or 25 without.

No functional change.

(rillig)

Add sgp40mox(4)

(nia)

indent: turn ps.com_ind into local variable

This makes it immediately clear that ps.com_ind is computed in the first
part of process_comment and then only used from there.

No functional change.

(rillig)

tests/indent: test comment to the right, collect more useful tests

(rillig)

tests/indent: cover more error cases and inline indentation

(rillig)

tests/indent: provide full line coverage for argument handling

(rillig)

aarch64 needs a clean build after MKRELRO default has changed.

(martin)

Mention sht4xtemp and sgp40mox in CHANGES.  Add an entry for the Sensirion
VOC algorithm in 3RDPARTY.

(brad)

A driver for the Sensirion SGP40 MOx gas sensor.  An example of this
chip from Adafruit is:

https://www.adafruit.com/product/4829

This is a moderately priced gas sensor that can detect volatile
organic compounds in the air.  The driver uses the 3-clause BSD
licensed VOC algorithm provided by Sensirion to turn the raw sensor
metric into a VOC index which can indicate the quality of the air in a
particular indoor environment.  All published functions of the chip
are supported and one unpublished feature.

(brad)

Remove trailing whitespace

(gson)

mk: Enable MKPIE on aarch64 (it's already enabled on 32-bit arm)

(nia)

mk: Enable MKRELRO on aarch64 to match x86.

(nia)

mk: Enable MKARGON2 now that this stuff works.

(nia)

- use microtime instead of getmicrotime, suggested by thorpej
- use ttclos for wchan even though we are sleeping in comopen now

(jmcneill)

Output alignement - give lwp 6 characters

(skrll)

cpu_uarea_alloc: For ILP32, do not try to allocate physical memory above
pmap_limits.avail_end.

Fix NULL dereference in uvm_pglistalloc_contig_aggressive().

(rin)

indent: check command line options stricter

Previously, bool options were allowed to have trailing garbage. For
example, the option '-bacc' could be spelled '-bacchus' as well.

Check that the exact option name is given in the command line, to
prevent typos in the configuration files and to reduce surprises just in
case a future option is a prefix of an existing option, or vice versa.

Add a new test program for error handling. Most of these tests are so
simple that it would be overkill to create 3 files for each test.

(rillig)

tests/indent: test long comments in single line

I had expected them to differ depending on the option '-[n]fc1', but
they look exactly the same. There are several possibilities for the
leading space in the output.

(rillig)

indent: extract fits_in_one_line from process_comment

No functional change.

(rillig)

fix typos and wrong ISO/IEC standard number in reference description.

(andvar)

libcrypt hack for vax

(nia)

Tickets #1358 and #1359

(martin)

Pull up following revision(s) (requested by abs in ticket #1359):

sys/arch/amiga/dev/amidisplaycc.c: revision 1.33
share/man/man4/man4.amiga/amidisplaycc.4: revision 1.14
sys/arch/amiga/dev/amidisplaycc.c: revision 1.35
sys/arch/amiga/dev/amidisplaycc.c: revision 1.36

Implement the WSDISPLAYIO_GET_FBINFO ioctl, needed by X wsfb driver.

Add support for WSDISPLAYIO_MODE_DUMBFB to WSDISPLAYIO_SMODE.

Remove parentheses from return. No functional changes.

Update documentation to mention current status of X11

(martin)

Pull up following revision(s) (requested by skrll in ticket #1358):

lib/libc/arch/aarch64/gen/setjmp.S: revision 1.4
lib/libc/arch/aarch64/gen/_setjmp.S: revision 1.5

Fix the lib/libc/setjmp/t_setjmp:{,_}longjmp_zero test cases

(martin)

libcrypt: work around compiler bugs to get MKARGON2 working on vax

(nia)

Fix previous.

(msaitoh)

doc: wm(4): Add Tiger Lake and newer devices (I219 LM10-LM15 and V10-V14).

(msaitoh)

Add support for I219V 15-19 and I219LM 16-19.

(msaitoh)

Print I219's version number.

(msaitoh)

Regen.

(msaitoh)

Add Intel I219V 15-19 and I219LM 16-19.

(msaitoh)

Add Intel I219's version number.

(msaitoh)

Add support for the NOTE_SECONDS, NOTE_MSECONDS, NOTE_USECONDS,
NOTE_NSECONDS, and NOTE_ABSTIME filter flags to EVFILT_TIMER,
API-compatible with the same in FreeBSD.

(thorpej)

Fix vmx(4) receive workqueue problem on qemu, reported by ozaki-r@n.o, thanks.

ESXi stops interrupt by vmxnet3_disable_intr() immediately.  In contrast, qemu
does not stop interrupt soon.  Hmm, qemu's behavior seems not to be correct,
however, there is no explicit specification of vmxnet3.  So, we have to accept
that behavior.

(knakahara)

getty: Remove 2 second sleep before opening tty

This (apparently very old!) workaround to ensure that DTR stays down long
enough to be detected is now handled by serial drivers themselves. For
console devices (framebuffer, serial console, etc) this was an unnecessary
2 second penalty that we have all been paying since the beginning of time.

(jmcneill)

inetd: remove trailing whitespace, add space after 'if' and 'for'

No functional change.

(rillig)

inetd.8: remove trailing whitespace

(rillig)

inetd.8: new sentence, new line; minor formatting issues

(rillig)

indent: in process_comment, migrate int variable to bool

No functional change.

(rillig)

indent: in process_comment, negate box_com to may_wrap

In the new line 213, may_wrap could only be true and was therefore a
redundant condition.

No functional change.

(rillig)

indent: negate a few condition in process_comment

No functional change.

(rillig)

Capitalize word.

(wiz)

indent: fix formatting of single-line comments (since today)

The change in pr_comment.c 1.70 from 3 hours ago did not cover all edge
cases correctly. Now it works for comments that are aligned with tabs.

(rillig)

tests/indent: test more single-line comments

(rillig)

indent: replace unreachable code with assertion

(rillig)

indent: use high-level buffer API for processing comments

Document the trickery of copying the last word from the previous line
since that it not obvious at all.

No functional change.

(rillig)

PR/56448: Solomon Ritzow: Various improvements.

Rate limiting code has been moved to ratelimit.c. I renamed
clear_ip_list to rl_clear_ip_list and broke the code up into more
functions. I have also made the per-IP rate limiting allocation more
efficient. IP addresses are now stored in their network format instead
of a string from getnameinfo (see inetd.h struct rl_ip_node). malloc
calls use only the space needed by the structure by using offsetof on
union members (I suppose this can be a bit dangerous if not done
correctly...). Per-IP rate limiting still supports textual comparison
using getnameinfo for address families other than AF_INET and AF_INET6, but I
don't think there are any that are actually compatible or used by inetd (I
haven't tested UNIX sockets with a remote bound to another file, but I did test
using IPv6 with the textual format by commenting out the IPv6 specific
code, and it works properly). Still potentially handy for the future.
The IP node list (se_rl_ip_list) now uses the <sys/queue.h> SLIST macros
instead of a custom list. I've broken rl_process up into helper functions
for each type of rate limiting and created a separate function for
address stringification, for use with printouts from the -d flag. I
tried to reduce stack memory use by moving printing code involving
string buffers into separate functions. I haven't tested rl_ipv6_eq on
a 32-bit system.

The code for the positional syntax has also been moved to parse.c.
Function try_biltin has been added to remove parse.c:parse_server's
dependency on the biltin structure definition.

File inetd.h has been updated with the proper function prototypes, and
the servtab structure has been update with the new IP node SLIST. I also
moved things around a bit. The way we (a peer and myself)
formatted inetd.h previously was somewhat confusing. Function and global
variable prototypes are now organized by the source file they are
defined in.

I also added a -f flag that I saw in another problem report
(https://gnats.netbsd.org/12823) that I thought could be useful. It
runs inetd in the foreground but without debug printouts or SO_DEBUG.
I'm not completely sure about the line "if (foreground) setsid()" that
I changed from "if (debug) setsid()".

(christos)

tests/indent: test formatting of long single-line code comments

(rillig)

tests/indent: test long code comments

(rillig)

asan is supported on aarch64

(skrll)

indent: fix wrapping for comments in otherwise empty lines

The comment above the code was wrong. The leading 3 characters were
indeed ignored, but the first of them was '/', not ' '. Of the trailing
3 characters, 2 were not ignored. The start and end of the comment would
not cancel out, they would rather sum up.

(rillig)

crypt.3: note parallelism caveats

(nia)

Fix release builds with MKARGON2=yes

This changes argon2 from a separately built library into a private
dependency of libcrypt and removes the argon2(1) utility (we already
have pwhash(1)). Giving libcrypt more library dependencies
complicates things (e.g. libcrypt is a dependency of openssl).
pthreads support gets disabled in argon2 for similar reasons.

For testing argon2, we rely on the libcrypt test suite.

(nia)

PR/56452: RVP: MAKEDEV should also create /dev/dri/renderD* devices

(christos)

PR/56453: Wataru Ashihara: config(1): Assertion fails in config -L
Only compare pointers when one is found.

(christos)

Revert previous change because it causes uninitialized warnings with KMSAN.
The previous code was correct. Add a comment explaining why. Requested by chuq@

(christos)

added missing copyright header. pointed out by nia. no functional change

(jhigh)

crypt(3): clean up some leftover debug goo

(nia)

crypt(3): match the Argon2 reference implementation's Base64 exactly

There are too many minor variations regarding padding and exact alphabet
to safely use the implementation in libc or an existing implementation
in libcrypt.

(nia)

fix typos in man pages.

(andvar)

Add Intel 400 Series PCH-V devices.

(msaitoh)

Regen.

(msaitoh)

Add Intel 400 Series PCH-V devices.

(msaitoh)

remove comment, it's fixed

(nia)

crypt(3): Make Argon2 implementation match the reference impl by
making sure input salts are decoded as base64.

(nia)

paranoia: use explicit_memset

(nia)

pw_gensalt.3: add argon2 bits

(nia)

passwd.conf.5: document using argon2

(nia)

Add libcrypt tests for Argon2i/Argon2i, based on reference hashes
from the argon2 test suite.

(nia)

crypt-argon2: Properly honor user's version number.

Follow upstream by defaulting to 0x10 if it's not specified.

(nia)

crypt-argon2: improve resilience of the parser.

Allow the version number to be unspecified as in the argon2 upstream
test suite, properly defaulting to a version if the v= block is
entirely missing, and treating the remaining block as parameters.

Fix a null pointer derefence when the encoded password is unspecified
in the settings string.

(nia)

fix various typos, mainly in comments.

(andvar)

Set a port interface of lagg(4) in promiscuous mode
when the lagg(4) is in promiscuous mode.

(yamaguchi)

lagg: update capabilities of ifnet and ethercom

Commonly capabilities of all child interface are configured
to a lagg interface.

(yamaguchi)

Note that while sleeping (HUPCL), time passes.
Try to avoid the otherwise infinite loop.

(kre)

Fix xrefs. Remove superfluous Pp.

(wiz)

Fix date.

(wiz)

Now Jason has made this build, avoid a 50+ year
sleep to implement HUPCL.

(kre)

Add hvn.4. OK'd by nonaka@.

(msaitoh)

Add buffer gap accessor to return the complete text of the buffer as a string

Bump version number

(agc)

Fix the build by adding 'sc_hup_pending' member to com_softc that
was apparently forgotten.

(thorpej)

indent: use separate variables for lexi_alnum and lexi

These two uses of the variable are independent of each other.

No functional change.

(rillig)

Allow getty to exit quickly a few times before deciding that it is exiting
too quickly. Based on a FreeBSD change from 1994.

(jmcneill)

indent: clean up comments in lexi and lexi_alnum

No functional change.

(rillig)

indent: extract lexi_alnum from lexi

No functional change.

(rillig)