Adapt to CFARGS().

(thorpej)

Adapt to CFARGS().

(thorpej)

Adapt to CFARGS().

(thorpej)

Adapt to CFARGS().

(thorpej)

Adapt to CFARGS().

(thorpej)

Adapt to CFARGS().

(thorpej)

Adapt to CFARGS().

(thorpej)

Adapt to CFARGS().

(thorpej)

Adapt to CFARGS().

(thorpej)

Adapt to CFARGS().

(thorpej)

revert rev 1.45:
  "PR/54435: Adjust for new kernel behavior of soreceive(9) clearing MSG_OOB"

That change was trying to make rlogin work again after the SIOCATMARK ioctl
was broken, but that kernel bug has now been fixed, so the original rlogin code
now works again.  Further, the changed rlogin code actually did the wrong thing,
by treating reception of the MSG_OOB byte as meaning that we are now
"at the mark", but that is not true... we are "at the mark" only when
we have reached the point in the stream where the MSG_OOB byte was originally,
as indicated by SIOCATMARK.  So going back to the previous code seems best
all around.  ok'd by christos.

(chs)

Adapt to CFARGS().

(thorpej)

Adapt to CFARGS().

(thorpej)

Adapt to CFARGS().

(thorpej)

Fix various typos in comments. Also add missing NetBSD RCS Id in some of these files.

(andvar)

Adapt to CFARGS().

(thorpej)

lint: in strict enum mode, error out on enum type mismatch in union cast

(rillig)

lint: merge almost duplicate code from 'sametype' into 'eqtype'

In 'sametype', the branch for comparing array types was unreachable
since it requires both tspecs to be the same, but t2 underwent the
array-to-pointer conversion.

Previously, lint warned about enum type mismatches, even without -e for
strict enum mode.  Instead, it got the case for 'char *' wrong, which is
now fixed.  Now lint behaves like GCC 10.3.0 in this regard.  The
warning about enum mismatch is useful though, so it may be re-added in a
future commit.

(rillig)

s/pasword/password/

(andvar)

lint: union casts are only available as a GCC extension, not in C99

(rillig)

tests/lint: prepare non-GCC test for union casts

(rillig)

tests/lint: test GCC extension for casting to union type

(rillig)

in sbsavetimestamp(), initialize struct timeval to 0 with memset() so that
the implicit padding is initialized.  this avoids later copying uninitialized
memory out to user space.  detected by KMSAN.

(chs)

initialize wc_unused to 0, to avoid writing uninitialized memory to disk.
detected by KMSAN.

(chs)

do not descend into the man or tests directory.
this avoids a problem where git sets the file timestamps differently
than CVS does and accidentally causes make to try to rebuild
various targets that don't work during the tools build.
this matches the change that was made to Makefile.am in our tree.

(chs)

lint: add quotes around placeholder in message 214

function '%s' expects to return value

(rillig)

lint: casting to a struct is not allowed in C99, only with GCC

(rillig)

tests/lint: test casting a struct to another struct

(rillig)

lint: clean up and move 'sametype'

This function is only used by lint1.  That's good since the lint2 code
was completely broken, as it would regard any two struct types as being
the same.

Remove the large switch statement since it is unlikely that there will
be new type derivations in C anytime soon.

No functional change.

(rillig)

lint: reduce number of negations in preprocessor condition

No functional change.

(rillig)

lint: make memory management code easier to read

No functional change.

(rillig)

1326

(snj)

Pull up following revision(s) (requested by nia in ticket #1326):
distrib/sets/lists/man/mi: revision 1.1724
share/man/man4/man4.x86/amdccp.4: revision 1.1
share/man/man4/man4.x86/Makefile: revision 1.23 via patch
Add a man page for amdccp(4)

(snj)

Address concerns about limited compile-time type checking with the
tag-value mechanism of specifying arguments to config_search(),
config_found(), and config_attach() by replacing the tag-value scheme
with a "struct cfargs", a pointer to which is passed to the aforementioned
functions instead.

The structure has a version field to allow for future ABI versioning
flexibility.  The external structure is canononicalized internally
before use.

To ease the initialization of this structure, use a variadic preprocessor
macro, CFARGS(), to construct an anonymous "struct cfargs" inline, the
address of which is passed to the target function.  A CFARGS_NONE macro
provides a symbolic stand-in for when the caller doesn't want to pass
arguments (currently expands to NULL and is handled during canonicalization).

(thorpej)

Cleanup alarm(3) handling in the timezone selection menu for error
cases, pointed out by RVP.

(martin)

When reading output from a program we don't know how much it will
be - so scale the buffer (within reasonable limits).
Problem pointed out by RVP, triggered e.g. by disks with lots of GPT
partitions.

(martin)

ssdfb: support having an optional reset pin

(tnn)

Switch evbppc/ibm4xx to generic evbppc (same as oea) kernel modules.

I've confirmed that kernels similar to amd64/conf/MODULAR work fine
both on 403 and 405.

XXX
Unfortunately, we cannot immediately switch evbppc/booke to generic
kernel modules yet; it has its own intr.h implementation.

(rin)

curses: clarify standout as the "best" _supported_ highlighting mode
of the current terminal

(nia)

Use unsigned to avoid undefined behavior in sdmmc_mem_sd_switch().
Found by kUBSan.

(msaitoh)

Document :On modifiers in more detail.

(wiz)

Reverse devpubd dependeny to avoid dangling reference to zfs which is
an optional part of the build.

(mlelstv)

tests/make: fix test for the variable modifier ':On'

The variable modifier ':On' sorts words numerically.  If these words are
not numeric at all, they get assigned the numeric value 0.  Internally,
':On' uses qsort for sorting the words.  Since qsort is not specified to
use a stable sorting algorithm, the test data must only use words that
either are written in the same way or that are numerically different.

The test varmod-order failed this requirement by trying to numerically
sort a list of non-numeric words.  This led to different results on BSD
and Ubuntu, as could be expected.

To fix the tests, distinguish between words and numbers in the tests.
While here, clean up the tests for all variants of the variable modifier
':O'.

Found by sjg on Ubuntu.

(rillig)

Remove ixgbe because both ixg and ixv exist in the list.

(msaitoh)

Fix locking against myself reported by rin@n.o.

In some machine, INTx interrupts occurs for some reason while holding
txq_lock in softint context.
e.g. https://dmesgd.nycbug.org/index.cgi?do=view&id=6139

The panic message is the following.
====================
[  50.1699480] panic: LOCKDEBUG: Mutex error: mutex_vector_enter,467: locking against myself
[  50.1800188] cpu0: Begin traceback...
[  50.1800188] 0xc7a29ac4: netbsd:db_panic+0xc
[  50.1900018] 0xc7a29adc: netbsd:vpanic+0x120
[  50.1999533] 0xc7a29af4: netbsd:aprint_debug
[  50.1999533] 0xc7a29b34: netbsd:lockdebug_abort1+0x18c
[  50.2099719] 0xc7a29b74: netbsd:lockdebug_wantlock+0x1e8
[  50.2199525] 0xc7a29bb4: netbsd:mutex_enter+0x288
[  50.2299642] 0xc7a29be4: netbsd:wm_intr_legacy+0x9c
[  50.2299642] 0xc7a29c2c: netbsd:i80321_intr_dispatch+0x138
[  50.2399631] 0xc7a29de4: netbsd:irq_entry+0x98
[  50.2499452] 0xc7a29e24: netbsd:entropy_enter+0x88
[  50.2599996] 0xc7a29e6c: netbsd:rnd_add_data_1+0x50
[  50.2699565] 0xc7a29ebc: netbsd:rnd_add_data+0x10c
[  50.2699565] 0xc7a29ed4: netbsd:rnd_add_uint32+0x28
[  50.2799524] 0xc7a29f1c: netbsd:wm_txeof+0x2c0
[  50.2899527] 0xc7a29f5c: netbsd:wm_handle_queue+0x44
[  50.3000257] 0xc7a29fac: netbsd:softint_thread+0x130
[  50.3100119] cpu0: End traceback...
====================

To fix this panic, stop wm(4) interrupts before calling softint.
This behavior is similar to MSI-X polling mode.

Reviewed by msaitoh@n.o, tested by rin@n.o, thanks.

(knakahara)

update the list of ethernet drivers that have been MPSAFEified.

(mrg)

drm: Plug another fence leak.

XXX pullup-9

(riastradh)

Accidentally commited some other changes that weren't quite ready.  Add
these changes to fix the build.

(oster)

lint: expand abbreviations in definitions of operator properties

No functional change.

(rillig)

Support on-demand re-scanning all devices to look for
autoconfig RAID sets.  raidctl now supports looking
for autoconfig RAID sets with a new '-L' flag.

(oster)

drm: Release fence if we're about to return too.

Should fix another fence leak.

XXX pullup-9

(riastradh)

fix typo in README.compileopts text.

(andvar)

s/suported/supported in comments

(andvar)

s/diferent/different/

(andvar)

ssdfb: define SSD1353 command set

also adjust some SSD1322 command names

(tnn)

fix various typos in comments and log messages.

(andvar)

curses: clarify documentation regarding the standout attribute

(nia)

Sync with HEAD.

(thorpej)

s/overwriten/overwritten/ in comments.

(andvar)

add pcib(4), pceb(4), pcmb(4).
pcmb is a separate man page for i386 only, pceb and pcib are references to pci(4) only and mentioned in its bridges section.
ok riastradh

(andvar)

tests/lint: fix test c11_generic_expression on ILP32

These platforms don't provide __uint128_t, at least not in lint.

The exact data type does not matter in this test, it just has to be
different from 'int'.

(rillig)

Document thorpej-cfargs2.

(thorpej)

Move case 'l' to be in sorted order.  No functional change.

(oster)

lint: clean up debug logging in the C grammar

(rillig)

lint: merge duplicate debugging code

The functions 'debug_node' and 'display_expression' were similar enough
to be merged.

Migrate debug_node to use the existing debug logging functions.

Remove the now unused option 'd' from the options string.

(rillig)

lint: remove option -d, clean up debug logging

The command line option -d was not used by /usr/bin/lint, and it only
triggered a handful of debug messages.  Move this debug logging over to
the compile-time -DDEBUG setting.

Move display_expression further up to avoid the forward declaration.

(rillig)

lint: make xasprintf simpler

No functional change.

(rillig)

lint: unexport nomem

No functional change.

(rillig)

fix typo in definition: s/threshhold/threshold/

(andvar)

lint: remove xmapalloc

Just trust the standard malloc to be smart enough.

No functional change.

(rillig)

tests/lint: test the usual arithmetic conversions in traditional C

(rillig)

ssdfb(4): add an iic fdt attachment example also

(tnn)

fix syntax error and typo in overwritten.

(andvar)

ssdfb(4): nix BUGS section, add EXAMPLES section

(tnn)

fix typos in word "otherwise".

(andvar)

ssdfb: support the 4-wire SPI interface

(tnn)

tests/lint: re-add the test for __uint128_t

(rillig)

lint: remove unreachable code from usual arithmetic conversions

(rillig)

tests/lint: fully cover the usual arithmetic conversions

(rillig)

lint: fix usual arithmetic conversions for 128-bit integer types

(rillig)

lint: demonstrate wrong integer conversion for __uint128_t

(rillig)

tests/lint: test the usual arithmetic conversions

The function 'balance' does not mention __uint128_t and nevertheless
works as expected.  Need to investigate further.

(rillig)

tests/lint: document why lint does not check _Generic selections

(rillig)

lint: remove hash value from symbol buffer

Conceptually, a symbol buffer does not need to remember its hash value
since that belongs to the symbol table.  This makes the code for the
symbol table simpler.  The number of hash calculations increases by
about 5%, which is negligible.

No functional change.

(rillig)

lint: merge duplicate code for removing a symbol from the table

No functional change.

(rillig)

lint: extract duplicate code for modifying the symbol table

No functional change.

(rillig)

lint: add debug logging for symbol table, clean up debug logging

When I tried to fix msg_115, I quickly ran into a segmentation fault,
probably related to the symbol table.  To better understand this part,
log insertions and deletions.

The other debug log messages do not need to mention the current file
position anymore, this is what lex_next_line takes care of since scan.l
1.113 from 2021-01-05.

(rillig)

tests/make: split tests for the variable modifier ':O'

The tests for parse errors are now in varmod-order, which lets the other
tests focus on the desired behavior of the modifiers.

(rillig)

s/dependend/dependent/

(andvar)

s/threshhold/threshold

(andvar)

lint: improve support for __int128_t and __uint128_t

For the .ln files, I chose the letter 'J' to represent the 128-bit
integer types since it is close to 'I' for int.  The naming of 'L' for
'long' is obvious, but 'Q' for 64-bit integers is a quad-16-bit word,
which is an unusual measurement unit nowadays.  One benefit of choosing
'J' is that the next letter, 'K' can then be used for 256-bit integer
types.

Support for 128-bit integer types is still very basic.  Plus, it is only
supported on LP64 platforms, which means that lint cannot be
cross-compiled to check for an LP64 platform while running on an ILP32
platform.

(rillig)

lint: initialize shared types in the same order as in tspec_t

This makes it easier to see whether there are any types missing, such as
__uint128_t.

No functional change.

(rillig)

lint: do not evaluate arguments of debug_step

To analyze the unexpected test failure of op_shl_lp64, I had reverted
debug_step to evaluate its arguments.  I then accidentally committed
that without running the tests again.

Anyway, the previous commit can now be used as a demonstration that
initdecl is indeed missing the initialization for __uint128_t, which
leads to the internal error in op_shl_lp64.

(rillig)

lint: clean up debug logging

The calls to debug_step, unlike printf, don't need a trailing newline.

Remove the debug_step0 macro and its relatives since lint already uses
enough other features from C99 that it essentially requires this
standard, which supports varargs macro arguments.  Among these features
are __func__ and printf("%zu").

In non-debug mode, do not evaluate the arguments of debug_step.
Evaluating the arguments had caused an internal error when running the
test op_shl_lp64.  This is indeed a bug since initdecl should have
initialized the type table for __uint128_t.  This had been forgotten
when support for __uint128_t was added in decl.c 1.69 from 2018-09-07.

No functional change.

(rillig)

lint: extract debug logging to separate file

Lint currently has several different kinds of debug log:

* The -DDEBUG log is controlled at compile time.
* The -d command line options enables some other debug logging.
* The -DYYDEBUG log for parsing is controlled at compile time.
* The -y command line option only has an effect in -DYYDEBUG mode.

Extracting the logging into a separate file is a first step towards
unifying these logs and making the code for debug logging stand out less
than the current #ifdef DEBUG.

No functional change.

(rillig)

lint: add debugging output for the grammar tokens

No functional change outside debug mode.

(rillig)

s/propective/prospective

(andvar)

s/threshhold/threshold

(andvar)

Fix a silly mistake (missing return) in the DEBUG case of the kernel pmap
case of pmap_extract().

(thorpej)

Run devpubd before volume managers and pseudo disks.

(mlelstv)

fix more typos in style found one in file - check/fix them all.

(andvar)

lint: reduce indentation in 'search'

No functional change.

(rillig)

lint: in has_constant_member, don't reuse variables

No functional change.

(rillig)

sunxi_platform: declare UART FIFO sizes for SoCs we support

(tnn)

lint: merge duplicate code for generating unqualified type

This is a preparation for fixing the wrong warnings in msg_115.c.

No functional change.

(rillig)

fix typos in comments

(andvar)

tests/lint: demonstrate more wrong warnings for const struct members

The code 't_const = false' occurs 4 times in the lint code, each
corresponding to one of the wrong warnings in the test.

This bug has been existing at least since 2001.  Back then, the lint
output was:

2001.12.24.20.52.09
| (23): lint error: popctrl() 1
| (15): syntax error [249]
| (19): warning: left operand of 'FARG' must be modifiable lvalue [115]
| (21): syntax error [249]
| (23): warning: function initialize_const_struct_member falls off bottom without returning value [217]
| exit status 1

from 2002.12.06.03.27.39
| (23): lint error: func.c, 168: popctrl()
| (15): warning: left operand of '=' must be modifiable lvalue [115]
| (19): warning: left operand of 'FARG' must be modifiable lvalue [115]
| (21): syntax error [249]
| (23): warning: function initialize_const_struct_member falls off bottom without returning value [217]
| exit status 1
until 2003.10.27.00.12.44

(rillig)

fix typos in comments

(andvar)

only read cpr register if we're going to use the value

(tnn)

make: fix lint warnings

The string functions from str.h are declared as 'static __unused' when
compiled with GCC, but lint explicitly undefines __GCC__ during
preprocessing.  Therefore, make those functions inline, to prevent
warnings that they are unused.

The macro UNCONST is used in a few places, and (again) since lint
undefines __GCC__, that macro expanded to a simple type cast, which lint
warned about.  To prevent this warning, implement UNCONST as a function
that works everywhere and hides the type cast.

In filemon_open, the code for closing F->in was obviously unreachable.

No functional change.

(rillig)

tests/lint: demonstrate wrong error message for initialization

Seen in usr.bin/make/var.c:4022 in C99 mode, where a ModChain variable
is initialized and two of the members are const-qualified.

(rillig)

make: clean up ApplyModifier_Order

No functional change.

(rillig)

make: reword comment for ApplyModifier_Order

(rillig)

make: handle parse errors in ':O' uniformly

Previously, the error handling for the variable modifier ':O' differed
depending on the exact variant and in some cases led to misleading
or missing diagnostics.

(rillig)

make: merge duplicate code for sorting strings and numbers

No functional change.

(rillig)

make: fix typo in manual page, add more tests for the new ':On'

(rillig)

make thermal zone parameters configurable by sysctl

(macallan)

tests/make: register test varmod-order-numeric

(rillig)

Add :On for numeric sort

Reviewed by: christos rillig

(sjg)

ssdfb(4): remove code for dealing with non-MPSAFE attachment

spi(4) was marked MPSAFE some time ago, so we're always on an
MPSAFE parent device.

(tnn)

com(4): fix FIFO for DW_APB on Allwinner A20 (got broken by com.c 1.360)

Older DesignWare UARTs do not advertise their FIFO length so we must
provide it via device properties.

(tnn)

Skip the test when the dtrace_syscall module is not loaded and can't
be autoloaded, as may be the case on arm because securelevel.

(gson)

gcc 11.2 out

(wiz)

As we're providing the legacy gcc __sync built-in functions for atomic
memory access we might as well get the memory barriers right...
From the gcc documentation:

In most cases, these built-in functions are considered a full barrier.
That is, no memory operand is moved across the operation, either forward
or backward. Further, instructions are issued as necessary to prevent the
processor from speculating loads across the operation and from queuing
stores after the operation.

type __sync_lock_test_and_set (type *ptr, type value, ...)

  This built-in function is not a full barrier, but rather an acquire
  barrier. This means that references after the operation cannot move to
  (or be speculated to) before the operation, but previous memory stores
  may not be globally visible yet, and previous memory loads may not yet
  be satisfied.

void __sync_lock_release (type *ptr, ...)

  This built-in function is not a full barrier, but rather a release
  barrier. This means that all previous memory stores are globally
  visible, and all previous memory loads have been satisfied, but
  following memory reads are not prevented from being speculated to
  before the barrier.

(skrll)

make: in TryParseNumber, reset errno as late as possible

No functional change.

(rillig)

tests/make: test spaces around numbers in comparisons

Just to see whether it is possible to write a conditional in the form
${ ${A} < ${B} :? ${A} : ${B} }, that is, with leading and trailing
whitespace, to make it easier for humans to read the code.

It's not possible, the result of this computation cannot be used in
further numeric comparisons, at least not in .if directives.  Leading
space would work, but trailing space wouldn't.

On the other hand, they would work in expressions of the form
${ ${A} < ${B} :? ... : ... } since in these, the condition is first
expanded and then parsed.  But that is an implementation detail that is
not documented and it is also difficult to understand.

(rillig)