Ammend ticket #1626

(martin)

Remove options unknown to all native gcc on this branch.
The version check did not work because on this branch the numbering
scheme wass different (e.g. gcc 5.x is used and HAVE_GCC is 53, which
numerically clearly is > 7 - but that is not what the new check meant).

(martin)

Describe after example like other examples

(ryoon)

PR/55851: Martin Husemann: recognize <symbol>.part.<n> names
This is gross; perhaps we should hide them completely (not print them
in stack traces etc.)

(christos)

fix aarch64 crossgdb

(christos)

regen

(christos)

s:aarch64/cpufunc.h:arm/cpufunc.h:

a baby step in the grand arm header unification challenge

(skrll)

Ticket #1635

(martin)

Pull up following revision(s) (requested by nonaka in ticket #1635):

sys/dev/hyperv/if_hvn.c: revision 1.19 (via patch)

hvn(4): fix unable to ifconfig up/down.

(martin)

Ticket #1146

(martin)

Pull up following revision(s) (requested by nonaka in ticket #1146):

sys/dev/hyperv/if_hvn.c: revision 1.19

hvn(4): fix unable to ifconfig up/down.

(martin)

add some basic tests for libossaudio

since there are already tests for audio this is focused on making
sure the ioctls translate properly and implement the necessary OSS
compat quirks.

right now this only covers the dsp ioctls, it should also cover the
mixer ioctls, although that's significantly harder.

(nia)

Multiple inclusion protection define consistency

(skrll)

Fix build failure when XNEPV is defined.

(knakahara)

arm copyin/out: make copyin not use copyout's epilogue (typo in labels)

The epilogues are the same, so this is harmless, but if they ever
changed (e.g. after rearranging the register usage) it would be broken
in a very confusing way.

(dholland)

arm bswap32: fix fatal typo in thumb code (PR 55854)

(dholland)

Trailing whitespace

(skrll)

hvn(4): fix unable to ifconfig up/down.

(nonaka)

Not pic->pic_addroute but pic->pic_hwunmask should enable interrupts for MSI-X.

pic->pic_addroute should not enable interrupt, because callers expect
interrupts have been disabled until they call pic->pic_hwunmask.

By the way, the old implement writes zero to Vector Control for MSI-X Table
Entries, howerver it must be read and updated.  Because, there are not only
Mask Bit but also ST lower and ST upper.

(knakahara)

Add ${LIBUTIL} to DPADD.

(simonb)

Fix editor mishap in r1.18

(martin)

Don't use EIMC_OTHER bit because it's read only other than 82598.

Documents say:

  82598:
    All of bit 31(OTHER bit) of EIxx are reserved. In reality, at least
    EIMS_OTHER and EIMC_OTHER exist and the OTHER interrupt doesn't work
    without EIMS_OTHER.

  Other than 82598:
    EIMS_OTHER is read only and EIMC_OTHER doesn't exist. If one of
    bit 29..16 is set, EIMS_OTHER is set to 1 (Note that bit 30(TCP timer
    isn't included)). Even if write bit 31 of EIMC to 1, it's ignored
    (EIMS_OTHER doesn't set).

We introduced new spin mutex in ixgbe.c rev. 1.260, so it's OK to remove
EIMC_OTHER stuff. We already set EIMS_OTHER in if_init(), so keep it for
82598. No functional change other than 82598.

Another solution is to control bit 30..16 directly to mask/unmask interrupt
instead of the mutex.

TODO:
  Some MSI-X interrupt(LSC, module insertion/removal etc.)'s mask/unmask
  code between ixgbe_msix_admin() and ixgbe_handle_admin() may be wrong.
  It'll be fixed later.

(msaitoh)

Use sel{record,remove}_knote().

(thorpej)

Add sel{record,remove}_knote(), so hide some of the details surrounding
knote / kevent registration in the selinfo structure.

(thorpej)

make(1): document why runIgnImpl is used in jobs mode

(rillig)

make(1): add tests for comments and non-comments in jobs mode

(rillig)

make(1): rename shell flags in struct Shell

The previous name 'echo' was too unspecific, given that the other fields
in the same struct are called echoOff, echoOn, echoTmpl.

(rillig)

make(1): clean up comments for struct Shell

(rillig)

make(1): name Shell fields consistently

They are all templates with a single %s placeholder, so embed this
unambiguously in the variable name.  The previous variable names didn't
provide any clue that echoCmd, execIgnore and errExit had a lot in
common.

(rillig)

make(1): clean up JobPrintCommand

The local variable 'cmd' had been used for both the unexpanded and the
expanded command.  This in turn had required the parameter to be
non-const.

(rillig)

make(1): eliminate global variable numCommands

It had only been used in a very small scope.  The elimination of
Lst_ForEach made it easy to turn this global variable into a local
variable.

(rillig)

make(1): extract JobOpenTmpFile from JobStart

(rillig)

make(1): rename RunFlags to CommandFlags

Flags of similar names are also available in CmdOpts (global command
line options) and Job.  The new name CommandFlags emphasizes that these
flags apply to the smallest scope possible, which is a single command,
as opposed to the whole GNode/Job.

(rillig)

make(1): split Job.errOffOrExecIgnore into separate fields

Like errOnOrEcho, these two fields were completely unrelated.  One of
them expected a %s placeholder, the other didn't.

(rillig)

make(1): split Job.errOnOrEcho into separate fields

They have never been related.  Furthermore, Job.errOn is really tricky
to reach at all.  To do that, one has to define a custom shell and set
hasErrCtl=true.  The manual page has an example for that, but it's
probably not use in practice, just like the possibility to use the C
shell for all commands.

(rillig)

make(1): negate Job.silent to echo

This gets rid of a few explicit negations and an implicit negation in
the variable name.

(rillig)

make(1): unpack struct JobFlags

The job flags are only used individually.

(rillig)

make(1): rename commandShell to shell

The word 'command' was not necessary for understanding the variable.

(rillig)

Another leading space

(skrll)

make(1): split JobFlags into separate fields

Having all these flags in a single bitmask makes it harder to see where
exactly they can possibly be used since their state could also be
modified using the unsuspicious job->flags = 0.  Using individual names
just leaves the single memset, and that is only used during
initialization.

(rillig)

Remove leading space that crept in in the last change

(skrll)

make(1): in JobStart, negate 'noExec' to 'run'

(rillig)

make(1): fix theoretical type mismatch for Job_Touch

(rillig)

make(1): fix test for command flags

The "false" is supposed to be run not only if the command has the '-'
flag, but also if the target is marked as .IGNORE or if the command line
option -i is given.

After the failed command, the remaining commands are skipped, therefore
the final echo for the empty line had to be moved up, at the beginning
of the target.

(rillig)

make(1): test all combinations of switches for running commands

The code in JobPrintSpecials is rather complicated and contains
surprising interaction between some of the switches.

To see the exact effects of the switches, record the current state and
its output, to prevent accidental breakage during the upcoming
refactorings.

(rillig)

Handle failing to acquire the iic bus.
Better handle errors when attaching sysmon sensors.

(jdc)

make(1): document limitations of deferred '$' in ':?' modifier

(rillig)

make(1): add test demonstrating how to defer evaluation in :? modifier

(rillig)

Avoid an unused variable (breaking the build)

(martin)

Skip the repeated_link_addr test by default as it causes the
evbarm-aarch64 testbed to hang (PR port-evbarm/55521), and will not be
safe to run by default even after that bug is fixed, for similar
reasons as t_repeated_updown.
---

t_repeated_mtu.sh changes the MTU, which may cause NFS to fail.
if you have NFS root, this is system killing.

t_repeated_scan.sh kills and restarts both hostapd and
wpa_supplicant.

(mrg)

Fix armeb; CORE_ADDR is uint64_t but 2nd argument of raw_supply() is
expected to be the same size as PC. Therefore, PC was always read as
zero for big-endian.

(rin)

Fix arm, for which PT_STEP is defined but unimplemented.

XXX
Stop exposing PT_STEP to userland for arm?

(rin)

Add a string literal for IAVF_VC_OP_CONFIG_RSS_LUT

(yamaguchi)

remove unnecessary lock acquire and release

(yamaguchi)

Fix a wrong value about HENA configuration

(yamaguchi)

New OpenSSL

(christos)

merge conflicts, regen

(christos)

Remove <sys/param.h> include and assume users already include that.
Removes an include cycle when including <sys/resource.h> via:
ys/time.h, sys/timevar.h, sys/mutex.h, sys/intr.h on top of this
file, and sys/param.h, uvm/uvm_param.h, sys/resourcevar.h below.

(martin)

xhci_pci: avoid potential double free of interrupt handles

Found by Kouichi Hashikawa in PR 55855.

(jakllsch)

Add "memory" constraint on wrpsr, lost in previous.

(uwe)

Remove unnecessary aarch64_dcache_wbinv_all now that pmapboot_enter does
dsb(ish)

(skrll)

make(1): clean up test output of opt-jobs-no-action

(rillig)

make(1): remove noise from test output of opt-jobs-no-action

(rillig)

make(1): split the -j -n test into separate targets

The manual page says that in -j mode when the shell does not have ErrCtl
(and none of the default shells has that), the command prefix '-'
"affects the entire job", but this seems to be wrong.  At least, there
is no change in the output from before, when all commands had been in
the same target.

(rillig)

make(1): add test for the -n option combined with RunFlags

(rillig)

make(1): refine test for combining -j1 and -n

(rillig)

Restructure the abort code for TD based transfers (ctrl, bulk, intr).

In PR kern/22646 some TDs can be on the done queue when the abort start
and, if this is the case, they need to processed after the WDH interrupt.
Instead of waiting for WDH we release TDs that have been touched by the
HC and replace them with new ones.  Once WDH happens the floating TDs
will be returned to the free list.

Also addresses the issue seen in PR kern/55835

Thanks to both Andreas Gustafsson and Edgar Fuß for testing.  Apologies to
Andreas Gustafsson for not committing this to HEAD for 4y6m.w

(skrll)

Remove an old description.
This behavior was modified in sys/dev/audio/audio.c rev 1.65 (Mar. 2020).

(isaki)

Rewrite error handling on audio_open().
This also fixes a few resource leaks on error case.

(isaki)

Fix that audio_open() didn't halt the recording mixer correctly
if fd_allocfile() failed, since rev 1.65.
Will fix PR kern/55848.

(isaki)

sp_tlb_flush() - fix inline asm miscompiled by newer gcc versions.

As one national park director once said: "my problems start when the
dumber of my visitors meet the smarter of my bears".

Old inline asm used specific hardcoded registers "assuming that gcc
doesn't do anything funny with these".  Unfortunately now it does,
especially when this function is inlined.  We ended up restoring a
wrong context.  The result was mysterious infinite memory faults.

Rewrite in safer inline asm, so that gcc is not confused.

Many thanks to chs@ for his patience.

(uwe)

arm bswap32: Improve the comments showing the byte flow.

It's confusing to use 1-4 for bytes 1-4 and then 0 for literal zero,
so use a-d for bytes 1-4.

(dholland)

make(1): add more tests for combining -j1 and -n

(rillig)

make(1): add test for combining -j1 with -n

(rillig)

make rump's uvm_aio_aiodone_pages() look more like the kernel version.
fixes some more rumpy assertions.

(chs)

make(1): in jobs mode, invert local variable noSpecials to run

(rillig)

make(1): negate RunFlags.silent to become RunFlags.echo

This reduces the number of negations in the code.

(rillig)

make(1): move flags errOff into RunFlags.ignerr

(rillig)

make(1): move flag runAlways into RunFlags

(rillig)

make(1): move flag shutUp into struct RunFlags

Running a command is controlled by several flags.  Instead of passing
them around individually, it's easier to have them grouped.

(rillig)

Ticket #1626

(martin)

Sync external/bsd/pkg_install with -current, requested by wiz in ticket #1626:

external/bsd/pkg_install/Makefile.inc          up to 1.7
external/bsd/pkg_install/dist/add/perform.c    up to 1.7
external/bsd/pkg_install/dist/admin/check.c    up to 1.4
external/bsd/pkg_install/dist/admin/main.c      up to 1.6
external/bsd/pkg_install/dist/admin/pkg_admin.1 up to 1.6
external/bsd/pkg_install/dist/create/perform.c  up to 1.3
external/bsd/pkg_install/dist/create/pl.c      up to 1.4
external/bsd/pkg_install/dist/info/perform.c    up to 1.3
external/bsd/pkg_install/dist/lib/iterate.c    up to 1.3
external/bsd/pkg_install/dist/lib/lib.h        up to 1.10
external/bsd/pkg_install/dist/lib/license.c    up to 1.10
external/bsd/pkg_install/dist/lib/pkgdb.c      up to 1.4
external/bsd/pkg_install/dist/lib/plist.c      up to 1.4
external/bsd/pkg_install/dist/lib/version.h    up to 1.17
external/bsd/pkg_install/dist/lib/vulnerabilities-file.c up to 1.4
external/bsd/pkg_install/lib/Makefile          up to 1.11
external/bsd/pkg_install/lib/config.h          up to 1.3

Import pkg_info 20201205, move the default pkg database from /var/db/pkg
to ${PREFIX/pkgdb.

(martin)

Ticket #1140

(martin)

Sync external/bsd/pkg_install with -current, requested by wiz in ticket #1140:

external/bsd/pkg_install/Makefile.inc          up to 1.7
external/bsd/pkg_install/dist/add/perform.c    up to 1.7
external/bsd/pkg_install/dist/admin/check.c    up to 1.4
external/bsd/pkg_install/dist/admin/main.c      up to 1.6
external/bsd/pkg_install/dist/admin/pkg_admin.1 up to 1.6
external/bsd/pkg_install/dist/create/perform.c  up to 1.3
external/bsd/pkg_install/dist/create/pl.c      up to 1.4
external/bsd/pkg_install/dist/info/perform.c    up to 1.3
external/bsd/pkg_install/dist/lib/iterate.c    up to 1.3
external/bsd/pkg_install/dist/lib/lib.h        up to 1.10
external/bsd/pkg_install/dist/lib/license.c    up to 1.10
external/bsd/pkg_install/dist/lib/pkgdb.c      up to 1.4
external/bsd/pkg_install/dist/lib/plist.c      up to 1.4
external/bsd/pkg_install/dist/lib/version.h    up to 1.17
external/bsd/pkg_install/dist/lib/vulnerabilities-file.c up to 1.4
external/bsd/pkg_install/lib/Makefile          up to 1.11
external/bsd/pkg_install/lib/config.h          up to 1.3

Import pkg_info 20201205, move the default pkg database from /var/db/pkg
to ${PREFIX/pkgdb.

(martin)

the busypage test is buggy, expect it to fail.

(chs)

include gdbarch.h

(christos)

add dummy ddxInputThreadInit() if INPUTTHREAD is defined.
fixes sun3 build and should fix x68k build too.

(mrg)

Change the default interrupt-affinity of iavf(4)

(yamaguchi)

A couple of tweaks to the previous re-factor:

- Some of what was defined as "generic itimer" behavior turned out to be
  ptimer-specific.  As such, everything related to the "fired timer queue"
  is now specific to ptimers, and the queue and softint handle fields of
  itimer_ops are not needed.

- Split itimer_fini() into 2 parts: itimer_poision() marks the timer as
  dead and attempts to cancel it.  itimer_fini() is then just responsible
  for freeing itimer resources and releasing the lock.  They are split
  into two parts, as ptimers require an addition processing step between
  those two operations, but other kinds of itimers do not necessarily require
  that.

- Export a few more itimer-related symbols that other itimer types will
  need.

Riding previous kernel version bump since there are no external uses of
this code since the version bump that accompanied the original change.

(thorpej)

make(1): split JobPrintSpecials into manageable pieces

(rillig)

make(1): extract JobPrintSpecials from JobPrintCommand

(rillig)

make(1): extract InitShellNameAndPath from Shell_Init

This gets rid of the ugly "else #endif".

(rillig)

make(1): clean up debug logging

(rillig)

make(1): replace signal handling macros with local functions

(rillig)

make(1): indent job.c with tabs instead of spaces

(rillig)

make(1): remove duplicate code for job output

(rillig)

make(1): replace macro MESSAGE with local function

The first parameter of the macro was always stdout, and there was no
apparent reason to pass anything else there.

Let the compiler decide whether to inline this or not, it's not
time-critical.

(rillig)

make(1): remove duplicate code from bmake_strdup

Inlining is the job of the compiler, not of humans.

(rillig)

make(1): normalize output of test sh-dots for non-native mode

(rillig)

make(1): add tests and tutorial for the ?= assignment operator

(rillig)

make function static (fixes crossgdb build, reported by martin@)

(christos)

Tickets #1628 - #1634

(martin)

Tickets #1142 - #1145

(martin)

Apply patch, requested by maya in ticket #1634:

        external/mit/libX11/dist/modules/im/ximcp/imRmAttr.c    (patch)

PR 55640: fix off by one in X Input Method.

(martin)

Apply patch, requested by maya in ticket #1145:

external/mit/libX11/dist/modules/im/ximcp/imRmAttr.c (patch)

PR 55640: fix off by one in X Input Method.

(martin)

Pull up following revision(s) (requested by kardel in ticket #1633):

sys/dev/ic/nvme.c: revision 1.53

PR kern/55839:

handle multiple nvme_rescan()s correctly by doing the
name-space identify only once per nsid.
fixes issue where modloading triggers multiple
rescans.

(martin)

Pull up following revision(s) (requested by kardel in ticket #1144):

sys/dev/ic/nvme.c: revision 1.53

PR kern/55839:

handle multiple nvme_rescan()s correctly by doing the
name-space identify only once per nsid.
fixes issue where modloading triggers multiple
rescans.

(martin)

Pull up following revision(s) (requested by kardel in ticket #1632):

sys/netinet/ip_mroute.c: revision 1.164 (patch)

PR kern/55779:

restore non-desctructive guarantee of ip_mforward() mbuf
argument. This avoids generation invalid UDP checksums
on multicast packets in ip_output().

XXX the root cause of the misguided fix in 2008 should be
XXX investigated

(martin)

Pull up following revision(s) (requested by kardel in ticket #1143):

sys/netinet/ip_mroute.c: revision 1.164

PR kern/55779:

restore non-desctructive guarantee of ip_mforward() mbuf
argument. This avoids generation invalid UDP checksums
on multicast packets in ip_output().

XXX the root cause of the misguided fix in 2008 should be
XXX investigated

(martin)

Pull up the following, requested by kre in ticket #1631:

external/public-domain/tz/dist/systemv          delete
external/public-domain/tz/dist/pacificnew      delete
external/public-domain/tz/dist/yearistype.sh    delete
external/public-domain/tz/dist/Makefile        up to 1.1.1.29
external/public-domain/tz/dist/NEWS            up to 1.1.1.32
external/public-domain/tz/dist/README          up to 1.1.1.9
external/public-domain/tz/dist/TZDATA_VERSION  up to 1.22
external/public-domain/tz/dist/africa          up to 1.1.1.23
external/public-domain/tz/dist/antarctica      up to 1.1.1.13
external/public-domain/tz/dist/asia            up to 1.1.1.27
external/public-domain/tz/dist/australasia      up to 1.1.1.20
external/public-domain/tz/dist/backward        up to 1.1.1.11
external/public-domain/tz/dist/backzone        up to 1.1.1.19
external/public-domain/tz/dist/checktab.awk    up to 1.1.1.10
external/public-domain/tz/dist/etcetera        up to 1.1.1.4
external/public-domain/tz/dist/europe          up to 1.1.1.29
external/public-domain/tz/dist/factory          up to 1.1.1.4
external/public-domain/tz/dist/iso3166.tab      up to 1.1.1.6
external/public-domain/tz/dist/leap-seconds.list up to 1.1.1.14
external/public-domain/tz/dist/leapseconds      up to 1.1.1.16
external/public-domain/tz/dist/leapseconds.awk  up to 1.1.1.11
external/public-domain/tz/dist/northamerica    up to 1.1.1.26
external/public-domain/tz/dist/southamerica    up to 1.1.1.17
external/public-domain/tz/dist/theory.html      up to 1.1.1.11
external/public-domain/tz/dist/version          up to 1.1.1.19
external/public-domain/tz/dist/ziguard.awk      up to 1.1.1.5
external/public-domain/tz/dist/zishrink.awk    up to 1.1.1.7
external/public-domain/tz/dist/zone.tab        up to 1.1.1.18
external/public-domain/tz/dist/zone1970.tab    up to 1.1.1.20
external/public-domain/tz/dist/zoneinfo2tdf.pl  up to 1.1.1.4
distrib/sets/lists/base/mi (apply patch)
doc/3RDPARTY (apply patch)
external/public-domain/tz/share/zoneinfo/Makefile (apply patch)

Update tzdate from 2018i to 2020d

(martin)

Pull up following revision(s) (requested by kre in ticket #1629):

bin/sh/exec.c: revision 1.54

PR bin/55526

Fix a bug that has existed since the "command" command was added in
2003.  "command foo" would cause the definition of a function "foo"
to be lost (not freed, simply discarded) if "foo" is (in addition to
being a function) a filesystem command.  The case where "foo" is
a builtin was handled.

For now, when a function exists with the same name as a filesystem
command, the latter can never appear in the command hash table, and
when used (which can only be via "command foo", just "foo" finds
the function) will always result in a full PATH search.

XXX pullup everything (from NetBSD 2.0 onwards).  (really -8 and -9)

(martin)

Pull up following revision(s) (requested by kre in ticket #1630):

sbin/dump/dump.h: revision 1.59
sbin/dump/main.c: revision 1.78

PR bin/55834

count blocks written in unsigned 64 bit counter
rather than signed int which overflows after 2^31-1
blocks (2TiB) after which neither the 5 minute
status updates or SIGINFO (^T) reports are issued
until the negative numbers increase past 0 and
wildly inaccurate reports would be written.

(martin)

Pull up following revision(s) (requested by mrg in ticket #1628):

external/mit/xorg-server.old/dist/xkb/xkb.c: revision 1.2

merge security fixes for xkb, as found in these xserver gitlab
commits:

270e439739e023463e7e0719a4eede69d45f7a3f - xkb: only swap once in XkbSetMap
446ff2d3177087b8173fa779fa5b77a2a128988b - Check SetMap request length carefully
87c64fc5b0db9f62f4e361444f4b60501ebf67b9 - Fix XkbSetDeviceInfo() and SetDeviceIndicators() heap overflows
de940e06f8733d87bbb857aef85d830053442cfe - xkb: fix key type index check in _XkbSetMapChecks
f7cd1276bbd4fe3a9700096dec33b52b8440788d - Correct bounds checking in XkbSetNames()

i haven't tested these run OK, and it was a 33 out of 34 hunks
did not apply cleanly, but they merge was still largely the
same (patch failed due to whitespace changes mostly), and i am
able to build-test successfully.

(martin)

Pull up following revision(s) (requested by mrg in ticket #1142):

external/mit/xorg-server.old/dist/xkb/xkb.c: revision 1.2

merge security fixes for xkb, as found in these xserver gitlab
commits:

270e439739e023463e7e0719a4eede69d45f7a3f - xkb: only swap once in XkbSetMap
446ff2d3177087b8173fa779fa5b77a2a128988b - Check SetMap request length carefully
87c64fc5b0db9f62f4e361444f4b60501ebf67b9 - Fix XkbSetDeviceInfo() and SetDeviceIndicators() heap overflows
de940e06f8733d87bbb857aef85d830053442cfe - xkb: fix key type index check in _XkbSetMapChecks
f7cd1276bbd4fe3a9700096dec33b52b8440788d - Correct bounds checking in XkbSetNames()

i haven't tested these run OK, and it was a 33 out of 34 hunks
did not apply cleanly, but they merge was still largely the
same (patch failed due to whitespace changes mostly), and i am
able to build-test successfully.

(martin)

Add some debugging output to check sensor addition and refresh.

(jdc)

acpicpu(4): Add support for Arm CPUs.

(jmcneill)

acpicpu: Add support for ACPI P-states and T-states on Arm.

(jmcneill)

ACPI Processor UID is 32-bits (ci_acpiid).

(jmcneill)

micron SMART 202 is percent lifetime used not remaining.

almost gave myself a heart attack when my server said 7% remaining!

(mrg)

Fix 32-bit build.

(jmcneill)

mknative for aarch64eb.

(rin)

Add elf32-aarch64.c to DPSRCS and CLEANFILES.

(rin)

make(1): add new unit test opt-keep-going-multiple.mk to file lists

(rillig)

fix the build; gcc does not always see that it can't happen.

(christos)

make(1): rename Var_Export1 to ExportVar

Since Var_Export1 is neither exported by the module nor does it belong
to the Var type, the previous function name was misleading.  The 1 in
the function name was not as expressive as possible.  The new name
aligns nicely with UnexportVar, which is a very young name as well.

(rillig)

make(1): fix wrong exit status for multiple failed main targets

(rillig)

make(1): add test for wrong exit status 0 after failed targets with -k

(rillig)

make(1): actually fix the use-after-free bug and the double-free

The use-after-free bug had been there since 2020-11-22, the double-free
bug since a few minutes.

(rillig)

make(1): fix use-after-free in -DDEBUG_SRC mode (since 2020-11-22)

(rillig)

make(1): merge local variables in Compat_Run

(rillig)

make(1): clean up Compat_Run

Now that errors in the main targets and in their dependencies have the
same effect on the .END node and its dependencies, the two variables can
be merged.

(rillig)

make(1): don't make .END if the main targets already failed

This only applies to -k mode.  By default, make exits earlier and skips
the .END node as well if an error occurs.

(rillig)

make(1): fix exit status in -k mode if a dependency fails

Whether in -k mode or not, the exit status tells whether all requested
targets were made or not.  If a dependency could not be made, the main
target was not made as well, therefore the exit status must be nonzero
in such a case.

This part of the code lacked proper unit tests until today.  The unit
test deptgt-end-fail.mk is compatible with make>=2003 at least, allowing
to compare the output over time.

In 2003, in the ok-ok-ok-ok case, "Making all from all-dep." was printed
twice in a row, for whatever reason  ... (40 minutes later) ... If I had
just made the two commands for 'all' and '.END' more distinguishable.
Back in 2003, the local variables for .END had not been initialized,
instead the .END node was run with the local variables of the last
preceding node.  In this case, that node was 'all', therefore ${.TARGET}
had obviously expanded to 'all'.

Somewhere in 2004, the shell commands were no longer run with the -e
flag, which resulted in the "exit status $?" line to be printed in cases
that had stopped early before.

Somewhere in 2005, the local variables for the .END node had been fixed.
The variable ${.TARGET} now had the value '.END', just as expected.  In
addition, the dependencies for the .END node were made, although without
getting their proper local variables.  This resulted in the output
"Making  out of nothing" instead of the expected "Making end-dep out of
nothing".

Still in 2005, in the test case "all=ok all-dep=ok end=ok end-dep=ERR",
the error code of the failed 'end-dep' was first reported as "*** Error
code 1 (continuing)".  To compensate for this improvement, a new bug had
been introduced.  The test case "all=ok all-dep=ok end=ERR end-dep=ERR"
had properly exited with status 1 on 2005-01-01, but on 2006-01-01 it
exited with status 0, thereby ignoring errors in the .END node.

Somewhere in 2008, some of the error messages (but not all) were
directed to stderr instead of stdout.  The actual output stayed the same
though.

Somewhere in 2011, the dependency of the .END node got its own local
variables, and ${.TARGET} now expanded to 'end-dep', as expected.

Somewhere in 2016, the two empty lines between the "*** Error code 1
(continuing)" and the "Stop." got compressed into a single empty line.

On 2020-12-07 (that is, today), the exit status 1 has been restored in
the error cases, after it had been wrong for at least 14 years.

(rillig)

make(1): refactor Compat_Run to show the error condition more clearly

This refactoring allows to gradually change the conditions for the
"Stop." error message, to demonstrate which cases are affected by each
tiny change.

(rillig)

make(1): refactor error handling in Compat_Run

This is in preparation for the upcoming bug fixes.

(rillig)

make(1): test all combinations of failed main and .END targets

Adding an individual test for each of the 16 combinations would have
been too much manual work, and it's not easy to come up with a good
naming scheme for all the tests, keeping them short and expressive at
the same time.

(rillig)

make(1): add test for .END after failed main node

(rillig)

make(1): document undefined behavior from 2014

Earlier versions of make didn't know the -v option to print the expanded
value of a variable.  To make the test runnable by older makes as well,
switch to -V instead, which has been available much longer.

(rillig)

make(1): error out on null bytes in makefiles

Makefiles are text files, they must not contain null bytes.

The previous code in this area was rotten anyway.  It assumed that
buf_end could be NULL even if buf_ptr was a valid pointer, which is no
longer true, probably since a few years already.

Continuing parsing after a null byte does not make sense.  If there's a
null byte in a text file, that file is corrupted, and parsing it leads
to unintended effects easily.  Therefore the only sensible action is to
stop parsing immediately.

The check whether cf->readMore could be null was outdated as well, which
previously made the fatal error impossible to reach.  Because of the
missing unit tests, nobody noticed this though.

The "exit status 0" in opt-file.exp is worring but that's due to another
bug and will be fixed in a follow-up commit.

(rillig)

make(1): rename IFile.nextbuf to readMore

The previous name sounded too much like a noun, which was too confusing.
See unit-tests/opt-file.mk for the history of this part of the code.

(rillig)

make(1): document how make behaved for null bytes in the makefile

(rillig)

make(1): add test for makefile containing null bytes

(rillig)

make(1): test parsing a makefile that ends in a backslash

(rillig)

acpidump: Do not print FACS if HW_REDUCED flag is set.

According to ACPI 6.3 spec, FACS is optional when HW_REDUCED is set. ACPICA
ignores the FACS completely when HW_REDUCED is set, so we need to follow
suit since it is not available through /dev/acpi as the table is not
installed.

(jmcneill)