make(1): move prototype of SuffFindDeps further down

Just to limit its scope.

(rillig)

make(1): move SuffExpandWildcards further up

This avoids an unnecessary forward declaration.

(rillig)

make(1): document Suffix and Src

(rillig)

Adjust egister usage so that r4 and r5 are preserved as cur{cpu,lwp}
respectively as required by the change to make ASTs operate per-LWP
rather than per-CPU.  DO_AST_AND_RESTORE_ALIGNMENT_FAULTS expects this.

Remove the call to dosoftints while I'm here as it's dont in DO_AST...

XXX untested

(skrll)

Adjust egister usage so that r4 and r5 are preserved as cur{cpu,lwp}
respectively as required by the change to make ASTs operate per-LWP
rather than per-CPU.  DO_AST_AND_RESTORE_ALIGNMENT_FAULTS expects this.

Remove the call to dosoftints while I'm here as it's dont in DO_AST...

XXX untested

(skrll)

Adjust egister usage so that r4 and r5 are preserved as cur{cpu,lwp}
respectively as required by the change to make ASTs operate per-LWP
rather than per-CPU.  DO_AST_AND_RESTORE_ALIGNMENT_FAULTS expects this.

Remove the call to dosoftints while I'm here as it's dont in DO_AST...

XXX untested

(skrll)

Adjust egister usage so that r4 and r5 are preserved as cur{cpu,lwp}
respectively as required by the change to make ASTs operate per-LWP
rather than per-CPU.  DO_AST_AND_RESTORE_ALIGNMENT_FAULTS expects this.

XXX untested

(skrll)

Adjust code and register usage so that r4 and r5 are preserved as
cur{cpu,lwp} respectively as required by the change to make ASTs
operate per-LWP rather than per-CPU.  These registers are used by
DO_AST_AND_RESTORE_ALIGNMENT_FAULTS expecting this usage.

XXX untested

(skrll)

Sprinkle some comments about ENABLE_ALIGNMENT_FAULTS leaving curcpu in r4
and curlwp in r5

(skrll)

Ensure that r5 contains curlwp before DO_AST_AND_RESTORE_ALIGNMENT_FAULTS
in lwp_trampoline as required by the move to make ASTs operate per-LWP
rather than per-CPU.

Thanks to martin@ for bisecting the amap corruption he was seeing and
testing this fix.

(skrll)

make(1): improve comment for Suffix_GetSuffix

(rillig)

make(1): rename Suff functions whose subject is a single suffix

The naming scheme Suffix_Func makes these functions easily
distinguishable from those that merely happen to be in the Suff module
but have nothing to do with suffixes, such as SuffStrIsPrefix.

(rillig)

malloc(9) -> kmem(9)

(thorpej)

make(1): rename type SuffFlags to SuffixFlags

(rillig)

make(1): rename SuffList to SuffixList

(rillig)

make(1): rename type Suff to Suffix

This avoids confusion with the module suff.c of the same name.

The existing naming convention is that the module's public functions are
named Suff_Func and its private functions are named SuffFunc.  This
collides with the naming convention that a the functions of the type Suff
are called Suff_Func as well.

To resolve this collision, rename Suff to Suffix.  The related types like
SuffList and the affected functions like SuffRef will be renamed in a
follow-up commit.

(rillig)

make(1): rename suffNull to nullSuff

This variable is internal to the suff.c module, therefore there is no
need to prefix it with the module name.  The new name follows the naming
convention established by emptySuff.

(rillig)

make(1): rename GNode.context to vars

Especially in the variables module, the expression 'ctxt->context' looked
redundant.  Having a GNode as a context sounds ok, but a context of a
context just doesn't make sense.

(rillig)

make(1): improve name of local variable in SrcList_Add

Now that nothing in suff.c is named 's' anymore, there is no need for
's2' either.

(rillig)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

make(1): rename SuffAddSrc to SrcList_Add

The main character in this function is the list of sources, therefore
make it the subject.

(rillig)

make(1): improve parameter name in SuffUpdateTarget

(rillig)

make(1): document necessary condition in SuffUpdateTarget

(rillig)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

XXX Audit use of KM_NOSLEEP here.

(thorpej)

make(1): limit memory usage in tests

There is a suspicious condition in SuffUpdateTarget code that looks wrong
on the first sight.  When removing it though, make allocates huge amounts
of memory.  To stop freezing the whole machine in this situation, limit
the total memory.

The limit of 200000 has been determined experimentally on NetBSD 8.0
x86_64.  With a limit of 100000, make wouldn't even start.  100 MB of
memory is really a lot for such a simple program that according to top(1)
only needs 8 MB.  But 200 MB is still better than 5 GB.

Since the Makefile is used on other platforms as well, via the bmake
distribution, and since every operating system has its own list of ulimit
options, make this configurable.

(rillig)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

make(1): in SuffExpandChildren, only expand ${VAr} if needed

(rillig)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

make(1): add test for dynamic variable with modifiers in global context

(rillig)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

make(1): clean up freeing of environment variables in Var_Parse

The previous code with the extra boolean variable was a brain-twister
since the responsibility of freeing the memory was distributed over 3
different functions.

(rillig)

malloc(9) -> kmem(9)

(thorpej)

make(1): clean up parameter order in EvalUndefined

(rillig)

malloc(9) -> kmem(9)

(thorpej)

make(1): rename local variable in Var_Subst

(rillig)

make(1): add test for .include with trailing garbage in the line

(rillig)

make(1): clean up reference counting in SuffList_Insert

(rillig)

make(1): move reference counting for suffixes to SrcNew

(rillig)

make(1): clean up reference counting for suffixes

(rillig)

Bump date for previous.

(wiz)

make(1): add explanation for test suff-rebuild

(rillig)

make(1): add more debug logging for suffix handling

One notable thing is that there is no debug output when adding a
transformation rule like ".c.o",  which means that these rules don't end
up in the global allTargets variable.

This may or may not be intentional.  It seems not intentional since this
is one of the causes for the suff-rebuild test to behave unexpectedly.

(rillig)

make(1): enable debug logging for test suff-rebuild

As long as it is not clear why this test fails, it's better to have the
debug log available, both for reading it and for getting notified if
any behavior in this area changes.

(rillig)

Add a per-CPU event counter that counts every time an interrupt handler is
preempted by a higher priority interrupt.

(jmcneill)

boot.cfg.5: Note that userconf can be used multiple times

Additionally:
- Make it easier for the reader to learn which keywords can be used
  multiple times
- Use multiple "userconf" lines in the EXAMPLES section, conveniently
  listing the current DRM drivers that a user might need to disable to
  troubleshoot "blank screen after boot" issues.

(kim)

Fix previous and tag the right callout...

(mlelstv)

Run callout without kernel lock, the softint itself is still protected.

(mlelstv)

make(1): improve comment style in GNode_Free

It was unclear what the ellipsis referred to.  It was meant to refer to
the function call Lst_Free, but that was not necessarily obvious to a
casual reader.

(rillig)

make(1): fix indentation in Make_HandleUse

(rillig)

make(1): fix comment for allTargets

Source nodes are also included in this list.  What's not includes is
nodes that are _only_ source nodes.

(rillig)

make(1): add more debug logging for suffixes

The "Removing suffix" is not covered by the current tests.  It would be
best if that code were unreachable at all, since a reference count of -1
doesn't make sense.

(rillig)

make(1): add test for incomplete transformation rule

(rillig)

make(1): add debug logging when adding a suffix to the global list

(rillig)

make(1): rename local variable s to suff

The name s was ambiguous.  It could have meant suffix, src, str, and
probably more.

(rillig)

Trailing whitespace

(skrll)

roundsleep(): Too many zeros; tv_nsec should be compared with
500 msec, not 5000. Raised by clang for ILP32 archs.

(rin)

make(1): make debug logging more precise in Suff_EndTransform

(rillig)

make(1): flatten Suff_EndTransform

This avoids the duplicate code for testing OP_TRANSFORM.

(rillig)

make(1): make output of test suff-rebuild more verbose

(rillig)

make(1): rename SuffScanTargets to SuffUpdateTarget

The word "scan" no longer applies to this function since that is done by
SuffUpdateTargets instead.

(rillig)

Restore missing message for RB_ASKNAME.
Cleanups.

(mlelstv)

Fix build with clang for earmv7hf; loadroundkey() is used only for __aarch64__.

(rin)

make(1): clean up parameter names for SuffScanTargets

The prefix "gs" came from a time when SuffScanTargets was called via
Lst_ForEach, passing it a struct GNodeSuff.  The "gs" had just been the
abbreviation for "GNode + Suff", which was already non-expressive.  On
top of that, the struct had a third field "r", also with an unclear name,
which was not even mentioned in the name of the struct.

For now, just remove the needless prefix since it has absolutely no
meaning anymore.  Maybe it will become clear what the "r" was supposed to
mean, it could be some kind of "result".

(rillig)

valuator_mask_zero() is enough for mouse button events.

(tsutsui)

malloc(9) -> kmem(9)

(thorpej)

make(1): make string iterator in ParseDependencyTargetWord const

(rillig)

valuator_mask_zero() is enough for mouse button events.

(tsutsui)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

Sync with xorg-server:

Report which settings are chosen per a config file in the log file.

(tsutsui)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

Note import of dhcpcd-9.3.3

(roy)

Sync with dhcpcd-9.3.3

(roy)

When validating the mount device string make sure its length
is below *data_len and below PATH_MAX.

Reported-by: syzbot+2d3af801141509cc858c@syzkaller.appspotmail.com

(hannken)

Regen.

(msaitoh)

Add newer Intel PCH internal devices.

(msaitoh)

make(1): fix local variable name in ParseDoDependencyTargets

(rillig)

make(1): run tests with different shells as well, reduce output

(rillig)

make(1): fix test opt-debug-jobs for native shell

Even after substituting the actual shell name with <shell>, the trailing
optional -q option needs to be normalized.

(rillig)

Regenated from pcidevs

(reinoud)

Add modern QUMRANET/Red Hat VIRTIO range PCI devices

(reinoud)

make(1): fix test opt-debug-jobs when compiled with dash as shell

make USER_CPPFLAGS=-DDEFSHELL_CUSTOM='\"/usr/pkg/bin/dash\"'

(rillig)

make(1): remove redundant postprocessing for test var-op-shell

The regular expression from the previous line already matches everything
that the removed line could ever match.

(rillig)

make(1): remove postprocessing for test directive-export-gmake

Since revision 1.3, directive-export-gmake.mk takes care of handling this
case.  Removing the "error" lines from the output of the tests only makes
the test harder to understand and may also hide future bugs.

(rillig)

make(1): mark srclist as a bad global variable

The previous comment "List of sources" didn't tell anything about the
purpose of the variable, it was only useful before July 2020, when its
data type was still Lst, without any type information.

Having a global variable here seems pointless, but all the code about
suffix transformations is so tricky and not well covered by tests that I
don't dare to convert the global variable to a local variable in
Suff_FindDeps.  The change itself would be trivial, but the hidden and
undocumented intentions of the original author probably aren't.

(rillig)

Update 'elfdefinitions.h' to elftoolchain revision [r3891].

(jkoshy)

make(1): compare pointers against NULL instead of implicit conversion

(rillig)

make(1): fix compilation error in -DDEBUG_SRC mode

(rillig)

Ticket #1624

(martin)

Pull up following revision(s) (requested by hannken in ticket #1624):

libexec/httpd/bozohttpd.c: revision 1.124

Bozohttpd clobbers files greater than 4GB on 32bit archs.
Make sure the alignment mask derived from pagesize is an off_t.

(martin)

Ticket #1134

(martin)

Pull up following revision(s) (requested by hannken in ticket #1134):

libexec/httpd/bozohttpd.c: revision 1.124

Bozohttpd clobbers files greater than 4GB on 32bit archs.
Make sure the alignment mask derived from pagesize is an off_t.

(martin)

We have to ignore interrupts when suspending here the same way
we have to do with revoke.

Reported-by: syzbot+0cfb253b382a9836450a@syzkaller.appspotmail.com

(hannken)

Bozohttpd clobbers files greater than 4GB on 32bit archs.

Make sure the alignment mask derived from pagesize is an off_t.

(hannken)

Add some sysctl values for debugging TX/RX queues.

(msaitoh)

Add comment.

(msaitoh)

Sync 'utarray.h' and 'uthash.h' with elftoolchain revision [r3891].

This change upgrades these files to UT{HASH,ARRAY}_VERSION 2.1.0.

(jkoshy)

Sort options.

Prompted by pgoyette.

(wiz)

Preserve Xen SIR slots for VM_GUEST_XENPVH.

(bouyer)

Make this at least compile.
Looks like a missing part from "Round of uvm.h cleanup (2020-09-05 18:30)".

(hannken)

Don't complain about additional DNAME records received when resolving A or
AAAA (like already done for SIG/KEY and CNAME).

(is)

Trailing whitespace

(skrll)

Adjust blank line & white space to slightly reduce diff from upstream.
No binary changes.

(rin)

Cleanup - colliding fixes for same issue

(sjg)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

Some tests need help with dash

(sjg)

Always use -r -f /dev/null when not  intending to read a makefile

(sjg)

Remove heuristic for dealing with trailing newlines being truncated by mailers.

Patch and explanation taken from bsdimp:
https://bsdimp.blogspot.com/2020/08/a-35-year-old-bug-in-patch-found-in.html
https://svnweb.freebsd.org/base?view=revision&revision=364291

Every version of patch since the first one posted to mod.sources in 1985 have
included a heuristic for coping with the state of email messaging at the
time. This heuristic would add up to 4 blank lines to a patch if it thought it
needed it. The trouble is, though this causes at least one bug.

The bug in my case is that if you have a context diff whose last hunk only
deletes 3 or fewer lines, then if you try to reverse apply it with -R, it will
fail. The reason for this is the heuristic builds an internal representation
that includes those blank lines. However, it should really replicate the lines
from the pattern lines line it would any other time, not assume they are blank
lines. Removing this heuristic will prevent patch from misapplying the lines
removed after applying a 'fuzz' factor to the previous blank line in the file. I
believe this will only affect 'new-style' 4.3BSD context diffs and not the
older-style 4.2BSD diffs and plain, non-context diffs. It won't affect any of
the newer formats, since they don't use the 'omitted' construct in the same way.

Since this heuristic was put into patch at a time when email / etc ate trailing
white space on a regular basis, and since it's clear that this heuristic is the
wrong thing to do at least some of the time, it's better to remove it
entirely. It's not been needed for maybe 20 years since patch files are not
usually corrupted. If there are a small number of patch files that would benefit
from this corruption fixing, those already-currupt patches can be fixed by the
addition of blank lines. I'd wager that no one will ever come to me with an
example of a once-working patch file that breaks with this change. However, I
have 2 patches from the first 195 patches to 2.11BSD that are affected by this
bug, suggesting that the relative frequency of the issue has changed
signficantly since the original heuristic was put into place.

(rhialto)

make(1): make test vardebug independent from the shell

(rillig)

make(1): fix test output of var-op-shell for dash

Dash is helpful and outputs the line number in case of an error.  The
other shells don't do this.  Accept both variants.

(rillig)

make(1): fix test directive-export-gmake for dash

Dash only accepts environment variables whose names follow the usual
naming conventions.  (I didn't look up the exact details.)  In
particular, it rejects environment variables whose names start or end
with spaces.

This would result in an empty output from grep, in which case the exit
status from the shell command is non-zero, thus make prints an error
about this.  This error message should not appear in the test output, to
keep the test output the same for all platforms.

(rillig)

make(1): fix error message of failed :!cmd! modifier (since 2000-04-29)

(rillig)

make(1): document 20-year-old bug in the :!cmd! modifier

(rillig)

Add "AOT" Ahead Of Time

(maya)

don't expose 'compatible[]'

(ryo)

use aprint_verbose_dev()

(ryo)

Set USE_XZ_SETS to yes by default for aarch64eb in the same manner as aarch64.

(rin)

Support aarch64eb; just works fine.

(rin)

Support aarch64eb in */config.guess.

Cherry-picked from upstream:
https://git.savannah.gnu.org/gitweb/?p=config.git;a=commit;h=1c4398015583eb77bc043234f5734be055e64bea

Everything except external/apache2/llvm/dist/llvm/cmake/config.guess
is patched, which is under vendor tag and cannot be modified. I expect
that this file is not actually used as we use hand-crafted version of
configure script instead of cmake for building LLVM.

Note that external/apache2/llvm/autoconf/autoconf/config.guess has
already been committed on Oct. 20, but commit message disappeared as
cvs aborted due to "permission denied" when trying to modify the file
mentioned above. Sorry for confusing you.

Also note that GMP uses its own config.guess Patch for
external/lgpl3/gmp/dist/config.guess is provided by ryo@. Thanks!

(rin)

Mark t_tsan_*:*profile test cases as expected failures as discussed in
PR toolchain/55760.

(gson)

Add new spin mutex to avoid race between ixgbe_msix_admin() and ixgbe_handle_admin().

At first, it seems "IXGBE_WRITE_REG(hw, IXGBE_EIMC, IXGBE_EIMC_OTHER)"
cannot stop interrupts, because 31th bit is reserved for 82598, 82599,
X540 and X550.  So, the current following design
    (1) ixgbe_msix_admin() disables interrupts
    (2) ixgbe_msix_admin() calls workqueue_enqueue() for ixgbe_handle_admin()
    (3) ixgbe_handle_admin() does interrupt processing
    (4) after ixgbe_handle_admin() has done all interrupt processings,
        ixgbe_handle_admin() enables interrupts
does not work correctly, that is, interrupts can be lost while
ixgbe_handle_admin() is running.

To fix that, add new spin mutex(adapter->admmin_mtx) which protects
atomically the following two members.
    - adapter->admin_pending
    - adapter->task_requests

The unnecessary "IXGBE_WRITE_REG(hw, IXGBE_EIMC, IXGBE_EIMC_OTHER)"
code will be removed later.

Reviewed and tested by hikaru@n.o and msaitoh@n.o, thanks.

(knakahara)

When SS_RESTARTSYS was added, it was accidentally given the same value as
the existing SS_ASYNC.  SS_ASYNC was already vestigial at that point,
having been superceded by SB_ASYNC, however the SS_ASYNC flag is still
set and cleared, unlessly because it is never checked.
Fix this conflict by removing SS_ASYNC and its vestigial uses.

(chs)

Remove a pointless printf.

(chs)

make(1): rename local functions in suffix handling

Name these functions after their main object, which is the suffix list.

(rillig)

make(1): merge duplicate calls to SuffInsert

(rillig)

make(1): clean up code style in make.c and suff.c

(rillig)

make(1): clean up code style in targ.c

(rillig)

make(1): initialize and free GNode fields in declaration order

Initialization and destruction of the fields is independent from the
other fields.  Therefore use declaration order, which allows to quickly
see whether a field was forgotten.

While here, add comments that in cleanup mode, not all memory is freed.
The variables of a node and the suffix survive right now.

(rillig)

make(1): fix initialization order of modules (broken since today)

In CLEANUP mode, Var_Init depends on Targ_Init since the variable scopes
are implemented as GNodes.

By the way, since 1999-09-15 variables are no longer stored in lists but
in hash tables.

(rillig)

make(1): rename variables in targ.c

The previous names didn't make it obvious that 'allTargets' and 'targets'
belong together.  Naming both 'allTargets' provides a stronger hint.

(rillig)

make(1): clean up and extend comments in targ.c

(rillig)

make(1): make some GNode functions const

(rillig)

make(1): in CLEANUP mode, preallocate list of all GNodes

This makes the code simpler and more uniform.

(rillig)

make(1): rename TargFreeGN to GNode_Free

This is the usual counterpart to a New function, like for Lst, HashTable,
Buffer.

(rillig)

make(1): rename Targ_NewGN to GNode_New

This function is a classical constructor function, and if it weren't for
CLEANUP mode, it would have no dependencies on anything else besides the
memory allocator.  Therefore it doesn't really matter which module
defines this function, and there is no need for the "Targ" to be part of
the function name.

(rillig)