stdio(3): fix typos in the manual page

fputc cannot read characters, it can only write them.

(rillig)

Make sure init_prom_interface() only runs once, otherwise we initialize
a mutex twice, and that upsets LOCKDEBUG.  But instead of seeing a
proper message about it, the output happens before the PROM console
interfcace is initialized, we would end up with a translation fault
back into SRM.

(thorpej)

make(1): add test for the special .IGNORE dependency source

(rillig)

PR/55599: Valery Ushakov: libpcap gets SIGBUS on strictly aligned CPUs
Define LBL_ALIGN as suggested

(christos)

make(1): fix assertion failure for .SUFFIXES in archives

This occurred in the posix1.mk test, even though it is disabled in
unit-tests.  But in tests/usr.bin/make it still runs.  There, it should
have produced an "expected failure" but crashed instead.

The archive-suffix test is the stripped-down version of the posix1 test.

(rillig)

make(1): trust that Var_Parse never returns NULL

That function is quite long, but all its return paths lead either to the
expanded variable expression, or to var_Error or varNoError.

(rillig)

Fix a bunch of typos in various man pages.

(fcambus)

make(1): trust that Var_Subst never returns NULL

It really never does, and it doesn't even report errors.  It just
returns the content of the buffer, up to the first parse error.

(rillig)

make(1): make getBoolean simpler

This function is so seldom used that there is no point having
complicated code for it.

(rillig)

make(1): add comments for ModifyWord_Subst

Without any comments, the code is unnecessarily hard to follow.

(rillig)

make(1): clean up comments in dir.c

(rillig)

make(1): clean up documentation for CompatInterrupt and Compat_Run

(rillig)

make(1): split ApplyModifier_To into paragraphs

(rillig)

make(1): remove ReturnStatus, SUCCESS and FAILURE

These are used in so few places now that it is easier to use a simple
Boolean for them.

(rillig)

make(1): clean up comments in suff.c, small refactorings

In SuffParseTransform, the parameter names have been renamed to make the
"side effects" comment redundant.

In Suff_AddSuffix and Suff_AddLib, the parameter has been made const.

In SuffRemoveSrc, the unused variable has been removed, and the return
type has been fixed.

(rillig)

make(1): add bmake_strsedup for duplicating a substring

(rillig)

make(1): merge duplicate code for bmake_strldup

(rillig)

make(1): fix test opt-debug-g1

Including the directory cache made the test output fragile.

(rillig)

make(1): rename LstNode functions to match their type

(rillig)

make(1): clean up indentation, comments and variable scope in job.c

(rillig)

make(1): remove duplicate code for allocation a substring

(rillig)

make(1): rename Lst_FindB back to Lst_Find

The migration from "comparison function" to "match function" is done,
the "B" in the names is no longer needed.

(rillig)

make(1): migrate remaining Lst_Find to Lst_FindB

While here, rename SuffSuffIsSuffix to SuffSuffGetSuffix since a
function named "is" should return a boolean, not a string pointer.

(rillig)

make(1): start replacing Lst_Find with Lst_FindB

Lst_Find is called with a "comparison" function that returns the integer
0 if the desired node is found.  This leads to confusion since there are
so many different return value conventions for int, such as 0/1 for
mimicking false/true, -1/0 as in close(2), and the sign as in strcmp(3).
This API is much easier to understand if the "comparison" function is
not called a comparison function (since that is too close to strcmp),
but a "match" function that just returns a boolean.

In Lst_FindFromB, the node argument may be null.  This deviates from the
other Lst functions, which require Lst and LstNode to generally be
non-null.  In this case it is useful though to make the calling code
simpler.

In arch.c, this makes a lot of the previous documentation redundant.

In cond.c, the documentation is reduced a little bit since it had
already been cleaned up before.  It also removes the strange negation
from CondFindStrMatch.

In dir.c, the documentation collapses as well.

In main.c, separating the ReadMakefile function from the callbacks for
Lst_FindB allows the former to get back its natural function signature,
with proper types and no unused parameters.

To catch any accidental mistakes during the migration from Lst_Find to
Lst_FindB, the code can be compiled with -DUSE_DOUBLE_BOOLEAN, which
will complain about incompatible function pointer types.

(rillig)

make(1): fix null pointer dereference when sys.mk is not found

This is quite hard to trigger in a real-life scenario since it requires
precise timing.

Instead, I created /tmp/sys.mk and ran "./make -m /tmp -f /dev/null" in
the debugger, after setting a breakpoint in this line:

ln = Lst_Find(sysMkPath, ReadMakefile, NULL);

Once this line was reached, I removed /tmp/sys.mk to make ReadMakefile
fail.  Just adding a few parse errors won't help since ReadMakefile only
fails if the file cannot be found.

(rillig)

make(1): add another Boolean variant to check during development

(rillig)

make(1): allow for strict type checking for Boolean

Having Boolean aliased to int creates ambiguities since int is widely
used.  Allow to occasionally compile make with -DUSE_DOUBLE_BOOLEAN to
check that the type definitions still agree.

(rillig)

Update the if_wg tests for the human readable 'latest-handshake'
output of wgconfig.

(tih)

Slightly clarify, and style.

(maxv)

'doreti_checkast' isn't global anymore, localify.

(maxv)

Correct my rev1.159, it was incomplete, the check must be done later
because the value can change in the meantime (and get set to zero).

(maxv)

nvmm: explicitly include atomic.h

(maxv)

make(1): clean up code in make.c

Var_Subst never returns NULL.

In Main_ExportMAKEFLAGS, don't compare ints with booleans.

In MainParseArgs, use char for the current character.  First, that's
more precise and correct, and second, it makes debugging easier for
those who don't know the ASCII table by heart.

(rillig)

make(1): rename confusing function ReadAllMakefiles

The old name implied that the function would read multiple files, which
was not the case.

The comment above that function was highly confusing.  It's not that the
function returns a boolean, but rather 0 or non-zero, and 0 means that
Lst_Find should stop searching.

One of the next refactorings will be to make Lst_Find return the first
list node for which the function returns TRUE.  This will reduce the
confusion about the several functions called SomethingP in suff.c.  The
P suffix means to return TRUE or FALSE, not 0 or non-zero.

(rillig)

Cover the full kernel address range in KASAN

(skrll)

merge xorgproto 2020.1.

(mrg)

Skip threxec test pointing at PR 55338, this kills some test beds.

(martin)

Fix white space and indent.

(isaki)

Fix pasto in previous -- pass the right size to memset...

(riastradh)

Allow vdprintf to work on non-blocking non-regular files (Rob Newberry)

(christos)

Nix trailing whitespace.

(riastradh)

Zero out more lock snapshots in sysctl exposure.

(riastradh)

make(1): remove redundant MAKEFLAGS from subdir make

The make flags are passed via the environment, not via the command line.
This is not as obvious and visible, but it works.

(rillig)

make(1): remove unused variable not_parallel

The variable malloc_options seems unused as well, but the manual page
for jemalloc(3) mentions it.

(rillig)

make(1): remove redundant comments from hash.c

(rillig)

make(1): inline LstIsValid and LstNodeIsValid

A simple null pointer comparison is easier to understand than the fuzzy
word "valid".

(rillig)

make(1): fix build errors for USER_CPPFLAGS=-DNDEBUG

The functions LstIsValid and LstNodeIsValid are only used in assertions.

Without the always-false assertion, Enum_ValueToString could have
returned undefined behavior.

(rillig)

Ticket #1599

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1599):

sys/dev/usb/if_atu.c: revision 1.73
sys/dev/usb/if_axe.c: apply patch
sys/dev/usb/if_axen.c: apply patch

atu(4): Reject packets larger than MCLBYTES.

(martin)

Ticket #1067

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1067):

sys/dev/usb/usbnet.c: revision 1.39
sys/dev/usb/if_atu.c: revision 1.73

usbnet: Reject buflen>MCLBYTES in usbnet_newbuf.
atu(4): Reject packets larger than MCLBYTES.

(martin)

Also skip the stress_short test - it just needs way too long to timeout
and fail.

(martin)

lockme_DOUBLEINIT:
The failure message differs slightly when using LOCKDEBUG, modify the
expected pattern to cover both variants.

(martin)

make(1): rename SuffixCmpData to SuffSuffIsSuffixArgs

The new name makes the comment above that struct redundant.

(rillig)

Skip a few tests with reference to already existing PRs as after "recent"
scheduler changes these tests now leave rump_server processes around that
eat CPU and disturb later tests.

(martin)

make(1): clean up targ.c

The main part is removing redundant or outdated information from
comments.  In a few places, the expression cond ? TRUE : FALSE has been
simplified.

(rillig)

atu(4): Reject packets larger than MCLBYTES.

(riastradh)

PR/55612: Martin Husemann: libarchive tests pollute /tmp w/o cleanup
Set $TMPDIR to where we are.

(christos)

PR/55612: Martin Husemann: libarchive tests pollute /tmp w/o cleanup
Make tests obey $TMPDIR.

(christos)

make(1): clean up arch.c

Remove redundant parts of the function comments.  Move the "side
effects" to the main section, since these effects are main effects, not
side effects.

Remove the redundant prototype for ArchFree.

(rillig)

Ticket #1066

(martin)

Pull up following revision(s) (requested by hannken in ticket #1066):

external/cddl/osnet/sys/kern/policy.c: revision 1.9

Glue operation secpolicy_fs_mount() passes wrong arguments to
operation kauth_authorize_system().

KAUTH_SYSTEM_MOUNT / KAUTH_REQ_SYSTEM_MOUNT_NEW wants the to be
covered vnode and the mount flags, not the mount structure.

Fix for PR kern/55602: zpool panic on mounting zfs filesystem

(martin)

make(1): fix test for interrupted command execution

In the first version of this test, I had completely misunderstood the
whole topic.

To test the interrupt, the make process has to be interrupted, not the
shell.  This generates the correct message that the target is removed.

The filename for .PHONY targets is removed even though .PHONY targets
usually don't correspond to a file.  The message is only printed if
there actually is a corresponding file.  That's why this message does
not appear when interrupting "make clean".

Finally, since files get created and removed during a single run of
make, the file cache needs to be disabled.  This is done by prefixing
the filenames with "././", see Dir_FindFile.

(rillig)

make(1): clean up suffix handling

(rillig)

make(1): add tests for :tl and :tu modifiers

(rillig)

Show the time of the latest handshake properly formatted.

(tih)

make(1): fix manual page about the modifiers of the :C modifier

(rillig)

Add RCS Id. Remove Pp before/after Sh. Remove port after section,
since the man page is in man8 directly (the ports are mentioned
in the text).

(wiz)

PR/55605: Soumendra Ganguly: Wait for child to finish when stdin is not a tty

(christos)

usbnet: Reject buflen>MCLBYTES in usbnet_newbuf.

(riastradh)

Don't cache the sa, because we are dealing with multiple mbufs (from ozaki-r)

(christos)

Glue operation secpolicy_fs_mount() passes wrong arguments to
operation kauth_authorize_system().

KAUTH_SYSTEM_MOUNT / KAUTH_REQ_SYSTEM_MOUNT_NEW wants the to be
covered vnode and the mount flags, not the mount structure.

Fix for PR kern/55602: zpool panic on mounting zfs filesystem

(hannken)

Fix a bunch of typos in various device drivers and kernel man pages.

(fcambus)

make(1): add test for interrupting a command

(rillig)

Formatting tweaks.

(uwe)

missing quote

(christos)

Restrict npf.conf fixes to "blacklistd" -> "blocklistd"

(christos)

Nix trailing whitespace.

(riastradh)

make(1): add tests for the &&, || and ! operators

(rillig)

Nix trailing whitespace.

(riastradh)

make(1): add test for unquoted string literals

(rillig)

When running the tests with atf-run the directory we are running in is
drwx------ so when we change to a different user, we can't find the socket
we created.

Make a directory and put the socket in there. Of course now atf can't
record its results as a different user, but that is not fatal.

tc-se:FATAL ERROR: Cannot create results file '/tmp/atf-run.9vOjFd/tcr': \
Permission denied

(christos)

make(1): add test for operator precedence in conditions

(rillig)

Some KASAN fixes and tweaks

- don't access BSS variables when __md_early
- centralise the INIT_ARM_STACK_{SHIFT,SIZE} defines and create a new
  INIT_ARM_TOTAL_STACK
- Only create L1PT entries in kasan_md_shadow_map_page if
  arm32_kernel_vm_init hasn't created the L2PTs (and their L1PT entries)
- Add some comments to explain what's going on

(skrll)

Use C rather than assembly

(skrll)

Fix build if NBCMDMAC is zero

(skrll)

Change to the KVA stack address straight after the MMU is turned on

(skrll)

make(1): extend test for the exists function in conditions

(rillig)

#ifdef -> #if defined

(skrll)

Fix uninitialized, caught by llvm. Tuck variables in blocks where they are
needed.

(christos)

Fix typo in comment

(skrll)

Fix typo

(skrll)

new compat_bsdos man page.

(christos)

New man page from Dan Plassche.

(christos)

Remove unneeded sete{u,g}id pointed out by kre.
Remove dup unlink.

(christos)

arm_cpu_topology_set only takes two arguments

(skrll)

We already zeroed the struct, no point in zeroing things twice.

(christos)

Bump the version for entry additions to IP_STAT and IP6_STAT

Welcome to 9.99.72

(ozaki-r)

Another typo -- its vfs_newvnode().

(hannken)

netstat: strengthen against kernel changes

netstat uses sysctlbyname to get counter data from the kernel.
sysctlbyname fails with ENOMEM if actual counter data in the kernel is
larger than a passed buffer.  netstat just skips showing counters of a
category if sysctlbyname fails, so if we added new counters of the
category to the kernel, nestat shows nothing for the category.

Fortunately sysctlbyname fills data as much as possible even if a passed
buffer is short.  So we can allow netstat to show the filled data anyway
if sysctlbyname fails with ENOMEM.

Note that this backcompat mechanism works only if new counters are
appended, and doesn't work if new counters are inserted into the middle
or counters are moved.

(ozaki-r)

thmap(9): Minor readability and style tweaks.

- Fix typo: hmap -> thmap

- Reduce excessive indentation.

- Specify largest entry width for flag name table.

- Include parameter names in function descriptions for easier
  reference.

(riastradh)

wg: Sort includes.

(riastradh)

netinet: Include the needful so include order doesn't matter.

(riastradh)

Just zero out struct file::f_lock when exposed to userland.

Userland has no business examining a snapshot of the lock state, even
if pseudonymized.  Should fix hppa build, where kmutex_t is somewhat
larger than anticipated by recent changes.

(riastradh)

make(1): fix the other assertion from Lst_FindFrom

When I migrated the Lst_FindFrom to the strict API variant, I forgot
that Lst_FindFrom requires both arguments (list and node) to be
non-null.  I had only checked that the list is non-null.

There are only very few calls to Lst_FindFrom, and they are all ok now.

(rillig)

Revert removal -- evidently the leading dash does mean something.

Specifically, it cancels out the same entry elsewhere in the set
list, and apparently it is only for twelve files in the entire tree.
Someone^TM should document this more clearly, and/or just get rid of
it because I'm at least the third person to be confused by this
according to the revision history.

(riastradh)

make(1): fix assertion failure in suffix handling

Found by running ./build.sh, in the very early stage.
Fixed by restoring the previous behavior of returning NULL for invalid
arguments.

(rillig)

npf: Remove harmless vestiges of debugging hacks.

(riastradh)

netstat: support new packet counters

(ozaki-r)

inet6: reduce silent packet discards

(ozaki-r)

inet: reduce silent packet discards

(ozaki-r)

inet: pull m_get_rcvif_psref out of ip_input for simplicity

Same as ip6_input.

(ozaki-r)

inet6: pass rcvif to ip6_forward to avoid extra psref_acquire

(ozaki-r)

ether: count dropped packets on output

(ozaki-r)

ether: count dropped packets on input

(ozaki-r)

ether: separate handling of LLC frames as ether_input_llc (NFCI)

(ozaki-r)

net: introduce IFQ_ENQUEUE_ISR to assemble packet queuing routines (NFCI)

(ozaki-r)

inet: reduce indents of a normal path to improve readability (NFCI)

(ozaki-r)

ipsec: rename ipsec_ip_input to ipsec_ip_input_checkpolicy

Because it just checks if a packet passes security policies.

(ozaki-r)

inet, inet6: count packets dropped by IPsec

The counters count packets dropped due to security policy checks.

(ozaki-r)

make(1): clean up Dir_AddDir

Extract the null check for path to the top level.  This has the
side-effect of only incrementing dotLast.refCount if that entry is
actually used.

Reduce the indentation of the code by returning early from the simple
branches.

(rillig)

make(1): remove trailing 'S' from names of Lst functions

The migration from null-passing Lst functions to argument-checking Lst
functions is completed.

There were 2 surprises: The targets list may be NULL, and in Dir_AddDir,
the path may be NULL.  The latter case is especially surprising since
that function turns into an almost-nop in that case.  This is another
case where probably 2 independent functions have been squeezed into a
single function.  This may be improved in a follow-up commit.

All other lists were fine.  They were always defined and thus didn't
need much work.

(rillig)

make(1): migrate Lst_Find to Lst_FindS

(rillig)

make(1): remove unused reference to Lst_Last

(rillig)

make(1): migrate Lst_First to Lst_FirstS

(rillig)

make(1): add test for the undocumented .NULL special dependency target

(rillig)

make(1): add test for the undocumented .NULL special dependency target

(rillig)

make(1): add tests for the special .INCLUDES and .LIBS variables

(rillig)

make(1): print suffix flags in the standard way

This changes the output (it is now SUFF_NULL instead of just NULL), and
the order of the flags in the output is reversed.

(rillig)

make(1): disable the sync-mi convenience target

(rillig)

Use wrapper name for call to setsockopt(2), NFC for non-rump builds.

(rjs)

Summary: let wg interfaces carry multicast traffic

Once a wg interface is up and running, it is useful to be able to run
a routing protocol over it.  Marking the interface multicast capable
enables this.  (One must also use the wgconfig --allowed-ips option to
explicitly permit the group one needs, e.g. 224.0.0.5/32 for OSPF.)

(tih)

make(1): migrate Lst_IsEmpty to Lst_IsEmptyS

(rillig)

make(1): pass the command-line variables to the subdir make

(rillig)

make(1): add test for the -dg1 option

(rillig)

npftest: Wait at least one tick in each gc busy wait iteration.

Otherwise the busy wait loop runs a little too fast for the gc about
half the times I run the test.

XXX We should really arrange mstohz to round up!

(riastradh)

npf: Make sure to initialize portmap_lock only once.

PR kern/55586

(riastradh)

npf: Don't stop early after sleeping and before processing instances.

We already check winfo->exit below, after processing instances and
before sleeping again.

Candidate fix for:

panic: kernel diagnostic assertion "LIST_EMPTY(&winfo->instances)" failed: file "/home/riastradh/netbsd/current/src/sys/rump/net/lib/libnpf/../../../..//net/npf/npf_worker.c", line 300 NPF instances must be discharged before the npfk_sysfini() call

(riastradh)

Avoid undefined behaviour as detected by KUBSAN

(skrll)

Remove bogus Atffile and Kyuafile entries for if_wg tests.

(riastradh)

Sort and deduplicate set lists.

(riastradh)

Omit spurious leading dash in debug/ad.mips set list entries.

(if this actually means something feel free to revert and document
what it means somewhere obvious!)

(riastradh)

Fix obsolete entry for /usr/lib/libcdk.so.

This was broken in rev. 1.1230.

(riastradh)

Ticket #1065

(martin)

Fix a bunch of typos in various kernel man pages.

(fcambus)

Pull up following revision(s) (requested by riastradh in ticket #1065):

sys/dev/usb/usbdevices.config: revision 1.41 (patch)
sys/dev/usb/ugen.c: revision 1.152
sys/dev/usb/ugen.c: revision 1.153
sys/dev/usb/ugen.c: revision 1.154
sys/dev/usb/ugen.c: revision 1.155 (patch)
sys/dev/usb/ugen.c: revision 1.156
sys/dev/usb/ugen.c: revision 1.157

Remove UGEN_ASLP microoptimization.
cv_signal already has this microoptimization.
While here, make the lock cover the relevant things we're issuing
cv_signal about -- progress toward real MP-safety.

Hold the lock over access to the data structures it covers.
Still not MPSAFE, but progress.

Convert DIAGNOSTIC prints to KASSERTs.

Share unit numbering for ugen and ugenif.
This way putting ugenif in kernel config actually works to wire it to
the /dev/ugenN.MM device nodes in userland.

Not a fully fleshed out solution to the ugen problem -- there's no
way for a userland driver to kick out a kernel driver and take over,
but this will let us, e.g., use uhidev(4) for Yubikey OTP/U2F/FIDO2
but ugen(4), with pcscd(8), for Yubikey CCID.

Fix various MP-safety issues while here (still not MPSAFE, but more
progress).

Expose Yubikey CCID interface to userland via ugenif.

Fix sloppy mistakes in previous.
1. Give the offset of the rbnode, not some other random members to
  overwrite with garbage.
2. Don't try to unlock a mutex at NULL.
3. Make sure all paths out after ugenif_acquire go via
  ugenif_release.

Fix ugen detach after partial attach.

While here, register null pmf handler even for partially attached
devices so they don't needlessly interfere with suspend.

(martin)

Sort includes, nix trailing whitespace, fix comment.

(riastradh)

Move address hashing from init_main.c to kern_sysctl.c.

This way rump gets it automatically.  Make sure blake2s is in
librumpkern.so, not just in librumpkern_crypto.so, for this to work.

(riastradh)

- when running as root, create the socket under a different uid/gid to verify
  that it works properly with different users opening the socket.
- verify that linux works the same for both getpeereid() and fstat()

(christos)

wg: Assert MCLBYTES is enough for requested length in wg_get_mbuf.

(riastradh)

Move mii_phy_statusmsg(sc) back to its original position. Fixes
deafness bug on macppc reported and tested by martin@
Thanks !

(kardel)

Enable NCLOOKUP for ZFS.

(hannken)

Tickets #1058, #1060 - #1064

(martin)

Pull up following revision(s) (requested by kre in ticket #1064):

bin/sh/exec.c: revision 1.54

PR bin/55526

Fix a bug that has existed since the "command" command was added in
2003.  "command foo" would cause the definition of a function "foo"
to be lost (not freed, simply discarded) if "foo" is (in addition to
being a function) a filesystem command.  The case where "foo" is
a builtin was handled.

For now, when a function exists with the same name as a filesystem
command, the latter can never appear in the command hash table, and
when used (which can only be via "command foo", just "foo" finds
the function) will always result in a full PATH search.

XXX pullup everything (from NetBSD 2.0 onwards).  (really -8 and -9)

(martin)

Pull up following revision(s) (requested by nia in ticket #1063):

share/man/man8/afterboot.8: revision 1.68
share/man/man8/afterboot.8: revision 1.69
share/man/man8/afterboot.8: revision 1.70
share/man/man8/afterboot.8: revision 1.71
share/man/man8/afterboot.8: revision 1.72
share/man/man8/afterboot.8: revision 1.73
share/man/man8/afterboot.8: revision 1.63
share/man/man8/afterboot.8: revision 1.64
share/man/man8/afterboot.8: revision 1.65
share/man/man8/afterboot.8: revision 1.66
share/man/man8/afterboot.8: revision 1.67
afterboot.8: Explain how connecting to open WiFi works with wpa_supplicant

afterboot.8: Explain how to install pkgin on a fresh system
afterboot.8: Be clearer about exactly when you might need to login as root
afterboot.8: Explain devpubd
afterboot.8: Mention mdnsd
afterboot.8: Use cdn. Don't be arch specific. Requested by leot.
afterboot.8: Correct URL directory order
afterboot.8: Use wpa_* for everything WiFi, update links
reasoning: ifconfig scan is unreliable while wpa_supplicant is running
afterboot.8: Start the daemons after configuring wpa_supplicant.
afterboot.8: uname -p, pointed out by various people
afterboot.8: If it needs a disclaimer that most people shouldn't do it...

(martin)