libc atomic: Make previous work a little less accidentally.

(riastradh)

atf-run_test.sh: fix spelling of "through"

Reported by Jim Spath in PR misc/57318.

(gutteridge)

Remove unconditional UAUDIO_DEBUG again.

(mlelstv)

Fix UAUDIO_DEBUG build.

(mlelstv)

libc __atomic_is_lock_free: Fix clang build with symbol hacks.

(riastradh)

Use PRI{u,x}{BUSSIZE,VADDR,PADDR} etc

(skrll)

More KNF

(skrll)

Some KNF

(skrll)

spaces -> TAB

(skrll)

lint: clean up indentation and wrapping in C parser

(rillig)

add missing '\n'

(ryo)

commonize case block

(ryo)

don't pass add=1 to print_tree() when displaying by specifying nodes.

For example, "sysctl -w kern.mbuf=" had been displayed extra node names in the MIB.
# sysctl -w kern.mbuf=
kern.mbuf.mbuf.msize = 512
kern.mbuf.mbuf.mclbytes = 2048
:

(ryo)

switch gdb to gdb.old

(christos)

Add support for USB Audio Class 2.0.

(mlelstv)

Add code for USB Audio Class 2.0.

This is only half of the game as UAC2 devices tend to use 24bit or 32bit
samples. This requires more support in audio(4).

(mlelstv)

Amend ticket #128 for backout of virtio.c changes

(martin)

Backout attempts to build fix for ticket #128 for this file, needs
other changes.

(martin)

Trailing whitespace

(skrll)

Fix lying comment.

(dholland)

Tickets #1811 - #1820

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1820):

usr.sbin/route6d/route6d.c: revision 1.72

PR/53365: Thomas Barabosch: memory leak in route6d

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1819):

sys/sys/common_limits.h: revision 1.3

Fix wrong scoping of {U,}LLONG_MAX. Final case, I think.
PR 53298 from Roberto E. Vargas Caballero.

(martin)

Apply patch, requested by riastradh in ticket #1818:

external/bsd/file/dist/src/readelf.c (apply patch)

PR kern/52532: fix bounds check in ELF header parser.

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1817):

sys/fs/hfs/libhfs.c: revision 1.15

Fix support for case sensitive HFS.

Without this change, the wrong file is returned, if 2 file names contain a
subset of each other.

Code submitted in PR bin/52993 by Harold Gutch

(martin)

Tickets #1618 - #1626

(martin)

Pull up following revision(s) (requested by kre in ticket #1626):

usr.sbin/iostat/iostat.c: revision 1.68

Fix processing of the archaic arg format (BACKWARD_COMPATIBILITY) so it
doesn't repeat the processing every iteration.  Repeatedly seeing the wait
interval does no harm, but setting the iteration count (reps) over and
over again rather defeats its purpose.

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1625):

sys/uvm/uvm_map.c: revision 1.403

mmap(2): Avoid arithmetic overflow in search for free space.

PR kern/56900

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1624):

libexec/ld.elf_so/rtld.c: revision 1.212

ld.elf_so(8): Make fork take a shared, not exclusive, lock.

We only need to ensure that there are no concurrent modifications to
the rtld data structures in flight, since the threads that began
those modifications will not exist in the child and will therefore be
unable to complete them in the child.

A shared lock suffices to ensure there are no such concurrent
modifications in flight; an exclusive lock is not necessary, and can
cause deadlock if fork is executed from a signal handler, which is
explicitly allowed by POSIX (and our own sigaction(2) man page) which
marks fork as async-signal-safe.

PR lib/56979

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1816):

sys/uvm/uvm_map.c: revision 1.396

uvm(9): Fix mmap optimization for topdown case.

PR kern/51393

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1623):

sys/uvm/uvm_map.c: revision 1.396

uvm(9): Fix mmap optimization for topdown case.

PR kern/51393

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1815):

sys/uvm/uvm_map.c: revision 1.395

uvm(9): Fix 19-year-old bug in assertion about mmap hint.

Previously this would _first_ remember the original hint, and _then_
clamp the hint to the VM map's range:

        orig_hint = hint;
        if (hint < vm_map_min(map)) {  /* check ranges ... */
                if (flags & UVM_FLAG_FIXED) {
                        UVMHIST_LOG(maphist,"<- VA below map range",0,0,0,0);
                        return (NULL);
                }
                hint = vm_map_min(map);
        ...
        KASSERTMSG(!topdown || hint <= orig_hint, "hint: %#jx, orig_hint: %#jx",
            (uintmax_t)hint, (uintmax_t)orig_hint);

Even if nothing else happens in the ellipsis, taking the branch
guarantees the assertion will fail in the topdown case.

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1622):

sys/uvm/uvm_map.c: revision 1.395

uvm(9): Fix 19-year-old bug in assertion about mmap hint.

Previously this would _first_ remember the original hint, and _then_
clamp the hint to the VM map's range:

        orig_hint = hint;
        if (hint < vm_map_min(map)) {  /* check ranges ... */
                if (flags & UVM_FLAG_FIXED) {
                        UVMHIST_LOG(maphist,"<- VA below map range",0,0,0,0);
                        return (NULL);
                }
                hint = vm_map_min(map);
        ...
        KASSERTMSG(!topdown || hint <= orig_hint, "hint: %#jx, orig_hint: %#jx",
            (uintmax_t)hint, (uintmax_t)orig_hint);

Even if nothing else happens in the ellipsis, taking the branch
guarantees the assertion will fail in the topdown case.

(martin)

PR/57313: Timo Buhrmester: Don't bail if "." cannot be opened. From FreeBSD

(christos)

Pull up following revision(s) (requested by riastradh in ticket #1815):

sys/uvm/uvm_mmap.c: revision 1.180

mmap(2): If we fail with a hint, try again without it.
`Hint' here means nonzero addr, but no MAP_FIXED or MAP_TRYFIXED.

This is suboptimal -- we could teach uvm_mmap to do a fancier search
using the address as a hint.  But this should do for now.

Candidate fix for PR kern/55533.

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1621):

sys/uvm/uvm_mmap.c: revision 1.180

mmap(2): If we fail with a hint, try again without it.
`Hint' here means nonzero addr, but no MAP_FIXED or MAP_TRYFIXED.

This is suboptimal -- we could teach uvm_mmap to do a fancier search
using the address as a hint.  But this should do for now.

Candidate fix for PR kern/55533.

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1620):

sys/compat/netbsd32/netbsd32_fs.c: revision 1.89

data_len == 0 on mount means "the kernel knows". Fixes amd on compat32.

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1813):

sys/external/bsd/drm2/dist/drm/i915/i915_gpu_error.c: revision 1.9

Lock around use of irq_queue.

(martin)

Pull up the following, requested by mrg in ticket #1812:

xsrc/external/mit/xorg-server/dist/composite/compwindow.c up to 1.1.1.9 (patch)
xsrc/external/mit/xorg-server.old/dist/composite/compwindow.c 1.2 (patch)

Fix ZDI-CAN-19866 and CVE-2023-1393, a use-after-free problem.

(martin)

Pull up the following, requested by mrg in ticket #1619:

xsrc/external/mit/xorg-server/dist/composite/compwindow.c up to 1.1.1.9 (patch)
xsrc/external/mit/xorg-server.old/dist/composite/compwindow.c 1.2 (patch)

Fix ZDI-CAN-19866 and CVE-2023-1393, a use-after-free problem.

(martin)

Pull up following revision(s) (requested by mlelstv in ticket #1811):

external/bsd/fetch/dist/libfetch/common.c: revision 1.3
external/bsd/fetch/dist/libfetch/common.c: revision 1.4

Use SNI.

Shut down SSL when closing connection.

(martin)

Pull up following revision(s) (requested by mlelstv in ticket #1618):

external/bsd/fetch/dist/libfetch/common.c: revision 1.3
external/bsd/fetch/dist/libfetch/common.c: revision 1.4

Use SNI.

Shut down SSL when closing connection.

(martin)

Tickets #135 and #136

(martin)

Pull up following revision(s) (requested by mrg in ticket #135):

share/mk/bsd.x11.mk: revision 1.150

bump XORG_SERVER_TEENY.

(martin)

Pull up following revision(s) (requested by mrg in ticket #135):

xsrc/external/mit/xorg-server/dist/ChangeLog        up to 1.1.1.24
xsrc/external/mit/xorg-server/dist/configure        up to 1.17
xsrc/external/mit/xorg-server/dist/configure.ac      up to 1.19
xsrc/external/mit/xorg-server/dist/meson.build      up to 1.1.1.14
xsrc/external/mit/xorg-server/dist/composite/compwindow.c up to 1.1.1.9
xsrc/external/mit/xorg-server/dist/xkb/xkbUtils.c    up to 1.1.1.8
xsrc/external/mit/xorg-server/include/dix-config.h  up to 1.50
xsrc/external/mit/xorg-server/include/version-config.h up to 1.20
xsrc/external/mit/xorg-server/include/xorg-config.h  up to 1.30
xsrc/external/mit/xorg-server/include/xorg-server.h  up to 1.30
xsrc/external/mit/xorg-server.old/dist/composite/compwindow.c: revision 1.2

Sync src/external/mit/xorg-server with head to fix ZDI-CAN-19866 and
CVE-2023-1393, a use-after-free problem.

Pull across fixes for ZDI-CAN-19866 / CVE-2023-1393: to xorg-server.old

(martin)

Pull up following revision(s) (requested by riastradh in ticket #136):

sys/arch/x86/x86/intr.c: revision 1.164
sys/arch/x86/isa/clock.c: revision 1.41
sys/arch/x86/include/intr_private.h: revision 1.1

x86/intr: Work around sleazy clockintr with a secret frame argument.
PR kern/57197

(martin)

Also report precision from hwinfo.

(mlelstv)

Ammend ticket #128 for additional pullups

(martin)

Additionally pull up the following for ticket #128 to fix the build:

sys/dev/pci/if_vioif.c: revision 1.107
sys/dev/pci/virtio.c: revision 1.71

Use PRIuBUSSIZE to print bus_size_t variables.

(martin)

libkvm: suppress lint warnings about extern declarations for now

This should be properly fixed by someone who is familiar with libkvm, as
it affects <sys/cpu_data.h> as well.

(rillig)

0x%p -> %p in KASSERTMSGs

(skrll)

+PIR (private information retrieval)

(jschauma)

Fix wrong variable names

This fixes build errors in virtio_mmio.c

(yamaguchi)

mbuf(9): Sprinkle KASSERTMSG.

No functional change intended.

(riastradh)

Correct the previous (change both "2023b" -> "2023c" not just one in the
dup & correct).

(kre)

tzdata updated to 2023c (2023cgtz).

(kre)

Merge tzdata2023c

(kre)

spkr(4): Avoid some overflow issues.

XXX pullup-8
XXX pullup-9
XXX pullup-10

Reported-by: syzbot+1a9980f3631bbd710ded@syzkaller.appspotmail.com
https://syzkaller.appspot.com/bug?id=ea851fc4688cbac29a567cb49a4fd24d9afff426

Reported-by: syzbot+b4655f9c1734f886d610@syzkaller.appspotmail.com
https://syzkaller.appspot.com/bug?id=b61236df29f595e38b12ee533b7b3275c8ec1865

(riastradh)

lint: allow querying for octal integer constants

(rillig)

Added flags to store status of attaching a virtio device

This prevents a panic on reboot after a virtio device had called
virtio_child_attach_failed().

(yamaguchi)

Use descriptor chain for free slots instead of vq_entry list

Descriptors can be chained by themself. And descriptors added to
avail ring or used ring are already chained. But it was not used
for unused descriptors and another linked list structure named
vq_entry was used.
The chain is also used for unused descriptors to make virtio(4)
simpler.

(yamaguchi)

openssl: Omit local comment.

May be helpful explanation but it didn't make its way upstream,
whereas the file has moved and had other upstream changes, so let's
make the next merge less painful.

No functional change intended.

(riastradh)

libpuffs: ignore lint warning about nested extern for now

This should be properly fixed by someone familiar with puffs.

(rillig)

pull across fixes for ZDI-CAN-19866 / CVE-2023-1393: use after free

(mrg)

bump XORG_SERVER_TEENY.

(mrg)

updates for xorg-server 21.1.8.

(mrg)

merge xorg-server 21.1.8.

(mrg)

atalk(4): Omit spurious satosat.

The input is already a struct sockaddr_at pointer.

(riastradh)

sockaddr_alloc(9): Avoid uninitialized buffer in sockaddr_checklen.

Manifests only under DIAGNOSTIC because the DIAGNOSTIC check itself
uses an uninitialized buffer.

Reported-by: syzbot+54b120643dfd6edc2318@syzkaller.appspotmail.com
https://syzkaller.appspot.com/bug?id=afb5b6e5da6e806aeb7fddcf1d03c3262f6fc765

(riastradh)

atalk(4): Don't let userland control sa_len when adding addresses.

- The struct sockaddr_at object accessed by at_ifinit always comes
  from an ioctl buffer that is adequately sized and fully initialized
  from userland memory.

- The newly created sockaddr_at object is later used with
  sockaddr_copy, which requires sa_len to be correctly initialized.

- sa_len is not generally required to be correctly initialized by
  userland in most entry points (with some exceptions, e.g. gif(4)
  configuration).

I don't know whether existing userland programs initialize sa_len
correctly; if they do, we can verify it matches sizeof(struct
sockaddr_at), but there's no need to copy sa_len then if it is
verified to be that fixed value.

Reported-by: syzbot+fb4e112846e31bc4c09d@syzkaller.appspotmail.com
https://syzkaller.appspot.com/bug?id=6e511f97443d681b8917c6258d6463b28b36e8c9

Reported-by: syzbot+dce8a2b69dc06d9d6115@syzkaller.appspotmail.com
https://syzkaller.appspot.com/bug?id=e521a01ced5d0bbd363e998b81bc29f3282fd75f

Reported-by: syzbot+705a2a35990549b12c8d@syzkaller.appspotmail.com
https://syzkaller.appspot.com/bug?id=b9147d4070e1d240acd27155ce1f863997175517

Reported-by: syzbot+b9c649832cc9b1fdc7d6@syzkaller.appspotmail.com
https://syzkaller.appspot.com/bug?id=d5c9ad3d43042ec6e9f7bd30e13a37205e7e0373

Reported-by: syzbot+ac4ab136ca76e8152218@syzkaller.appspotmail.com
https://syzkaller.appspot.com/bug?id=349c0c4eded3eff1ff5fc2cd2d88b42806e08a47

Reported-by: syzbot+b75c731d20e46e9543e9@syzkaller.appspotmail.com
https://syzkaller.appspot.com/bug?id=e014d790e218797e217dd590ebe5a3a89e65b627

XXX pullup-8
XXX pullup-9
XXX pullup-10

(riastradh)

libc: Define __atomic_is_lock_free.

Limited to architectures where it is actually needed by gcc for any
calls to stdatomic.h atomic_is_lock_free for now.

We should also add it to other architectures too, along with lockful
atomic r/m/w operations for sizes that can't be handled natively, but
that's a lot more work.  It is also necessary for -fno-inline-atomics
but we're missing a lot of other symbols for that too, to be fixed.
For now, this should enable the OpenSSL build to complete on these
architectures again after I reverted a local change.

XXX pullup-10

(riastradh)

Tickets #1809 and #1810

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1810):

sys/nfs/nfs_serv.c: revision 1.184
sys/nfs/nfs_srvsubs.c: revision 1.17
sys/nfs/nfsm_subs.h: revision 1.56
sys/nfs/nfsm_subs.h: revision 1.57

nfs: Use unsigned fhlen so we don't trip over negative values.

nfs: Avoid integer overflow in nfs_namei bounds check.

nfs: Use unsigned name lengths so we don't trip over negative ones.
- nfsm_strsiz is only used with uint32_t in callers, but let's not
  leave it as a rake to step on.
- nfsm_srvnamesiz is abused with signed s.  The internal conversion
  to unsigned serves to reject both negative and too-large values in
  such callers.
  XXX Should make all callers use unsigned, rather than flipping back
  and forth between signed and unsigned for name lengths.

nfs: Avoid free of uninitialized on bad name size in create, mknod.
XXX These error branches are a nightmare and need to be more
systematically cleaned up.  Even if they are correct now, they are
impossible to audit and extremely fragile in case anyone ever needs
to make other changes to them.

(martin)

Tickets #1616 and #1617

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1617):

sys/nfs/nfs_serv.c: revision 1.184
sys/nfs/nfs_srvsubs.c: revision 1.17
sys/nfs/nfsm_subs.h: revision 1.56
sys/nfs/nfsm_subs.h: revision 1.57

nfs: Use unsigned fhlen so we don't trip over negative values.

nfs: Avoid integer overflow in nfs_namei bounds check.

nfs: Use unsigned name lengths so we don't trip over negative ones.
- nfsm_strsiz is only used with uint32_t in callers, but let's not
  leave it as a rake to step on.
- nfsm_srvnamesiz is abused with signed s.  The internal conversion
  to unsigned serves to reject both negative and too-large values in
  such callers.
  XXX Should make all callers use unsigned, rather than flipping back
  and forth between signed and unsigned for name lengths.

nfs: Avoid free of uninitialized on bad name size in create, mknod.
XXX These error branches are a nightmare and need to be more
systematically cleaned up.  Even if they are correct now, they are
impossible to audit and extremely fragile in case anyone ever needs
to make other changes to them.

(martin)

Tickets #128 - #134

(martin)

Pull up following revision(s) (requested by riastradh in ticket #134):

sys/nfs/nfs_serv.c: revision 1.184
sys/nfs/nfs_srvsubs.c: revision 1.17
sys/nfs/nfsm_subs.h: revision 1.56
sys/nfs/nfsm_subs.h: revision 1.57

nfs: Use unsigned fhlen so we don't trip over negative values.

nfs: Avoid integer overflow in nfs_namei bounds check.

nfs: Use unsigned name lengths so we don't trip over negative ones.
- nfsm_strsiz is only used with uint32_t in callers, but let's not
  leave it as a rake to step on.
- nfsm_srvnamesiz is abused with signed s.  The internal conversion
  to unsigned serves to reject both negative and too-large values in
  such callers.
  XXX Should make all callers use unsigned, rather than flipping back
  and forth between signed and unsigned for name lengths.

nfs: Avoid free of uninitialized on bad name size in create, mknod.
XXX These error branches are a nightmare and need to be more
systematically cleaned up.  Even if they are correct now, they are
impossible to audit and extremely fragile in case anyone ever needs
to make other changes to them.

(martin)

Pull up following revision(s) (requested by abs in ticket #133):

sys/arch/amiga/stand/bootblock/boot/libstubs.h: revision 1.8
sys/arch/amiga/stand/bootblock/boot/version: revision 1.3
sys/arch/amiga/stand/bootblock/boot/libstubs.s: revision 1.11
sys/arch/amiga/stand/bootblock/boot/console.c: revision 1.16

Fix NetBSD/amiga bootblocks for Kickstart 3.2 - from Karoly Balogh
Kickstart 3.2 changed to not initialize console.device before
bootstrap, so the previous NetBSD bootblocks would crash when they
tried to initialise console output.

With this change if the call to the OpenDevice() stub fails, the
code now calls FindResident() and InitResident() before retrying
the OpenDevice().

Many thanks to Karoly Balogh for tracking this down (and also for
knowing just who to poke to get insight into the 3.2 changes :)

(martin)

Pull up following revision(s) (requested by abs in ticket #1809):

distrib/amiga/stand/xdevtostream.uue: revision 1.1
distrib/amiga/stand/device-streams-2.2.1.lha.uue: revision 1.1
distrib/amiga/stand/rdbinfo.uue: revision 1.2
distrib/amiga/stand/device-streams.tar.gz.uue: file removal
distrib/amiga/stand/Makefile: revision 1.6
distrib/amiga/stand/device-streams-2.2.1-src.tar.gz.uue: revision 1.1
distrib/amiga/stand/device-streams.README.md: revision 1.1
distrib/amiga/stand/update: revision 1.1
distrib/amiga/stand/xstreamtodev.uue: revision 1.2

Update device-streams binaries from Roc Valles
- Split device-streams.tar.gz.uue into seperate source and
  binaries device-streams-2.2.1-src.tar.gz and device-streams-2.2.1.lha
  to match upstream
- Add device-streams.README.md from upstream
- Add simple 'update' script to help updating next time
- Binaries now avoid 32 bit file offset issues (they use 64 bit
  offsets where supported, and otherwise avoid corrupting data due
  to 32 bit limits)
- Binaries now built with updated bebbo/amiga-gcc toolchain

Pullup: netbsd-10, netbsd-9 and possibly netbsd-8

(martin)

Pull up following revision(s) (requested by abs in ticket #1616):

distrib/amiga/stand/xdevtostream.uue: revision 1.1
distrib/amiga/stand/device-streams-2.2.1.lha.uue: revision 1.1
distrib/amiga/stand/rdbinfo.uue: revision 1.2
distrib/amiga/stand/device-streams.tar.gz.uue: file removal
distrib/amiga/stand/Makefile: revision 1.6
distrib/amiga/stand/device-streams-2.2.1-src.tar.gz.uue: revision 1.1
distrib/amiga/stand/device-streams.README.md: revision 1.1
distrib/amiga/stand/update: revision 1.1
distrib/amiga/stand/xstreamtodev.uue: revision 1.2

Update device-streams binaries from Roc Valles
- Split device-streams.tar.gz.uue into seperate source and
  binaries device-streams-2.2.1-src.tar.gz and device-streams-2.2.1.lha
  to match upstream
- Add device-streams.README.md from upstream
- Add simple 'update' script to help updating next time
- Binaries now avoid 32 bit file offset issues (they use 64 bit
  offsets where supported, and otherwise avoid corrupting data due
  to 32 bit limits)
- Binaries now built with updated bebbo/amiga-gcc toolchain

Pullup: netbsd-10, netbsd-9 and possibly netbsd-8

(martin)

Pull up following revision(s) (requested by abs in ticket #132):

distrib/amiga/stand/xdevtostream.uue: revision 1.1
distrib/amiga/stand/device-streams-2.2.1.lha.uue: revision 1.1
distrib/amiga/stand/rdbinfo.uue: revision 1.2
distrib/amiga/stand/device-streams.tar.gz.uue: file removal
distrib/amiga/stand/Makefile: revision 1.6
distrib/amiga/stand/device-streams-2.2.1-src.tar.gz.uue: revision 1.1
distrib/amiga/stand/device-streams.README.md: revision 1.1
distrib/amiga/stand/update: revision 1.1
distrib/amiga/stand/xstreamtodev.uue: revision 1.2

Update device-streams binaries from Roc Valles
- Split device-streams.tar.gz.uue into seperate source and
  binaries device-streams-2.2.1-src.tar.gz and device-streams-2.2.1.lha
  to match upstream
- Add device-streams.README.md from upstream
- Add simple 'update' script to help updating next time
- Binaries now avoid 32 bit file offset issues (they use 64 bit
  offsets where supported, and otherwise avoid corrupting data due
  to 32 bit limits)
- Binaries now built with updated bebbo/amiga-gcc toolchain

Pullup: netbsd-10, netbsd-9 and possibly netbsd-8

(martin)

Pull up following revision(s) (requested by bouyer in ticket #131):

sys/arch/x86/x86/consinit.c: revision 1.36
sys/arch/xen/x86/pvh_consinit.c: revision 1.3
sys/arch/xen/include/xen.h: revision 1.48

Allow a PVH dom0 to use VGA as console: make xen_pvh_consinit() return 1 if
it handles the console and 0 otherwise (especially when console=tty0 or
console=pc is present on the command line).

In consinit() fallback to native console selection if xen_pvh_consinit()
returns 0.

(martin)

Pull up following revision(s) (requested by bouyer in ticket #130):

sys/arch/x86/x86/mpacpi.c: revision 1.110

mpacpi_config_cpu(): Xen with a PVH dom0 reports x2apic->LocalApicId
below 0xff, which causes a panic later because no CPUs are attached.

Accept the bogus LocalApicId value for VM_GUEST_XENPVH.

(martin)

Pull up following revision(s) (requested by bouyer in ticket #129):

sys/kern/vfs_xattr.c: revision 1.39

extattr_set_vp(): properly handle XATTR_REPLACE flags, FFSv2ea will return
ENOATTR, not ENODATA if the attribute is missing.

Makes glusterfs 10 run on a FFSv2ea file system.

(martin)

Pull up following revision(s) (requested by yamaguchi in ticket #128):

sys/dev/pci/if_vioif.c: revision 1.83-1.102,1.105,1.106

vioif(4): remove unnecessary lock release
if_percpuq_enqueue() can call with rxq->rxq_lock held because of per-cpu.

vioif(4): access to txq_active and rxq_active with lock held

vioif(4): use device reset to stop interrupt completely

vioif(4): rename {txq,rxq}_active to {txq,rxq}_running_handle

vioif(4): stop interrupt before schedule handler

vioif(4): adjust receive buffer to ETHER_ALIGN

vioif(4): added event counters related to receive processing

vioif(4): fix missing virtio_enqueue_abort for error handling

vioif(4): drain receive buffer on stopping the device
to remove branch in vioif_populate_rx_mbufs_locked()

vioif(4): divide interrupt handler for receiving
into dequeuing and preparing of buffers

vioif(4): merge drain into clear of queue

vioif(4): increase output error counter

vioif(4): added a structure to manage variables for packet processings

vioif(4): prepare slot before dequeuing

vioif(4): added __predct_false to error check

vioif(4): added new data structure for network queues
and moved the same parameters in vioif_txqueue and
vioif_rxqueue into the new structure

vioif(4): added functions to manipulate network queues

vioif(4): rename sc_hdr_segs to sc_segs

vioif(4): reorganize functions
This change is move of function and rename,
and this is no functional change.

vioif(4): divide IFF_OACTIVE into per-queue

vioif(4): clear flags when configure is failed

vioif(4): fix wrong memory allocation size

(martin)

atalk(4): Don't abuse queue(9) internals.

(riastradh)

raidframe: Nix unused parameter to raidwrite_component_area.

All calls use the same value.  Prune dead branches using it.

(riastradh)

style(5): Forbid extern in .c files.

Discussed on tech-userlevel (bcc tech-kern):
https://mail-index.netbsd.org/tech-userlevel/2023/03/15/msg013727.html

(riastradh)

systat(1): try to give this page a quick facelift

... too bad what it really needs is reconstructive surgery.  I tried
to fix the most obvious problems (unsorted lists, obviously wrong
markup, pleonastic wording that drowns out useful information in
repetition and lifetime supply of quote marks).

This page really needs a native speaker to take some loving care of it.

(uwe)

PR misc/57305 from Nan Xiao

Be consistent with method (and style) when referring to the mbufs and
ifstat sub-commands when describing what is available (and correct
"mbuf" to be "mbufs" which is what the internal command really is).

That is don't just "double quote" one and 'single quote' the other.

(kre)

PR/57288: Mingye Wang: <ssp/ssp.h>: Use __builtin_dynamic_object_size
for LLVM > 9 and GCC > 12, introducing _SSP_FORTIFY_LEVEL == 3

(christos)

openssl: Remove local micro-optimization on AMD (but not Intel).

Upstream OpenSSL changed

loop 1b

to

dec %rcx
jnz 1b

which has mostly the same semantics, in this change:

https://github.com/openssl/openssl/pull/4743

For some reason, in one of the OpenSSL updates, we ended up with a
local change to revert this.

The Intel and AMD optimization guides are silent on the LOOP
instruction, but Agner Fog's tables shows that while LOOP is one
cycle shorter than DEC;JNZ on AMD Zen microarchitectures, it is a
good half dozen cycles longer than DEC;JNZ on recent Intel
microarchitectures.

The history of the OpenSSL change suggests it was intended, and I
can't find any indication other than `merge conflicts' that we
intended to keep the LOOP version.  So let's reduce the local diff by
nixing it.

(riastradh)

use carp mac address when replying to neighbor solicitations referring
to carp interface addresses.
unconfuses commercial routers

(kardel)

openssl: Omit local indentation diff in mips bignum assembly.

Cute as it is to write the an instruction in a delay slot with an
extra space, it's not really useful to keep this around as a local
change since the substantive change was applied upstream years ago.

(riastradh)

openssl: Omit needless sprintf->snprintf under OPENSSL_SYS_WIN32.

Much as I'm happy to eliminate sprintf, there's very little value to
maintaining a local change under an #ifdef that will never, ever be
taken on NetBSD.

Verified libcrypto.so does not sprout any references to sprintf as a
result.

(riastradh)

openssl: Omit needless #ifdef notyet around __atomic_is_lock_free.

At the time this was done, our gcc version did not have it, but now
it does, so let's reduce the local diff.

(riastradh)

openssl: Omit needless #include <inttypes.h> in mem_clr.c.

This was needed back when the file was patched locally to cast a
pointer to intptr_t rather than to int, but that code is now gone and
the include is no longer necessary.  So let's reduce the local diff
by omitting this unnecessary change.

(riastradh)

openssl: Revert local patch around fileno(stdin/stdout).

According to the commit history, this was introduced when gcc4.5
complained about using the return value of fileno without checking it
against -1.  gcc 10.4 no longer appears to object, so let's just nix
the local patch.

(riastradh)

virtio(4): Use flexible array members, not zero-length arrays.

This enables the compiler to detect sizeof mistakes like
PR kern/57304.

(riastradh)

virtio(4): Fix sizing of virtqueue allocation.

vq->vq_avail[0].ring is a zero-length array, and thus sizeof is zero;
likewise vq->vq_used[0].ring.

Use vq->vq_avail[0].ring[0] and vq->vq_used[0].ring[0] to fix this
and restore the previous allocation sizing logic.

XXX We shouldn't use zero-length arrays here -- they are asking for
trouble like this, and C99 has a standard way to express what we're
actually trying to get at it, flexible array members.

PR kern/57304

Reported-by: syzbot+7fb1047f5dfa33b26331@syzkaller.appspotmail.com

(riastradh)

s/ourput/output/ in comment.

(andvar)

lint: warn about 'extern' declarations inside function bodies

https://mail-index.netbsd.org/tech-userlevel/2023/03/15/msg013727.html

The previous attempt (message 351 about 'extern' declarations outside
headers) did not cover the proposal from the tech-userlevel mailing list
but instead warns about a different usage pattern of the 'extern'
keyword.

(rillig)

s/interrput/interrupt/ and s/accesss/access/ in comments.

(andvar)

lint: clean up comments for handling 'linted' comments

No functional change.

(rillig)

x86/bus_dma.c: Sprinkle KASSERTMSG.

(riastradh)

lint: condense debugging code

No functional change.

(rillig)

lint: warn about extern declarations outside headers

https://mail-index.netbsd.org/tech-userlevel/2023/03/15/msg013727.html

(rillig)

make: declare all common symbols in headers, unexport others

No functional change.

(rillig)

tests/make: add expectations for string comparison errors

(rillig)

Add missing PRIuBUSSIZE to mips.

(nakayama)

PR bin/56014 from Kouichi Hashikawa

Don't try to optimise away placing the "s" or " " after "N user"
(" " where N==1, "s" otherwise) when it seems unnecessary, as that
fails when the number of users hasn't changed, but the screen is
being redrawn from nothing (as in after being resumed from a ^Z,
as in the PR, but just doing a ^L would make the same thing happen).

XXX pullup -10 (maybe -9 as well - seems too trivial for -8).

(kre)

Undo previous "restore lost break" and fix the issue that seems to
have been intending to correct properly (or at least, more rationally).

This makes adding/deleting drives for "vmstat" (and "iostat", though
the man page doesn't say that it also works there) using the :display
:ignore and :drive sub-commands work sensibly using fnmatch()
rather than what was there most of the time since it was added.

Previously ":ignore dk*" would ignore the first dk (wedge) found in
the system (whether or not it was ignored already) and that was it.
[":ignore dk* dk*" would just do that twice.]

Now the same command will ignore all dk* drives (all wedges), which
is what I would anticipate almost anyone would expect it to do.

Similarly for ":display" (to add drives) and ":drives" to explictly
list particular ones.

When the fnmatch() code was added, almost 9 and a half years ago now,
it was almost correct - except always resulted in an error occurring
(though that was little more than a minor inconvenience).

That was "fixed" 5 months later (9 years and almost a month ago now)
with the cvs log message "restore lost break" - which was absolutely
the wrong thing to do (the break was fine when no patterns were used,
and so a name could only ever match one drive - but wrong when the
whole point is to match many).

Somehow in the past 9+ years, no-one noticed that this functionality
had been rendered almost useless.

While here, fix a related problem ... just above I referred to the
error that occurred as a "minor inconvenience" - that's because while
an error would be shown on the screen, it would then immediately be
removed again, an observant user might notice the quick flash, but
that would be it.

Handle that by detecting whether any changes are actually made, and
don't go completely redrawing the screen (removing the error message
that was just placed there) if there is no point.  This doesn't
entirely fix this problem, as if we do

:drives foo wd*

and there is no "foo" drive in the system, we'd get an error message
from that, but adding the wd* drives (assuming there are some, of course)
counts as a change, so that error message will still not last very long.
The order of that command line makes no difference, it isn't that wd drives
were found after foo wasn't, but that the whole line matched (at least one)
drive (and changed its state - for the "drives" command, that is equivalent
to matched) - but also contained an entry which did not match at all.
That's a harder problem to fix.

No pullups planned, as no-one seems to mind how it has been all this time.

(kre)

Apply this commit from FreeBSD:

  commit 6bae6625e0e06816c80ac4971dfccf0643abe3f0
  Author: Kirk McKusick <mckusick@FreeBSD.org>
  Date:  Wed Aug 17 14:19:59 2022 -0700

    Improve handling of missing '.' and '..' in UFS directories.

    The UFS filesystem expects to find '.' and '..' as the first two entries
    in a directory. The kernel's UFS name cache can become quite confused
    when these two entries are not present as the first two entries.

    Prior to this change, when the fsck_ffs(8) utility detected that
    '.' and/or '..' were missing, it would report them, but only offered
    to replace them if the space at the beginning of the directory was
    available. Otherwise it was left to the system administrator to
    move the offending file(s) out of the way and then rerun fsck_ffs(8)
    to create the '.' and '..' entries.

    With this change, fsck_ffs(8) will always be able to create the '.'
    and/or '..' entries. It moves any files in the way elsewhere in the
    directory block. If there is no room in the directory block to which
    to move them, they are placed in the lost+found directory.

    Reported by:  Peter Holm
    Sponsored by: The FreeBSD Foundation

(chs)

Use PRIuBUSSIZE to print bus_size_t variables.

(nakayama)

virtio(4): Avoid name collision with global intrhand on sparc64.

Pacifies -Werror=shadow.

No functional change intended.

(riastradh)

fix various typos in documentation, comments and sysctl device description.
mainly aion -> ation and inlude -> include.

(andvar)

s/dipslay/display/ in comments.

(andvar)

s/diplay/display/ and s/DIPPLAY/DISPLAY/ in comments.

(andvar)

s/displyed/displayed/

(andvar)

Change CASMAGIC to 0xFEDABABE so that it cannot accidentally end up in
valid kernel memory.  Due to the VARM accesses above S0 should always
give a ptelen trap.
Bug found by Kalvis Duckmanton.

(ragge)

Ensure that the kernel do not try to allocate a S0 segment larger than 1G,
since the hardware prohibits that.

(ragge)

Use backing device to send advertisements. Otherwise the packets originate
from the virtual MAC address, which confuses switches.

(mlelstv)

Fix parser for carp state.
The state values are uppercase words INIT, BACKUP and MASTER.

(mlelstv)

s/resultion/resolution/ in comment.

(andvar)

s/Predective/Predictive/ and s/dedected/detected/ in comments.

(andvar)

s/deteted/detected/ in log message.

(andvar)

s/deteced/detected/ and s/couner/counter/ in comments.

(andvar)

Fix NetBSD/amiga bootblocks for Kickstart 3.2 - from Karoly Balogh

Kickstart 3.2 changed to not initialize console.device before
bootstrap, so the previous NetBSD bootblocks would crash when they
tried to initialise console output.

With this change if the call to the OpenDevice() stub fails, the
code now calls FindResident() and InitResident() before retrying
the OpenDevice().

Many thanks to Karoly Balogh for tracking this down (and also for
knowing just who to poke to get insight into the 3.2 changes :)

(abs)

Mark as MPSAFE.

(mlelstv)

Fix 32bit overflow when calculating balloon size.
Don't make uvm_pglistalloc wait, it will wait forever. Instead rely on
the retries by this driver. This also allows to cancel the request.
Increase inflate speed by factor 10 (same as deflate).

(mlelstv)

A single SCSI request may require multiple slots in the virtio queue
but the queue isn't sized for the theoretical maximum. So just use
XS_BUSY to pace the scsipi layer.

(mlelstv)

restore fetch of qsize.

(mlelstv)

Setup virtqueues after registering them to virtio_softc

(yamaguchi)

After a ':' (as in login:group or just :group) insist that there
actually be a group name (of some form, don't care what) present.

(kre)

PR misc/57287 from Nan Xiao

While it has always been assumed that everyone "just knew" that a simple
"su' meant "su root" perhaps the man page really should make that explicit.

Do that (using slightly different wording than suggested in the PR).

(kre)

Use snprintf_ss in pthread__assertfunc and update comment in
pthread__errorfunc. snprintf can use locks in some code paths and we
only care about the restricted subset here.

(joerg)

Added check of pointer for allocated memory before release of resource

(yamaguchi)

vioif(4): fix wrong memory allocation size

(yamaguchi)

Actually make the only changes that actually existed in the 2023b update...

(kre)

tzdata updated from 2023a to 2023b

(kre)

Merge tzdata2023b

(kre)

Allow a PVH dom0 to use VGA as console: make xen_pvh_consinit() return 1 if
it handles the console and 0 otherwise (especially when console=tty0 or
console=pc is present on the command line).
In consinit() fallback to native console selection if xen_pvh_consinit()
returns 0.

(bouyer)

mpacpi_config_cpu(): Xen with a PVH dom0 reports x2apic->LocalApicId
below 0xff, which causes a panic later because no CPUs are attached.
Accept the bogus LocalApicId value for VM_GUEST_XENPVH.

(bouyer)

extattr_set_vp(): properly handle XATTR_REPLACE flags, FFSv2ea will return
ENOATTR, not ENODATA if the attribute is missing.

Makes glusterfs 10 run on a FFSv2ea file system.

(bouyer)

Unwrap. NFCI.

(skrll)

nfs: Avoid free of uninitialized on bad name size in create, mknod.

XXX These error branches are a nightmare and need to be more
systematically cleaned up.  Even if they are correct now, they are
impossible to audit and extremely fragile in case anyone ever needs
to make other changes to them.

XXX pullup-8
XXX pullup-9
XXX pullup-10

(riastradh)

nfs: Use unsigned name lengths so we don't trip over negative ones.

- nfsm_strsiz is only used with uint32_t in callers, but let's not
  leave it as a rake to step on.

- nfsm_srvnamesiz is abused with signed s.  The internal conversion
  to unsigned serves to reject both negative and too-large values in
  such callers.

  XXX Should make all callers use unsigned, rather than flipping back
  and forth between signed and unsigned for name lengths.

XXX pullup-8
XXX pullup-9
XXX pullup-10

(riastradh)

nfs: Avoid integer overflow in nfs_namei bounds check.

XXX pullup-8
XXX pullup-9
XXX pullup-10

(riastradh)

nfs: Use unsigned fhlen so we don't trip over negative values.

XXX pullup-8
XXX pullup-9
XXX pullup-10

(riastradh)