NetBSD Source-Changes / commit log search

2024-05-09 21:47:47 UTC Now

2022-02-09 21:24:29 UTC MAIN commitmail json YAML

src/usr.bin/make/unit-tests/Makefile@1.307 / diff / nxr@1.307
src/usr.bin/make/unit-tests/objdir-writable.mk@1.7 / diff / nxr@1.7

tests/make: remove redundant 'echo' from variable assignments

Before main.c 1.231 from 2014-09-09, a variable assignment using the
operator '!=' generated a warning "Couldn't read shell's output" if the
output of the command was empty. The simplest way to suppress this
wrong warning was to add an empty 'echo' to the command. This hack is
no longer needed.

(rillig)

2022-02-09 21:09:25 UTC MAIN commitmail json YAML

make: fix mistakes, spelling and typos in comments and manual page

No binary change for -DNDEBUG.

(rillig)

2022-02-09 21:03:13 UTC MAIN commitmail json YAML

src/usr.bin/make/cond.c@1.328 / diff / nxr@1.328
src/usr.bin/make/parse.c@1.664 / diff / nxr@1.664
src/usr.bin/make/var.c@1.1010 / diff / nxr@1.1010

make: clean up variable names

No binary change.

(rillig)

2022-02-09 20:52:06 UTC MAIN commitmail json YAML

src/usr.bin/make/main.c@1.578 / diff / nxr@1.578
src/usr.bin/make/unit-tests/Makefile@1.305 / diff / nxr@1.305
src/usr.bin/make/unit-tests/objdir-writable.exp@1.5 / diff / nxr@1.5

make: prefix the warning about read-only .OBJDIR with a colon

For consistency with the other warnings.

(rillig)

2022-02-09 18:54:19 UTC MAIN commitmail json YAML

tests/make: use more distinctive placeholder for TMPDIR

(rillig)

2022-02-09 18:09:48 UTC MAIN commitmail json YAML

src/sys/dev/usb/uhidev.c@1.82 / diff / nxr@1.82

Do not explicitly set the HID Report Protocol upon attach, some devices
don't like it and should be in Report Protocol after enumeration/reset
anyway.

May address PR kern/55019.

(jakllsch)

2022-02-09 11:16:45 UTC MAIN commitmail json YAML

src/external/mit/xorg/bin/xsetwallpaper/Makefile@1.4 / diff / nxr@1.4

Add back NOMAN for now to fix the build

(martin)

2022-02-09 07:51:45 UTC MAIN commitmail json YAML

src/usr.bin/vmstat/vmstat.c@1.251 / diff / nxr@1.251

Fix typo in usage.

(wiz)

2022-02-09 07:34:18 UTC MAIN commitmail json YAML

src/usr.bin/vmstat/vmstat.c@1.250 / diff / nxr@1.250

allow the number of disks displayed in the default output
to be controlled.

(mrg)

2022-02-09 07:34:08 UTC MAIN commitmail json YAML

src/usr.bin/vmstat/vmstat.1@1.26 / diff / nxr@1.26

allow the number of disks displayed in the default output
to be controlled.

(mrg)

2022-02-09 07:32:33 UTC MAIN commitmail json YAML

src/sys/dev/usb/umcs.c@1.18 / diff / nxr@1.18

if the interrupt pipe can't be opened, also print the error.

(mrg)

2022-02-09 07:30:35 UTC MAIN commitmail json YAML

src/external/mit/xorg/bin/xsetwallpaper/Makefile@1.3 / diff / nxr@1.3

fix the build of xsetwallpaper.

(mrg)

2022-02-08 22:36:02 UTC MAIN commitmail json YAML

src/usr.bin/make/meta.c@1.197 / diff / nxr@1.197

Use a variable to store command line to be filtered.

This avoids any nasty side effects from content of command line.

Reviewed by: rillig

(sjg)

2022-02-08 21:13:22 UTC MAIN commitmail json YAML

src/lib/libedit/chared.c@1.62 / diff / nxr@1.62
src/lib/libedit/histedit.h@1.61 / diff / nxr@1.61

libedit: fix typos, apply KNF to newly imported code (PR/56693)

No binary change.

(rillig)

2022-02-08 20:39:59 UTC MAIN commitmail json YAML

src/bin/sh/histedit.c@1.61 / diff / nxr@1.61

sh: fix typo in comment

(rillig)

2022-02-08 15:05:10 UTC MAIN commitmail json YAML

PR/56693: Walter Lozano: Add support for rl_delete_text and rl_set_key

(christos)

2022-02-08 14:45:58 UTC netbsd-9 commitmail json YAML

src/doc/CHANGES-9.3@1.1.2.75 / diff / nxr@1.1.2.75

Ticket #1426

(martin)

2022-02-08 14:45:00 UTC netbsd-9 commitmail json YAML

src/sys/dev/ata/ata_recovery.c@1.2.8.1 / diff / nxr@1.2.8.1
src/sys/dev/ata/ata_subr.c@1.8.4.1 / diff / nxr@1.8.4.1

Pull up following revision(s) (requested by jdolecek in ticket #1426):

sys/dev/ata/ata_recovery.c: revision 1.3
sys/dev/ata/ata_subr.c: revision 1.9

stop xfer timeouts during recovery, all xfers will be requeued anyway
this avoids race with the timeout routine when processing the xfers
for requeueing

should fix PR kern/54790 by Izumi Tsutsui

(martin)

2022-02-08 12:59:17 UTC MAIN commitmail json YAML

src/sys/kern/subr_pcu.c@1.26 / diff / nxr@1.26
src/sys/kern/subr_psref.c@1.17 / diff / nxr@1.17
src/sys/kern/subr_thmap.c@1.9 / diff / nxr@1.9

kern: Mark some functions __diagused to pacify clang.

These functions are called only in KASSERT. This shouldn't be a
problem since the recent change to make KASSERT compile (but not run)
the expression, via sizeof, so the functions are referenced -- which
I did in order to avoid having #ifdefs and regular build breakage
because someone forgot to build with or without DIAGNOSTIC. But
apparently clang decided to make it a problem.

Maybe we should just set -Wno-unneeded-internal-declaration -- not
clear it flags any real problems, but it takes effort to research
because apparently clang has no documentation about what else it does
or why anyone decided this is objectionable enough to turn it on by
default. (The only documentation it seems to have, two example
warning messages with no elaboration at
<https://releases.llvm.org/13.0.0/tools/clang/docs/DiagnosticsReference.html#wunneeded-internal-declaration>,
seems to indicate it is mixed up with warning about static non-inline
functions in header files.)

(riastradh)

2022-02-08 08:57:11 UTC MAIN commitmail json YAML

src/sys/kern/vfs_vnode.c@1.129 / diff / nxr@1.129

Operation vfs_suspend() returns ENOENT if the mount is gone (IMNT_GONE).

Adjust the KASSERT() appropriately.

(hannken)

2022-02-07 23:24:26 UTC MAIN commitmail json YAML

src/usr.bin/make/parse.c@1.663 / diff / nxr@1.663

make: remove stray empty line

No functional change.

(rillig)

2022-02-07 22:43:50 UTC MAIN commitmail json YAML

tests/make: demonstrate combination of .USE with transformation rule

Reported in 2003 in PR toolchain/20993. Linking a transformation rule
with .USE or .USEBEFORE node makes the transformation rule fail.

(rillig)

2022-02-07 21:57:47 UTC MAIN commitmail json YAML

lint: drop compatibility with C90

Since tools/README 1.5 from 2022-02-03, the tools no longer need to be
compatible with C90, they may now use C99 features. Lint had used
<stdbool.h> and snprintf already.

No functional change.

(rillig)

2022-02-07 09:50:05 UTC MAIN commitmail json YAML

src/doc/CHANGES@1.2860 / diff / nxr@1.2860

note some recent things i've done in pci, scan_ffs, vmstat and blkdiscard.

(mrg)

2022-02-07 09:33:45 UTC MAIN commitmail json YAML

src/doc/3RDPARTY@1.1835 / diff / nxr@1.1835

update GMP info.

(mrg)

2022-02-07 09:33:26 UTC MAIN commitmail json YAML

src/sbin/blkdiscard/Makefile@1.1 / diff / nxr@1.1
src/sbin/blkdiscard/blkdiscard.8@1.1 / diff / nxr@1.1
src/sbin/blkdiscard/blkdiscard.c@1.1 / diff / nxr@1.1

convert my fdiscard-stuff.c into blkdiscard.c and give it a UI
that matches the linux-util version.

comes in two forms: blkdiscard equivalent, and the (almost)
original interface i used (the "-s" option is conflicting and
i've switched to only the not yet implemented secure erase
option.) the only real difference is that "fdiscard" mode
requires the -R flag to do something, vs blkdiscard needs the
-n flag to not do anything.

not yet hooked into the build or sets. would like more testing
on it to be performed before doing that (but soon.)

(mrg)

2022-02-07 02:44:49 UTC MAIN commitmail json YAML

lint: reword message about bit-field in a union

There is nothing illegal about a bit-field in a union, it is allowed by
C90, C99 and C11.

Fixes PR toolchain/53219.

(rillig)

2022-02-07 02:39:10 UTC MAIN commitmail json YAML

src/tests/usr.bin/xlint/lint1/msg_041.c@1.3 / diff / nxr@1.3
src/tests/usr.bin/xlint/lint1/msg_041.exp@1.3 / diff / nxr@1.3

tests/lint: add test for message 41 about bit-field in union

See PR toolchain/53219.

(rillig)

2022-02-07 02:35:09 UTC MAIN commitmail json YAML

src/usr.sbin/ldpd/tlv.h@1.5 / diff / nxr@1.5

ldpd: remove unused bit-field member from anonymous union

The struct common_hello_tlv contained an anonymous union, which is a C11
feature. That union contained a bit-field, which is very unusual since
the C standards answer basically all interesting questions about
bit-fields in unions with "implementation-defined" or "unspecified".
GCC passes these questions further down by saying "Determined by ABI".

This was the only occurrence of a bit-field union member in the whole
NetBSD tree, and it caused the lint diagnostic 41 to be downgraded from
error to warning on 2021-09-17 since this exotic construct is allowed by
the C standards but practically unused.

No binary change.

(rillig)

2022-02-06 22:21:25 UTC MAIN commitmail json YAML

src/sys/arch/arm/arm32/bus_dma.c@1.135 / diff / nxr@1.135

if we have to bounce a buffer, clear our anything already setup in
the map before trying again.

riastradh@ noticed that a map had two types of mbuf types, and this
seems to avoid it as seen on eqos(4) on quartz64.

add a couple more event counts for bus dma events.

ok @skrll @raistradh @jmcneill

XXX: pullup-8 and pullup-9 probably.

(mrg)

2022-02-06 20:20:19 UTC MAIN commitmail json YAML

fix various typos in comments, log messages and documentation.
mainly s/aparently/apparently/ and s/implmented/implemented/.

(andvar)

2022-02-06 19:29:52 UTC MAIN commitmail json YAML

src/sys/kern/subr_autoconf.c@1.295 / diff / nxr@1.295

move attribute before function declarator

(tnn)

2022-02-06 16:23:12 UTC MAIN commitmail json YAML

src/etc/rc.subr@1.110 / diff / nxr@1.110

Small changes in mount_critical_filesystems_zfs

avoid unnecessary eval, switch to $() and -ne.

from kre@, thanks!

(alnsn)

2022-02-06 15:52:21 UTC MAIN commitmail json YAML

sdhc: Retire SDHC_FLAG_USE_ADMA2 flag.

ADMA2 support in sdhc is mature now, so no need for it to be opt-in.

(jmcneill)

2022-02-06 15:48:12 UTC MAIN commitmail json YAML

src/sys/dev/acpi/dwcmmc_acpi.c@1.2 / diff / nxr@1.2

acpi: dwcmmc: Honour broken-cd and non-removable DSD properties

(jmcneill)

2022-02-06 15:47:06 UTC MAIN commitmail json YAML

src/sys/dev/fdt/dwcmmc_fdt.c@1.19 / diff / nxr@1.19

fdt: dwcmmc: Honour broken-cd and non-removable DT properties

(jmcneill)

2022-02-06 15:40:55 UTC MAIN commitmail json YAML

src/sys/arch/arm/nvidia/tegra_sdhc.c@1.31 / diff / nxr@1.31

sdhc: tegra: Set SDHC_FLAG_BROKEN_ADMA2_ZEROLEN quirk flag.

The Tegra SDHCI implementation apparently treats ADMA2 descriptors with
length of 0 incorrectly.

(jmcneill)

2022-02-06 12:12:08 UTC MAIN commitmail json YAML

src/sys/external/bsd/vchiq/dist/interface/compat/vchi_bsd.h@1.19 / diff / nxr@1.19

vchiq(4): Fix llvm build with only one loff_t definition.
Author: Taylor R Campbell <riastradh@NetBSD.org>

(martin)

2022-02-06 11:56:01 UTC MAIN commitmail json YAML

src/sys/kern/subr_autoconf.c@1.294 / diff / nxr@1.294

Revert previous, mark cfdriver_iattr_count as __diagused instead.

(martin)

2022-02-06 10:05:56 UTC MAIN commitmail json YAML

src/sys/arch/amiga/dev/amidisplaycc.c@1.39 / diff / nxr@1.39

Refactor cursor drawing.
Fixes rare case where cursor gets painted over when screen is cleared.

(jandberg)

2022-02-06 07:37:29 UTC MAIN commitmail json YAML

src/distrib/notes/common/main@1.568 / diff / nxr@1.568

Add pf(4) to the "list of features we plan to remove" (eventually)
list in the installation notes. Ironically, the only other thing here
is groff(1), which is used to generate these installation notes.

(nia)

2022-02-05 23:10:20 UTC MAIN commitmail json YAML

src/sys/kern/kern_exec.c@1.515 / diff / nxr@1.515

Prevent escallation of privilege due to poor handling of argc == 0 in set*id
binaries by refusing to execute them.

(christos)

2022-02-05 17:32:59 UTC MAIN commitmail json YAML

src/sys/dev/scsipi/scsiconf.c@1.298 / diff / nxr@1.298

Initialize "replun" -- found with KMSAN.

(hannken)

2022-02-05 15:29:50 UTC MAIN commitmail json YAML

src/sys/kern/kern_ntptime.c@1.61 / diff / nxr@1.61

kernel: Avoid arithmetic overflow in ntp_adjtime.

Reported-by: syzbot+f4343a1c91ddfe8bbe97@syzkaller.appspotmail.com

(riastradh)

2022-02-05 15:17:40 UTC MAIN commitmail json YAML

src/sys/kern/subr_autoconf.c@1.293 / diff / nxr@1.293

cfdriver_iattr_count() is only used in a KASSERT, so #ifdef DIAGNOSTIC it.

(martin)

2022-02-05 14:11:52 UTC MAIN commitmail json YAML

src/sys/fs/v7fs/v7fs_vfsops.c@1.18 / diff / nxr@1.18

fix membername in dprintf

(zafer)

2022-02-05 10:41:15 UTC MAIN commitmail json YAML

src/usr.bin/make/unit-tests/var-scope-local.mk@1.4 / diff / nxr@1.4

tests/make: document and try to reproduce the crash in Parse_IsVar

Fixed in parse.c 1.662 from today. To actually crash make, the end of
the expanded dependency line must be at the end of a mapped region.
There is no guaranteed crash, as this depends on the memory allocator.
NetBSD's jemalloc allocates large contiguous regions, making it less
likely for an allocation to end up at the end of a mapped region. The
memory allocators used by FreeBSD and OpenBSD are better at detecting
such bugs.

(rillig)

2022-02-05 00:37:19 UTC MAIN commitmail json YAML

src/usr.bin/make/parse.c@1.662 / diff / nxr@1.662

Ensure Parse_IsVar does not step off the end of input string.

(sjg)

2022-02-05 00:26:21 UTC MAIN commitmail json YAML

src/usr.bin/make/make.h@1.298 / diff / nxr@1.298
src/usr.bin/make/trace.c@1.31 / diff / nxr@1.31

make: improve C90 support

Do not use inline functions, remove trailing comma in enum declaration,
do not use 'long long' for printing a timestamp. This re-introduces the
Year 2038 Problem for pre-C99 compilers when printing the trace log, but
that is a seldom used feature.

(rillig)

2022-02-05 00:20:48 UTC MAIN commitmail json YAML

src/usr.bin/make/test-variants.mk@1.1 / diff / nxr@1.1
src/usr.bin/make/test-variants.sh deleted

tests/make: migrate test-variants.sh from shell to make

Using a makefile for defining the test variants allows running several
test variants individually, instead of using a single filter expression.

The test variants can be configured more fine-grained. It is possible
to exclude a few test cases per variant, which is useful for no-regex, a
compile-time switch for excluding the variable modifier ':C'.

Fix the definitions for the C90 tests. Previously they didn't override
the compiler option '-Wsystem-headers', thereby complaining about usage
of 'long long'.

(rillig)

2022-02-04 23:43:10 UTC MAIN commitmail json YAML

src/usr.bin/make/unit-tests/varmod-order-numeric.mk@1.6 / diff / nxr@1.6
src/usr.bin/make/var.c@1.1009 / diff / nxr@1.1009

make: use fixed type for comparing numbers using the modifier ':On'

When the modifier ':On' was added on 2021-07-30, there were concerns
that pre-C99 environments would not have the type 'long long', therefore
the type was made configurable, but parsing such numbers was hard-coded
to using strtoll.

To improve compatibility with C90 environments, use 'long' and 'strtol'
in these environments. In C99 environments, use 'long long' and
'strtoll', to account for larger file sizes.

If the flexibility of choosing yet another type for these numbers should
ever arise, it can still be implemented. Until then, reduce the number
of possible build configurations.

(rillig)

2022-02-04 23:22:19 UTC MAIN commitmail json YAML

make: use unsigned int for line numbers everywhere

Previously, some line numbers were stored as signed int while others
were stored as size_t. Since line numbers are never negative, use an
unsigned type. Since the maximum file size for makefiles is 1 GB (see
loadfile), unsigned int is large enough even on 64-bit platforms.

Using a single data types reduces the number of type conversions. Using
unsigned int improves compatibility with C90 (printf %u instead of %zu),
which is needed by bmake, which is derived from usr.bin/make.

No functional change.

(rillig)

2022-02-04 23:03:38 UTC MAIN commitmail json YAML

src/sys/dev/usb/uhub.c@1.159 / diff / nxr@1.159

uhub(4): Sprinkle dtrace probes.

(riastradh)

2022-02-04 18:28:53 UTC MAIN commitmail json YAML

src/sys/arch/luna68k/conf/GENERIC@1.131 / diff / nxr@1.131
src/sys/arch/luna68k/conf/INSTALL@1.32 / diff / nxr@1.32

Use "options WS_KERNEL_FG=WSCOL_GREEN" as most ports with color support.

For demonstration on nono that supports 4bpp framebuffer recently.

(tsutsui)

2022-02-04 17:21:56 UTC MAIN commitmail json YAML

src/distrib/x68k/floppies/ramdisk/list@1.35 / diff / nxr@1.35

Use more shrinked tools in src/distrib/utils.

Saves ~24KB.

(tsutsui)

2022-02-04 17:19:52 UTC MAIN commitmail json YAML

src/distrib/x68k/floppies/ramdisk/Makefile@1.49 / diff / nxr@1.49

Specify -fno-unwind-tables to shring ramdisk binaries.

Saves ~8KB.

(tsutsui)

2022-02-04 15:33:57 UTC MAIN commitmail json YAML

src/sys/kern/vfs_mount.c@1.87 / diff / nxr@1.87

Stop clearing "v_mountedhere" in mount_domount() error path.

We did not set it and may clear the value from another mount.

(hannken)

2022-02-04 06:16:03 UTC MAIN commitmail json YAML

src/sys/arch/x68k/stand/xxboot/Makefile.xxboot@1.19 / diff / nxr@1.19

Add missing -m68020-60 option. This makes xxboot_ustarfs work even on 68060.
Problem reported by Makoto Kamada. Confirmed on XEiJ (68060 mode).

(isaki)

2022-02-03 21:02:47 UTC MAIN commitmail json YAML

src/etc/rc.subr@1.109 / diff / nxr@1.109

Compare $_mount_es with 0

(alnsn)

2022-02-03 20:52:44 UTC MAIN commitmail json YAML

src/etc/rc.subr@1.108 / diff / nxr@1.108

Add mount_critical_filesystems_zfs

The new function is similar to mount_critical_filesystems
but it walks through ZFS datasets and mounts matching entries.

(alnsn)

2022-02-03 20:32:38 UTC MAIN commitmail json YAML

src/doc/CHANGES@1.2859 / diff / nxr@1.2859
src/tools/README@1.5 / diff / nxr@1.5

tools: allow tools to use C99

The previous requirement was that tools should only use C89 features.
Several tools did not follow this rule for years. Since nobody
complained about not being able to build NetBSD in a C89 environment,
drop that rule, now requiring C99.

https://mail-index.netbsd.org/tech-toolchain/2022/01/30/msg004091.html

(rillig)

2022-02-03 17:23:50 UTC MAIN commitmail json YAML

src/sys/arch/powerpc/include/oea/vmparam.h@1.23 / diff / nxr@1.23

bump MAXTSIZ
now clang runs again

(macallan)

2022-02-03 14:22:18 UTC netbsd-8 commitmail json YAML

src/doc/CHANGES-8.3@1.1.2.121 / diff / nxr@1.1.2.121

Ticket #1735

(martin)

2022-02-03 14:21:27 UTC netbsd-8 commitmail json YAML

xsrc/external/mit/xterm/dist/graphics_sixel.c@1.1.1.3.2.2 / diff / nxr@1.1.1.3.2.2

Pull up following revision(s) (requested by mrg in ticket #1735):

xsrc/external/mit/xterm/dist/graphics_sixel.c: revision 1.2 (patch)

apply upstream fix for CVE-2022-24130.

(martin)

2022-02-03 14:20:20 UTC netbsd-9 commitmail json YAML

src/doc/CHANGES-9.3@1.1.2.74 / diff / nxr@1.1.2.74

Ticket #1425

(martin)

2022-02-03 14:19:04 UTC netbsd-9 commitmail json YAML

xsrc/external/mit/xterm/dist/graphics_sixel.c@1.1.1.3.4.2 / diff / nxr@1.1.1.3.4.2

Pull up following revision(s) (requested by mrg in ticket #1425):

xsrc/external/mit/xterm/dist/graphics_sixel.c: revision 1.2 (patch)

apply upstream fix for CVE-2022-24130.

(martin)

2022-02-03 09:46:26 UTC MAIN commitmail json YAML

src/sys/fs/udf/udf_allocation.c@1.46 / diff / nxr@1.46

Revere modification of initializer; it can lead to race conditions where two
allocation would pick the `empty' space causing a panic later on.

(reinoud)

2022-02-03 01:59:24 UTC MAIN commitmail json YAML

xsrc/external/mit/xterm/dist/graphics_sixel.c@1.2 / diff / nxr@1.2

apply upstream fix for CVE-2022-24130.

(mrg)

2022-02-02 22:43:14 UTC MAIN commitmail json YAML

src/sys/dev/ic/spdmem.c@1.38 / diff / nxr@1.38

Fix misplaced comma.

(nakayama)

2022-02-02 15:18:53 UTC MAIN commitmail json YAML

src/sys/dev/pci/pcidevs.h@1.1432 / diff / nxr@1.1432
src/sys/dev/pci/pcidevs_data.h@1.1431 / diff / nxr@1.1431

Regen.

(msaitoh)

2022-02-02 15:18:21 UTC MAIN commitmail json YAML

src/sys/dev/pci/pcidevs@1.1448 / diff / nxr@1.1448

Add some devices from AMD BKDG.

(msaitoh)

2022-02-02 15:05:28 UTC MAIN commitmail json YAML

src/sys/dev/pci/pcidevs@1.1447 / diff / nxr@1.1447

Fix AMD F16_HB from 0x1568 to 0x1538.

AMD BKDG says the host bridge's device ID is 0x1538. Before pcidevs
rev. 1.1261, F16_HB was located next to 0x1537, so I suspect 0x1568 was typo
of 0x1538.

(msaitoh)

2022-02-02 14:27:21 UTC netbsd-9 commitmail json YAML

src/doc/CHANGES-9.3@1.1.2.73 / diff / nxr@1.1.2.73

Tickets #1423 and #1424

(martin)

2022-02-02 14:25:49 UTC netbsd-9 commitmail json YAML

Pull up the following revisions (requested by msaitoh in ticket #1424):

sys/dev/pci/ixgbe/ix_txrx.c 1.95
sys/dev/pci/ixgbe/ixgbe.c 1.305 via patch
sys/dev/pci/ixgbe/ixgbe_mbx.c 1.19
sys/dev/pci/ixgbe/ixgbe_netbsd.h 1.15-1.16
sys/dev/pci/ixgbe/ixv.c 1.178 via patch

Use atomic_{load,store}_relaxed() for event counters.

(martin)

2022-02-02 14:23:11 UTC netbsd-9 commitmail json YAML

src/build.sh@1.333.2.2 / diff / nxr@1.333.2.2

Pull up following revision(s) (requested by mrg in ticket #1423):

build.sh: revision 1.345

add "distsets" alias for "distribution sets".

(martin)

2022-02-02 05:40:59 UTC MAIN commitmail json YAML

src/sys/external/bsd/ipf/netinet/ip_nat.c@1.26 / diff / nxr@1.26

s/Incluse/Include/

(msaitoh)

2022-02-02 04:26:39 UTC netbsd-9 commitmail json YAML

src/doc/CHANGES-9.3@1.1.2.72 / diff / nxr@1.1.2.72

ticket #1422

(msaitoh)

2022-02-02 04:25:41 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by martin in ticket #1422):
usr.sbin/sysinst/util.c: revision 1.64
usr.sbin/sysinst/arch/hpcsh/md.c: revision 1.11
usr.sbin/sysinst/arch/alpha/md.c: revision 1.10
usr.sbin/sysinst/arch/sparc64/md.c: revision 1.7
usr.sbin/sysinst/arch/emips/md.c: revision 1.10
usr.sbin/sysinst/arch/cobalt/md.c: revision 1.15
usr.sbin/sysinst/arch/x68k/md.c: revision 1.12
usr.sbin/sysinst/arch/sandpoint/md.c: revision 1.10
usr.sbin/sysinst/arch/luna68k/md.c: revision 1.10
usr.sbin/sysinst/arch/hp300/md.c: revision 1.12
usr.sbin/sysinst/arch/vax/md.c: revision 1.8
usr.sbin/sysinst/arch/hpcmips/md.c: revision 1.10
usr.sbin/sysinst/target.c: revision 1.16
usr.sbin/sysinst/arch/mvme68k/md.c: revision 1.12
usr.sbin/sysinst/arch/arc/md.c: revision 1.14
usr.sbin/sysinst/target.c: revision 1.17
usr.sbin/sysinst/arch/i386/md.c: revision 1.34
usr.sbin/sysinst/arch/mac68k/md.c: revision 1.11
usr.sbin/sysinst/arch/atari/md.c: revision 1.8
usr.sbin/sysinst/arch/sgimips/md.c: revision 1.10
usr.sbin/sysinst/arch/acorn32/md.c: revision 1.8
usr.sbin/sysinst/install.c: revision 1.22
usr.sbin/sysinst/arch/amiga/md.c: revision 1.7
usr.sbin/sysinst/arch/cats/md.c: revision 1.6
usr.sbin/sysinst/arch/dummy/md.c: revision 1.7
usr.sbin/sysinst/arch/shark/md.c: revision 1.7
usr.sbin/sysinst/arch/pmax/md.c: revision 1.9
usr.sbin/sysinst/arch/newsmips/md.c: revision 1.7
usr.sbin/sysinst/arch/mipsco/md.c: revision 1.9
usr.sbin/sysinst/arch/landisk/md.c: revision 1.15
usr.sbin/sysinst/arch/hppa/md.c: revision 1.9
usr.sbin/sysinst/arch/prep/md.c: revision 1.14
usr.sbin/sysinst/defs.h: revision 1.77
usr.sbin/sysinst/arch/ofppc/md.c: revision 1.13
usr.sbin/sysinst/arch/ews4800mips/md.c: revision 1.8
usr.sbin/sysinst/defs.h: revision 1.78
usr.sbin/sysinst/arch/macppc/md.c: revision 1.7
usr.sbin/sysinst/arch/evbppc/md.c: revision 1.10
usr.sbin/sysinst/defs.h: revision 1.79
usr.sbin/sysinst/gpt.c: revision 1.27
usr.sbin/sysinst/arch/bebox/md.c: revision 1.10
usr.sbin/sysinst/gpt.c: revision 1.28
usr.sbin/sysinst/arch/sparc/md.c: revision 1.7
usr.sbin/sysinst/arch/evbsh3/md.c: revision 1.7
usr.sbin/sysinst/arch/evbarm/md.c: revision 1.22
usr.sbin/sysinst/arch/news68k/md.c: revision 1.8
usr.sbin/sysinst/upgrade.c: revision 1.19
usr.sbin/sysinst/arch/zaurus/md.c: revision 1.12
usr.sbin/sysinst/arch/playstation2/md.c: revision 1.10
usr.sbin/sysinst/arch/hpcarm/md.c: revision 1.11
usr.sbin/sysinst/arch/evbmips/md.c: revision 1.10
usr.sbin/sysinst/main.c: revision 1.28
Add an option to set the directory where we look for message catalogs.
Try to get rid of all wedges we created (after unmounting).
When upgrading, update the boot code post extraction from
the updated target file system.
Do not defer wedge deletions when we have nothing mounted.
Define and use a constant for maximum disk name length.

(msaitoh)

2022-02-02 01:21:34 UTC MAIN commitmail json YAML

src/bin/sh/histedit.c@1.60 / diff / nxr@1.60

After (a few days short of) 21 years, revert 1.25, which did nothing except
make the -e option to "fc" fail to work (the commit message was about some
other changes entirely, so I an only assume this was committed by mistake).

It says a lot about the use of the fc command that no-one noticed that
this did not work properly for all this time.

Internally in sh, it is possible for built in commands to use either
getopt(3) (from libc) or the much simpler internal shell nextopt() routine
for option (flag) parsing. However it makes no sense to use getopt()
and then access a global variable set only by nextopt() instead of the
one getopt() sets (which is what the code had used previously, forever).

Use the correct variable again.

XXX pullup -9 -8 (-7 -6 -5 ...)

(kre)

2022-02-01 18:27:24 UTC MAIN commitmail json YAML

src/tests/fs/vfs/t_vnops.c@1.62 / diff / nxr@1.62

Test mkdir(2) with one or more trailing slashes - this currently fails
for v7fs.

(martin)

2022-02-01 17:12:24 UTC MAIN commitmail json YAML

src/sys/fs/v7fs/v7fs_vnops.c@1.33 / diff / nxr@1.33

fix spelling of "regular" in comment

(jakllsch)

2022-02-01 12:10:04 UTC MAIN commitmail json YAML

src/doc/3RDPARTY@1.1834 / diff / nxr@1.1834

expat 2.4.4 out (security fix release)

(wiz)

2022-02-01 11:42:19 UTC netbsd-9 commitmail json YAML

src/doc/CHANGES-9.3@1.1.2.71 / diff / nxr@1.1.2.71

Tickets #1420 and #1421

(martin)

2022-02-01 11:41:29 UTC netbsd-9 commitmail json YAML

src/sys/dev/scsipi/cd.c@1.342.4.3 / diff / nxr@1.342.4.3

Pull up following revision(s) (requested by reinoud in ticket #1421):

sys/dev/scsipi/cd.c: revision 1.351

Limit buffer size for device capabilities requests as a work-around for PR
kern/56109.

(martin)

2022-02-01 11:40:02 UTC netbsd-8 commitmail json YAML

src/doc/CHANGES-8.3@1.1.2.120 / diff / nxr@1.1.2.120

Ticket #1734

(martin)

2022-02-01 11:38:29 UTC netbsd-8 commitmail json YAML

src/sys/dev/pci/ixgbe/ixgbe.c@1.88.2.49 / diff / nxr@1.88.2.49

Pull up the following revisions, requested by msaitoh in ticket #1734:

sys/dev/pci/ixgbe/ixgbe.c 1.264,1.269,1.272,
1.306 via patch

Four INTx related fixes:
- Fix a bug that the all interrupt sources are enabled when the
interface is UP and the INTx line is shared with other devices.
- Fix a bug that it might incorrectly enable interrupt when
IFF_RUNNING is not set.
- Don't process TX/RX if a queue interrupt isn't occurred.
- Increment legacy interrupt counter after checking INTx sharing.

(martin)

2022-02-01 11:35:46 UTC netbsd-9 commitmail json YAML

src/sys/dev/pci/ixgbe/ixgbe.c@1.199.2.19 / diff / nxr@1.199.2.19

Pull up the following revisions, requested by msaitoh in ticket #1420:

sys/dev/pci/ixgbe/ixgbe.c 1.264,1.269,1.272,
1.306 via patch

Four INTx related fixes:
- Fix a bug that the all interrupt sources are enabled when the
interface is UP and the INTx line is shared with other devices.
- Fix a bug that it might incorrectly enable interrupt when
IFF_RUNNING is not set.
- Don't process TX/RX if a queue interrupt isn't occurred.
- Increment legacy interrupt counter after checking INTx sharing.

(martin)

2022-02-01 10:45:02 UTC MAIN commitmail json YAML

src/usr.sbin/cpuctl/cpuctl.c@1.32 / diff / nxr@1.32

allow "cpuN" as well as "N" to specific a CPU.

update usage to include a change i made from 2015 to allow multiple
CPUs to be operated on at the same time for most commands.

(mrg)

2022-02-01 09:18:07 UTC MAIN commitmail json YAML

src/usr.bin/vmstat/vmstat.c@1.249 / diff / nxr@1.249

when picking which 2 disks to show in the 'vmstat' default output
and they haven't been specified on the command line, pick the two
devices that have had the largest read+write IO bytes count.

(mrg)

2022-02-01 09:08:33 UTC MAIN commitmail json YAML

src/sys/arch/arm/sociox/files.sociox@1.11 / diff / nxr@1.11

retire SocioNext AVE 32/64 GbE driver

(nisimura)

2022-02-01 08:58:25 UTC MAIN commitmail json YAML

src/sys/arch/arm/sociox/if_ave.c deleted

retire SocioNext AVE 32/64 GbE driver

(nisimura)

2022-02-01 05:27:40 UTC MAIN commitmail json YAML

src/sys/arch/x86/include/specialreg.h@1.189 / diff / nxr@1.189

s/shareing/sharing/. No functional change.

(msaitoh)

2022-02-01 04:59:16 UTC MAIN commitmail json YAML

src/sys/dev/pci/ixgbe/ixgbe.c@1.306 / diff / nxr@1.306

Increment legacy interrupt counter after checking INTx sharing.

(msaitoh)

2022-02-01 01:28:26 UTC MAIN commitmail json YAML

src/sys/dev/pci/pci_subr.c@1.242 / diff / nxr@1.242

Fix typo. Found by rillig. s/vendor specific/vendor-specific/

(msaitoh)

2022-01-31 22:58:26 UTC MAIN commitmail json YAML

src/usr.bin/make/hash.h@1.46 / diff / nxr@1.46

make: remove redundant declaration of HashIter_Init

Since hash.h 1.41 from 2021-12-07.

No binary change.

(rillig)

2022-01-31 20:49:28 UTC MAIN commitmail json YAML

src/usr.bin/make/make.h@1.296 / diff / nxr@1.296

make: make DEBUG0 simpler

All arguments to DEBUG0 are string literals, and none of them contains a
'%', which makes them safe to pass to printf directly. Any accidental
'%' would be caught by the compiler.

No functional change.

(rillig)

2022-01-31 18:15:45 UTC MAIN commitmail json YAML

src/bin/sh/histedit.c@1.59 / diff / nxr@1.59

When we initialize libedit (editline) always call ourselves "sh" no
matter what $0 is (or is not) set to. This means that editrc(5)
lines that start "sh:" are used (in addition to those with no prefix,
which will usually be most of them), regardless of the name or manner in
which we were invoked.

OK christos@

(kre)

2022-01-31 17:59:41 UTC netbsd-8 commitmail json YAML

src/doc/CHANGES-8.3@1.1.2.119 / diff / nxr@1.1.2.119

Tickets #1730 - #1733

(martin)

2022-01-31 17:58:05 UTC netbsd-8 commitmail json YAML

src/sys/arch/x86/x86/procfs_machdep.c@1.15.2.13 / diff / nxr@1.15.2.13

Pull up following revision(s) (requested by msaitoh in ticket #1733):

sys/arch/x86/x86/procfs_machdep.c: revision 1.43
sys/arch/x86/x86/procfs_machdep.c: revision 1.44

Update for cpuid flags:
- The table 11 was changed from CPUID 0x0f leaf 0 %edx to a Linux mapping.
- The table 12 was changed from CPUID 0x0f leaf 1 %edx to CPUID 0x07 leaf 1
%edx. Print avx_vnni and avx512_bf16.
- Print cppc, enqcmd and arch_lbr.
- Modify linux mapping. No used on NetBSD.

Fix procfs_machdep.c rev. 1.143. Print CPUID 0x00000007:1 %eax correctly.

(martin)

2022-01-31 17:56:28 UTC netbsd-9 commitmail json YAML

src/doc/CHANGES-9.3@1.1.2.70 / diff / nxr@1.1.2.70

Tickets #1415 - #1419

(martin)

2022-01-31 17:54:59 UTC netbsd-9 commitmail json YAML

src/sys/arch/x86/x86/procfs_machdep.c@1.33.2.5 / diff / nxr@1.33.2.5

Pull up following revision(s) (requested by msaitoh in ticket #1419):

sys/arch/x86/x86/procfs_machdep.c: revision 1.43
sys/arch/x86/x86/procfs_machdep.c: revision 1.44

Update for cpuid flags:
- The table 11 was changed from CPUID 0x0f leaf 0 %edx to a Linux mapping.
- The table 12 was changed from CPUID 0x0f leaf 1 %edx to CPUID 0x07 leaf 1
%edx. Print avx_vnni and avx512_bf16.
- Print cppc, enqcmd and arch_lbr.
- Modify linux mapping. No used on NetBSD.

Fix procfs_machdep.c rev. 1.143. Print CPUID 0x00000007:1 %eax correctly.

(martin)

2022-01-31 17:52:44 UTC netbsd-8 commitmail json YAML

src/usr.sbin/cpuctl/arch/i386.c@1.74.6.14 / diff / nxr@1.74.6.14

Pull up following revision(s) (requested by msaitoh in ticket #1732):

usr.sbin/cpuctl/arch/i386.c: revision 1.125
usr.sbin/cpuctl/arch/i386.c: revision 1.126
usr.sbin/cpuctl/arch/i386.c: revision 1.127

Add Alder Lake, Rocket Lake and Sapphire Rapids. From the latest Intel SDM.
Remove debug code and simplify. No functional change.
Decode Intel Hybrid Information Enumeration (CPUID Fn0000_001a).

(martin)

2022-01-31 17:51:00 UTC netbsd-9 commitmail json YAML

src/usr.sbin/cpuctl/arch/i386.c@1.104.2.10 / diff / nxr@1.104.2.10

Pull up following revision(s) (requested by msaitoh in ticket #1418):

usr.sbin/cpuctl/arch/i386.c: revision 1.125
usr.sbin/cpuctl/arch/i386.c: revision 1.126
usr.sbin/cpuctl/arch/i386.c: revision 1.127

Add Alder Lake, Rocket Lake and Sapphire Rapids. From the latest Intel SDM.
Remove debug code and simplify. No functional change.
Decode Intel Hybrid Information Enumeration (CPUID Fn0000_001a).

(martin)

2022-01-31 17:46:36 UTC netbsd-8 commitmail json YAML

src/sys/arch/x86/include/specialreg.h@1.98.2.23 / diff / nxr@1.98.2.23

Pull up the following revisions (all via patch), requested by
msaitoh in ticket #1731:

sys/arch/x86/include/specialreg.h 1.179-1.188

- Add CPUID definitions of Last Branch Record, Thread Director,
AVX version of VNNI, Fast short REP MOV, HRESET, PPIN, Architectural
LBR, Linear Address Masking and Hybrid Information from the latest
Intel SDM.
- Add CPUID definitions of AddrMaskExt, INT_WBINVD, IbrsSameMode,
EferLmsleUnsupported, PSFD and SecureTSC from AMD APM.
- Print CLFSH instead of CLFLUSH because both Intel and AMD documents
say so.
- Modify comment. Add comment. Fix typo. Use __BIT(). KNF. Sort lines.
No functional change.

(martin)

2022-01-31 17:42:18 UTC netbsd-9 commitmail json YAML

src/sys/arch/x86/include/specialreg.h@1.150.2.10 / diff / nxr@1.150.2.10

Pull up the following revisions (all via patch), requested by msaitoh
in ticket #1417:

sys/arch/x86/include/specialreg.h 1.179-1.188

- Add CPUID definitions of Last Branch Record, Thread Director,
AVX version of VNNI, Fast short REP MOV, HRESET, PPIN, Architectural
LBR, Linear Address Masking and Hybrid Information from the latest
Intel SDM.
- Add CPUID definitions of AddrMaskExt, INT_WBINVD, IbrsSameMode,
EferLmsleUnsupported, PSFD and SecureTSC from AMD APM.
- Print CLFSH instead of CLFLUSH because both Intel and AMD documents
say so.
- Modify comment. Add comment. Fix typo. Use __BIT(). KNF. Sort lines.
No functional change.

(martin)

2022-01-31 17:38:36 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by msaitoh in ticket #1730):

sys/dev/pci/ixgbe/ixgbe_mbx.h: revision 1.19
sys/dev/pci/ixgbe/ixgbe_vf.c: revision 1.31
sys/dev/pci/ixgbe/ixgbe_x540.c: revision 1.23
sys/dev/pci/ixgbe/if_sriov.c: revision 1.17
sys/dev/pci/ixgbe/ixv.c: revision 1.172
sys/dev/pci/ixgbe/ixv.c: revision 1.173
sys/dev/pci/ixgbe/ixgbe.c: revision 1.301
sys/dev/pci/ixgbe/ixgbe_type.h: revision 1.55
sys/dev/pci/ixgbe/ixgbe_82599.c: revision 1.29
sys/dev/pci/ixgbe/ixgbe_mbx.c: revision 1.16
sys/dev/pci/ixgbe/ixgbe_mbx.c: revision 1.17
sys/dev/pci/ixgbe/ixgbe_mbx.c: revision 1.18

Add code to support API version 1.5. No functional change.
- This change adds almost all code to support API 1.5 except real negotiation
and upgrade mailbox functions.
- From ix-3.3.18, ix-3.3.22 and ixv-1.5.24.

Enable mailbox API 1.5 support. Tested on ESXi with ixgben 1.10.3.0.

Don't clear mailbox related counters in ixgbe_upgrade_mbx_params_vf().
Don't clear mailbox related counters in ixgbe_upgrade_mbx_params_pf().

(martin)

2022-01-31 17:36:25 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by msaitoh in ticket #1416):

sys/dev/pci/ixgbe/ixgbe_mbx.h: revision 1.19
sys/dev/pci/ixgbe/ixgbe_vf.c: revision 1.31
sys/dev/pci/ixgbe/ixgbe_x540.c: revision 1.23
sys/dev/pci/ixgbe/if_sriov.c: revision 1.17
sys/dev/pci/ixgbe/ixv.c: revision 1.172
sys/dev/pci/ixgbe/ixv.c: revision 1.173
sys/dev/pci/ixgbe/ixgbe.c: revision 1.301
sys/dev/pci/ixgbe/ixgbe_type.h: revision 1.55
sys/dev/pci/ixgbe/ixgbe_82599.c: revision 1.29
sys/dev/pci/ixgbe/ixgbe_mbx.c: revision 1.16
sys/dev/pci/ixgbe/ixgbe_mbx.c: revision 1.17
sys/dev/pci/ixgbe/ixgbe_mbx.c: revision 1.18

Add code to support API version 1.5. No functional change.
- This change adds almost all code to support API 1.5 except real negotiation
and upgrade mailbox functions.
- From ix-3.3.18, ix-3.3.22 and ixv-1.5.24.

Enable mailbox API 1.5 support. Tested on ESXi with ixgben 1.10.3.0.

Don't clear mailbox related counters in ixgbe_upgrade_mbx_params_vf().
Don't clear mailbox related counters in ixgbe_upgrade_mbx_params_pf().

(martin)

2022-01-31 17:30:22 UTC netbsd-9 commitmail json YAML

src/sys/dev/usb/usbnet.c@1.25.2.6 / diff / nxr@1.25.2.6

Pull up following revision(s) (requested by riastradh in ticket #1415):

sys/dev/usb/usbnet.c: revision 1.44 (via patch)

usbnet: Defer hardware multicast filter updates to USB task.

Breaks deadlock:
- usbnet_detach holds usbnet lock, awaits kpause in ure_reset
- callout holds softclock `lock' (sequential softints, blocks kpause
wakeup), awaits softnet_lock in tcp_timer_keep, frag6_fasttimo, &c.
- soclose holds softnet_lock, awaits usbnet lock in SIOCDELMULTI

This change breaks the deadlock by not passing the SIOCADDMULTI or
SIOCDELMULTI ioctl synchronously to the driver, which typically takes
the usbnet lock.

With this change, the ethernet layer still maintains the list of
multicast addresses synchronously, but we defer the driver logic that
updates the hardware multicast filter to an asynchronous USB task
without softnet_lock held.

This doesn't cause exactly the same ioctl to be sent to the driver --
usbnet just sends SIOCDELMULTI with an all-zero struct ifreq, and
might drop some ioctls if issued in quick succession. This is OK
because none of the drivers actually distinguish between SIOCADDMULTI
and SIOCDELMULTI, or examine the argument; the drivers just commit
whatever multicast addresses are listed in the ethercom.

Other than the different ioctl submitted, there is no change to the
ABI or locking scheme of usbnet, so this is safe to pull up to
netbsd-9. This means we unfortunately can't guarantee that if a
process issues SIOCADDMULTI and then sendto, the multicast filter
update will be done by the time of the sendto -- and, more
importantly, the packets received in reply to it. But failing to
guarantee that is better than deadlocking! Later changes on HEAD
will restore the synchronous multicast filter updates with much more
extensive ABI changes and API simplifications in usbnet(9).
Proposed on tech-net:

https://mail-index.netbsd.org/tech-net/2021/12/30/msg008164.html

XXX pullup-9

(martin)

2022-01-31 17:23:37 UTC MAIN commitmail json YAML

src/tests/fs/vfs/t_renamerace.c@1.44 / diff / nxr@1.44

Extend the time to wait for the thread to quit.

It seems that alarm(1) is not enough time for the thread to actually exit after quittingtime = 1.
It randomly failed with "Test program received signal 14" on a slow environment.

(ryo)

2022-01-31 16:54:28 UTC MAIN commitmail json YAML

src/bin/sh/cd.c@1.53 / diff / nxr@1.53
src/bin/sh/histedit.c@1.58 / diff / nxr@1.58

Add some comments explaining accesses to the environment via
getenv()/setenv()/unsetenv() which manipulate the envornoment
the shell was passed at entry.

These are a little odd in sh as that environment is copied into
the shell's internal variable data struct at shell startup, and
normally never accessed after that - in builtin commands (test.
printf, ...) getenv() is #defined to become an internal sh lookup
function instead, so even those never use the startup environment).

NFCI

(kre)

2022-01-31 14:44:49 UTC MAIN commitmail json YAML

src/lib/libedit/readline.c@1.171 / diff / nxr@1.171
src/lib/libedit/readline/readline.h@1.51 / diff / nxr@1.51

PR/56622: Walter Lozano: Improve readline compatibility by adding
rl_readline_state support.

(christos)

2022-01-31 10:14:55 UTC MAIN commitmail json YAML

src/sys/dev/pci/pci_subr.c@1.241 / diff / nxr@1.241
src/sys/dev/pci/pcireg.h@1.165 / diff / nxr@1.165

Decode SCSI programming interface. Whitespace fix.

(msaitoh)

2022-01-31 10:11:33 UTC MAIN commitmail json YAML

src/sys/dev/pci/pci_subr.c@1.240 / diff / nxr@1.240
src/sys/dev/pci/pcireg.h@1.164 / diff / nxr@1.164

Add three new extended capabilities:

- Physical Layer 32.0 GT/s
- Alternate Protocol
- System Firmware Intermediary

(msaitoh)

2022-01-31 09:16:09 UTC MAIN commitmail json YAML

add support Hardware updates to Access flag and Dirty state (FEAT_HAFDBS)

- The DBM bit of the PTE is now used to determine if it is writable, and
the AF bit is treated entirely as a reference bit. A valid PTE is always
treated as readable. There can be no valid PTE that is not readable.
- LX_BLKPAG_OS_{READ,WRITE} are used only for debugging purposes,
and has been superseded by LX_BLKPAG_AF and LX_BLKPAG_DBM.
- Improve comment

The need for reference/modify emulation has been eliminated,
and access/permission faults have been reduced, however,
there has been little change in overall performance.

(ryo)

2022-01-31 08:43:05 UTC MAIN commitmail json YAML

src/sys/arch/aarch64/aarch64/pmap.c@1.126 / diff / nxr@1.126

Skip unnecessary PTE operations and TLB invalidation.

(ryo)

2022-01-31 06:54:50 UTC MAIN commitmail json YAML

src/sys/arch/x86/x86/procfs_machdep.c@1.44 / diff / nxr@1.44

Fix procfs_machdep.c rev. 1.143. Print CPUID 0x00000007:1 %eax correctly.

(msaitoh)

2022-01-30 19:49:30 UTC MAIN commitmail json YAML

src/external/mpl/bind/dist/lib/isc/hp.c@1.7 / diff / nxr@1.7

Add some more debugging to collect information about the sequence of events.

(christos)

2022-01-30 19:47:04 UTC MAIN commitmail json YAML

src/external/mpl/dhcp/dist/omapip/isclib.c@1.7 / diff / nxr@1.7

Bump the number of "workers" to 2 which effectively bumps the number of
contexts to 8. We seem to need 5 contexts so that should stop the error
checking to hp_retire() from triggering.

(christos)

2022-01-30 18:54:52 UTC MAIN commitmail json YAML

src/external/mpl/bind/dist/lib/isc/hp.c@1.6 / diff / nxr@1.6

a bit less verbose

(christos)

2022-01-30 16:08:14 UTC netbsd-8 commitmail json YAML

src/doc/CHANGES-8.3@1.1.2.118 / diff / nxr@1.1.2.118

Ticket #1729

(martin)

2022-01-30 16:06:36 UTC netbsd-8 commitmail json YAML

Pull up the following, requested by msaitoh in ticket #1729:

sys/dev/pci/ixgbe/if_sriov.c 1.12-1.16
sys/dev/pci/ixgbe/ixgbe.c 1.295-1.297,1.300,1.304 via patch
sys/dev/pci/ixgbe/ixgbe.h 1.84
sys/dev/pci/ixgbe/ixgbe_82598.c 1.17-1.18
sys/dev/pci/ixgbe/ixgbe_82598.h 1.9
sys/dev/pci/ixgbe/ixgbe_82599.c 1.24-1.28
sys/dev/pci/ixgbe/ixgbe_82599.h 1.8
sys/dev/pci/ixgbe/ixgbe_api.c 1.26-1.27
sys/dev/pci/ixgbe/ixgbe_api.h 1.16
sys/dev/pci/ixgbe/ixgbe_bypass.h 1.3
sys/dev/pci/ixgbe/ixgbe_common.c 1.34-1.42
sys/dev/pci/ixgbe/ixgbe_common.h 1.15-1.16
sys/dev/pci/ixgbe/ixgbe_dcb.c 1.12-1.13
sys/dev/pci/ixgbe/ixgbe_dcb.h 1.8-1.9
sys/dev/pci/ixgbe/ixgbe_dcb_82598.c 1.10-1.12
sys/dev/pci/ixgbe/ixgbe_dcb_82598.h 1.8
sys/dev/pci/ixgbe/ixgbe_dcb_82599.c 1.10-1.11
sys/dev/pci/ixgbe/ixgbe_dcb_82599.h 1.8
sys/dev/pci/ixgbe/ixgbe_fdir.h 1.4
sys/dev/pci/ixgbe/ixgbe_features.h 1.4
sys/dev/pci/ixgbe/ixgbe_mbx.c 1.13-1.15
sys/dev/pci/ixgbe/ixgbe_mbx.h 1.15-1.18
sys/dev/pci/ixgbe/ixgbe_netmap.c 1.5
sys/dev/pci/ixgbe/ixgbe_osdep.c 1.8
sys/dev/pci/ixgbe/ixgbe_osdep.h 1.31
sys/dev/pci/ixgbe/ixgbe_phy.c 1.25-1.29
sys/dev/pci/ixgbe/ixgbe_phy.h 1.13
sys/dev/pci/ixgbe/ixgbe_rss.h 1.6
sys/dev/pci/ixgbe/ixgbe_sriov.h 1.5
sys/dev/pci/ixgbe/ixgbe_type.h 1.51-1.54
sys/dev/pci/ixgbe/ixgbe_vf.c 1.28-1.29
sys/dev/pci/ixgbe/ixgbe_vf.h 1.15
sys/dev/pci/ixgbe/ixgbe_x540.c 1.20-1.22
sys/dev/pci/ixgbe/ixgbe_x540.h 1.10
sys/dev/pci/ixgbe/ixgbe_x550.c 1.21-1.25
sys/dev/pci/ixgbe/ixgbe_x550.h 1.7
sys/dev/pci/ixgbe/ixv.c 1.170, 1.174-1.175 via patch

- Add typecast for type mismatch.
- Fix retry count calculation of I2C read/write.
- Wait longer for link after fiber MAC setup.
- ixv(4): Use adapter->mta for the multicast array memory instead of
the on-stack array.
- Match X550_PHY_ID correctly on X550.
- Print NVM image version on 82598.
- Use 64bit for lxon + lxoff.
- Don't expose garbage data of hw.ixvN.debug.
- Some NetBSD unrelated changes:
- Fix infinite recursion on PCIe link down if VMDQ is used.
- Move PF mailbox initialization from ixgbe_attach() to
ixgbe_init_iov().
- Add IPv6 mask for flow director.
- Change error level in ixgbe_fc_autoneg().
- Check host interface return status when writing NVM.
- Change DCB credit parameters.
- Restore some mailbox related functions. Revert part of ixgbe_mbx.c
rev. 1.7 and ixgbe_mbx.h rev. 1.11. No functional change.
- Rename IXGBE_VT_MSGTYPE_{ACK,NACK} to
IXGBE_VT_MSGTYPE_{SUCCESS,FAILURE}. No functional change.
- Remove unused argument. Change argument.
- Remove unnecessary return value check.
- Remove debug error message.
- Remove dead code.
- Add some unused macros.
- Fix typo in comment.
- Rename some functions.
- Sort lines, modify comment.
- Whitespace fix.

(martin)

2022-01-30 16:03:50 UTC netbsd-9 commitmail json YAML

src/doc/CHANGES-9.3@1.1.2.69 / diff / nxr@1.1.2.69

Ticket #1414

(martin)

2022-01-30 15:58:29 UTC netbsd-9 commitmail json YAML

Pull up the following revisions, requested by msaitoh in ticket #1414:

sys/dev/pci/ixgbe/if_sriov.c 1.12-1.16
sys/dev/pci/ixgbe/ixgbe.c 1.295-1.297,1.300,1.304 via patch
sys/dev/pci/ixgbe/ixgbe.h 1.84
sys/dev/pci/ixgbe/ixgbe_82598.c 1.17-1.18
sys/dev/pci/ixgbe/ixgbe_82598.h 1.9
sys/dev/pci/ixgbe/ixgbe_82599.c 1.24-1.28
sys/dev/pci/ixgbe/ixgbe_82599.h 1.8
sys/dev/pci/ixgbe/ixgbe_api.c 1.26-1.27
sys/dev/pci/ixgbe/ixgbe_api.h 1.16
sys/dev/pci/ixgbe/ixgbe_bypass.h 1.3
sys/dev/pci/ixgbe/ixgbe_common.c 1.34-1.42
sys/dev/pci/ixgbe/ixgbe_common.h 1.15-1.16
sys/dev/pci/ixgbe/ixgbe_dcb.c 1.12-1.13
sys/dev/pci/ixgbe/ixgbe_dcb.h 1.8-1.9
sys/dev/pci/ixgbe/ixgbe_dcb_82598.c 1.10-1.12
sys/dev/pci/ixgbe/ixgbe_dcb_82598.h 1.8
sys/dev/pci/ixgbe/ixgbe_dcb_82599.c 1.10-1.11
sys/dev/pci/ixgbe/ixgbe_dcb_82599.h 1.8
sys/dev/pci/ixgbe/ixgbe_fdir.h 1.4
sys/dev/pci/ixgbe/ixgbe_features.h 1.4
sys/dev/pci/ixgbe/ixgbe_mbx.c 1.13-1.15
sys/dev/pci/ixgbe/ixgbe_mbx.h 1.15-1.18
sys/dev/pci/ixgbe/ixgbe_netmap.c 1.5
sys/dev/pci/ixgbe/ixgbe_osdep.c 1.8
sys/dev/pci/ixgbe/ixgbe_osdep.h 1.31
sys/dev/pci/ixgbe/ixgbe_phy.c 1.25-1.29
sys/dev/pci/ixgbe/ixgbe_phy.h 1.13
sys/dev/pci/ixgbe/ixgbe_rss.h 1.6
sys/dev/pci/ixgbe/ixgbe_sriov.h 1.5
sys/dev/pci/ixgbe/ixgbe_type.h 1.51-1.54
sys/dev/pci/ixgbe/ixgbe_vf.c 1.28-1.29
sys/dev/pci/ixgbe/ixgbe_vf.h 1.15
sys/dev/pci/ixgbe/ixgbe_x540.c 1.20-1.22
sys/dev/pci/ixgbe/ixgbe_x540.h 1.10
sys/dev/pci/ixgbe/ixgbe_x550.c 1.21-1.25
sys/dev/pci/ixgbe/ixgbe_x550.h 1.7
sys/dev/pci/ixgbe/ixv.c 1.170, 1.174-1.175 via patch

- Add typecast for type mismatch.
- Fix retry count calculation of I2C read/write.
- Wait longer for link after fiber MAC setup.
- ixv(4): Use adapter->mta for the multicast array memory instead of
the on-stack array.
- Match X550_PHY_ID correctly on X550.
- Print NVM image version on 82598.
- Use 64bit for lxon + lxoff.
- Don't expose garbage data of hw.ixvN.debug.
- Some NetBSD unrelated changes:
- Fix infinite recursion on PCIe link down if VMDQ is used.
- Move PF mailbox initialization from ixgbe_attach() to
ixgbe_init_iov().
- Add IPv6 mask for flow director.
- Change error level in ixgbe_fc_autoneg().
- Check host interface return status when writing NVM.
- Change DCB credit parameters.
- Restore some mailbox related functions. Revert part of ixgbe_mbx.c
rev. 1.7 and ixgbe_mbx.h rev. 1.11. No functional change.
- Rename IXGBE_VT_MSGTYPE_{ACK,NACK} to
IXGBE_VT_MSGTYPE_{SUCCESS,FAILURE}. No functional change.
- Remove unused argument. Change argument.
- Remove unnecessary return value check.
- Remove debug error message.
- Remove dead code.
- Add some unused macros.
- Fix typo in comment.
- Rename some functions.
- Sort lines, modify comment.
- Whitespace fix.

(martin)

2022-01-30 13:21:09 UTC MAIN commitmail json YAML

src/usr.bin/make/dir.c@1.277 / diff / nxr@1.277
src/usr.bin/make/job.c@1.450 / diff / nxr@1.450
src/usr.bin/make/make.h@1.295 / diff / nxr@1.295

Make the GNode lineno unsigned to fix lint warning in var.c calling
PrintLocation()

(christos)

2022-01-30 13:11:46 UTC MAIN commitmail json YAML

src/external/mpl/bind/dist/lib/isc/hp.c@1.5 / diff / nxr@1.5

Avoid retiring a thread with a xtid >= isc__hp_max_threads and crashing.
XXX: need to fix the real bug, but this will do for now.

(christos)

2022-01-30 11:58:29 UTC MAIN commitmail json YAML

src/usr.sbin/sysinst/defs.h@1.79 / diff / nxr@1.79
src/usr.sbin/sysinst/gpt.c@1.28 / diff / nxr@1.28
src/usr.sbin/sysinst/target.c@1.17 / diff / nxr@1.17

Do not defer wedge deletions when we have nothing mounted.
Define and use a constant for maximum disk name length.

(martin)

2022-01-29 21:37:07 UTC MAIN commitmail json YAML

src/sys/dev/usb/usbnet.c@1.44 / diff / nxr@1.44

usbnet: Defer hardware multicast filter updates to USB task.

Breaks deadlock:

- usbnet_detach holds usbnet lock, awaits kpause in ure_reset
- callout holds softclock `lock' (sequential softints, blocks kpause
wakeup), awaits softnet_lock in tcp_timer_keep, frag6_fasttimo, &c.
- soclose holds softnet_lock, awaits usbnet lock in SIOCDELMULTI

This change breaks the deadlock by not passing the SIOCADDMULTI or
SIOCDELMULTI ioctl synchronously to the driver, which typically takes
the usbnet lock.

With this change, the ethernet layer still maintains the list of
multicast addresses synchronously, but we defer the driver logic that
updates the hardware multicast filter to an asynchronous USB task
without softnet_lock held.

This doesn't cause exactly the same ioctl to be sent to the driver --
usbnet just sends SIOCDELMULTI with an all-zero struct ifreq, and
might drop some ioctls if issued in quick succession. This is OK
because none of the drivers actually distinguish between SIOCADDMULTI
and SIOCDELMULTI, or examine the argument; the drivers just commit
whatever multicast addresses are listed in the ethercom.

Other than the different ioctl submitted, there is no change to the
ABI or locking scheme of usbnet, so this is safe to pull up to
netbsd-9. This means we unfortunately can't guarantee that if a
process issues SIOCADDMULTI and then sendto, the multicast filter
update will be done by the time of the sendto -- and, more
importantly, the packets received in reply to it. But failing to
guarantee that is better than deadlocking! Later changes on HEAD
will restore the synchronous multicast filter updates with much more
extensive ABI changes and API simplifications in usbnet(9).

Proposed on tech-net:
https://mail-index.netbsd.org/tech-net/2021/12/30/msg008164.html

XXX pullup-9

(riastradh)

2022-01-29 21:36:12 UTC MAIN commitmail json YAML

src/sys/dev/usb/xhci.c@1.155 / diff / nxr@1.155

xhci(4): Fix handling of endpoint reset/stop.

Use the same asynchronous task resetting a stalled/halted endpoint
and stopping a running endpoint -- either way we need to put the
endpoint back into a known state and, if there are transfers waiting
to run, start them up again.

- xhci_abortx must not drop the pipe (bus) lock -- usbdi(9) requires
this. So arrange to stop the endpoint and empty the queue
asynchronously.

- If the xhci softint claims an xfer for completion with
usbd_xfer_trycomplete, it must call usb_transfer_complete without
ever releasing the pipe (bus) lock -- it can't claim the xfer and
then defer the usb_transfer_complete to a task. So arrange to
reset the endpoint asynchronously, hold up new transfers until the
endpoint has been reset, and then do usb_transfer_complete
immediately.

(riastradh)

2022-01-29 20:54:58 UTC MAIN commitmail json YAML

src/usr.bin/make/make.1@1.304 / diff / nxr@1.304

Tweak description of local variable assignments

(sjg)

2022-01-29 20:52:45 UTC MAIN commitmail json YAML

src/lib/libedit/readline.c@1.170 / diff / nxr@1.170

Add more refreshes from Walter Lozano. The readline example in
http://www.mcld.co.uk/blog/2009/simple-gnu-readline-callback-style-example.html
still does not work, but it is better.

(christos)

2022-01-29 20:35:11 UTC MAIN commitmail json YAML

src/sys/kern/subr_autoconf.c@1.292 / diff / nxr@1.292

pmf(9): Conditionalize pmflock_debug output on PMFLOCK_DEBUG.

This is really only helpful for debugging the software logic to
handle the trees of devices for suspend/resume, not for debugging the
drivers, which is most of what we need to do. If anyone still finds
this useful they can make a sysctl knob for it or something, but for
now this substantially reduces the amount of debug output that's
getting in my way.

(riastradh)

Pull up the following revisions, requested by msaitoh in ticket #1728:

sys/dev/pci/pci_subr.c 1.232-1.239 via patch
sys/dev/pci/pcireg.h 1.62-1.63

- Decode link control2's Compliance Preset/De-emphasis more.
- Decode Physical Layer 16.0 GT/s extended capability.
- Decode Lane Margining at the Receiver extended capability.
- Print "reserved" instead of "unknown" when printing equalization
preset. One of them is known to be the default value.
- Fix typo.

(martin)

2022-01-29 17:08:33 UTC netbsd-9 commitmail json YAML

src/sys/dev/pci/pci_subr.c@1.215.2.6 / diff / nxr@1.215.2.6
src/sys/dev/pci/pcireg.h@1.147.4.4 / diff / nxr@1.147.4.4

Pull up the following revisions, requested by msaitoh in ticket #1412:

sys/dev/pci/pci_subr.c 1.232-1.239 via patch
sys/dev/pci/pcireg.h 1.62-1.63

- Decode link control2's Compliance Preset/De-emphasis more.
- Decode Physical Layer 16.0 GT/s extended capability.
- Decode Lane Margining at the Receiver extended capability.
- Print "reserved" instead of "unknown" when printing equalization
preset. One of them is known to be the default value.
- Fix typo.

(martin)

2022-01-29 17:05:45 UTC netbsd-8 commitmail json YAML

src/sys/net/ppp_tty.c@1.63.8.1 / diff / nxr@1.63.8.1

Pull up following revision(s) (requested by msaitoh in ticket #1727):

sys/net/ppp_tty.c: revision 1.68
sys/net/ppp_tty.c: revision 1.69

Use unsigned to avoid undefined behavior in pppasyncstart().

Use unsigned to avoid undefined behavior. Found by kUBSan.

(martin)

2022-01-29 17:03:53 UTC netbsd-9 commitmail json YAML

src/sys/net/ppp_tty.c@1.65.4.1 / diff / nxr@1.65.4.1

Pull up following revision(s) (requested by msaitoh in ticket #1411):

sys/net/ppp_tty.c: revision 1.68
sys/net/ppp_tty.c: revision 1.69

Use unsigned to avoid undefined behavior in pppasyncstart().

Use unsigned to avoid undefined behavior. Found by kUBSan.

(martin)

2022-01-29 16:59:32 UTC netbsd-9 commitmail json YAML

src/sys/dev/mii/makphy.c@1.60.2.4 / diff / nxr@1.60.2.4
src/sys/dev/mii/makphyvar.h@1.2.6.1 / diff / nxr@1.2.6.1

Pull up the following revisions (all via patch), requested by msaitoh
in ticket #1410:

sys/dev/mii/makphy.c 1.67,1.69-1.72
sys/dev/mii/makphyvar.h 1.3-1.4

- Add I347-AT4 support.
- Add three workarounds for QEMU e1000:
- QEMU sets BMSR_EXTSTAT but the access to register 15 fails.
Set EXTSR_1000TFDX and EXTSR_1000THDX if the access failed in the
attach function. It's just a cosmetic change.
- Marvell 88E1[01]11 have the Fiber/Copper auto selection feature,
but QEMU doesn't implement it. If the register access failed,
the media is regarded as copper only. It's just a cosmetic change.
- QEMU provides the PHY specific status register at 0x11 but the
link indication bit (PSSR_LINK) is always 1. It causes
"virsh domif-setlink xxx yyy down" doesn't work. To avoid this
problem, read the BMSR and check the BMSR_LINK bit. Add
MAKPHY_QUIRK_PSSR_LINK bit for this quirk. Set it if MII_EXTSR
doesn't exist because it's one of the case of QEMU.
- Reduce the number of access to the ESSR register. One of the reason
is that the register is not implemented on QEMU. Another reason is
that it's not required to access the register if the device is in
the copper only mode.

(martin)

2022-01-29 16:56:18 UTC netbsd-8 commitmail json YAML

src/sys/dev/mii/igphy.c@1.26.10.3 / diff / nxr@1.26.10.3
src/sys/dev/mii/ihphy.c@1.10.8.4 / diff / nxr@1.10.8.4
src/sys/dev/mii/makphy.c@1.42.8.6 / diff / nxr@1.42.8.6

Pull up following revision(s) (requested by msaitoh in ticket #1726):

sys/dev/mii/igphy.c: revision 1.37
sys/dev/mii/ihphy.c: revision 1.19
sys/dev/mii/makphy.c: revision 1.68

Fix a bug that "ifconfig xx0 media none" set LINK_STATE_UNKNOWN instead of
LINK_STATE_DOWN.

XXX We should check for other PHY drivers, too.

(martin)

2022-01-29 16:54:42 UTC netbsd-9 commitmail json YAML

src/sys/dev/mii/igphy.c@1.31.4.2 / diff / nxr@1.31.4.2
src/sys/dev/mii/ihphy.c@1.14.4.3 / diff / nxr@1.14.4.3
src/sys/dev/mii/makphy.c@1.60.2.3 / diff / nxr@1.60.2.3

Pull up following revision(s) (requested by msaitoh in ticket #1409):

sys/dev/mii/igphy.c: revision 1.37
sys/dev/mii/ihphy.c: revision 1.19
sys/dev/mii/makphy.c: revision 1.68

Fix a bug that "ifconfig xx0 media none" set LINK_STATE_UNKNOWN instead of
LINK_STATE_DOWN.

XXX We should check for other PHY drivers, too.

(martin)

2022-01-29 16:45:49 UTC netbsd-8 commitmail json YAML

src/sys/dev/pci/ixgbe/ixgbe_vf.h@1.8.6.5 / diff / nxr@1.8.6.5
src/sys/dev/pci/ixgbe/ixv.c@1.56.2.34 / diff / nxr@1.56.2.34

Pull up the following revisions (all via patch), requested by msaitoh
in ticket #1725:

sys/dev/pci/ixgbe/ixgbe_vf.h 1.16-1.17
sys/dev/pci/ixgbe/ixv.c 1.176-1.177

Make ifconfig -z ixvN clear event counter.

(martin)

2022-01-29 16:43:23 UTC netbsd-9 commitmail json YAML

src/sys/dev/pci/ixgbe/ixgbe_vf.h@1.13.8.2 / diff / nxr@1.13.8.2
src/sys/dev/pci/ixgbe/ixv.c@1.125.2.14 / diff / nxr@1.125.2.14

Pull up the following revisions (all via patch), requested by msaitoh
in ticket #1408:

sys/dev/pci/ixgbe/ixgbe_vf.h 1.16-1.17
sys/dev/pci/ixgbe/ixv.c 1.176-1.177

Make ifconfig -z ixvN clear event counter.

(martin)

2022-01-29 16:36:07 UTC netbsd-8 commitmail json YAML

src/sys/dev/pci/ixgbe/ixgbe.c@1.88.2.46 / diff / nxr@1.88.2.46

Pull up the following revisions, requested by msaitoh in ticket #1724:

sys/dev/pci/ixgbe/ixgbe.c 1.298, 1.303 via patch

Add some missing error counters to ierror.

(martin)

2022-01-29 16:33:10 UTC netbsd-9 commitmail json YAML

src/sys/dev/pci/ixgbe/ixgbe.c@1.199.2.16 / diff / nxr@1.199.2.16

Pullup the following revisions, requested by msaitoh:

sys/dev/pci/ixgbe/ixgbe.c 1.298, 1.303 via patch

Add some missing error counters to ierror.

(martin)

2022-01-29 16:01:21 UTC MAIN commitmail json YAML

When upgrading, update the boot code post extraction from
the updated target file system.

(martin)

2022-01-29 15:32:49 UTC MAIN commitmail json YAML

Try to get rid of all wedges we created (after unmounting).

(martin)

2022-01-29 12:27:30 UTC MAIN commitmail json YAML

src/sys/dev/ic/tpm.c@1.25 / diff / nxr@1.25
src/sys/dev/ic/tpmreg.h@1.11 / diff / nxr@1.11

tpm(4): Nix TPM_BE16/TPM_BE32. Just use sys/endian.h.

(riastradh)

2022-01-29 11:20:30 UTC MAIN commitmail json YAML

src/sys/dev/scsipi/scsiconf.c@1.297 / diff / nxr@1.297

In some cases the gcc optimizer is not smart enough to figure out why
the luns and nluns variables are never actually used when they are not
initialized - so initialize them always.

(martin)

2022-01-29 10:44:40 UTC MAIN commitmail json YAML

src/usr.bin/make/test-variants.sh@1.15 / diff / nxr@1.15

tests/make: clean up variants that are tested

Since main.c 1.373 from 2020-10-18, make does not use iovec anymore, so
remove that test variant.

Document the details of why generating the test coverage took so long on
NetBSD < 10.

Add another test variant with optimization for binary size (-Os), since
with that option, GCC 10 does not perform the same data flow analysis as
with -O2, in particular it gets confused about whether local variables
are correctly initialized across function calls.

(rillig)

2022-01-29 10:21:26 UTC MAIN commitmail json YAML

src/usr.bin/make/unit-tests/var-recursive.mk@1.4 / diff / nxr@1.4

tests/make: sync comment in test for recursive variable

(rillig)

2022-01-29 10:19:49 UTC MAIN commitmail json YAML

make: for recursive variables in commands, print location

Print the approximate location based on the last command that has been
defined for the target. It would be possible to get more detailed
location information by counting the number of commands of the target,
but that would get messy due to .USEBEFORE, .USE and .DEFAULT, and
still, this is an edge case, so don't waste too much code for it now.
Having this hint about the location is more helpful than just a plain
"Variable X is recursive" without any further details.

(rillig)

2022-01-29 10:09:37 UTC MAIN commitmail json YAML

src/usr.bin/make/unit-tests/var-recursive.exp@1.4 / diff / nxr@1.4
src/usr.bin/make/unit-tests/var-recursive.mk@1.3 / diff / nxr@1.3

tests/make: demonstrate recursive variable in target

(rillig)

2022-01-29 09:38:27 UTC MAIN commitmail json YAML

make: print stack trace on fatal errors

The only fatal error that occurs while the makefiles are read in is the
one about recursive variables, which didn't give any hint about the
location before.

If a recursive variable is detected while evaluating the commands of a
target to be made, there is no location information, as before.

(rillig)

2022-01-29 08:20:45 UTC MAIN commitmail json YAML

src/usr.sbin/cpuctl/arch/i386.c@1.127 / diff / nxr@1.127

Decode Intel Hybrid Information Enumeration (CPUID Fn0000_001a).

(msaitoh)

2022-01-29 08:18:22 UTC MAIN commitmail json YAML

src/sys/arch/x86/include/specialreg.h@1.188 / diff / nxr@1.188

Add Intel Hybrid Information Enumeration (CPUID Fn0000_001a).

(msaitoh)

2022-01-29 08:17:04 UTC MAIN commitmail json YAML

src/sys/dev/ic/spdmem.c@1.37 / diff / nxr@1.37

Add code for DDR5 a little. I have no datasheet.

(msaitoh)

2022-01-29 08:14:24 UTC MAIN commitmail json YAML

src/sys/dev/ic/spdmem.c@1.36 / diff / nxr@1.36
src/sys/dev/ic/spdmemreg.h@1.5 / diff / nxr@1.5

Add LPDDR4X and DDR5. Not decoded yet.

(msaitoh)

2022-01-29 07:42:10 UTC MAIN commitmail json YAML

src/usr.bin/make/make.1@1.303 / diff / nxr@1.303

Document quirks of target local variable assignments

(sjg)

2022-01-29 01:19:30 UTC MAIN commitmail json YAML

src/sys/dev/wscons/wsdisplayvar.h@1.56 / diff / nxr@1.56

Default WSDISPLAY_BORDER_COLOR to WS_DEFAULT_BG.
Avoids black overscan area when WS_DEFAULT_BG is set.

(uwe)

2022-01-29 01:12:37 UTC MAIN commitmail json YAML

src/usr.bin/make/cond.c@1.327 / diff / nxr@1.327

make: rename labels in CondParser_Leaf

No binary change.

(rillig)

2022-01-29 01:07:32 UTC MAIN commitmail json YAML

src/usr.bin/make/make.h@1.292 / diff / nxr@1.292
src/usr.bin/make/parse.c@1.658 / diff / nxr@1.658
src/usr.bin/make/var.c@1.1007 / diff / nxr@1.1007

make: inline functions that have a single call site

No functional change.

(rillig)

2022-01-29 00:52:53 UTC MAIN commitmail json YAML

src/usr.bin/make/unit-tests/check-expect.lua@1.2 / diff / nxr@1.2
src/usr.bin/make/unit-tests/var-scope-local.exp@1.3 / diff / nxr@1.3
src/usr.bin/make/unit-tests/var-scope-local.mk@1.3 / diff / nxr@1.3

tests/make: extend and isolate tests for target-local variables

Reusing the target var-scope-local.o for several tests made the test
more difficult to understand than necessary. The test names '2' and '3'
didn't convey any meaning.

Instead, add more test targets that are named after what they test. Add
tests for each of the 5 variable assignment operators, to demonstrate an
inconsistency between '+=' and '?='.

Add tests for the built-in target-local variables as well and explain
the general concepts, in particular the exact point where target-local
expressions are expanded.

The lines in the expected output file are not generated in the same
order as they appear in the makefile, so allow the 'expect' lines in
non-linear order, in check-expect.lua.

(rillig)

2022-01-29 00:03:42 UTC MAIN commitmail json YAML

src/lib/librefuse/refuse_log.c@1.2 / diff / nxr@1.2

librefuse: default_log_func is __printflike

(tnn)

2022-01-28 20:00:52 UTC MAIN commitmail json YAML

src/sys/fs/udf/udf_allocation.c@1.45 / diff / nxr@1.45

On freeing a virtual address in the VAT, use the correct value; this might
confuse other implementations who can reject the VAT on this.

(reinoud)

2022-01-28 19:38:51 UTC MAIN commitmail json YAML

src/usr.sbin/sysinst/main.c@1.29 / diff / nxr@1.29

sysinst: sync usage with man page

(wiz)

2022-01-28 19:36:00 UTC MAIN commitmail json YAML

src/usr.sbin/sysinst/sysinst.8@1.5 / diff / nxr@1.5

Sort options and their descriptions.

(wiz)

2022-01-28 19:28:09 UTC MAIN commitmail json YAML

src/usr.sbin/sysinst/sysinst.8@1.4 / diff / nxr@1.4

Document the missing command line options.

(martin)

2022-01-28 19:27:43 UTC MAIN commitmail json YAML

src/usr.sbin/sysinst/main.c@1.28 / diff / nxr@1.28

Add an option to set the directory where we look for message catalogs.

(martin)

2022-01-28 18:23:28 UTC MAIN commitmail json YAML

src/sys/dev/scsipi/scsiconf.c@1.296 / diff / nxr@1.296

Factor out the lun detection code to simplify control flow.

(christos)

2022-01-28 16:38:56 UTC MAIN commitmail json YAML

src/sys/arch/evbarm/conf/GENERIC@1.105 / diff / nxr@1.105
src/sys/arch/evbarm/conf/GENERIC64@1.193 / diff / nxr@1.193

drop WSDISPLAY_CUSTOM_BORDER, it's currently only used by vga(4) which isn't used on evbarm

(jakllsch)

2022-01-28 14:02:45 UTC MAIN commitmail json YAML

src/sys/dev/scsipi/scsiconf.c@1.295 / diff / nxr@1.295

shut up GCC about possibly-uninit; some KNF

(jakllsch)

2022-01-27 21:50:50 UTC MAIN commitmail json YAML

src/usr.bin/make/unit-tests/Makefile@1.302 / diff / nxr@1.302
src/usr.bin/make/unit-tests/opt-debug-hash.exp@1.4 / diff / nxr@1.4

numEntries can vary

(sjg)

2022-01-27 20:15:14 UTC MAIN commitmail json YAML

src/usr.bin/make/unit-tests/directive-for-escape.exp@1.16 / diff / nxr@1.16
src/usr.bin/make/unit-tests/directive-for-escape.mk@1.15 / diff / nxr@1.15

tests/make: add more edge cases for expansion of .for loop body

(rillig)

2022-01-27 18:44:49 UTC MAIN commitmail json YAML

src/sys/dev/scsipi/sd.c@1.333 / diff / nxr@1.333

use powerof2() in sd_validate_blksize()

(jakllsch)

2022-01-27 18:38:07 UTC MAIN commitmail json YAML

src/sys/dev/pci/vioscsi.c@1.29 / diff / nxr@1.29

We no need for PQUIRK_FORCELUNS now that we try REPORT LUNS.

(jakllsch)

2022-01-27 18:37:02 UTC MAIN commitmail json YAML

src/sys/dev/scsipi/scsi_spc.h@1.7 / diff / nxr@1.7
src/sys/dev/scsipi/scsiconf.c@1.294 / diff / nxr@1.294

Try REPORT LUNS command to enumerate logical units.

(jakllsch)

2022-01-27 18:07:27 UTC MAIN commitmail json YAML

src/sys/dev/ic/rtl8169.c@1.170 / diff / nxr@1.170

drop poorly phrased and redundant message about unsupported chip revisions

(jakllsch)

2022-01-27 14:39:49 UTC MAIN commitmail json YAML

src/sys/arch/evbarm/conf/GENERIC@1.104 / diff / nxr@1.104
src/sys/arch/evbarm/conf/GENERIC64@1.192 / diff / nxr@1.192

enable WSDISPLAY_CUSTOM_BORDER and WSDISPLAY_CUSTOM_OUTPUT to match i386 GENERIC

(jakllsch)

2022-01-27 14:18:40 UTC MAIN commitmail json YAML

src/sys/modules/if_wg/Makefile@1.2 / diff / nxr@1.2

Turn off ALTQ in if_wg module, to match default kernel configs

(jakllsch)

2022-01-27 11:26:44 UTC MAIN commitmail json YAML

src/usr.bin/make/unit-tests/directive-for-escape.exp@1.15 / diff / nxr@1.15
src/usr.bin/make/unit-tests/directive-for-escape.mk@1.14 / diff / nxr@1.14

tests/make: explain escaping in .for loops, add more test cases

(rillig)

2022-01-27 11:16:44 UTC MAIN commitmail json YAML

src/usr.bin/make/for.c@1.166 / diff / nxr@1.166

make: clean up AddEscape for building the body of a .for loop

Adding 1 + len bytes but only incrementing the pointer by len bytes
looked suspicious, so use the same expression in both places.

No functional change.

(rillig)

2022-01-27 11:00:07 UTC MAIN commitmail json YAML

src/usr.bin/make/hash.c@1.71 / diff / nxr@1.71

make: merge duplicate code for finding an entry in a hash table

No functional change.

(rillig)

2022-01-27 10:45:36 UTC MAIN commitmail json YAML

src/usr.bin/make/hash.c@1.70 / diff / nxr@1.70

make: replace HashEntry_KeyEquals with strncmp

No functional change.

(rillig)

2022-01-27 10:42:02 UTC MAIN commitmail json YAML

src/usr.bin/make/unit-tests/varname.mk@1.9 / diff / nxr@1.9

tests/make: test hash code collisions of variable names

In HashEntry_KeyEquals, the line 'return false' was not covered by any
tests before. Since it is an edge case that two variable names (or
other keys) have the same 32-bit hash code and still differ, better test
for that edge case explicitly since a bug in this place would be rare
and hard to find.

(rillig)

2022-01-27 10:34:55 UTC MAIN commitmail json YAML

src/usr.bin/make/parse.c@1.657 / diff / nxr@1.657

make: remove trailing whitespace, break lines

No binary change, except for assertion line numbers.

(rillig)

2022-01-27 09:53:43 UTC MAIN commitmail json YAML

src/usr.sbin/cpuctl/arch/i386.c@1.126 / diff / nxr@1.126

Remove debug code and simplify. No functional change.

(msaitoh)

2022-01-27 06:56:27 UTC MAIN commitmail json YAML

src/usr.bin/make/unit-tests/var-scope-local.exp@1.2 / diff / nxr@1.2
src/usr.bin/make/unit-tests/var-scope-local.mk@1.2 / diff / nxr@1.2

Unit test for local variables

(sjg)

2022-01-27 06:02:59 UTC MAIN commitmail json YAML

Allow local variable assignments in dependency lines

The variable is set in the context of the target.
This syntax has been supported by gmake for ~ever.
If necessary a makefile can set .MAKE.TARGET_LOCAL_VARIABLES=false
to disable this.

Expose GetBooleanExpr so parse.c can use it.

(sjg)

2022-01-27 02:34:23 UTC MAIN commitmail json YAML

src/sys/arch/arm/sociox/if_scx.c@1.36 / diff / nxr@1.36

always use mac_write/read to handle DWC registers

(nisimura)

2022-01-27 02:24:46 UTC MAIN commitmail json YAML

src/usr.bin/make/unit-tests/Makefile@1.301 / diff / nxr@1.301
src/usr.bin/make/unit-tests/opt-where-am-i.mk@1.4 / diff / nxr@1.4

Do not allow /usr/obj to cause failure.

(sjg)

2022-01-26 23:00:55 UTC MAIN commitmail json YAML

src/usr.bin/make/Makefile@1.121 / diff / nxr@1.121

make: generate coverage summary on 'make test-coverage'

(rillig)

2022-01-26 22:47:03 UTC MAIN commitmail json YAML

tests/make: test meta mode in jobs mode

(rillig)

2022-01-26 22:19:25 UTC MAIN commitmail json YAML

src/usr.bin/make/unit-tests/depsrc-meta.mk@1.5 / diff / nxr@1.5

tests/make: remove unnecessary conditional processing for meta test

The .if/.else distracted from the main topic of the test and made it too
hard to see the main targets.

(rillig)

2022-01-26 20:22:14 UTC MAIN commitmail json YAML

src/sbin/dump/traverse.c@1.55 / diff / nxr@1.55

PR/56643: Paul Goyette: Disable the last block adjustment for now. It seems
to break restore.

(christos)

2022-01-26 19:19:13 UTC MAIN commitmail json YAML

src/doc/3RDPARTY@1.1833 / diff / nxr@1.1833

postfix-3.6.4 is out.

(wiz)

2022-01-26 18:57:56 UTC MAIN commitmail json YAML

src/sys/arch/mips/cavium/dev/octeon_uart.c@1.10 / diff / nxr@1.10

Fix initialization of the register map by using the com_init_regs()
helper function. Pointed out by jmcneill.

(martin)

2022-01-26 16:49:06 UTC MAIN commitmail json YAML

src/sys/dev/usb/ehci.c@1.301 / diff / nxr@1.301

shut up an unused variable warning
apparently clang gets confused by bus_dmatag_subregion() being EOPNOTSUPP
on powerpc

(macallan)

2022-01-26 12:41:26 UTC MAIN commitmail json YAML

src/usr.bin/make/meta.c@1.194 / diff / nxr@1.194

make: clean up eat_dots for meta mode, part 2

At least on OpenBSD, "If the src and dst strings overlap, the behavior
is undefined" (since 2013-09-25), so rather use memmove instead.

Keep all other bugs for now, for example "/a/b//../" is reduced to
"/a/b/" instead of the correct "/a/", and for repeated "/././././" in
long paths, the performance is quadratic instead of linear.

Inline the two calls to eat_dots, turning the first into a two-liner.

(rillig)

2022-01-26 12:16:03 UTC MAIN commitmail json YAML

src/usr.bin/make/meta.c@1.193 / diff / nxr@1.193

make: clean up eat_dots for meta mode

No binary change.

(rillig)

2022-01-26 11:48:54 UTC MAIN commitmail json YAML

remove double t from targeted, add missing r to arbitrary
And fix few more typos along the way in comments and man pages.

(andvar)