Move CPUID_CAPEX_FLAGS next to %eax because it's for %eax.

(msaitoh)

No functional change.

- Modify comment. Add comment. Fix typo. Mainly taken from dragonfly.
- Use __BIT().

(msaitoh)

make: remove trailing whitespace in meta.c

(rillig)

sort

(skrll)

Remove unnecessary brackets

(skrll)

The translations that need invalidation are always last level so remove
the (dubious) logic around tracking the level.  The "any level" TLB
invalidation maintenance operation are used, but this may change after
further testing.

before
======
1661.0u 420.2s 2:53.82 1197.3% 231+29k 10+33918io 102pf+0w
1646.8u 425.2s 2:52.96 1198.0% 232+29k 1+33937io 49pf+0w
1647.9u 425.7s 2:52.58 1201.6% 232+29k 0+33940io 32pf+0w

After
=====
1602.5u 420.8s 2:49.09 1196.6% 238+30k 24+33893io 54pf+0w
1600.7u 421.3s 2:51.53 1178.8% 238+30k 1+33914io 33pf+0w
1597.5u 424.3s 2:50.46 1186.1% 238+30k 0+33915io 17pf+0w

LGTM from ryo@

(skrll)

Whitespace

(skrll)

Trailing whitespace

(skrll)

update header too.

(christos)

The "ibm" and "oldibm" tables are identical, because POSIX just
standardised the table from V7. Nobody, including the original authors,
seems to have noticed this.  Merge them and update the documentation.
Also fix the odd, inconsistent, spelling of "pre-4.3BSD-Reno").
(From nabijaczleweli)

(christos)

Fix emul and exe DT_ types (from RVP, as was the previous commit)

(christos)

etcupdate(8): consistent -h and -? text

(lukem)

ihidev(4): Prohibit closing an unopened ihidev.

(riastradh)

ihidev(4): Avoid reference count overflow.

(riastradh)

ims(4): Sprinkle KERNEL_LOCKED_P assertions.

Access to the softc and hidms state is currently kernel-locked.

(riastradh)

ihidev(4): Take the lock for ihidev_open, ihidev_close.

Need this to serialize access to sc_state, sc_refcnt.

XXX Should harmonize this with uhidev(4) and tighten assertions.

(riastradh)

ihidev(4): Check kmem_alloc(..., KM_NOSLEEP) for failure.

(riastradh)

ihidev(4): Allocate report buffer with KM_SLEEP.

Limited to 64k and only happens on attach anyway.  Let's not leave a
rake to trip on here.

(riastradh)

ihidev(4): Fix locking and interrupt handler.

- Can't run iic_exec in softint because it does cv_wait, at least on
  some i2c controllers -- defer to workqueue instead.

- Fix violations of locking rules:
  . Do not take a lock at higher IPL than it is defined at!
  . Do not sleep under a lock!
  . Definitely do not sleep under a spin lock!
  In this case, sc_intr_lock was defined at IPL_VM but used at IPL_TTY,
  and i2c transactions -- possibly causing sleep for cv_wait -- were
  issued under it.

  But in this case, the interrupt handler needs only a single bit to
  mark whether the work is pending, so just use atomic_swap for that.

- Use an adaptive lock (IPL_NONE) for i2c transactions.

- Detach children, and do so before freeing anything.

(riastradh)

genfs(9): Prune dead branch.

(riastradh)

ihidev(4): Add missing includes and header guard.

Mark the sections that are conventionally separate files for hardware
interface (*reg.h) versus software state (*var.h).

(riastradh)

don't blindly enable memory and IO access on macppc

(macallan)

add flag to disable blindly enabling memory and IO access on everything we
find

(macallan)

Add unit-test for .MAKE.META.CMP_FILTER

(sjg)

This is a temporary hack to avoid nfs crashes related to nfs_delaytruncate.

(christos)

meta_cmd_cmp: use bool for once

Just use Buf_Init() some mallocs will be inevitable.

(sjg)

Put the appropriate DT_ constant in the dirent structure depending on the
file type.

(christos)

make: inline EvalBare

No functional change.

(rillig)

Update for cpuid flags:

- The table 11 was changed from CPUID 0x0f leaf 0 %edx to a Linux mapping.
- The table 12 was changed from CPUID 0x0f leaf 1 %edx to CPUID 0x07 leaf 1
  %edx. Print avx_vnni and avx512_bf16.
- Print cppc, enqcmd and arch_lbr.
- Modify linux mapping. No used on NetBSD.

(msaitoh)

Add Architectural LBR and Linear Address Masking.

(msaitoh)

Both Intel and AMD says the name of CPUID 0x01 %edx bit 19 is "CLFSH".

(msaitoh)

Don't use __printflike, use the explicit attribute so that this works outside
NetBSD.

(christos)

libedit: rl_message: annotate __printflike

(tnn)

Formatting. NFCI.

(skrll)

Trailing whitespace

(skrll)

Restore the previous pmap_remove_all behaviour as the new method meant
the n1sdp couldn't complete a build.

No noticeable change in kernel build performance.

(skrll)

Add some CPUID bits from the latest Intel SDM.

- Last Branch Record.
- Thread Director.
- AVX version of VNNI.
- Fast short REP MOV.
- HRESET.
- PPIN.

(msaitoh)

Add Alder Lake, Rocket Lake and Sapphire Rapids. From the latest Intel SDM.

(msaitoh)

sysinst(8): use scan_ssid=1 so hidden wifi networks can be used

(nia)

bump

(skrll)

meta.c: add .MAKE.META.CMP_FILTER

On rare occasions it is useful to be able to filter command lines
before comparison.

(sjg)

Use __BIT(). KNF. No functional change.

(msaitoh)

A few more sysinst message catalog adjustments

(martin)

Ignore new APC UPS devices when matching uhid devices.

(martin)

regen (new APC UPS device id)

(martin)

Add a new APC UPS device id.

(martin)

Fix to call lacp_linkstate with IFNET_LOCK held

Network stack calls lacp_linkstate through lagg_port_ioctl when
doing "ifconfig up" or "ifconfig down" to an interface that is
a member of lagg(4). And IFNET_LOCK in the member interface
is held while the ioctl.
Therefore, lacp_linkstate is renamed to
lacp_linkstate_ifnet_locked, and always called with IFNET_LOCK
held. It avoids locking agains myself.

(yamaguchi)

lagg(4): Need to take IFNET_LOCK around if_init.

This should really just avoid dropping IFNET_LOCK before it's done
changing the port interface's configuration, but this stop-gap change
will serve provisionally to reduce crashes until we can confirm that
there's no deadlock lurking in the time this logic drops IFNET_LOCK.

(riastradh)

remove redundant error initialization and break earlier. (from rvp)

(christos)

fix few typos in comments.

(andvar)

acpi: sdhc: Support sdhci-caps and sdhci-caps-mask properties.

(jmcneill)

tests/make: clean up after test for option '-dF'

When the file for the debug log cannot be opened, make exits
immediately.  This doesn't give the test a chance to clean up the
temporary log file.

Instead of trying to treat a regular file as a directory and create a
file in it, assume that the directory /nonexistent-$uuid is actually
nonexistent.  This leads to the same kind of error message, independent
of strerror(3).

(rillig)

Tweak some sysinst catalog files

(martin)

PR/56618: Walter Lozano: Improve libedit compatibility with readline by
implementing:

    rl_copy_text, rl_erase_empty_line, rl_message, rl_on_new_line,
    rl_replace_line, rl_restore_prompt, rl_save_prompt

(christos)

Use a single "p" variable.

Should fix PR kern/56614: kernel panic on tmux

(hannken)

acpi: ged: Mask interrupts before dispatching handler

For the benefit of GEDs backed by level interrupts, mask the interrupt
source before dispatching the handler to a worker thread and unmask it
after it has been handled.

(jmcneill)

doc: sysinst WLAN changes

(nia)

sysinst(8): Add a "data" argument to do_ifreq that is set after the
ifr struct is zeroed.

This allows us to simplify the code by not having 2x socket creation
code for checking whether interfaces are wireless.

(nia)

use a single nc variable.

(christos)

Fix locking in the error path (from RVP). Centralize unlock code.

(christos)

sysinst(8): Avoid asking Wi-Fi questions about non-Wi-Fi devices.

(nia)

make: add debug logging for capturing the output of external commands

This applies to all 4 situations in which the output of an external
command is used for modifying a variable or an expression:

* the assignment operator '!='
* the assignment modifier '::!='
* the SUN shell modifier ':sh'
* the other shell modifier ':!cmd!'

Previously, only the shell modifier ':!cmd!' had debug logging.

Suggested by Christoph Badura.

(rillig)

sun4v: add function to retrieve hypervisor api version

(palle)

read the ps arguments from the correct place.

(christos)

Get rid of usrstack/USRSTACK. Document that the old version of getargv is
broken because of ASLR.

(christos)

Add sysinst message catalogs

(martin)

Use p->p_stackbase instead of USRSTACK because the stackbase can move because
of ASLR.

(christos)

Add sysinst catalogs to a few more md lists

(martin)

Add sysinst catalog files

(martin)

sysinst(8): Add initial support for connecting to Wi-Fi networks
by spawning wpa_supplicant.

Reviewed by martin.

(nia)

"Unobsolete" the sysinst message catalogs, now that we install them again.

(martin)

Fix alpha build

(skrll)

Typo in a comment

(khorben)

tests/make: add placeholders for .PARSEDIR and .INCLUDEDFROMDIR

When run via 'cd usr.bin/make/unit-tests && make test', the tests are in
the current directory.  When run via ATF, the tests are in
/usr/tests/usr.bin/make/unit-tests, while the current directory is a
temporary directory.  Allow both variants, plus others that may occur in
the bmake distribution.

(rillig)

sun4v: enable sun4v_intr_xxx() function previously imported from OpenBSD. Note that the sun4v_intr_devino_to_sysino() function is adapted to match OpenBSD version 1.57 (the introduction of INTR_DEVINO is done in revision 1.58)

(palle)

tests/make: ensure that '.ifn' is an unknown directive

Due to the way DetermineKindOfConditional works, it could have been that
'.ifn' is treated like the negation of the plain '.if'.

(rillig)

make: add missing printflike annotations to parse.c

Clang is stricter than GCC in checking format string inconsistencies.
Reported by Tobias Nygren.

(rillig)

make: extract low-level character operations into utility function

Suggested by nia.
https://mail-index.netbsd.org/source-changes-d/2022/01/09/msg013564.html

No functional change.

(rillig)

make: in Cmd_Exec, return error message instead of format string

This change leaves only literal format strings in parse.c.  It allows
for more detailed error messages than the current "non-zero status" or
"exited on a signal".

No functional change.

(rillig)

uvideo(4): Fix USB interface numbering.

Don't try to be clever and count -- just use bInterfaceNumber.

The previous logic to count interface descriptors failed to consider
interfaces with alternate settings, which led it to pass an invalid
interface number to usbd_device2interface_handle.

It is simpler to just use the recorded bInterfaceNumber, which is
guaranteed by the USB spec to be zero-indexed and below
bNumInterfaces as we need.

(riastradh)

tests/make: demonstrate inconsistencies in Cmd_Exec callers

The assignment 'VAR != cmd' generates a warning, the others generate an
error message.  That error message is ignored for backwards
compatibility though.

The assignment via the expression ${VAR::!=cmd} only uses the output of
the command if there was no error, the other places use the output
nevertheless.

(rillig)

First try (certainly wrong for many builds) to add sysinst catalog files.

(martin)

make: shorten ApplyModifier_Assign

No functional change.

(rillig)

Install sysinst message catalogs.

(martin)

make: use consistent variable names for varargs

No binary change.

(rillig)

tests/make: test output channels for parse errors and other errors

(rillig)

dwcmmc: Add ACPI attach support

(jmcneill)

dwcmmc: Add support for card detect using SDMMC_CDETECT register

(jmcneill)

acpi: Add acpi_dsd_bool helper

(jmcneill)

make: fix crash for newline in .for value in -dp mode (since yesterday)

(rillig)

updates for xkeyboard-config 2.34.

(mrg)

make: fix use-after-free in -dp mode (since yesterday)

In a .for loop that contains an unclosed .if directive,
Cond_restore_depth generates an error message.  If stack traces are
enabled using the option '-dp', the details of the .for loop are added
to the stack trace, but at that point, the ForLoop had already been
freed.  To reproduce:

make-2022.01.09.00.33.57 -r -f unit-tests/directive-for.mk -dp

(rillig)

make: remove redundant lines from stack traces

These lines repeated the information from the .for loop line above them.

(rillig)

make: in ApplyDependencySourceWait, align variable type with %u

No binary change.

(rillig)

merge xkeyboard-config 2.34.

(mrg)

merge xauth 1.1.1 and xterm 370.

(mrg)

merge libXi 1.8 and libdrm 2.4.109.

updated generated_static_table_fourcc.h generated with:

  python3.9 gen_table_fourcc.py include/drm/drm_fourcc.h ../include/generated_static_table_fourcc.h

(mrg)

Use comp-sysutil-debug (not sysutils)

(skrll)

Match verb forms.

(wiz)

Remove unnecessary machine=emips item - it was added to
distrib/sets/lists/debug/md.emips

(skrll)

Let user gracefully abort recording with SIGINT.

(mlelstv)

etcupdate: add -? for help. improve option errors

Support -? to show help.
Implemented using getopts "leading colon optstring" feature.
Improve error messages for unknown options and missing arguments.
Change usage-related errors from stdout to stderr.
Keep all other errors to stdout for now.

(lukem)

etcupdate: -h to stdout. improve help

Send -h help to stdout not stderr, and exit 0 not 1.
Show options alphabetically.
Use UPPER_CASE instead of lowercase as the convention for argument names.

(lukem)

etcupdate: style change: function { on new line

(lukem)

eqos: handle the GMAC_MTL_INTERRUPT_STATUS register having something

drain a couple of registers that want either a read or a write-1-to-
clear bit, and keep track of how many happen via evcnt.

i had this trigger one time, but not since adding instrumentation to
see exactly it was saying (the GMAC_MTL_INTERRUPT_STATUS_Q0IS bit was
set, and it requires some handling now implemented.)

ok jmcneill

(mrg)

make: remove redundant parameter from ForLoop_SubstVarLong

The buffer of a .for loop is always either empty or ends with '\n'.  A
variable name consists of arbitrary non-whitespace characters.
Therefore a variable name can never reach the end of the buffer.

No functional change.

(rillig)

postinstall(8); add -?. expand operation usage

(lukem)

make: add details about .for loop variables to stack traces

The stack traces are enabled with the debug logging option '-dp'.

(rillig)

make: fix stack traces in -dp mode (since 2021-01-26)

Previously, the stack traces omitted some lines that seemed to be
redundant.  As a result, the stack traces contained confusing line
numbers.

(rillig)

postinstall: improve -s usage

Reword -s SRC_ARG to be a bit clearer as to the variations, and sync
more with postinstall(8).

(lukem)

postinstall: tweak -a and -m usage

(lukem)

postinstall: add -? to usage

(lukem)

make: reduce confusing code in ParseForLoop

The previous version of the code gave the wrong impression that For_Eval
would modify CurFile.  That happens only later, in For_Run.

No functional change.

(rillig)

eqos: interrupt evcnt and minor fix

there's basic interrupt evcnt, which is the parent for the rx and
tx interrupts, and 3 status interrupts, one of which has 7 more
subtypes (watchdog timeout, carrier missing/lost, etc.)  as these
cases are evcnt counted now, make some debugging default off.

avoid removing bits from dma_status when rx/tx is handled, so that
later check of dma_status for non-zero does not trip.  the two bits
in dma_status removed are never checked again besides the test that
may have failed (but probably doesn't as at least one other bit in
two other variables will be set.)

ok jmcneill

(mrg)

make: fix line number in debug log after returning from a file

The parser returns to the next line, not to the current line.

(rillig)

tests/make: test line numbers in debug output for parsing files

(rillig)

make: return early from SkipIrrelevantBranches

No functional change.

(rillig)

make: fix reported line numbers of continuation lines (since 2002)

Previously, multi-line directives like '.info' or '.error' reported the
line number of their last line instead of their first line, which is
more usual.  This also affected the debug log from '-dp'.

(rillig)

urlphy(4): Fix missing mii locking in urlphy_attach.

(riastradh)

ukbd(4): Fix previous change to initial LED flashing.

Without this change the LEDs would get stuck on until the first
keypress.  (This also seemed to trigger a crash in heavy load on
bringing aue(4) up and down over and over again while unplugging, but
I'm not sure why and I hope it's not actually related...)

(riastradh)

make: inline Buf_Clear

No functional change.

(rillig)

fix emips

(christos)

Ticket #1723

(martin)

Pull up following revision(s) (requested by jnemeth in ticket #1723):

sys/conf/copyright: revision 1.20

Welcome to 2022!

(martin)

Ticket #1401

(martin)

Pull up following revision(s) (requested by jnemeth in ticket #1401):

sys/conf/copyright: revision 1.20

Welcome to 2022!

(martin)

place additional parens around multiline string constant to appease clang

(tnn)

make: rename is_shell_metachar, fix character conversion warning

No binary change.

(rillig)

tests/make: demonstrate edge case in parsing .for loops

(rillig)

make: constify UnescapeBackslash, fix typo in comment

No binary change.

(rillig)

make: remove redundant braces

No binary change, except for assertion line numbers.

(rillig)

defflag FCOM_INIT_ARM

(skrll)

KNF

(skrll)

Make VERBOSE_ARM32 compile again and reduce #ifdefs while I'm here

(skrll)

Attempt to fix emips build

(skrll)

postinstall: add -?. improve option errors

Support -? to show help.
Implemented using getopts "leading colon optstring" feature.
Improve error messages for unknown options and missing arguments.

(lukem)

postinstall: usage improvements

Show options alphabetically.
Use UPPER_CASE instead of lowercase as the convention for argument names.
Provide per-OPERATION argument usage.
Implement options alphabetically.

(lukem)

postinstall: improve validation and help

Validate the operation and items before extracting any etc.tgz,
so that help or errors are displayed quicker, for a better user
experience.

Style:
- Rename todo to ITEMS.
- Order processing of list after check.
- Ensure DIFF_OPT is initialised, for consistency.

(lukem)

postinstall: style tweaks

Fix ... in comments and internal errors.
Sort variables declared at top of main(), for easier review.

(lukem)

postinstall: help to stdout. usage tweaks

When invoked as "help" or "usage", send the usage to stdout
instead of stderr, so that it's easier to pipe to a pager.

Explicitly warn that the operation is missing.

Tweak the usage; "operation" instead of "op", no need for [] around ...

(lukem)

Use += for SRCS list

(pgoyette)

Remove extra blank line

(pgoyette)

Use \t for pre-comment white-space

(pgoyette)

make: clean up structure of For_Eval

Put related decisions on the same indentation level, remove unnecessary
negation, keep the code for the '.for' directive together.

No functional change.

(rillig)

s/udpate/update/

(andvar)

make: remove redundant condition in ParseRawLine

The input buffer is guaranteed to be terminated by '\n'.  This means
that after a '\\', there is no need to check for the end of that buffer.

While here, condense ReadLowLevelLine.

No functional change.

(rillig)

make: rename local variable in ParseRawLine

The previous variable name suggested that the variable would point to
the first '#' character of the line, instead it points to the whitespace
before the first '#'.

No functional change.

(rillig)

make: condense UnescapeBackslash

No functional change.

(rillig)

make: in loadfile, use simpler magic numbers

No functional change.

(rillig)

make: have as few statements as possible between va_start and va_end

No functional change.

(rillig)

make: remove redundant function parameter in suffix handling

Now that mainNode is globally visible, there is no need to pass it
through function parameters.

No functional change.

(rillig)

make: merge duplicate variables for the main target

No functional change.

(rillig)

make: clean up comments, variable names, function names

The comment in ApplyDependencySourceOther repeated the code, its second
half didn't match any current code.

The comment above ParseDependencySourcesEmpty repeated the code.

No binary change, except for assertion line numbers.

(rillig)

make: clean up handling of .for loops

Sort ForLoop members in natural reading order.

Remove redundant condition in ForLoop_ParseItems; at that point, the
number of variables is non-zero.

Rename Buf_AddEscaped since that function is not part of the Buffer API,
it is specific to .for loops.

No functional change.

(rillig)

make: eliminate file-scope variable forLevel

No functional change.

(rillig)

make: use simpler code for handling .for loops

Since the body of a .for loop is scanned from start to end, there is no
need to remember the length of a variable name.

Using memcmp for comparing the variable name was probably overkill since
the variable names are usually very short, so rather compare them byte
by byte.

No functional change.

(rillig)

tests/make: fix documentation in cond-func.mk

(rillig)