Added more field definitions for ARMv8.x system registers

(ryo)

macroify. NFC.

(ryo)

QEMU e1000's PHY code doesn't reflect the PSSR_LINK bit. Do workaround.

  IEEE 802.3 clause 22's PHY device has a link status bit in the BMCR
  register, but it's required to read twice to get the correct value.
  Almost all PHY devices have the vendor specific register which has
  the link status bit that it's not required to read twice. makphy(4)
  use the bit in the PSSR register to reduce the access cost.

  QEMU's e1000 provides the PHY specific status register at 0x11 but the
  link indication bit (PSSR_LINK.) is always 1 because
  e1000x_update_regs_on_link_{down,up}() modify MII_SR_LINK_STATUS
  (BMSR_LINK in NetBSD) but don't modify PSSR_LINK. It causes
  "virsh domif-setlink xxx yyy down" doesn't work.
  To avoid this problem, read the BMSR and check the BMSR_LINK bit. Add
  MAKPHY_QUIRK_PSSR_LINK bit for this quirk. Set it if MII_EXTSR doesn't
  exist because it's one of the case of QEMU.

  Found and tested by ozaki-r.

(msaitoh)

Properly size and array to hold the larget return from wctomb.

(blymn)

err.h: dead once is dead enough

Per joerg's advice keep the __dead in front position as it is where
_Noreturn would go.

(uwe)

remove DIAGNOSTIC so that function is defined for KASSERTMSG. Hope that the
compiler removes it.

(christos)

fix ID_AA64ISAR0_EL1.ATOMIC field definition

(ryo)

fix typos, mainly s/comand/command/

(andvar)

Use a volative local shadow of a field in an (on-stack) non-volatile struct
that is to be referenced after a return from setjmp() via longjmp().

This doesn't ever seem to have caused a problem, but I think using
volative vars is required here.

For reasons I never bothered to discover, even though this change
certainly requires a store into stack memory which wasn't required
before, earlier measurements showed the shell getting (slightly) smaller
with this change in place.

NFCI

(kre)

Install the missing sh syntax element in the MKDEBUGKERNEL = no test, so
that "continue" is a command as intended, and not an invalid last arg to
the '[' command (the last arg is required to be ']').

Sometime the proverbial someone should go through this and remove all the
obsolete test -o and -a operators, and probably do something with test's
usage of ! as well.  Not today, or not by me anyway.

(kre)

s/compnent/component/

(andvar)

exec(3): execlpe() first argument should be named "file"

"path" arguments are names used as-is, "file" arguments to "p"
functions are used to construct the pathname using $PATH if necessary.

(uwe)

use a function "runit" to echo and execute avoiding set -x.

(christos)

getopt_long(3): "index" is an argument, not a field.

(uwe)

getopt_long(3): use NULL, not 0, for flag in the example.

(uwe)

put back the nfs ramdisk kernel for emips.

(christos)

Fix DIAGNOSTIC fallout

(skrll)

bozohttpd: remove obsolete .bzdirect handling

OK mrg@

(kim)

KNF

(skrll)

consistency. NFCI.

(skrll)

mcommphy(4): Add driver for Motorcomm YT8511 GbE PHY.
eqos(4): Add driver for DesignWare Ethernet Quality-of-Service controller.

(jmcneill)

Add driver for DesignWare Ethernet Quality-of-Service controller.

(jmcneill)

Add driver for Motorcomm YT8511 GbE PHY

(jmcneill)

the nfs kernel is only for pmax

(christos)

move the kernels for earmv5{,eb} in the ad.arm file so that they don't
override it

(christos)

There is no point in putting a second sysinst binary into the install
image's root filesystem.

(martin)

Now that (semi-)manual entropy setup may happen outside of the main
install/upgrade path, we need to (re-)write the entropy seed file
afterwards - the earlier written one would not have an entropy estimate
if we get here.

(martin)

sort

(skrll)

wsemul_vt100.c - make static everything that can be static

Externally, wsdisplay only needs wsemul_vt100_ops.  Internally (as
vt100 emulation is split into several files) wsemul_vt100_subr.c needs
wsemul_vt100_reset().

(uwe)

fix pmax

(christos)

fix few more typos in comments.

(andvar)

Create empty files for the "extra" kernels. Grr I should fix this properly
(run checkflists after building the kernels)

(christos)

fix the build.

(christos)

fix the build (KASSERT)

(christos)

fix part of mips

(christos)

fix KASSERT issue

(christos)

fix KASSERTMSG issue

(christos)

arm: Remove #ifdef DIAGNOSTIC now wrong after KASSERT change.

Objects in question aren't volatile here so access is flushable.

(riastradh)

arm: No #if DIAGNOSTIC needed any more.

Compiler can (and gcc does) flush call to strlen when the result is
unused, so no performance impact here.

(riastradh)

ptsname(3): fix equivalence example

The buffer is static, don't make it appear that we are returning a
pointer to a local variable.

(uwe)

tests/make: demonstrate bugs in PrintStackTrace

(rillig)

make: clean up nitpicks

In ParseWord, the expressions '*p' and 'ch' are the same.

In ParseDependencyTargetWord, clean up a wordy comment and join two
conditions.

In the test cond-token-number, clarify that make doesn't convert from
hex to decimal but only from hex to internal representation.

No functional change.

(rillig)

make: clean up parsing of makefiles

Remove redundant comments.

Rename IFile.first_lineno to forBodyLineno since it only contains a
useful value in .for loops but not in .include files.  Also clarify that
this line number is the start of the loop body, since in PrintStackTrace
this line is used as a human-readable line number.  For a .for loop in
which the loop head spans multiple lines, this line number is wrong
anyway.

No functional change.

(rillig)

make: remove redundant IFile.fromForLoop

No functional change.

(rillig)

make: clean up handling of .for loops and .include directives

No functional change.

(rillig)

tests/make: test edge cases in .for loops

(rillig)

make: in .for loops, pass the body to be filled as parameter

This is a preparation for cleaning up the code for loading and parsing
files, especially the part for including other files and for .for loops.

No functional change.

(rillig)

make: fix line number in error message about open conditionals

(rillig)

fix typos in word "diagnostic".

(andvar)

make: remove unused parameter from Parse_PushInput

The parameter readMore was never NULL.

No functional change.

(rillig)

make: fix error message when reading more than 1 GB from stdin

Previously, the error message was:
make: (null): file too large
Now it is:
make: (stdin): file too large

(rillig)

make: clean up loadfile

Do not reserve extra space "just in case a makefile does not end in
'\n'" since that doesn't happen often.

The assertion for 'buf.len <= buf.cap' was redundant.

No functional change.

(rillig)

fix typos in comments, mainly basicly -> basically.

(andvar)

make: convert do-while into while in FindKeyword

GCC generates more efficient code; previously it wasn't aware that (end
- start) was always positive, thus allowing to omit the code for
dividing a negative number by 2.

No functional change.

(rillig)

zero out the tzh structure to fix reproducibile builds.

(christos)

make: reduce indentation in Main_SetObjdir

No functional change.

(rillig)

make: remove redundant comments from ParseDependencySourceSpecial

(rillig)

Always declare function used in KASSERT

(christos)

KASSERT now always uses the expression, so don't protect with DIAGNOSTIC

(christos)

s/coudn/couldn/ and s/couln/couldn/ in comment and log messages.

(andvar)

s/creting/creating/

(andvar)

s/happends/happens/ in comment.

(msaitoh)

s/sensitve/sensitive/

(msaitoh)

Protect KASSERT() with "#ifdef DIAGNOSTIC" as its expression is
undefined otherwise.

(hannken)

Remove an "#ifdef DIAGNOSTIC", KASSERT() always conumes its expression.

(hannken)

s/frambuffer/framebuffer/ in comment.

(msaitoh)

s/aquire/acquire/ in comment.

(msaitoh)

Regen.

(msaitoh)

s/sytem/system/

(msaitoh)

s/assoicate/associate/

(msaitoh)

s/implemenation/implementation/ in comment.

(msaitoh)

Welcome to 2022!

(jnemeth)

Print Physical Layer 16.0 GT/s and Lane Margining at the Receiver extended cap.

- Decode Physical Layer 16.0 GT/s extended capability.
- Decode Lane Margining at the Receiver extended capability.
- Rename pcie_link_compliance_preset_deemphasis to
  pcie_link_preset_preshoot_deemphasis because the table is referenced from
  multiple places.
- Print "reserved" instead of "unknown" when printing equalization preset.
  One of them is known to be the default value.
- Rename PCI_EXTCAP_PYSLAY_16GT to PCI_EXTCAP_PL16G.

(msaitoh)

more KASSERT vs. DIAGNOSTIC fallout

(macallan)

make this compile again by moving a KASSERT into the #ifdef DIAGNOSTIC block
it depends on

(macallan)

s/interrups/interrupts/

(andvar)

fix few typos in comments, mainly in word "parameter".

(andvar)

forgot one @CONFIG@

(christos)

drm: Reduce default debug level to driver-specific messages.

Let's make a liiiiittle less log spew by default with `boot -x'.

(riastradh)

thinkpad(4): Omit workaround for acpiec_bus_read.

acpiec_bus_read now initializes the whole ACPI_INTEGER like its
signature suggests, so we don't need to pick out the low bits of the
result or carefully avoid undefined behaviour from uninitialized
stack garbage.

(riastradh)

acpiec(4): Make sure to fully initialize an ACPI_INTEGER on read.

Write as essay about what this is supposed to do, as far as I can
tell from reading acpica and the commit history and the relevant PR.

(riastradh)

acpi(9): Return full 64-bit object to caller in PCI config read.

The value of the object will be as small as requested, but the whole
uint64_t object will be written as the caller of a space handler
expects, instead of just part of it.

(riastradh)

Grow to fit debug kernels

(christos)

Grow a little

(christos)

Add kernel debug files.

(christos)

change CONFIG to @CONFIG@ to indicate substitution is going to happen.

(christos)

Don't try to install netbsd-CONFIG.debug files build with kernel=

(christos)

sysmon(9): Document lock order.

(riastradh)

drm: Convert noisy flush_workqueue message to dtrace probe.

(riastradh)

sysmon(9): Fix callout/thread synchronization.

Callout may ONLY take sme_work_mtx, at IPL_SOFTCLOCK; MUST NOT touch
sme_mtx at IPL_NONE.  All state the callout needs is serialized by
sme_work_mtx now:

- calls to sme_schedule_callout
- calls to sme_schedule_halt
- struct sysmon_envsys::sme_events_timeout
- struct sysmon_envsys::sme_events_list
- struct sysmon_envsys::sme_callout_state
- struct envsys_data::flags
  => yes, this is a little silly -- used for ENVSYS_FNEED_REFRESH
  => should maybe separate the static driver-defined features from
    the state flags needed by sysmon_envsys but not important now

Sleeping under sme_work_mtx (except on other adaptive locks at
IPL_SOFTCLOCK) is forbidden.  Calling out to the driver under
sme_work_mtx is forbidden.

This should properly fix:

https://mail-index.netbsd.org/tech-kern/2015/10/14/msg019511.html
PR kern/56592

(riastradh)

sysmon(9): Fix mistake in sysmon_task_queue_barrier.

Need to allocate the task structure with malloc(9), not on the stack;
the task thread will free it with free(9).  Forgot to squash this
into previous commit.

(riastradh)

sys/net: Document if_mcast_op with comment and refuse other commands.

Meant only for multicast addition/deletion operations, nothing else.

(riastradh)

sys/net: Document if_flags_set with a comment.

(riastradh)

ethersubr(9): Assert IFNET_LOCKED in ether_ioctl_reinit.

Changes to if_flags are nontrivial configuration changes that require
the long-term ioctl lock.

(riastradh)

sys/net: Assert IFNET_LOCKED in if_ioctl, if_init, and if_stop.

Exception: Not for SIOCADDMULTI/SIOCDELMULTI, for which it is the
driver's responsibility to take internal locks.  Typically this is
already done via struct ethercom::ec_lock.

(riastradh)

altq(9): Fix missing IFNET_LOCK around if_ioctl.

(riastradh)

sys: Use if_init wrapper function.

Exception: Not in kern_pmf.c, for the kind of silly reason that it
avoids having kern_pmf.c refer to symbols defined only in net; this
avoids a pain in the rump.

(riastradh)

sys: Use if_ioctl wrapper function.

(riastradh)

sys: Use if_stop wrapper function.

Exception: Not in kern_pmf.c, for the kind of silly reason that it
avoids having kern_pmf.c refer to symbols defined only in net; this
avoids a pain in the rump.

(riastradh)

sys/net: New functions if_ioctl, if_init, and if_stop.

These are wrappers, suitable for inserting appropriate kasserts
regarding the API's locking contract, for the corresponding functions
in struct ifnet.

Since these are intended to commit configuration changes to the
interface, which may involve resetting the device, the caller should
hold IFNET_LOCK.  However, I can't straightforwardly prove that all
callers do yet, so the assertion is disabled for now.

(riastradh)

umass(4): Omit needless reference counting.

autoconf never detaches before attach has completed, so there is no
longer any need for this mechanism.

(riastradh)

ukbd(4): Avoid races in LED setting on attach.

- Don't reuse sc_delay for LED task -- a keyboard interrupt shortly
  after attach might reset sc_delay so that the LEDs never get turned
  back off.

- Don't turn the LEDs back off after attach if something else has
  already changed them by the time the callout fires.

(And make sure to callout_halt before done this time!)

(riastradh)

acpi(9): Fix memory ordering and completion bugs in notifiers.

1. Guarantee everything which happened before acpi_register_notify
  has also happened before the notifier is actually called.

2. On acpi_deregister_notify, don't return until the notifier is
  definitely not running any more on any CPU, using
  AcpiOsWaitEventsComplete.

(riastradh)

acpi(9): Implement AcpiOsWaitEventsComplete.

(riastradh)

sysmon(9): New sysmon_task_queue_barrier(pri) function.

This waits for the completion of all tasks at priority pri or lower
that are currently queued at the time of the call.

(riastradh)

acpibat(4): Print ACPI error when _STA fails.

(riastradh)

acpibat(4): Delete excessive blank lines.

Makes it hard to follow when there is a big gap between everything
even when there is a tight logical coupling, like setting and testing
an error code.

(riastradh)

acpibat(4): Fix attach and detach ordering.

On attach: Don't register acpibat_resume handler with pmf or
acpibat_notify_handler with acpi until it is safe to call
acpibat_update_info and acpibat_update_status.
=> This requires the sc->sc_sensor array to be allocated, so allocate
  that first.
=> This requires sc->sc_sme to be created, so defer them to
  config_interrupts after sysmon_envsys_register.
=> Make sure to register the notify handler before initially polling
  the info and status.

On detach: Deregister pmf handler and acpi notifier before we destroy
anything.

(riastradh)

libkern: Make KASSERT verify expression is valid if !DIAGNOSTIC.

This way it is no longer necessary to mark variables __diagused if
they are used in KASSERT conditions.

Fix fallout from this by removing now-unnecessary and `#ifdef
DIAGNOSTIC'.

Don't do the same for KDASSERT if !DEBUG -- unlike KASSERT and
DIAGNOSTIC, variables needed by KDASSERT and DEBUG are likely to be
expensive to compute (and potentially difficult for a compiler to
prove flushable), so we don't want to require them under !DEBUG.

(riastradh)

acpi: Support DT link compat string lists

A "compatible" DSD property may either be a string, or a package of
strings. Support both variants in acpi_compatible_match.

(jmcneill)

s/totaled/totalled/

(andvar)

s/quetion/question/

(andvar)

usbd_do_request_len (and friends) return usbd_status so return one in
the usbd_create_xfer failure case.  Spotted by Riastradh.

(skrll)

sysmon: Delete trailing whitespace.  No functional change intended.

(riastradh)

Still not big enough - bump some more.

(pgoyette)

make: sync API documentation of parse.c with latest changes

(rillig)

make: prevent out-of-bounds pointer in AdjustVarassignOp

It's a rather theoretical case that 'name' would point at the very end
of the address space and the string there would be "V=", but in that
case, the expression 'name + 3' would wrap around.

(rillig)

doc: Update TODO.smpnet to reflect invention of ETHER_F_ALLMULTI.

(riastradh)

make: merge duplicate code in Parse_IsVar

No functional change.

(rillig)

make: eliminate type VarAssignParsed

No functional change.

(rillig)

make: unexport types VarAssignOp and VarAssign

These types are only needed in the parsing module.

No functional change.

(rillig)

make: list VarAssignOp in the same order as in the manual page

No functional change.

(rillig)

make: condense code in ApplyModifier_Assign

List the assignment operators in the same order as in the manual page.

No functional change.

(rillig)

s/bandwith/bandwidth/

(andvar)

- With DEBUG=-g (which is also set when we build CTF) we build netbsd.gdb *and*
  netbsd-${KERNEL_CONFIG}.debug because it is not worth having two sets of
  rules (one that builds just netbsd.gdb and one that builds both netbsd.gdb
  and netbsd-${KERNEL_CONFIG}.debug. This maintains compatibility building
  netbsd.gdb when DEBUG=-g
- When either MKDEBUGKERNEL=yes or MKDEBUG=tes we set DEBUG=-g if DEBUG was
  not set.
- We only make a debuginstall rule to install netbsd-${KERNEL_CONFIG}.debug
  if MKDEBUG=yes

(christos)

forgot one KERNEL_BUILD (Tobias Nygren)

(christos)

Use the tail of KERNEL_BUILD since it can be a full path.

(christos)

Make fdopendir visible according to POSIX.1 spec.

(nros)

With recent changees to debug kernel stuff from Christos we are
once again pushing the size limit.  Bump it again.

(pgoyette)

acpiout(4): Work around firmware that doesn't like some brightnesses.

Instead of just asking for cur - 5 or cur + 5, repeatedly ask for
that increment, check whether we actually made progress in that
direction, and if not keep going with another increment, until we hit
the bounds of brightness levels.

I can't find anything in the ACPI spec about this, but my laptop
seems to have trouble with certain levels: 15, 75, 85, 95.  It goes
in all other increments of 5 from 5 to 100, just not those ones --
acts as if the change just never happened, so with the old logic the
brightness up/down would get stuck unable to move in either
direction.

This should have no impact on machines where the first increment
actually takes.

(riastradh)

Ticket #1722

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1722):

sys/dev/cgd.c: revision 1.142

cgd(4): Fix criterion for detach when wedgies are held.

The somewhat confusingly named DK_BUSY(dksc, pmask) answers the
following question:

        Suppose I hold either the character or the block device (but
        not both) of all of the partitions in pmask.  Is anyone else
        using the disk, rendering it unsafe to detach?

This is useful for ioctls like CGDIOCCLR and VNDIOCCLR, which must be
issued on open file descriptors for the disk, so the question cannot
simply be answered by testing whether dk_openmask != 0.
Instead, DK_BUSY breaks the question into the following criteria:

        1. Are there any _other_ partitions than those in pmask open
          at all?  If so, it must be someone else, since I only hold
          partitions in pmask -- hence the disk is busy.
        2. Are any of the partitions in pmask open _both_ as a block
          device _and_ as a character device?  If so, it must be
          someone else, since I only hold _either_ the character
          _or_ the block device open but not both -- hence the disk
          is busy.

When config_detach_all runs at shutdown time, it tries to detach
cgd(4), which has DVF_DETACH_SHUTDOWN; this is important so we submit
queued writes to the underlying disk and wait for them to complete
with dk_drain.

If cgd(4) has any dk wedges with file systems mounted still
configured on it, it isn't ready to detach yet.  But asking
DK_BUSY(dksc, 1 << RAW_PART) returns false, because the dk wedges
only hold RAW_PART open as a block device -- so if nobody has
RAW_PART open as a character device, or any other partitions open,
cgd_detach blithely goes on its way to forcibly detach the wedges.

Instead, ask DK_BUSY(dksc, 0), because the caller -- cgd_detach
issued by config_detach_all -- does not, in fact, hold any partitions
open, so it doesn't need to work around them like ioctl(CGDIOCCLR)
does.  Fixes hang in zfs on dk on cgd during shutdown (and probably
also zfs on cgd without any intervening dk but I haven't tested).

(This change might have the side effect that `drvctl -d cgdN' doesn't
work, but I don't care.)

XXX pullup-9
XXX pullup-8 (...-7, -6, -5...)

(martin)

Tickets #1397 and #1398

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1398):

sys/dev/cgd.c: revision 1.142

cgd(4): Fix criterion for detach when wedgies are held.

The somewhat confusingly named DK_BUSY(dksc, pmask) answers the
following question:

        Suppose I hold either the character or the block device (but
        not both) of all of the partitions in pmask.  Is anyone else
        using the disk, rendering it unsafe to detach?

This is useful for ioctls like CGDIOCCLR and VNDIOCCLR, which must be
issued on open file descriptors for the disk, so the question cannot
simply be answered by testing whether dk_openmask != 0.
Instead, DK_BUSY breaks the question into the following criteria:

        1. Are there any _other_ partitions than those in pmask open
          at all?  If so, it must be someone else, since I only hold
          partitions in pmask -- hence the disk is busy.
        2. Are any of the partitions in pmask open _both_ as a block
          device _and_ as a character device?  If so, it must be
          someone else, since I only hold _either_ the character
          _or_ the block device open but not both -- hence the disk
          is busy.

When config_detach_all runs at shutdown time, it tries to detach
cgd(4), which has DVF_DETACH_SHUTDOWN; this is important so we submit
queued writes to the underlying disk and wait for them to complete
with dk_drain.

If cgd(4) has any dk wedges with file systems mounted still
configured on it, it isn't ready to detach yet.  But asking
DK_BUSY(dksc, 1 << RAW_PART) returns false, because the dk wedges
only hold RAW_PART open as a block device -- so if nobody has
RAW_PART open as a character device, or any other partitions open,
cgd_detach blithely goes on its way to forcibly detach the wedges.

Instead, ask DK_BUSY(dksc, 0), because the caller -- cgd_detach
issued by config_detach_all -- does not, in fact, hold any partitions
open, so it doesn't need to work around them like ioctl(CGDIOCCLR)
does.  Fixes hang in zfs on dk on cgd during shutdown (and probably
also zfs on cgd without any intervening dk but I haven't tested).

(This change might have the side effect that `drvctl -d cgdN' doesn't
work, but I don't care.)

XXX pullup-9
XXX pullup-8 (...-7, -6, -5...)

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1397):

sys/dev/pckbport/synaptics.c: revision 1.71

synaptics(4): New sysctl knob for debug output.

Set hw.synaptics.debug=1 to re-enable it; the compile-time DIAGNOSTIC
option was inappropriate for this.

(martin)

remove the NEED_OWN_INSTALL_TARGET conditional for setting the install
variables, suggested by phone@

(christos)

convert the ehci device owner ship change message to display the ehciN as well.

(mrg)

Add ${_MKTARGET_INSTALL}

(christos)

use ${INSTALL_FILE} so that unpriv builds work.

(christos)

don't match the empty pattern

(christos)

tests/make: demonstrate edge case that evaluates an expression twice

(rillig)

make: remove redundant code from CondParser_ComparisonOrLeaf

No functional change.

(rillig)

make: split ParseWord into the actual ParseWord and ParseFuncArg

Combining two similar but fundamentally different parsing tasks in a
single function only increased the complexity, of the implementation as
well as the call sites.

The code makes it obvious now that a function argument is a bare word
surrounded by parentheses.

The special case of an empty word is only needed for the function
argument, it cannot occur in a bare word.  The code for that has been
moved to the caller.  Such an empty word not only occurs for 'defined()'
but also for 'defined(${:U})'.

No functional change.

(rillig)

make: make ParseWord in condition parser simpler

Merge the two return values (bool, string) into a single return value.
As before, the caller cannot observe the difference between a parse
error and an empty word, both are handled in the same way.

In CondParser_ComparisonOrLeaf, the word cannot be empty since the
calling function CondParser_Token already handles all cases that could
lead to an empty word.

No functional change.

(rillig)

make: internally return false for irrelevant leaves in conditions

The result of irrelevant leaves is effectively ignored by CondParser_And
and CondParser_Or.  Use the 'doEval &&' pattern to make the code
consistent with CondParser_Comparison and CondParser_FuncCall.

No functional change.

(rillig)

drm: Restore hw.drm2.debug sysctl knob, previously lost in merge.

(riastradh)

Enable split-debug files for kernels. Enabled by default with MKDEBUG=yes.

(christos)

build the rest of the tools.

(christos)

xinitrc: delay preprocessing of COLOR in xrdb input

Revert previous and fix it properly.  #ifdef COLOR is intended to be
processed by xrdb, but the script source itself is processed by the C
preprocessor at build time.  Spell that # as XHASH to protect the
conditional.

(uwe)

Remove duplicate KASSERT

(skrll)

make: in irrelevant function calls in conditions, return false

When a condition contains an irrelevant function call, it doesn't matter
whether the function call evaluates to true or to false, it will be
discarded anyway by either CondParser_And or CondParser_Or.

Returning false instead of true makes the code simpler, plus it is more
common to return false for irrelevant results.

No functional change.

(rillig)

make: use simpler return type for ParseWord in conditions

No functional change.

(rillig)

make: replace table for function lookup in conditions with simple code

The code for looking up the function from the table forced the compiler
to use a specific memory layout.  Replacing the table with explicit code
provides the compiler more opportunities to optimize the code.  Another
side effect is that there are fewer pointer operations.

Previously, is_token checked that the character after the word does not
continue the word, this is now done separately since for the function
lookup, this check was unnecessary.  The newly added skip_string
provides a higher abstraction level, it is no longer necessary to pass
the string length as a separate, redundant parameter.

No functional change.

(rillig)

make: clean up condition parser

No functional change.

(rillig)

make: merge duplicate types CondEvalResult and CondResult

No binary change.

(rillig)

make: merge duplicate enum constants for CondEvalResult and CondResult

No binary change.

(rillig)

make: remove redundant parameter for evaluating conditions

No functional change.

(rillig)

make: merge types CondResult and CondEvalResult

No functional change.

(rillig)

lint: do not output "Lint pass2:"

A colon at the end of a line requires at least 1 follow-up line, but
xlint cannot know whether lint2 will find anything to complain about.
Having a colon followed by nothing creates unnecessary confusion.

(rillig)

tests/lint: extend documentation for omitted braces in initializer

(rillig)

tests/make: test function names without following '('

(rillig)

make: fix double-free in CLEANUP mode (since 2021.12.27.23.11.55)

When make is run without the '-f' option, it searches for the files
'makefile' and 'Makefile' in the current directory.  The function
ReadFirstDefaultMakefile allocated memory for these filenames, added the
filenames to opts.makefiles and then freed the memory.  From that
moment, opts.makefiles contained dangling pointers.

The function main_CleanUp cleans the list, but only if make is compiled
with -DCLEANUP.  Since main.c 1.557 from 2021.12.27.23.11.55, the
strings in opts.makefiles are freed as well, before that, only the list
nodes were freed.  Freeing the strings led to the double-free.

Fix this bug by using a separate list for these short-lived strings.  At
the point where ReadFirstDefaultMakefile is called, opts.makefiles is
not used anymore, therefore there are no side effects.

To reproduce, run 'make test-coverage', which compiles with -DCLEANUP.
The test opt-chdir failed with a segmentation fault in main_Cleanup.
This test may be the only one that doesn't use the option '-f'.

(rillig)

make: rename and constify SkipExtraTargets

No binary change.

(rillig)