fix mainly same typos as in my previous commit but outside sys/dev/dm.

(andvar)

fix typos in sys/dev/dm code comments and documentation.
also remove some trailing space in documentation.

(andvar)

ssdfb: add missing break in switch. Unbreaks contrast setting for SSD1353

spotted by hannken@

(tnn)

Fix link erorrs on ancient monolithic Xservers after DRI3 was enabled.

https://mail-index.netbsd.org/source-changes/2021/08/19/msg131652.html
> fix dri3 extension building and build it.
>
> needed for amdgpu.

XXX: I wonder if each Xorg server extension can be enabled/disabled
    per ${MACHINE} basis rather than in MI include/dix-config.h header.

(tsutsui)

PR/56331: Paul Goyette: Add -z option to display 0 instead of ' ' in vmstat.

(christos)

PR/56370: mirabilos: libedit change from 2017 kills history in gdb

(christos)

Add more api to make gdb-11 happy (but not gdbtui as usual)

(christos)

tests/lint: add more test cases for lossy integer conversion

(rillig)

fix some more typos in comments/log messages, improve wording as well.

(andvar)

tests/lint: guard against typos in test environment configuration

Some tests had "lint1-only-if" without a trailing colon, others included
the trailing colon.  The tests that included the trailing colon were run
even though they were supposed to be skipped, and they failed, as could
be expected.

To prevent further typos, always require the trailing colon, just as in
"lint1-flags" and fail fast on unknown "lint1" comments.

(rillig)

lint: extract check_prototype_conversion_integer

No functional change.

(rillig)

tests/lint: add tests for conversion from signed to unsigned

(rillig)

s/recoding/recording/ in comments where it didn't actually mean recoding.

(andvar)

s/accidentaly/accidentally/

(andvar)

s/helt/held+s/eroneously/erroneously/+s/splitted/split/+s/recommented/recommended/

(andvar)

rename glue.c to sodium_module.c

(christos)

rename glue.c to sodium_module.c

(christos)

renaname glue.c to sodium_module.c and remove libsodium_errno which is unused.

(christos)

rename glue.c to sodium_module.c

(christos)

Add glue.c for libsodium (suggested by riastradh). Tidy up.

(christos)

lint: rename local variable '1' in fold_float

It looked too similar to the number 1.

(rillig)

lint: fix spacing in tree.c

(rillig)

lint: do not warn about '(void)arg' and similar expressions

In the current NetBSD build, 5260 of the 46264 total lint warnings are
about expressions that have a null effect.  Most of these occurrences
follow well-established patterns, which makes the warnings bogus.
Remove these warnings.

(rillig)

tests/lint: demonstrate wrong warnings for 'null effect' expressions

(rillig)

tests/lint: suggest better quickfix for expected lint diagnostics

The /* expect */ comments are usually so detailed that they are placed
in a line of their own, referring to the following line.

(rillig)

lint: add missing newlines to grammar debug output

(rillig)

fix various typos in comments and log messages.

(andvar)

Ticket #1692

(martin)

Pull up following revision(s) (requested by ozaki-r in ticket #1692):

sys/netinet6/nd6.c: revision 1.277

nd6: prevent ln from being freed while releasing held packets

(martin)

Ticket #1338

(martin)

Pull up following revision(s) (requested by ozaki-r in ticket #1338):

sys/netinet6/nd6.c: revision 1.277

nd6: prevent ln from being freed while releasing held packets

(martin)

bump the map api

(christos)

note about per-cpu kernel profiling and its performance.

(ryo)

mkdep: avoid memory allocation in findcc

This change takes the idea of handling strings as pairs in the form
(start, len) by Robert Elz from
https://mail-index.netbsd.org/source-changes-d/2021/08/20/msg013427.html
and expands it by avoiding one more memory allocation, for iterating the
PATH environment variable.

No functional change.

(rillig)

mkdep: make argument of findcc const

Previously, findcc modified its argument string, even though it had been
declared as 'const char *'.  This triggered a lint warning that "strchr
effectively discards 'const char *' from argument", in fact, this code
caused the lint check to be implemented in the first place.

The first attempt at fixing it by removing the 'const' from the
parameter type was a bad idea since it made the API of that function
more complicated.

Revert back to making the parameter a 'const char *' and duplicate that
string internally as necessary.  Add a few more tests for absolute
pathnames since these had been missing before.  There are no tests yet
for snprintf with too long strings, but the current change does not
modify that part of the code.

(rillig)

mkdep: fix string constness in call to findcc

(rillig)

Add forgotten commit for previous. Change IXGBE_RX_COPY_LEN_MAX.

(msaitoh)

mkdep: fix prototype of findcc

A function that modifies a string argument must not declare that
argument as 'const char *', even if all callers (mkdep and lint) always
pass it a modifiable string.

No functional change.

(rillig)

lint: change return type of 'msb' from int to bool

No functional change.

(rillig)

s/memry/memory+s/softare/software/+s/grapics/graphics+s/ouput/output

(andvar)

lint: clean up formatting of 'fold'

(rillig)

lint: fix wrong integer overflow warning for unsigned types

(rillig)

add plural for packets and move it to new line to keep 80 symbols per line.

(andvar)

tests/lint: test folding of constant expressions

Since November 2001, there is a comment above the function 'fold' that
suggests there are a few bugs concerning overflow detection.  Add some
first 'proper regression tests' to prove these bugs.

(rillig)

lint: clean up lex_integer_constant

When lexing an integer constant, it does not make sense to check for
'struct', 'void' or other types.  Furthermore, the constants were listed
in some random-looking order, which made the code hard to read.

(rillig)

lint: un-abbreviate parameter names of macro

(rillig)

ssdfb: add support for SSD1306 and SH1106 at spi attachment

Only support the 4-wire mode for now. Support for 3-wire mode is
theoretically possible but most (all?) modules in circulation have the
BS0 / IM0 3-wire config pin internally grounded within the flat-flex
assembly so it is not easy to enable & test.

(tnn)

lint: remove redundant variable Bflag

No functional change.

(rillig)

lint: remove unused static variable

(rillig)

lint: simplify code for adding '-l' and '-L' to libraries

No functional change.

(rillig)

lint: merge duplicate code for passing flags to subprocesses

No functional change.

(rillig)

lint: uniformly pass command line flags to subprocesses

No functional change.

(rillig)

make: fix lint warning about strrchr discarding 'const'

No functional change.

(rillig)

moar tips

(nia)

Fix debugging formats

(christos)

bump bind libraries for bind 9.16.20

(christos)

new bind

(christos)

Adjust for bind-9.16.20

(christos)

Merge changes between bind 9.16.15 and 9.16.20 and restore dns client APIs
needed by dhcpd.

(christos)

ssdfb_spi: fix issues with command xfers needed for SSD1306 & SH1106

These controllers require D/C# to be deasserted for the entire duration
of the command, contrary to docs and how newer controllers like SSD1353
behave. Probably this is needed for all controllers that do not have the
WRITE_RAM (0x5c) command. Also support using alternate padding commands
for 3-wire mode when WRITE_RAM is not available.

(tnn)

fix dri3 extension building and build it.

needed for amdgpu.

(mrg)

don't disable DRI3 here.

(mrg)

Use m_adj(ETHER_ALIGN) more. Tested by me (amd64,aarch64) and rin (alpha).

- Align with ETHER_ALIGN everywhere where mbuf is allocated.
- Remove extra setting of M_PKTHDR. No functional change.
- Add comment.

(msaitoh)

install amdgpu.ids.

(mrg)

Add returns_nonnull attribute

(christos)

KNF. No functional change.

(msaitoh)

fix arm64 builds:  turn off MKCOMPAT for GCC

no idea why it was enabled as we can't easily target 32 bit.

if we figure this out for aarch32, the subdir names etc will
probably be different, or we can just revive the deleted
files no longer referenced with this commit.

(mrg)

don't mark sodium as solaris

(christos)

1333

(snj)

Pull up following revision(s) (requested by martin in ticket #1333):
usr.sbin/sysinst/defs.h: revision 1.72
usr.sbin/sysinst/disks.c: revision 1.75
usr.sbin/sysinst/upgrade.c: revision 1.18
PR 56354: all actions to set up swap space are not guaranteed to gain
us enough virtual memory anyway, so drop return codes from set_swap*.
The state for cleanup (which swap dev to unuse) has been made global
some time ago anyway.
Previously use of the return values was inconsistent. Error reporting
will only confuse users and sometimes the situation is hard to fix or
even impossible (like in miniroots copide to swap space for booting).

(snj)

Don't use fixed value. No functional change.

(msaitoh)

Don't call bus_dmamap_sync with rx_mbuf_sz(== MCLBYTES) to prevent panic.

If an mbuf is ETHER_ALIGNed, the packet size may be shorter than MCLBYTES.
For example, if the max frame size is 2048 by changing the interface's MTU,
an mbuf's max length is 2046. So, don't use rx_mbuf_sz for bus_dmamap_sync.

(msaitoh)

link in glamor and gbm.

(mrg)

Added description of license

(yamaguchi)

Make the test program run in background after doing BIOCPROMISC

t_vlan has rarely failed by checking IFF_PROMISC before the
test program do BIOCPROMISC. To solve this, BIOCPROMISC is
done in the foreground.

fixes PR/56357

(yamaguchi)

Indent.

(msaitoh)

PR/56355: Exclude the symbol trap, not all symbols other than trap.

(riastradh)

Don't define HAVE_TI_MODE if we don't have it.

(christos)

It's time to add ixg(4) and ixv(4).

(msaitoh)

Refresh unrefreshed descriptors' buffers correctly.

- Update next_to_refresh at least before ixgbe_rx_unrefresed() to detect
  the unrefreshed status correctly in ixgbe_rxeof().
- next_to_refresh points to the previous entry of the first unrefreshed
  descriptor, so fix a loop variable to point to the correct one in
  ixgbe_refresh_mbufs().
- Without the above two fixes, RX ring may have some unrefreshed entries
  which have inconsistent state. On such state, "ifconfig down up" causes
  panic in bus_dmamap_sync() on aarch64.
- Tested on amd64 and aarch64. OK'd by knakahara.

(msaitoh)

Fix broken name

(christos)

lint: extract suppress_messages from main

No functional change.

(rillig)

fix multiplei repetitive typos in comments, messages and documentation. mainly because copy paste code big amount of files are affected.

(andvar)

s/blake2s/blakes2s/ to match the directory that exists

(kre)

lint: sync usage message with reality

(rillig)

lint: move GCC builtins into gcc_builtins

No functional change.

(rillig)

modules for if_wg, blake2s, libsodium

(christos)

Some signnes, casts, and constant sizes.
Add module dependencies.

(christos)

Add module glue

(christos)

modules for blake2s libsodium and if_wg

(christos)

s/Windw/Window/ in log message.

(andvar)

tty.4: s/asynchronus/asynchronous/

(andvar)

nd6: prevent ln from being freed while releasing held packets

(ozaki-r)

Add missing check for error returns from read().  Found by inspection
while reviewing the changes suggested by RVP in PR install/56303, but
not believed to be the cause of the failure reported in that PR.

(gson)

add missing tpool.c.  fixes libreoffice build.

(mrg)

tests/lint: test default argument promotion with enum

(rillig)

tests/lint: test arithmetic promotions and enums

(rillig)

tests/lint: add tests for several messages about type mismatch

(rillig)

lint: remove dead code from check_bad_enum_operation

There is a single caller of that function, and it checks the exact same
condition beforehand.

(rillig)

remove unused oabi mknative output.

(mrg)

note sh3 switched.

(mrg)

note sh3 -> GCC 10.

(mrg)

switch sh3 to GCC 10.  buh bye GCC 9!

thanks to everyone who helped (most espcially rin@.)

(mrg)

tests/lint: document history of initialization of const members

(rillig)

install experimental/* and ext/opt_random.h.  they're expected to
be there (and the latter was removed by accident.)

regen for everyone (also picks up missing tgmath.h for many ports.)

fixes build of pkgsrc/databases/mongodb for me.

(mrg)

lint: add more details to message about redeclared tag

(rillig)

tests/lint: test message for redeclared tags

(rillig)

fetch experimental_headers, experimental_bits_headers, and ext_host_headers
to install install experimental/* and ext/opt_random.h.

(mrg)

tests/lint: remove unintended debugging output

(rillig)

tests/lint: fix check for expected message in msg tests

(rillig)

libedit: simplify calls to macro ADD_STRING

The lint comments CONSTCOND and LINTED were not necessary.  It is
simpler to just specify what to free.  GCC optimizes free(NULL) to be a
no-op.

No functional change.

(rillig)

readline: fix lint warning about effective unconst cast

Calling strchr to avoid the syntactical unconst cast is not necessary
here.  A simple pointer assignment is enough.

No functional change.

(rillig)

Define a constant for the size of device_t::dv_xname, rather than just
using 16.

(thorpej)

tests/lint: correct interpretation of NOTREACHED

The branch is unconditionally taken, therefore any later code is
unreachable as well.

(rillig)

tests/lint: test how NOTREACHED affects the unreachable warning

Inspired by lib/libedit/readline.c 1.159 from 2021-08-15.

(rillig)

grep-3.7 out.

(wiz)

PR/56355: Taylor Campbell: restore strcmp() over strncmp()

(christos)

libcurses: fix usage of __warn_references

Since that macro can expand to an empty token list, it adds its own
semicolon as needed.  Removing the extra semicolon fixes the lint
warnings about empty declarations.  These empty declarations are a GCC
extension.

(rillig)

lint: extend check for unconst functions

The functions memchr, strpbrk, strrchr and strstr effectively remove the
const qualifier of their first argument, just like strchr.

(rillig)

tests/lint: add tests for more unconst functions

(rillig)

libcrypto: suppress irrelevant lint warnings

The conversion from 'unsigned long' to 'int' in line 805 is due to the
laziness of declaring a carry flag as BN_ULONG, to save an extra
line of declaration.

The constants in conditional context come from the macro 'bn_cp_32'.

The unconst cast is used for initializing local BIGNUM constants; the
struct member is declared as non-const pointer.

(rillig)

lint: fix wrong warning about 'unsigned char >> constant'

(rillig)

tests/lint: demonstrate wrong warning about signed '>>'

Seen in libdes/ostr2key.c(81).

(rillig)

libdes: suppress some selected lint warnings

The type widths are handled carefully, so even if there is some
conversion from 64-bit long to uint32_t, no value bits get lost.

The fallthrough case statements are a variant of Duff's Device.

The bitwise '>>' on signed value is actually on a value of type
'unsigned char', and since all platforms supported by lint have
sizeof(int) == 4, the behavior is well defined.

(rillig)

jemalloc: suppress two irrelevant lint warnings

(rillig)

This is a mess; always define MB_LEN_MAX so both the regular and libhack
version of curses compiles. Really we should not be defining MB_LEN_MAX here,
and include <limits.h> in curses_private.h to get it.

(christos)

Turn on EL_SAFEREAD

(christos)

Add -I to find filecomplete.h

(christos)

need limits.h

(christos)

Use MBL_LEN_MAX (constant) so that SSP works

(christos)

Restore BSD BUGS section

(christos)

restore a bit of history.

(christos)

Conditionalize GSSAPI use on USE_KERBEROS

(christos)

Fix sun2 build for ldap/gssapi

(christos)

- Add command completion (from FreeBSD)
- Use EL_SAFEREAD

(christos)

Add verb to sentence.

(wiz)

Disable attempts to handle EINTR and non-blocking I/O by default. It is
confusing to other programs and unexpected behavior. Reported by Ingo Schwarze.
This behavior is now controlled with EL_SAFEREAD.

(christos)

Add a LINTED comment... Why doesn't NOTREACHED work?

(christos)

Ticket #1691

(martin)

Pull up following revision(s) (requested by christos in ticket #1691):

sys/compat/common/vfs_syscalls_43.c: revision 1.67
sys/compat/common/vfs_syscalls_50.c: revision 1.26
sys/compat/common/vfs_syscalls_30.c: revision 1.42

- memset struct stat to avoid kernel memory disclosure of padded fields
  (thanks Trend Micro for the report)
- use do_fhstat
- consistency in argument order of compat functions

(martin)

Tickets #1334 -  #1337

(martin)

Pull up following revision(s) (requested by christos in ticket #1337):

sys/compat/common/vfs_syscalls_43.c: revision 1.67
sys/compat/common/vfs_syscalls_50.c: revision 1.26
sys/compat/common/vfs_syscalls_30.c: revision 1.42

- memset struct stat to avoid kernel memory disclosure of padded fields
  (thanks Trend Micro for the report)
- use do_fhstat
- consistency in argument order of compat functions

(martin)

Pull up following revision(s) (requested by tsutsui in ticket #1336):

crypto/external/bsd/openssl/lib/libcrypto/arch/mips/mips.inc: revision 1.1
crypto/external/bsd/openssl/lib/libcrypto/arch/mips/mips.inc: revision 1.2
crypto/external/bsd/openssl/lib/libcrypto/arch/mips/bn.inc: revision 1.7
crypto/external/bsd/openssl/lib/libcrypto/arch/mips/poly1305.inc: revision 1.5
crypto/external/bsd/openssl/lib/libcrypto/arch/mips/bn.inc: revision 1.8
crypto/external/bsd/openssl/lib/libcrypto/arch/sparc/bn.inc: revision 1.3
crypto/external/bsd/openssl/lib/libcrypto/arch/mips/crypto.inc: revision 1.8
crypto/external/bsd/openssl/lib/libcrypto/arch/mips/aes.inc: revision 1.6
crypto/external/bsd/openssl/lib/libcrypto/arch/mips/sha.inc: revision 1.7

Centralize the logic for endian and 64 bit availability.

Handle the compat builds and both the n64 and non n64 variants

PR/56318: Izumi Tsutsui: Limit bn-sparcv8.S to sparc64; breaks
on sparcstation 2 (sun4c)

PR/56318: Izumi Tsutsui: Don't include mips.S for 32 bit mips because it
does not work for mips1

(martin)

Capitalization police.

(nia)