make(1): refine test for detecting misspellings in directives

The names of directives are only checked if the lines are actually
relevant.  In all other cases, the amount of work is reduced to the bare
minimum, which is just to scan for line continuations.

(rillig)

make(1): issue a parse error on unclosed variables

These errors had not been detected before by make.
In pkgsrc, this task as been done by pkglint since 2019-04-07.

(rillig)

make(1): remove unnecessary struct tag

Identifiers starting with an underscore and an uppercase letter are
reserved for the C implementation.

(rillig)

make(1): remove dead code from Var_Subst

The first parameter from Var_Subst had been a literal NULL in all cases.
These have been fixed using this command:

sed -i 's|Var_Subst(NULL, |Var_Subst(|' *.c

The one remaining case was not found because the "NULL," was followed by
a line break instead of a space.

The removed code probably wouldn't have worked as expected anyway.
Expanding a single variable to a literal string would have led to
unexpected behavior for cases like ${VAR:M${pattern}}, in case pattern
would contain an unescaped ':' itself.

(rillig)

Ensure .CURDIR is correct for tests that run sub-makes

(sjg)

make(1): disable archive test

On FreeBSD, running the archive.mk test results in "create-archive is up
to date" and similar messages.  The situation is unclear, and the
archive code seems to be practically unused.  Furthermore the archive
test doesn't ensure that it is run in ${.PARSEDIR}, so it needs a bit
more work.

(rillig)

say what is not configured in nvme_print()

(jdolecek)

Fix typo in comment.

(riastradh)

Omit now-unused function.

Ceased to be needed with the AES CCM changes.

For some reason gcc didn't complain about this, but clang did.

(riastradh)

Use CPU_IS_PRIMARY macro in cpu_stop(), cpu_resume(), and cpu_get_tsc_freq()
on x86.

OK kamil@

(fcambus)

Add TSV

(leot)

Initialize authctr in both branches.

I guess I didn't test the unaligned case, weird.

(riastradh)

note that MSI was enabled by default for Xen

(jdolecek)

remove NO_PCI_MSI_MSIX again, enabling MSI for Xen Dom0 by default

(jdolecek)

add a quirk to disable MSI, and enable it for Intel SSD DC P4500

this device seems to cause serious system responsiveness issues when configured
to use MSI, while it works fine when configured for either INTx or MSI-X

this is important so this works well under Xen Dom0, which doesn't
support MSI-X yet

fixes another issue reported as feedback for PR port-xen/55285 by Frank Kardel

(jdolecek)

_LKM -> _MODULE

(skrll)

Use -r for export.mk to minimize interference

(sjg)

Change cpus_booted back to a simple variable instead of a kcpuset.
octeon_cpu_spinup() was trying to set CPU status immediately on kernel
startup _well_ before the kcpuset was initialised.

(simonb)

make(1): add test for modifier part with unbalanced braces

(rillig)

make(1): remove redundant ApplyModifiersState.termc

(rillig)

make(1): document and reorder ApplyModifiersState

(rillig)

make(1): rename ApplyModifiersState.nstr and newStr

The old names were too easy to confuse.  In Var_Parse, nstr is indeed
used for the "new string", but that was misleading in ApplyModifiers,
especially since there was another variable called newStr.

The new variable names focus on the purpose of the variables, not on
their data types.

(rillig)

make(1): rename ApplyModifiersState.cp to next

The name "next" is more descriptive than a mere "cp".  It's easy to look
up the type of the variable, but not so easy to guess the purpose of the
variable, therefore the new name concentrates on the purpose.

(rillig)

make(1): in ApplyModifier_Match, use short local variable name

(rillig)

make(1): in ModifyWord_Match, use different variables

Using the same registers or memory locations for different variables is
the job of the register allocator, not the programmer.  For humans, that
practice is rather confusing.

(rillig)

make(1): replace comment in ApplyModifier_Match with code

(rillig)

make(1): remove unused lengthPtr and freePtr from ApplyModifiersState

(rillig)

make(1): remove unnecessary field from ApplyModifiersState

(rillig)

make(1): remove unnecessary variable assignment

It is not the job of an ApplyModifier function to directly manipulate the
final result of the ApplyModifiers function.  In fact, the resulting
pointer was overwritten unconditionally, in such an obvious way that the
compiler could have detected this.  GCC 5 didn't though, which reduces
the code size a bit.

(rillig)

make(1): move modifier character out of ApplyModifiersState

It is only used in the outer part of the loop to apply the modifiers.

(rillig)

make(1): replace macros with functions

Having the hidden parameter st->endc in the macro made it unnecessarily
difficult to understand the code.

(rillig)

make(1): use shorter variable name for parsing :D and :U

(rillig)

It's __ARM_NEON, not __ARM_NEON__, sometimes, apparently.

(riastradh)

Note that VSRI seems to hurt here.

(riastradh)

Take advantage of REV32 and TBL for 16-bit and 8-bit rotations.

However, disable use of (V)TBL on armv7/aarch32 for now, because for
some reason GCC spills things to the stack despite having plenty of
free registers, which hurts performance more than it helps at least
on ARM Cortex-A8.

(riastradh)

Add RCSIDs to the AES and ChaCha .S sources.

(riastradh)

make(1): document where to fix the .INCLUDEDFROM bug

(rillig)

catch up with source rename of fbsd-zfs -> zfs

(christos)

Issue aese/aesmc and aesd/aesimc in pairs.

Advised by the aarch64 optimization guide; increases cgd throughput
by about 10%.

(riastradh)

Align critical-path loops in AES and ChaCha.

(riastradh)

PIC for aes_neon_32.S.

Without this, tests/sys/crypto/aes/t_aes fails to start on armv7
because of R_ARM_ABS32 relocations in a nonwritable text segment for
a PIE -- which atf quietly ignores in the final report!  Yikes.

(riastradh)

Enable ChaCha NEON code on armv7 too.

The 4-blocks-at-a-time assembly helper is disabled for now; adapting
it to armv7 is going to be a little annoying with only 16 128-bit
vector registers.

(Should also do a fifth block in the integer registers for 320 bytes
at a time.)

(riastradh)

Use <aarch64/asm.h> rather than copying things from it here.

Vestige from userland build on netbsd-9 during development.

(riastradh)

Fix outdated comment.

(riastradh)

Simplify ChaCha selection and allow it to be used much earlier.

This way we can use it for cprng_fast early on.  ChaCha is easy
because there's no data formats that must be preserved from call to
call but vary from implementation to implementation -- we could even
make it a sysctl knob to dynamically select it with negligible cost.

(In contrast, different AES implementations use different expanded
key formats which must be preserved from aes_setenckey to aes_enc,
for example, which means a considerably greater burden on dynamic
selection that's not really worth it.)

(riastradh)

Reduce some duplication.

Shouldn't substantively hurt performance -- the comparison that has
been moved into the loop was essentially the former loop condition --
and may improve performance by reducing code size since there's only
one inline call to chacha_permute instead of two.

(riastradh)

make(1): add tests for parsing directives like .if and .info

(rillig)

New sysctl subtree kern.crypto.

kern.crypto.aes.selected (formerly hw.aes_impl)
kern.crypto.chacha.selected (formerly hw.chacha_impl)

XXX Should maybe deduplicate creation of kern.crypto.

(riastradh)

Gather auth[16] and ctr[16] into one authctr[32].

Should appease clang.

(riastradh)

make(1): remove unnecessary argument validation

(rillig)

make(1): add test for exporting single-character variables

(rillig)

make(1): prepare test for .export to show all exported variables

Currently the unit tests don't cover exporting of local variables like
.TARGET or @.  To see the effects, all exported variables must be listed
by the tests.

(rillig)

make(1): sort flags for test cases alphabetically

(rillig)

make(1): improve const-correctness in archive handling

The return value of Var_Value must not be modified.  Ideally it would be
declared as const char *, but that still takes a while, especially since
much of the make code is not yet covered by the unit tests.

The variable cp had to be changed to const char * as well, and while here
was split up into one variable per actual use case.

(rillig)

make(1): ignore gcov files for CVS

(rillig)

make(1): add test for unsetting an environment variable in -e mode

(rillig)

make(1): add very basic test for archive handling

The whole code in arch.c had been uncovered by tests before.

The code coverage shows that neither the archive name nor the member
contain any $, even though archive.mk looks like it.  It could be
necessary to place the variable assignments below the dependency line,
to force late evaluation.

(rillig)

make(1): add very basic test for archive handling

The whole code in arch.c had been uncovered by tests before.

The code coverage shows that neither the archive name nor the member
contain any $, even though archive.mk looks like it.  It could be
necessary to place the variable assignments below the dependency line,
to force late evaluation.

(rillig)

Skip v2m probe if armgic fails to attach

(jmcneill)

Remove CPU ID test in armgic_match. Perfectly normal to have GIC in
non-Cortex cores.

(jmcneill)

make(1): document API of Var_Value

(rillig)

Skip the repeated_link_addr test by default as it causes the
evbarm-aarch64 testbed to hang (PR port-evbarm/55521), and will not be
safe to run by default even after that bug is fixed, for similar
reasons as t_repeated_updown.

(gson)

Trailing whitespace

(skrll)

Improve the workqueue and callout handling.  Prompted by riastradh@.

(jdc)

icmp6: Remove __packed attribute from icmp6 structures

They should naturally align.
Add compile time assertations to icmp6.c to prove this.

(roy)

add reference to net/py-xmm7360 for the network initialization script

(jdolecek)

Nix trailing whitespace.

Helpful hint:

(setq show-trailing-whitespace t)

(riastradh)

ip6: Remove __packed attribute from ip6 structures

They should naturally align.
Add compile time assertations to ip6_input.c to prove this.

(roy)

Don't remove the _LKM #ifdefs, but do s/_LKM/_MODULE/

(skrll)

more attribution

(jdolecek)

s/MODULE/_MODULE/

spotted by chuq@

(skrll)

Don't remove the _LKM #ifdefs, but do s/_LKM/_MODULE/

(skrll)

Don't define _LKM. LKMs are dead. Long live modules.

(skrll)

Fix typo _MODULAR -> _MODULE.  Hopefully this fixes the builds.

(skrll)

Use the new "run_unsafe" atf_config_get() option also with a couple of other
tests that are known to be unsafe.

(jruoho)

fix build error. need cast.

(ryo)

Instead of just skipping interfaces that are "up", skip the whole
repeated_updown test case unless explicitly enabled with "atf-run -v
run_unsafe=yes".  Gratuitously configuring interfaces "up" is no more
safe than gratuitously configuring them "down"; for example, it could
lead to accidentally connecting to an insecure network or diverting
traffic from the desired route.

(gson)

Improve PostScript output.

Some highlights in no particular order:

%destructor was somehow lost from the list that follows, it should be
part of it.

Use .Ic for yacc directives when they are defined, .Ql otherwise.

Use explicit .Sq Li (instead of .Ql) in description of %destructor to
make sure the result is consistently quoted.  It more readable that
way.

Use .Va and .Vt where appropriate.

C preprocessor directives are marked up with .No (a nop), so that it's
easy to switch them to something else if need be.  For now just use
them as plain words.

(uwe)

Fix markup errors.

(uwe)

make(1): make test for dynamic variable name more specific

Since all the string literals have either 7 or 8 characters, there is no
need to call strcmp for shorter or longer variable names.

(rillig)

make(1): extract code for dynamic variable names out of Var_Parse

(rillig)

Add debug output for ENDDEFS.

This makes it more clear in the debug output where config switched
from definitions to selections.

(uwe)

Don't print the location of the include directive twice.

cfgdbg() already prints the current file and line number, so don't
print the same information ourselves in the message too.

(uwe)

make(1): fix off-by-one error in Var_Parse for dynamic variables

(rillig)

make(1): add test for off-by-one error in Var_Parse

(rillig)

Minor wording improvements.

(wiz)

make(1): add coverage test for dynamic = TRUE in Var_Parse

(rillig)

make(1): rename VarEvalFlags variables to eflags

This way, they cannot be confused with other flags, and any mismatch of
mixing eflags with constants other than VARE_* is immediately apparent.

(rillig)

use the right printing function

(christos)

make(1): rename local variable in Var_Parse

(rillig)

make(1): add test for unclosed variables

(rillig)

make(1): add test for expanding dynamic variables

(rillig)

make(1): make return value of Var_Parse constant

This return value is not supposed to be modified since it can be a string
literal.  The modifiable part is returned via freePtr, but only for
freeing, not for actually modifying anything.

(rillig)

make(1): explicitly add dependencies on headers

This prevents partial builds after changing a header.  The declared
dependencies are more than strictly necessary, but that's still better
than having inconsistent partial builds because too few dependencies are
declared.

(rillig)

make(1): revert making Var_Parse return a const string

The dependencies between the C files and nonints.h are not declared
properly, which resulted in a successful partial build, but a full "make
clean && make" failed.

(rillig)

make(1): mark result of Var_Parse as const

Var_Parse can return either a string literal or an allocated string.  The
former must not be modified by the caller.  If the string is allocated,
it is returned in freePtr as well, but only for freeing it after use.

(rillig)

make(1): reduce scope and rename local variable in Var_Parse

(rillig)

make(1): eliminate another local variable in Var_Parse

(rillig)

make(1): split local variable into two in Var_Parse

(rillig)

make(1): split local variable into two

Reusing a const char * parameter to store a char * and later free that
string was not a good idea. It made the pretty long code of Var_Parse
more difficult to understand.

(rillig)

replace KDE with a desktop that's actually current in pkgsrc

(nia)

make(1): reorder arguments of ParseModifierPart

First the input parameters, then additional data, then special arguments.

(rillig)

extattr.3 is obsolete

(christos)

make(1): merge VARE_NOSUBST into VARE_WANTRES

The flag VARE_NOSUBST is only a few days old. It had grown out of the
VARP_NOSUBST and VAR_NOSUBST flags, not knowing at that time that it
meant the exact opposite of VARE_WANTRES.

(rillig)

this file contained the same information as extattr_namespace_to_string.3
and somewhat incorrect too.

(christos)

make(1): remove wrong comment from VarOrder

(rillig)

make(1): reorder code in ParseModifierPart to be more readable

(rillig)

make(1): in ParseModifierPart, only update length on success

(rillig)

fix attribution - I was confused what was the correct final version

(jdolecek)

make(1): remove wrong comment for VarUniq

VarUniq is not about sorting the words.

(rillig)

make(1): save a few bytes and cycles by comparing against 0

The comparison against ac - 1 could have been optimized by the compilers
as well, but both GCC 5 and Clang produce smaller code for the comparison
against 0.

(rillig)

make(1): remove unnecessary block scope

(rillig)

make(1): document the circumstances in which brk_string returns NULL

(rillig)

finish sentence

(jdolecek)

add note that the network initialization script needs the device nodes
to be created

(jdolecek)

If Unwind_Backtrace is broken, ctx.n will still contain ~0, and we will
return that which poor behavior for the user, so return 0 instead.
We could document ~0 to be an error, but that would deviate from the
Linux behavior which is not desirable. Noted by Poul-Henning Kamp

(christos)

make(1): avoid memory allocation for oneBigWord in modifiers

(rillig)

add support for wwanc(4) device nodes (xmm[0-9])

(jdolecek)

robots: Use arc4random_uniform for better uniform distribution

(nia)

make(1): help the compiler to find common subexpressions

(rillig)

make(1): add convenience functions for adding to a SepBuf

(rillig)

random(6): Use arc4random_uniform to simplify code

(nia)

note new Intel XMM7360 driver

(jdolecek)

Revert arc4random usage for now

this is a host tool and needs to be portable

future plans: add arc4random to libnbcompat

(nia)

add rudimentary wwanc(4) manpage

(jdolecek)

make(1): add Buffer functions for common tasks

Adding a string or a substring to a buffer are common tasks when handling
variables.  There is no need to spell out the strlen call or the pointer
subtraction at every call site.

Subtracting pointers results in a ptrdiff_t, which would have to be
converted to an int in each case for WARNS=6. Having this conversion in a
single place keeps the code clean.

(rillig)

Add driver for Intel XMM7360 LTE modem, based upon Linux driver available
at https://github.com/xmm7360/xmm7360-pci

This version works on Linux, OpenBSD, and NetBSD.

OpenBSD port written for genua GmbH

Modem requires python script from the master site to initialize the network,
it will be added to pkgsrc shortly

(jdolecek)

make(1): add tests for :!...! parse errors

(rillig)

Another /usr/libdata/usr/tests/sys/crypto/chacha set list entry.

(Why do we need this here _and_ in debug/mi?)

(riastradh)

make(1): add test for missing input validation in :[123] modifier

(rillig)

Sort includes.

(riastradh)

make(1): add Buf_AddInt to make the calling code simpler

(rillig)

make(1): add basic tests for the :S modifier

(rillig)

Add missing include to fix the build on architectures w/o any special
accelerated AES implementation.

(martin)

make(1): make code in the :S modifier simpler

This code path is covered by the "sequences of letters" in modmisc.mk.

(rillig)

make(1): fix bug in :S modifier from 2020-07-19

(rillig)

make(1): demonstrate bug in the :S modifier with the 1 modifier

The bug has been introduced in var.c r1.268 on 2020-07-19.

(rillig)

make(1): use consistent test names in modmisc.mk

(rillig)

make(1): add test for prefix mismatch in SysV substitution

(rillig)

make(1): add test for appending and exporting a variable

(rillig)

Tickets #1023 - #1030

(martin)

Pull up following revision(s) (requested by nia in ticket #1030):

distrib/notes/evbarm/hardware: revision 1.15
distrib/notes/evbarm/contents: revision 1.11

Fix location of device trees

more 9.0 hardware

(martin)

Pull up following revision(s) (requested by nia in ticket #1029):

distrib/notes/evbarm/upgrade: revision 1.3
distrib/notes/evbarm/upgrade: revision 1.4
distrib/notes/evbarm/upgrade: revision 1.5

Initial evbarm upgrade instructions - need work

clarify

upgrades to upgrade instructions

(martin)

Remove Arm OABI -> EABI change notice

(jmcneill)

ARM -> Arm

(jmcneill)

make(1): add tests for appending to a variable

(rillig)

Pull up following revision(s) (requested by tsutsui in ticket #1028):

share/mk/bsd.x11.mk: revision 1.135
external/mit/xorg/server/xorg-server/hw/xnest/Makefile: revision 1.22
external/mit/xorg/server/xorg-server.old/hw/xnest/Makefile: revision 1.4

Fix typos in ${X11INCS.DIX} include paths. PR/55500
Remove extra "-I" for ${X11INCS.DIX} macro.

(martin)

Remove duplicate word

(jmcneill)

List all supported Amlogic SoCs

(jmcneill)

Pull up following revision(s) (requested by tsutsui in ticket #1027):

external/mit/xorg-server/dist/fb/fbcmap_mi.c: revision 1.2
external/mit/xorg-server.old/dist/fb/fbscreen.c: revision 1.2
external/mit/xorg-server.old/dist/fb/fb.h: revision 1.2
external/mit/xorg-server/dist/fb/fb.h: revision 1.2
external/mit/xorg-server/dist/fb/fbscreen.c: revision 1.2
external/mit/xorg-server.old/dist/fb/fbcmap_mi.c: revision 1.2

Fix 1bpp Xservers on "whitePixel=0, blackPixel=1" VRAMs.

- Don't override pScreen->blackPixel and pScreen->whitePixel
  (set in MD server Init functions per -filpPixels option)
  on 1bpp servers in merged fbSetupScreen() (merged one
  from cfbSetupScrenn and mfbSetupScreen() in old xsrc/xfree)
- Pull mfbCreateColormap() function from old xsrc/xfree tree
  and use it on 1bpp servers

Required by forthcoming X11R7'fied ancient Xsun and XsunMono servers:
https://mail-index.netbsd.org/port-sun3/2020/07/17/msg000157.html

Without these fixes, mouse pointers and twm window titlebar etc. are
rendered inverted.

Pull 1bpp server fixes from xorg-server.old:
https://mail-index.netbsd.org/source-changes/2020/07/18/msg119488.html

Confirmed on luna68k 1bpp Xorg 1.20 server using xf86-video-wsfb
with "-flipPixels" option.

(martin)

Add i.MX8MQ

(jmcneill)

ThunderX is covered by SBBR+SBSA

(jmcneill)

Add BCM2711

(jmcneill)

Clarify SBSA support

(jmcneill)

Pull up following revision(s) (requested by tsutsui in ticket #1026):

external/mit/xorg-server.old/dist/hw/netbsd/x68k/x68kInit.c: revision 1.3

Use AllocDevicePair() to initialize input devices in InitInput().

This should have been done on the initial X11R7'fied imoprt as
upstream xnest did:
https://cgit.freedesktop.org/xorg/xserver/commit?id=32ce5c83a504d2cafd2b19ed628b40032ef347b3

Tested and no visible regression on XM6i.

(martin)

Note support for TI AM335x SoC

(jmcneill)

make(1): add test for .MAKE.SAVE_DOLLARS

(rillig)

Pull up following revision(s) (requested by jdolecek in ticket #1025):

sys/dev/wsfb/genfb.c: revision 1.73

reduce stack usage in genfb_calc_hsize()

(martin)

Pull up following revision(s) (requested by jdolecek in ticket #1024):

sys/dev/pci/pci_subr.c: revision 1.224

change pci_conf_print() to allocate memory for the regs dynamically
instead of on-stack

(martin)

Pull up following revision(s) (requested by roy in ticket #1023):

external/apache2/mDNSResponder/dist/mDNSShared/PlatformCommon.c: revision 1.6
external/apache2/mDNSResponder/dist/mDNSPosix/mDNSPosix.c: revision 1.17
external/apache2/mDNSResponder/dist/mDNSPosix/PosixDaemon.c: revision 1.13
external/apache2/mDNSResponder/dist/mDNSPosix/PosixDaemon.c: revision 1.14

mdnsd: Treat EADDRNOTAVAIL as a transient error

mdnsd: starting and stopping are informational messages

mdnsd: Make the unable to parse resolv.conf message informative

(martin)

make(1): fix missing error message about missing @ delimiter

This had been broken since 2020-07-03, during a "refactoring".

(rillig)

make(1): add test about missing delimiters in :@ modifier

These error conditions have been broken since var.c 1.236 on 2020-07-03.

(rillig)

share/mk/bsd.README: fix typo

(rillig)

style: fix typo about enum constants being capitalized

(rillig)

make(1): remove references to the removed lst.lib

(rillig)

Refactor remaining mount_* commands to use the common pathadj()
function for resolving paths.

Make pathadj() no longer warn about symlinks. Symlinks in /dev are
regularly used in several places like LVM . The warning was also
only visible when calling a mount_* command directly as mount(8)
itself would resolve the path witout warning before passing it to
a mount_* command.

(mlelstv)

#define<tab>
Nuke trailing whitespace.

(simonb)

Rework "machine cp0" command and support macros to use CP0 reg defines
instead of magic numbers for CP0 regs with a select number.

(simonb)

Add CP0 Config Registers 6 and 7.

(simonb)

Use EIMR/EIRR regs definitions from <mips/cpuregs.h>

(simonb)