Check EICR's queue bit instead of IFF_RUNNING. This change fixes a bug that
it might incorrectly enable interrupt when IFF_RUNNING is not set. It also
changes that the TX/RX is not processed if a queue interrupt isn't occurred.

(msaitoh)

Don't use "more" flag for simplify in ixgbe_legacy_irq().
No functional change intended.

(msaitoh)

Use .MAKE.DEPENDFILE as makefiles set it

(sjg)

Always issue isb after cpacr_el1 writes since it is a context-changing
operation.

(jmcneill)

Fix a longstanding bug in hilkbd (and dnkbd) console attachment.

cn_tab->cn_dev is initialized in wsdisplay_emul_attach()
(but not in wsdiaplay_cnattach()) so it cannot be used
when hil(4) is attached before wsdisplay(4) is attached.
Instead, use exported wsdisplay_cnputc() that is actually
set in early wsdisplay_cnattach().

Now we can use ddb and RB_ASKNAME via HIL keyboard console.
Should be pulleld up to netbsd-8 and netbsd-9.

(tsutsui)

Use C99 designated initializers for struct consdev.

(tsutsui)

Handle WSSCREEN_REVERSE properly.  Based on OpenBSD's sti(4).

Also remove WSSCREEN_UNDERLINE from capabilities that is not handled
by sti(4) ROM routines.

Tested on HP9000/425t with CRX.

(tsutsui)

Adjust to "pool" usage in our standard ntp.conf, pointed out
by Connor McLaughlan.

(martin)

Use designated initializers for struct ata_bustype

(skrll)

Avoid potentially accessing an array with an index out of range.

Reported-by: syzbot+8832f540234b996bc5a9@syzkaller.appspotmail.com
Reported-by: syzbot+0b785dd10d987350ecb3@syzkaller.appspotmail.com

(nia)

When reading from a block device, queue parallel block requests to
fill a buffer with breadn.

(mlelstv)

Update to 2021, hopefully less errors made in this year.

(maya)

Trailing whitespace

(skrll)

Use designated initializers for struct ata_bustype

(skrll)

List calendar's known calendars explicitly, and only install those.

Prevents build failures caused by installing editor backups and other
such silliness.

(dholland)

Simplify setting of EIAC register. No functional change intended.

(msaitoh)

Fix a bug that INTx is disabled if the INTx line is shared with other device.
ixgbe.c rev. 1.264 was not correct.

    Restore EIMS before return. To read ECIR, clearing EIMC is required for
    an errata, so
        0) save the original EIMS value
        1) clear EIMS
2) read EICR
3) restore with the saved value.

(msaitoh)

The EICR register are cleared in the beginning of the ixgbe_legacy_irq(),
so it's not required to clear each bit later in the function.

(msaitoh)

The EICR register's all OTHER interrupt bits are cleared in the beginning of
the ixgbe_msix_admin(), so it's not required to clear each bit later in the
function.

(msaitoh)

trailing whitespace

(jmcneill)

Avoid negating the minimum size of pid_t (this overflows).

Reported-by: syzbot+e2eb02f9dfaf4f2e6626@syzkaller.appspotmail.com

(nia)

Reorder some code to reduce diff between ixgbe_legacy_irq() and
ixgbe_msix_admin. No functional change intended.

(msaitoh)

Add some debug printf()s and modify comments.

(msaitoh)

Remove strange ixgbe_enable_intr() in ixgbe_legacy_irq().

If the interface is UP and the INTx line is shared with other devices,
it result in enabling all interrupt sources even if some of them are
disabled for the workqueue. Delete ixgbe_enable_intr() in ixgbe_legacy_irq().

(msaitoh)

Add A1659A CRX framebuffer to "Supported hardware" list.

Also remove SGC support from "Unsupported hardware" list.

(tsutsui)

G/c trailing whitespace.

(uwe)

Add direct-config support.

(thorpej)

Attachment pretty print

(skrll)

Register each virtual bus's i2c_tag_t so that references for e.g. HDMI DDC
in the device tree work.

(thorpej)

Change fdtbus_register_i2c_controller() to directly register the i2c_tag_t,
rather than the device and a set of functions (the only of which was to
return the i2c_tag_t anyway).  Previously, this assumed only a single
i2c controller node per device_t, which is not true with an i2c mux.

(thorpej)

Deduplicate and group the USB stuff.  Spotted by uwe@

(skrll)

Tidyup the i.MX SoC support by

- Moving the  FDTised code to sys/arch/arm/nxp to match the
  sys/arch/{cpu}/{vendor} convention
- FDTise some more drivers
- Secure Non-Volatile Storage
- watchdog driver
- On chip OTP
- Match fsl,imx6dl
- Add some more drivers to GENERIC that will be supported by i.MX 6
  boards

(skrll)

make(1): fix a few lint warnings

(rillig)

make(1): fix lint warnings for constant condition in DEBUG calls

(rillig)

make(1): fix MAKE_RCSID for lint mode

Previously, running lint mode didn't define MAKE_RCSID at all, which
resulted in a syntax error.

While here, reduced the indentation and nesting of the preprocessor
directives.

(rillig)

make(1): rename CmdOpts.lint to strict

When running lint(1) on the code, it defines the preprocessor macro
"lint" to 1, which generated a syntax error in the declaration "Boolean
lint", as that became "Boolean 1".

(rillig)

make(1): remove trailing whitespace in manual page

(rillig)

make(1): fix memory leak in Var_Undef (since 2020-12-22)

(rillig)

Ticket #1159

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1159):

sys/dev/usb/ohci.c: revision 1.314
sys/external/bsd/dwc2/dwc2.c: revision 1.75
sys/dev/usb/ehci.c: revision 1.284
sys/dev/usb/uhci.c: revision 1.305
sys/dev/usb/xhci.c: revision 1.136

usb: Omit bogus assertions about struct usbd_pipe::up_intrxfer.

These assertions were only valid for pipes at UE_IN_DIR, UE_INTERRUPT
endpoints created with usbd_open_pipe_intr, which uses up_intrxfer to
pass the struct usbd_xfer object to usbd_close_pipe to free later.

In contrast, for pipes at UE_OUT_DIR, UE_INTERRUPT endpoints,
up_intrxfer is never initialized, so the assertion cannot be right.
In principle we might even have more than one outstanding interrupt
transfer at a time, rendering the point of the assertion moot anyway.

Found by interrupting a uhidev write to a u2f device.

ok nick

(martin)

Future-proof ID_AA64PFR0_EL1.GIC test -- any value other than 0 means that
the GIC CPU interface is supported.

(jmcneill)

More sorting

(skrll)

Fix fallout from mkimage rev 1.76.

For mkimage:

- Update "size" if auto-calculated.
- Use "dd bs=1" instead of non-portable "head -c".
- Some style nits.

For MD make_label() functions:

- Stop using "newsize" as image size in MB, use "size" instead.

(rin)

<space><tab> consistency

(skrll)

Sort some devices under each driver type

(skrll)

Note about bitmap access ops support for hp300 SGC CRX framebuffer.

(tsutsui)

Add bitmap access ops support for SGC CRX (A1659-66001) framebuffer.

Also modify existing 425e EVRX attachment to use updated MI sti(4) ops
more efficiently.

The Xorg server and mlterm-wscons (that support wsdisplay bitmap) work
fine on SGC hp425t.

No particular comments on port-hp300@ and port-hppa@:
https://mail-index.netbsd.org/port-hp300/2020/12/19/msg000184.html
https://mail-index.netbsd.org/port-hp300/2020/12/20/msg000185.html

Special thanks to Miod Vallat again, for contributing the SGC CRX
framebuffer with the SGC connector and flexible cable for HP9000/425t.

He also contributed DIO-II "Hyperion" monochrome framebuffer and
1 plane grayscale SGC GRX (A1924-66001), and I've confirmed hyper(4)
just works even with Xorg server.  I will try GRX as the next project.

(tsutsui)

Pull the latest OpenBSD sti(4) changes for bitmap framebuffer support.

- bitmap and colormap ops based on old HP ngle X11 driver:
  http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys/dev/ic/sti.c#rev1.76
  > Work-in-progress support for non-accelerated X11 on *some* sti(4)
  > frame buffers; based upon the old HP ngle X11 driver.
  > Currently limited to CRX (720/735/750), Timber (710, old 715),
  > Artist (712, 715) and EG (B-series), however the
  > colormap isn't set up correctly on Timber and EG yet.
  >
  > Joint work with Artem Falcon, now in good enough shape to be worked further
  > in the tree.
- misc other cosmetic changes to reduce diffs

No particular comments on port-hp300@ and port-hppa@:
https://mail-index.netbsd.org/port-hp300/2020/12/19/msg000184.html
https://mail-index.netbsd.org/port-hp300/2020/12/20/msg000185.html

The MD hp300 attachment for SGC CRX (A1659-66001) will be committed
separately.

(tsutsui)

Add missing '\n' in debug

(skrll)

Mention sparc64 E250 environmental monitoring.
Belatedly mention pcf8574(4).

(jdc)

Rename the CPU fan to SYS fan to match what the firmware calls it.
Check for fan failure and high temperature events when setting the fan
speed.  If one or both is true, run the fans at full speed.

(jdc)

Handle pins that represent alerts.
  split out common code for alert and indicator pins
  change the previously debug-only callout to work for alerts too
  split out common code for alerts in refresh and in callout
While here, remove redundant variable used for checking sysmon setup.

(jdc)

Add GPIO pin alert definitions for the E250.
Note, that the front panel also applies to the E450.

(jdc)

wsdisplay(4): WSDISPLAYIO_GET_EDID - fix struct name.

Spotted by RVP.

(uwe)

fix tpyo
spotted by RVP, thanks!

(macallan)

Add support for i2c-mux-gpio and i2c-mux-pinctrl I2C mux virtual
controllers.

(thorpej)

Add fdtbus_gpio_count(), which counts the number of GPIO entries
in a specified property.

(thorpej)

Add missing call to fdtbus_register_i2c_controller().  This doesn't
affect basic child attachment, but would have broken other references
to the i2c controller in DT overlays.

(thorpej)

evbarm: GENERIC.common - g/c the commented out copy of pseudo-device fss.

(uwe)

make(1): fix return type of macro DEBUG

This macro was supposed to return a boolean expression all the time, it
just hadn't been implemented this way.  This resulted in wrong output
for the test sh-flags, in compilation modes -DUSE_UCHAR_BOOLEAN and
-DUSE_CHAR_BOOLEAN, since in ParseCommandFlags, the expression
DEBUG(LOUD) didn't fit into a boolean.

(rillig)

make(1): allow .undef to undefine multiple variables at once

Since make doesn't support variable names containing spaces, this edge
case is not enough reason to stop this feature.  Having multiple
variable names as arguments nicely aligns with other directives such as
.for and .export.

(rillig)

make(1): add test for undefined variable in dependency declaration

(rillig)

nl(1): remove superfluous exit

Remove exit(3) call missed when errors were converted to errx(3).

(ginsbach)

Count bus_dmamap_sync events for coherent ranges and non-coherent ranges

(skrll)

When lpiconf flushing is required, make sure to flush to PoC and not PoU.
Spotted by nick.

(jmcneill)

make(1): fix comment in test about null bytes in makefiles

(rillig)

make(1): re-add improved assertion in ParseGetLine

(rillig)

make(1): remove assertion about lines ending with '\n'

It fails the NetBSD build.sh.

(rillig)

make(1): clean up after test opt-file

(rillig)

make(1): remove needless assignment to line_end in ParseGetLine

(rillig)

make(1): fix assertion failure for files without trailing newline

Previously, mmapped files didn't always have the final newline added.
Only those that ended at a page boundary did.

This confused ParseRawLine, which assumed (and since parse.c 1.510 from
moments ago also asserted) that every line ends with a newline, which
allows the code to assume that after a backslash, there is at least one
other character in the buffer, thereby preventing an out-of-bounds read.

This bug had been there at least since parse.c 1.170 from 2010-12-25
04:57:07, maybe even earlier, I didn't check.

Now line_end always points to the trailing newline, which allows
ParseGetLine to overwrite that character to end the string.

(rillig)

make(1): fix commit number in tests for :gmtime and :localtime

(rillig)

Correctly ACK the fan failure interrupt in ixgbe_legacy_irq().

(msaitoh)

make(1): prevent undefined behavior in loadfile_mmap

Reading a file without a trailing newline had resulted in an
out-of-bounds write, in the common case where the file is loaded via
mmap.

(rillig)

Nothing here came from UCB, it's all NetBSD.

(ad)

Comments.

(ad)

usb: Omit bogus assertions about struct usbd_pipe::up_intrxfer.

These assertions were only valid for pipes at UE_IN_DIR, UE_INTERRUPT
endpoints created with usbd_open_pipe_intr, which uses up_intrxfer to
pass the struct usbd_xfer object to usbd_close_pipe to free later.

In contrast, for pipes at UE_OUT_DIR, UE_INTERRUPT endpoints,
up_intrxfer is never initialized, so the assertion cannot be right.
In principle we might even have more than one outstanding interrupt
transfer at a time, rendering the point of the assertion moot anyway.

Found by interrupting a uhidev write to a u2f device.

ok nick

(riastradh)

make(1): remove excess newline from parse errors (since 2020-11-01)

For the modifiers :gmtime and :localtime, the excess newline had been
added in var.c 1.631 from 2020-10-31 21:40:20.

For the modifiers :range and :ts, the excess newline had been added in
var.c 1.635 from 2020-11-01 14:36:25.

(rillig)

make(1): align tests for :localtime with those for :gmtime

These tests had been almost the same before, now they are as similar as
possible again.

(rillig)

make(1): move tests for :gmtime to parse time

It's easier to have both the expressions and the expected values in a
single file.  This also allows for flexible handling of multiple
acceptable outputs, in this case for 32-bit time_t.

(rillig)

Set default for .MAKE.OS once

(sjg)

embedded/mkimage: Pad image with zeros to multiple of 4 MB plus 1 MB.

Otherwise, there may not be enough space after the ffs partition for a
gpt, leading to very confusing results.

(riastradh)

seemingly did not appear in netbsd 9

(nia)

Remove variable in function declaration argument

(skrll)

make(1): remove redundant parameters from ParseModifierPart

(rillig)

make(1): fix garbled output for failed shell command (since 2020-12-20)

Passing a struct as printf argument for the %s conversion doesn't work.
On NetBSD-8.0-x86_64, the output looks normal, but on SunOS-5.9, the
output is garbled, containing bytes 0xFF and 0xFE.

This bug had been introduced in parse.c 1.507 from 2020-12-20 14:52:16.

Thanks to sjg for finding this bug so quickly.

(rillig)

make(1): save a few memory allocations in variable expressions

(rillig)

make(1): switch memory handling from MFStr to FStr

This makes all intermediate strings constant.  For this simple
search-and-replace refactoring, all intermediate locations where the
"current value of the expression" was stored had to be of the type
MFStr.

Using FStr instead of MFStr allows to save a few memory allocations,
which will be done in the follow-up commits.

(rillig)

make(1): clean up memory management for expanding variable expressions

Previously, memory management had been split among several variables.
The general idea was very simple though.  The current value of the
expression needs to be kept in memory, and each modifier either keeps
that value or replaces it with its own newly allocated result, or
var_Error or varUndefined.

Using MFStr, it does not matter anymore that var_Error and varUndefined
are statically allocated since these are assigned using MFStr_InitRefer.

The complexity of the implementation is now closer to the actual
complexity.  Most probably the code can be simplified even more.

(rillig)

make(1): add tests for :tW and :tw modifiers

(rillig)

make(1): use FStr for ApplyModifiersState.newVal

Memory management is still complicated in this area.  To clean this up,
the previous value of the expression needs to be converted to an MFStr
first, and later to an FStr.

(rillig)

make(1): add tests for variable modifiers on trailing slashes

(rillig)

make(1): fix undefined behavior in meta_oodate

Do not increment a null pointer.

Do not assign to a variable twice in the same statement.  To be fair,
this may be safe because of the sequence point when the function is
called, but anyway, it looks too close to undefined behavior.

(rillig)

make(1): reduce scope of cp in meta_oodate

That function is way too long (550 lines) and has too creative variable
names such as fname, fname1, fname2, fname3.

(rillig)

make(1): fix declared variable type in printCMDs

No functional changes since StringListNode and GNodeListNode are both
typedefs of a simple generic ListNode.

(rillig)

run_rc_command - don't prefix the rcvar variable name with the dollar sign.

The output without the dollar sign is less confusing as it's actual
valid shell syntax:

  $ /etc/rc.d/foo rcvar
  # food
  food=YES

Brought up on tech-userlevel@ by Rocky Hotas with some LGTMs from
other people and no objections.

We still refer to '$food' in warnings/errors though.

(uwe)

make(1): omit linear search for command in Compat_RunCommand

(rillig)

make(1): remove redundant assignment in ApplyModifier_SysV

(rillig)

make(1): error out on unknown variable modifiers at parse time

Before, make printed an "error message" that did not include the word
error and thus was not easily identified as such.  This "error message"
also did not influence the exit status in the default mode but only in
-dL mode.  The error message also didn't include any line number
information and was thus rude.

(rillig)

make(1): include line numbers in output of test varmod-edge.mk

Suppressing the line numbers does not provide much benefit, given that
the test file doesn't change often.

(rillig)

disable (U)DMA for ATAPI on aceride(4), the chip doesn't support it
PR port-sparc64/55540

(jdolecek)

make(1): move tests for indirect modifiers around

The next commit will error out on unknown modifiers and influence the
exit status.  The test modmisc.mk contains both parse time tests and run
time tests.  To prevent the latter from being run, the parse error is
moved to varmod-indirect.mk, which only contains parse time tests.

(rillig)

make(1): remove wrong error message for indirect modifier in lint mode

(rillig)

make(1): document that indirect modifiers fall back to SysV modifiers

(rillig)

make(1): remove redundant const declarations for parameters

(rillig)

make(1): extract ApplySingleModifier from ApplyModifiers

(rillig)

make(1): turn ApplyModifiersState.val into a local variable

This reduces the scope and makes it more obvious at which places this
variable can be changed and how the memory management is done.

(rillig)

Support __HAVE_PMAP_PV_TRACK in sys/uvm/pmap based pmaps (aka common pmap)

(skrll)

Remove bogus KASSERT - can't assert a spin mutex is !mutex_owned.

(skrll)

Remove VM_MD_TO_PAGE that was accidentally committed in 1.106.  It's going
to be readded with the code that uses it

(skrll)

make(1): use FStr for memory management in Var_SetWithFlags

(rillig)

make(1): extract SetVar from Var_SetWithFlags

SetVar contains the part that is not concerned about memory management
and expansion of the variable name.

(rillig)

make(1): fix memory leak in Var_Delete (since yesterday)

The memory leak had been introduced in var.c 1.736 from 2020-12-19
20:47:24.

(rillig)

make(1): clean up memory handling in VarAssign_EvalShell

(rillig)

make(1): clean up memory handling in Parse_DoVar

(rillig)

make(1): remove constant parameter from MakeMode

(rillig)

make(1): change return type of Var_Value to FStr

(rillig)

make(1): use FStr in VarNew

(rillig)

make(1): eliminate libName_freeIt from Arch_ParseArchive

(rillig)

make(1): return FStr from Var_Parse

This reduces the number of variable declarations at the call sites.

(rillig)

make(1): clean up memory handling in CondParser_String

(rillig)

make(1): export FStr and MFStr

These types are a replacement for the pattern "var + var_freeIt" that
enforces these two variables to be updated together.

(rillig)

make(1): clean up memory handling in CondParser_String

(rillig)

Remove old part of comment

(skrll)

sun4v: add comment in sun4v_tl1_ptbl_miss code path - no functional change

(palle)

make(1): document memory handling in ApplyModifiers

(rillig)

Some KNF.  NFC.

(skrll)

make(1): replace freeIt with FStr in EvalUndefined

Previously, the parameter out_freeIt was not guaranteed to be
initialized in every case, at least when looking only at EvalUndefined.
This contradicted the variable name.

Replace the two parameters with a single FStr to ensure that these
variables are always initialized together.

(rillig)

style fix

(jmcneill)

Managment -> Management

(jmcneill)

For the E250:
  set fans to medium speed when attaching and full speed when detaching.
  remove unused PS fan definition.
In general:
  return early from attach if the device isn't present.
  handle errors from sysmon during attach so that detach doesn't crash.
  try to handle errors when acquiring the iic bus during detach.

(jdc)

Improve the English in the previous comment fix.

(skrll)

make(1): replace FStr_Assign with separate initialization functions

In GetVarnamesToUnexport, there is no need to free the local FStr since
the only place where it is assigned an allocated string is at the very
end.

Having separate functions for the two main use cases of a possibly
allocated string makes the calling code simpler.  This is a preparatory
commit for making the memory allocation in ApplyModifiers easier to
understand.

(rillig)

make(1): extract string functions from ApplyModifier_To

(rillig)

Retry clearing WDCTL_RST a few times before giving up. Makes SATA work in
Solidrun Honeycomb LX2K.

(jmcneill)

ddb: add two new modifiers to "show pool" and "show all pools"

- /s shows a short single-line per pool list (the normal output
  is about 10 lines per.)
- /S skips pools with zero allocations.

(mrg)

update several items that are done or dead.

(mrg)

No need to allocate bounce buffers if we have a single range that covers
all of physical memory.

(jmcneill)

make(1): fix error message for .info/.warning/.error without argument

Previously, the error message was "Unknown directive", which was
obviously wrong.  The new error message is "Missing argument".

(rillig)

Use sel{record,remove}_knote().

(thorpej)

Use sel{record,remove}_knote().

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

make(1): error out if .undef has not exactly 1 argument

(rillig)

Use sel{record,remove}_knote().

(thorpej)

Use sel{record,remove}_knote().

(thorpej)

implement boot -d for arm64.

could be done at the end of initarm() except it hangs currently.
this gets you a db> prompt before devices are configured.

ok @skrll.

(mrg)

malloc(9) -> kmem(9)

(thorpej)

Use sel{record,remove}_knote().

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

Use sel{record,remove}_knote().

(thorpej)

make(1): extract Var_DeleteVar from Var_Delete

(rillig)

make(1): add tests for undefining variables with exotic names

(rillig)

make(1): extract Var_Undef from ParseDirective

(rillig)

make(1): rewrite tests for misspelled .elif directive

Put the simple tests at the top, demonstrating that there are already
some cases in which the misspelled directive is detected.  It's not
detected though if the surrounding conditional branch is skipped.

(rillig)

ahci_exec_fis: wait for the correct amount of time when AT_WAIT is set

(jmcneill)

Tickets #1639 and #1640

(martin)

Pull up following revision(s) (requested by tsutsui in ticket #1640):

sys/dev/scsipi/scsiconf.c: revision 1.283

Add NOLUNS quirk for more SEAGATE SCA/WIDE drives.

Tested on NetBSD/luna68k and LUNA with SCA 80pin -> NARROW 50pin and
WIDE 68pin -> NARROW 50pin connectors.

(martin)

Pull up following revision(s) (requested by tsutsui in ticket #1639):

distrib/miniroot/install.sub: revision 1.54 (patch)
distrib/miniroot/install.sub: revision 1.56 (patch)
distrib/miniroot/install.sub: revision 1.57 (patch)
distrib/miniroot/install.sub: revision 1.58 (patch)
distrib/miniroot/install.sub: revision 1.59 (patch)
distrib/hp300/miniroot/install.md: revision 1.20
distrib/miniroot/list: revision 1.36
distrib/mvme68k/miniroot/install.md: revision 1.9
distrib/mvme68k/miniroot/install.md: revision 1.10
distrib/sun3/miniroot/install.md: revision 1.6
distrib/miniroot/install.sub: revision 1.47 (patch)
distrib/sun3/miniroot/install.md: revision 1.7
distrib/sun2/miniroot/install.md: revision 1.6
distrib/sun2/miniroot/install.md: revision 1.7
distrib/amiga/miniroot/install.md: revision 1.31
distrib/mac68k/miniroot/install.md: revision 1.6
distrib/mac68k/miniroot/install.md: revision 1.7
distrib/mac68k/miniroot/install.md: revision 1.8
distrib/miniroot/upgrade.sh: revision 1.23
distrib/miniroot/install.sh: revision 1.26
distrib/miniroot/upgrade.sh: revision 1.24
distrib/miniroot/install.sh: revision 1.27
distrib/hp300/miniroot/install.md: revision 1.18
distrib/hp300/miniroot/install.md: revision 1.19
distrib/miniroot/install.sub: revision 1.50 (patch)
distrib/miniroot/install.sub: revision 1.51 (patch)
distrib/miniroot/install.sub: revision 1.52 (patch)
distrib/miniroot/install.sub: revision 1.53 (patch)

Remove uses of test ... -a ... and test ... -o ...
eXorcize and `` -> $()
Fix miniroot installation failure on network configuration.  PR/54833
No particular comment in the PR.
Should be pulled up to netbsd-9.
Fix "[: SMALL test, no fallback usage" error on miniroot installation.
Avoid and replace use of '-a', '(' and ')' operatos marked obsolescent
by modern POSIX.1-2017:
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html#tag_20_128_16
as suggested by kre@ in PR/54835.
Should be pulled up to netbsd-9.
The idiom
set $whatever
while [ $# - gt 10 ]; do shift 10; done
eval echo \$$#
fails when $# turns out to be 10 (or any multiple), it would need
to be instead
while [ $# -ge 10 ]; do shift 9; done
but there hasn't been a shell that cannot handle ${10} (etc) correctly
in a very long time, so let's just use that instead (properly quoted,
in case IFS happens to contain a digit for some bizarre reason).
We should also "set -f" / "set +f" (or better, restore the prev setting of -f)
around the "set $whatever" part, but if that was ever going to cause a problem
here, it would have already, so leave that for now.
test ! -n "$foo"  is just a quaint way of saying test -z "$foo"
and test ! -z "$foo" is really just test -n "$foo"  so let's just
use the simple (and more obvious) forms.
NFCI.
The kernel and X sets should be specified in MD miniroot scripts.
Otherwise they are not listed at least on ftp installation.
The problem was reported by Martin Trusler on port-hp300@:
https://mail-index.netbsd.org/port-hp300/2020/11/21/msg000174.html
Should be pulled up to netbsd-9 and netbsd-8.
Add modules set for default sets on miniroot installation.
Should be pulled up to netbsd-9 and netbsd-8.
Add missing md_get_partition_range() that causes installation failure.
Also reported by Martin Trusler on testing hp300 miniroot.
Should be pulled up to netbsd-9 and netbsd-8.
Explicitly sort set names fetched via ftp nlist.
Several binary sets are stored as symbolic links on releases and
it seems some ftpd doesn't sort nlist outputs by name in such case.
Worth to pullup to netbsd-9 and netbsd-8.
Use proper release version strings ("9.1" rather than "91") in banners.
Also define and use "MACHINE" variable to describe port names
(no uname(1) or sysctl(8) in miniroot binary list by default).
I guess the short format like "91" by ${DISTRIBREV} was used only
for split sets for floppies in 1990's releases.
Worth to pullup to netbsd-9.
Inform the default installation directory in the official ftp server.
Fetch files via ftp using auto-fetching with URL per each binary set.
On slower machines, it takes more than five minutes to get a large
set binary and it could cause timeout of ftp control session, so
getting multiple binary sets in a single ftp session always fails.
Briefly tested on HP 9000/425e with 9.1 tree and ftp.netbsd.org binaries.
No particular comments on tech-install@ and port-hp300@.
Maybe should be pulled up to netbsd-9.

(martin)

ata_timeout: restore spl in ATACH_RECOVERING path

(jmcneill)

make(1): extract ParseSkippedBranches from ParseReadLine

(rillig)

make(1): extract ParseForLoop from ParseReadLine

(rillig)

make(1): rename mode constants for ParseGetLine to be more expressive

(rillig)

make(1): add test for null byte in .for loop body

(rillig)

make(1): fix documentation of GetLineMode

ParseGetLine always returns a logical line, even for PARSE_RAW.

(rillig)

- malloc(9) -> kmem(9)
- Use sel{record,remove}_knote().

(thorpej)