Added sysctl nodes for ixl(4) Interrupt throttling(ITR)

(yamaguchi)

Fix a tyop.  Thankfully this #define was unused.

(simonb)

Fix TLB count probe on MIPS32R2+/MIPS64R2+ for CPUs that have a Config4
register with a Config4[MMUExtDef] value.

(simonb)

make(1): fix undefined behavior in malformed :S modifier

The unit tests failed on Ubuntu, and by looking closely at the code, it
was trivial to see the out-of-bounds memory read.

Other modifiers may have the same problem and will be inspected later.

(rillig)

fix the UFS2 extattr truncate code to play nice with wapbl.
also, rather than pull in the FreeBSD V_NORMAL/V_ALT flags to
vinvalbuf() and the buf b_xflags field and BX_ALTDATA flag,
add a binvalbuf() function to invalid a specific buffer
and use that to invalidate the two possible exattr bufs
during IO_EXT truncations.

(chs)

Rename MIPSNN_CFG4_MMU_EXT_DEF_MMU_SIZE_EXT to MIPSNN_CFG4_MMU_SIZE_EXT.

(simonb)

CN70XX also has Config6 (CvmMemCtl2) and Config7 (CvmVMConfig) registers.

(simonb)

CP0 Config6 and Config7 aren't probeable.  Adjust comments for these two.

(simonb)

CN70XX has a config4 CP0 register.

(simonb)

Add two cnMIPS III COP0 register names.

(simonb)

Bit definitions Config4 and Config5 registers.

(simonb)

if we find composity sync enabled, leave it on instead of unconditionally
enabling it on sparc*

(macallan)

Publicly declare st40_pmb_init().

(uwe)

Fix grammar.

(uwe)

ST40_PMB_DA_BITS - all values for the non-continuous size field.

Size field has two reserved bits in the middle.  Don't depend on them
being zero, they can be defined in future versions.  Provide exhaustive
list with all possibile "filler" bits in the middle so that we
correctly report the size field value regardless of the unrelated bits.

(uwe)

Cite Cryptography Research evaluation of VIA RNG and give live URL.

(URL verified to be archived in the Internet Archive for posterity)

(riastradh)

Remove now unused ModMap data for each keyboard.

(tsutsui)

Initialize ModMap dynamically using keymap data per each keyboard.

Now ScrollLock LED works properly.

(tsutsui)

make(1): add test for indirect unclosed variable

The error message mentions only the original variable name right now.
It's left to the Makefile author to see where the actual unclosed
variable value comes from.  From a usability standpoint that's not
optimal, but everything else would need additional cycles even in the
good cases, or it might have side-effects when evaluating a variable
twice (once to detect the error, and a second time to find out the
details of the error).

(rillig)

Update a comment

(skrll)

Sort the #define __HAVEs. NFCI.

(skrll)

Code to dump PMB contents.

(uwe)

Add snprintb formats.  Fix PASCR name.

(uwe)

db_get_line - raw access to the DDB command line.

Provide a way for DDB commands to access the remainder of the command
line as-is.

(uwe)

make(1): remove unnecessary assignments to st->next

No change in the size of the resulting binary.  Apparently GCC already
knew these assignments were redundant.

(rillig)

make(1): document parameters to ApplyModifiers

(rillig)

make(1): use specialized return type for ApplyModifier functions

This makes it immediately obvious what happens after a modifier has been
applied, instead of having to translate single-character mnemonics or
booleans to their actual intention.

This also reduces the size of the binary since there are fewer jumps.

(rillig)

make(1): fix segfault when evaluating ${::=value}

The bug had been in the handling of the SysV modifier for many years, but
it had not been triggered since the "parsing position for the next
modifier" had been initialized to a non-NULL pointer.

In var.v r1.350, this pointer had been initialized to NULL instead since
every ApplyModifier function must set it in every case where it returns
anything except "default_case".

There might have been a slight chance of tricking make to output a wrong
error message, but nothing worse.

(rillig)

make(1): add enough tests to cover the ApplyModifier functions

Only a few return statements are still missing from the code coverage.

In ApplyModifier_Assign, the test for an empty variable name is skipped
for now since it segfaults.

In ApplyModifier_SysV after the second ParseModifierPart, the branch for
the missing delimiter is not reached since this case is already checked
for in the first part of the function. To trigger this branch, a
specially crafted, unrealistic string needs to be created, and that's too
complicated for the moment.

(rillig)

make(1): add unit tests for parse errors in modifiers

(rillig)

Remove unused functions required to handle non-XKB autorepeat.

(tsutsui)

Fix LED defintions to match xkb/xkbInit.c.

Now CapsLock and NumLock LEDs work correctly.
XXX: No ScrollLock LED

(tsutsui)

Issue three more swaps to save eight stores.

Reduces code size and yields a small (~2%) cgd throughput boost.

Remove duplicate comment while here.

(riastradh)

fix xmm7360_os_msleep() macro to actually work when not wrapped inside a block

from genua

(jdolecek)

sprinkle __diagused so this compiles without DIAGNOSTIC

(jdolecek)

adjust OpenBSD mbuf handling so tcpdump(1) works there; from genua

keep code as-is for NetBSD, DLT_RAW works there

(jdolecek)

Add definitions for the CP0 WatchLo/WatchHi registers.

(simonb)

rename label now that it has dual purpose; suggested by mrg@

(jdolecek)

gettext-0.21 is out.

(wiz)

cninit - don't reset cn_tab on entry.

cn_tab can be already set up by the MD startup code to point to an
early console vtable that can still be useful for debugging and as a
fallback.

(uwe)

make(1): add test for setting .OBJDIR via the command line

(rillig)

Build mkubootimage for evbsh3 too.

(uwe)

Don't write SR twice.

__INTR_MASK sets PSL_IMASK bits in SR but then in the next instruction
we overwrite SR anyway, so drop that redundant __INTR_MASK.

(uwe)

make(1): add test for including a nonexistent or empty file

(rillig)

G/c trailing whitespace.

(uwe)

Rewrite cprng_fast in terms of new ChaCha API.

(riastradh)

Draft 2x vectorized neon vpaes for aarch64.

Gives a modest speed boost on rk3399 (Cortex-A53/A72), around 20% in
cgd tests, for parallelizable operations like CBC decryption; same
improvement should probably carry over to rpi4 CPU which lacks
ARMv8.0-AES.

(riastradh)

Implement 4-way vectorization of ChaCha for armv7 NEON.

cgd performance is not as good as I was hoping (~4% improvement over
chacha_ref.c) but it should improve substantially more if we let the
cgd worker thread keep fpu state so we don't have to pay the cost of
isb and zero-the-fpu on every 512-byte cgd block.

(riastradh)

Fix big-endian build with appropriate casts around vrev32q_u8.

(riastradh)

make(1): add test for missing argument validation in .undef

(rillig)

make(1): add test about possibly ambiguous suffix rule

(rillig)

make(1): remove unnecessary parentheses in obvious cases

(rillig)

Use egrep rather than grep -E

Also we need to exclude noise that some shells include.
This is why the original test restricted itself to checking
for UT_* in env.

(sjg)

Use cat if no POSTPROC.${.TARGET:R}

On Linux sed with no flags throws an error.

(sjg)

make(1): remove dead code in parse error handling

(rillig)

make(1): add tests for unknown indented directives

It's quite expected that the .${:Uinfo} is not yet expanded when the
directive is parsed, otherwise the directive would have been accepted.
The surprising thing is that it is expanded at the point where the error
message is generated.

(rillig)

make(1): when parsing an unknown directive, print the directive name

(rillig)

make(1): refine test for detecting misspellings in directives

The names of directives are only checked if the lines are actually
relevant.  In all other cases, the amount of work is reduced to the bare
minimum, which is just to scan for line continuations.

(rillig)

make(1): issue a parse error on unclosed variables

These errors had not been detected before by make.
In pkgsrc, this task as been done by pkglint since 2019-04-07.

(rillig)

make(1): remove unnecessary struct tag

Identifiers starting with an underscore and an uppercase letter are
reserved for the C implementation.

(rillig)

make(1): remove dead code from Var_Subst

The first parameter from Var_Subst had been a literal NULL in all cases.
These have been fixed using this command:

sed -i 's|Var_Subst(NULL, |Var_Subst(|' *.c

The one remaining case was not found because the "NULL," was followed by
a line break instead of a space.

The removed code probably wouldn't have worked as expected anyway.
Expanding a single variable to a literal string would have led to
unexpected behavior for cases like ${VAR:M${pattern}}, in case pattern
would contain an unescaped ':' itself.

(rillig)

Ensure .CURDIR is correct for tests that run sub-makes

(sjg)

make(1): disable archive test

On FreeBSD, running the archive.mk test results in "create-archive is up
to date" and similar messages.  The situation is unclear, and the
archive code seems to be practically unused.  Furthermore the archive
test doesn't ensure that it is run in ${.PARSEDIR}, so it needs a bit
more work.

(rillig)

say what is not configured in nvme_print()

(jdolecek)

Fix typo in comment.

(riastradh)

Omit now-unused function.

Ceased to be needed with the AES CCM changes.

For some reason gcc didn't complain about this, but clang did.

(riastradh)

Use CPU_IS_PRIMARY macro in cpu_stop(), cpu_resume(), and cpu_get_tsc_freq()
on x86.

OK kamil@

(fcambus)

Add TSV

(leot)

Initialize authctr in both branches.

I guess I didn't test the unaligned case, weird.

(riastradh)

note that MSI was enabled by default for Xen

(jdolecek)

remove NO_PCI_MSI_MSIX again, enabling MSI for Xen Dom0 by default

(jdolecek)

add a quirk to disable MSI, and enable it for Intel SSD DC P4500

this device seems to cause serious system responsiveness issues when configured
to use MSI, while it works fine when configured for either INTx or MSI-X

this is important so this works well under Xen Dom0, which doesn't
support MSI-X yet

fixes another issue reported as feedback for PR port-xen/55285 by Frank Kardel

(jdolecek)

_LKM -> _MODULE

(skrll)

Use -r for export.mk to minimize interference

(sjg)

Change cpus_booted back to a simple variable instead of a kcpuset.
octeon_cpu_spinup() was trying to set CPU status immediately on kernel
startup _well_ before the kcpuset was initialised.

(simonb)

make(1): add test for modifier part with unbalanced braces

(rillig)

make(1): remove redundant ApplyModifiersState.termc

(rillig)

make(1): document and reorder ApplyModifiersState

(rillig)

make(1): rename ApplyModifiersState.nstr and newStr

The old names were too easy to confuse.  In Var_Parse, nstr is indeed
used for the "new string", but that was misleading in ApplyModifiers,
especially since there was another variable called newStr.

The new variable names focus on the purpose of the variables, not on
their data types.

(rillig)

make(1): rename ApplyModifiersState.cp to next

The name "next" is more descriptive than a mere "cp".  It's easy to look
up the type of the variable, but not so easy to guess the purpose of the
variable, therefore the new name concentrates on the purpose.

(rillig)

make(1): in ApplyModifier_Match, use short local variable name

(rillig)

make(1): in ModifyWord_Match, use different variables

Using the same registers or memory locations for different variables is
the job of the register allocator, not the programmer.  For humans, that
practice is rather confusing.

(rillig)

make(1): replace comment in ApplyModifier_Match with code

(rillig)

make(1): remove unused lengthPtr and freePtr from ApplyModifiersState

(rillig)

make(1): remove unnecessary field from ApplyModifiersState

(rillig)

make(1): remove unnecessary variable assignment

It is not the job of an ApplyModifier function to directly manipulate the
final result of the ApplyModifiers function.  In fact, the resulting
pointer was overwritten unconditionally, in such an obvious way that the
compiler could have detected this.  GCC 5 didn't though, which reduces
the code size a bit.

(rillig)

make(1): move modifier character out of ApplyModifiersState

It is only used in the outer part of the loop to apply the modifiers.

(rillig)

make(1): replace macros with functions

Having the hidden parameter st->endc in the macro made it unnecessarily
difficult to understand the code.

(rillig)

make(1): use shorter variable name for parsing :D and :U

(rillig)

It's __ARM_NEON, not __ARM_NEON__, sometimes, apparently.

(riastradh)

Note that VSRI seems to hurt here.

(riastradh)

Take advantage of REV32 and TBL for 16-bit and 8-bit rotations.

However, disable use of (V)TBL on armv7/aarch32 for now, because for
some reason GCC spills things to the stack despite having plenty of
free registers, which hurts performance more than it helps at least
on ARM Cortex-A8.

(riastradh)

Add RCSIDs to the AES and ChaCha .S sources.

(riastradh)

make(1): document where to fix the .INCLUDEDFROM bug

(rillig)

catch up with source rename of fbsd-zfs -> zfs

(christos)

Issue aese/aesmc and aesd/aesimc in pairs.

Advised by the aarch64 optimization guide; increases cgd throughput
by about 10%.

(riastradh)

Align critical-path loops in AES and ChaCha.

(riastradh)

PIC for aes_neon_32.S.

Without this, tests/sys/crypto/aes/t_aes fails to start on armv7
because of R_ARM_ABS32 relocations in a nonwritable text segment for
a PIE -- which atf quietly ignores in the final report!  Yikes.

(riastradh)

Enable ChaCha NEON code on armv7 too.

The 4-blocks-at-a-time assembly helper is disabled for now; adapting
it to armv7 is going to be a little annoying with only 16 128-bit
vector registers.

(Should also do a fifth block in the integer registers for 320 bytes
at a time.)

(riastradh)

Use <aarch64/asm.h> rather than copying things from it here.

Vestige from userland build on netbsd-9 during development.

(riastradh)

Fix outdated comment.

(riastradh)

Simplify ChaCha selection and allow it to be used much earlier.

This way we can use it for cprng_fast early on.  ChaCha is easy
because there's no data formats that must be preserved from call to
call but vary from implementation to implementation -- we could even
make it a sysctl knob to dynamically select it with negligible cost.

(In contrast, different AES implementations use different expanded
key formats which must be preserved from aes_setenckey to aes_enc,
for example, which means a considerably greater burden on dynamic
selection that's not really worth it.)

(riastradh)

Reduce some duplication.

Shouldn't substantively hurt performance -- the comparison that has
been moved into the loop was essentially the former loop condition --
and may improve performance by reducing code size since there's only
one inline call to chacha_permute instead of two.

(riastradh)

make(1): add tests for parsing directives like .if and .info

(rillig)

New sysctl subtree kern.crypto.

kern.crypto.aes.selected (formerly hw.aes_impl)
kern.crypto.chacha.selected (formerly hw.chacha_impl)

XXX Should maybe deduplicate creation of kern.crypto.

(riastradh)

Gather auth[16] and ctr[16] into one authctr[32].

Should appease clang.

(riastradh)

make(1): remove unnecessary argument validation

(rillig)

make(1): add test for exporting single-character variables

(rillig)

make(1): prepare test for .export to show all exported variables

Currently the unit tests don't cover exporting of local variables like
.TARGET or @.  To see the effects, all exported variables must be listed
by the tests.

(rillig)

make(1): sort flags for test cases alphabetically

(rillig)

make(1): improve const-correctness in archive handling

The return value of Var_Value must not be modified.  Ideally it would be
declared as const char *, but that still takes a while, especially since
much of the make code is not yet covered by the unit tests.

The variable cp had to be changed to const char * as well, and while here
was split up into one variable per actual use case.

(rillig)

make(1): ignore gcov files for CVS

(rillig)

make(1): add test for unsetting an environment variable in -e mode

(rillig)

make(1): add very basic test for archive handling

The whole code in arch.c had been uncovered by tests before.

The code coverage shows that neither the archive name nor the member
contain any $, even though archive.mk looks like it.  It could be
necessary to place the variable assignments below the dependency line,
to force late evaluation.

(rillig)

make(1): add very basic test for archive handling

The whole code in arch.c had been uncovered by tests before.

The code coverage shows that neither the archive name nor the member
contain any $, even though archive.mk looks like it.  It could be
necessary to place the variable assignments below the dependency line,
to force late evaluation.

(rillig)

Skip v2m probe if armgic fails to attach

(jmcneill)

Remove CPU ID test in armgic_match. Perfectly normal to have GIC in
non-Cortex cores.

(jmcneill)

make(1): document API of Var_Value

(rillig)

Skip the repeated_link_addr test by default as it causes the
evbarm-aarch64 testbed to hang (PR port-evbarm/55521), and will not be
safe to run by default even after that bug is fixed, for similar
reasons as t_repeated_updown.

(gson)

Trailing whitespace

(skrll)

Improve the workqueue and callout handling.  Prompted by riastradh@.

(jdc)

icmp6: Remove __packed attribute from icmp6 structures

They should naturally align.
Add compile time assertations to icmp6.c to prove this.

(roy)

add reference to net/py-xmm7360 for the network initialization script

(jdolecek)

Nix trailing whitespace.

Helpful hint:

(setq show-trailing-whitespace t)

(riastradh)

ip6: Remove __packed attribute from ip6 structures

They should naturally align.
Add compile time assertations to ip6_input.c to prove this.

(roy)

Don't remove the _LKM #ifdefs, but do s/_LKM/_MODULE/

(skrll)

more attribution

(jdolecek)

s/MODULE/_MODULE/

spotted by chuq@

(skrll)

Don't remove the _LKM #ifdefs, but do s/_LKM/_MODULE/

(skrll)

Don't define _LKM. LKMs are dead. Long live modules.

(skrll)

Fix typo _MODULAR -> _MODULE.  Hopefully this fixes the builds.

(skrll)

Use the new "run_unsafe" atf_config_get() option also with a couple of other
tests that are known to be unsafe.

(jruoho)

fix build error. need cast.

(ryo)

Instead of just skipping interfaces that are "up", skip the whole
repeated_updown test case unless explicitly enabled with "atf-run -v
run_unsafe=yes".  Gratuitously configuring interfaces "up" is no more
safe than gratuitously configuring them "down"; for example, it could
lead to accidentally connecting to an insecure network or diverting
traffic from the desired route.

(gson)

Improve PostScript output.

Some highlights in no particular order:

%destructor was somehow lost from the list that follows, it should be
part of it.

Use .Ic for yacc directives when they are defined, .Ql otherwise.

Use explicit .Sq Li (instead of .Ql) in description of %destructor to
make sure the result is consistently quoted.  It more readable that
way.

Use .Va and .Vt where appropriate.

C preprocessor directives are marked up with .No (a nop), so that it's
easy to switch them to something else if need be.  For now just use
them as plain words.

(uwe)

Fix markup errors.

(uwe)

make(1): make test for dynamic variable name more specific

Since all the string literals have either 7 or 8 characters, there is no
need to call strcmp for shorter or longer variable names.

(rillig)

make(1): extract code for dynamic variable names out of Var_Parse

(rillig)

Add debug output for ENDDEFS.

This makes it more clear in the debug output where config switched
from definitions to selections.

(uwe)

Don't print the location of the include directive twice.

cfgdbg() already prints the current file and line number, so don't
print the same information ourselves in the message too.

(uwe)

make(1): fix off-by-one error in Var_Parse for dynamic variables

(rillig)

make(1): add test for off-by-one error in Var_Parse

(rillig)

Minor wording improvements.

(wiz)

make(1): add coverage test for dynamic = TRUE in Var_Parse

(rillig)

make(1): rename VarEvalFlags variables to eflags

This way, they cannot be confused with other flags, and any mismatch of
mixing eflags with constants other than VARE_* is immediately apparent.

(rillig)

use the right printing function

(christos)

make(1): rename local variable in Var_Parse

(rillig)

make(1): add test for unclosed variables

(rillig)

make(1): add test for expanding dynamic variables

(rillig)

make(1): make return value of Var_Parse constant

This return value is not supposed to be modified since it can be a string
literal.  The modifiable part is returned via freePtr, but only for
freeing, not for actually modifying anything.

(rillig)

make(1): explicitly add dependencies on headers

This prevents partial builds after changing a header.  The declared
dependencies are more than strictly necessary, but that's still better
than having inconsistent partial builds because too few dependencies are
declared.

(rillig)

make(1): revert making Var_Parse return a const string

The dependencies between the C files and nonints.h are not declared
properly, which resulted in a successful partial build, but a full "make
clean && make" failed.

(rillig)

make(1): mark result of Var_Parse as const

Var_Parse can return either a string literal or an allocated string.  The
former must not be modified by the caller.  If the string is allocated,
it is returned in freePtr as well, but only for freeing it after use.

(rillig)

make(1): reduce scope and rename local variable in Var_Parse

(rillig)

make(1): eliminate another local variable in Var_Parse

(rillig)

make(1): split local variable into two in Var_Parse

(rillig)

make(1): split local variable into two

Reusing a const char * parameter to store a char * and later free that
string was not a good idea. It made the pretty long code of Var_Parse
more difficult to understand.

(rillig)

replace KDE with a desktop that's actually current in pkgsrc

(nia)

make(1): reorder arguments of ParseModifierPart

First the input parameters, then additional data, then special arguments.

(rillig)

extattr.3 is obsolete

(christos)

make(1): merge VARE_NOSUBST into VARE_WANTRES

The flag VARE_NOSUBST is only a few days old. It had grown out of the
VARP_NOSUBST and VAR_NOSUBST flags, not knowing at that time that it
meant the exact opposite of VARE_WANTRES.

(rillig)

this file contained the same information as extattr_namespace_to_string.3
and somewhat incorrect too.

(christos)

make(1): remove wrong comment from VarOrder

(rillig)

make(1): reorder code in ParseModifierPart to be more readable

(rillig)

make(1): in ParseModifierPart, only update length on success

(rillig)

fix attribution - I was confused what was the correct final version

(jdolecek)

make(1): remove wrong comment for VarUniq

VarUniq is not about sorting the words.

(rillig)

make(1): save a few bytes and cycles by comparing against 0

The comparison against ac - 1 could have been optimized by the compilers
as well, but both GCC 5 and Clang produce smaller code for the comparison
against 0.

(rillig)

make(1): remove unnecessary block scope

(rillig)

make(1): document the circumstances in which brk_string returns NULL

(rillig)

finish sentence

(jdolecek)

add note that the network initialization script needs the device nodes
to be created

(jdolecek)

If Unwind_Backtrace is broken, ctx.n will still contain ~0, and we will
return that which poor behavior for the user, so return 0 instead.
We could document ~0 to be an error, but that would deviate from the
Linux behavior which is not desirable. Noted by Poul-Henning Kamp

(christos)

make(1): avoid memory allocation for oneBigWord in modifiers

(rillig)

add support for wwanc(4) device nodes (xmm[0-9])

(jdolecek)

robots: Use arc4random_uniform for better uniform distribution

(nia)

make(1): help the compiler to find common subexpressions

(rillig)

make(1): add convenience functions for adding to a SepBuf

(rillig)

random(6): Use arc4random_uniform to simplify code

(nia)

note new Intel XMM7360 driver

(jdolecek)

Revert arc4random usage for now

this is a host tool and needs to be portable

future plans: add arc4random to libnbcompat

(nia)