Link [ NetBSD | NetBSD OpenGrok source search | PR fulltext-search | Summary of daily snapshot builds | history of daily build result | pkgsrc commit viewer ]


   
        usage: [branch:branch] [user:user] [path@revision] keyword [... [-excludekeyword [...]]] (e.g. branch:MAIN sys/arch/arm, if_wm.c@1.234 )




switch to index mode

recent branches: MAIN (2h)  netbsd-8 (5d)  netbsd-10 (6d)  netbsd-9 (12d)  thorpej-ifq (176d)  thorpej-altq-separation (178d) 

2024-05-10 17:25:08 UTC Now

2021-11-20 01:52:51 UTC MAIN commitmail json YAML

Improve the wording of the "Argument List Processing" section (where
all the sh options, also used with "set", are listed) in response to
a discussion on icb conveyed to me by Darrin B. Jewell.
A few improvements to the description of the "set" built-in as well.

Bump Dd to cover all of this month's changes (so far).

(kre)

2021-11-20 00:23:51 UTC MAIN commitmail json YAML

Add commented out FONT_DROID_SANS_MONO10x20 option. This enables 80x24
terminal on WVGA models, which is slightly easier on the eyes ;)

(rin)

2021-11-20 00:17:10 UTC MAIN commitmail json YAML

- Accept anti-aliased fonts.
- Clear garbage from screen when attach.

(rin)

2021-11-20 00:15:04 UTC MAIN commitmail json YAML

Accept anti-aliased fonts; they are supported by rotated screen found on
hpcarm/WZERO3 and PXA270-based zaurus.

(rin)

2021-11-20 00:08:23 UTC MAIN commitmail json YAML

Add Droid_Sans_Mono_10x20, generated by ttf2wsfont(1).

Having 10x20 in addition to 9x18 and 12x22 may seem redundant, but
this font enables nice 80x24 and 80x30 terminals on WVGA (800x480)
and SVGA (800x600) displays, respectively :)

(rin)

2021-11-20 00:00:19 UTC MAIN commitmail json YAML

Sort Droid Sans Mono family fonts by size.

(rin)

2021-11-19 23:55:16 UTC MAIN commitmail json YAML

Add support to rotate anti-aliased fonts.

wsfont_rotate_{cw,ccw}_internal() have been cleaned up and unified into
new static function wsfont_rotate_internal().

(rin)

2021-11-19 23:51:17 UTC MAIN commitmail json YAML

Mention that fchmod conforms to XPG 4.2. Bump date.

(wiz)

2021-11-19 23:50:39 UTC MAIN commitmail json YAML

wsfont_rotate(): Add missing NULL check for wsfont_find0().

(rin)

2021-11-19 23:46:55 UTC MAIN commitmail json YAML

ahcisata(4): Introduce AHCI_QUIRK_EXTRA_DELAY quirk for devices that
need extra delays as done by AHCISATA_EXTRA_DELAY option.

Enable this quirk for "C600/X79 AHCI". Also add commented out quirk
entries for "Bay Trail SATA (AHCI)" and "Mobile AHCI SATA Controller",
for which non-reproducible failures worked around by extra delays have
been reported.

500 ms of delays inserted by these option/quirk may be too much. Add
AHCISATA_EXTRA_DELAY_MS option to adjust number of delays in ms, like:

----
options AHCISATA_EXTRA_DELAY_MS=200
----

Thanks prlw1@ and jun@ for testing!

(rin)

2021-11-19 22:24:29 UTC MAIN commitmail json YAML

2021-11-19 20:23:17 UTC MAIN commitmail json YAML

2021-11-19 20:13:05 UTC MAIN commitmail json YAML

indent: keep inbuf.save_com_s and inbuf.save_com_e in sync

No functional change.

(rillig)

2021-11-19 20:04:02 UTC MAIN commitmail json YAML

2021-11-19 20:01:37 UTC MAIN commitmail json YAML

indent: clean up io.c

No functional change.

(rillig)

2021-11-19 19:55:15 UTC MAIN commitmail json YAML

indent: replace ps.procname with ps.is_function_definition

Omly the first character of ps.procname was ever read, and it was only
compared to '\0'.  Using a bool for this means simpler code, less
memory and fewer wasted CPU cycles due to the removed strncpy.

No functional change.

(rillig)

2021-11-19 19:37:13 UTC MAIN commitmail json YAML

indent: fix formatting of function definitions (since 2019-04-04)

In the definition of a function with a pointer return type, the
formatting depended on the name of the function.  Function names
matching [A-Za-z+] were formatted correctly, those containing [$0-9_]
weren't.

(rillig)

2021-11-19 19:15:55 UTC MAIN commitmail json YAML

indent: merge duplicate code into is_identifier_part

No functional change.

(rillig)

2021-11-19 18:55:10 UTC MAIN commitmail json YAML

tests/indent: update comment for the fix from the previous commit

(rillig)

2021-11-19 18:52:33 UTC MAIN commitmail json YAML

indent: fix lost function name (since 2019-04-04)

When indent searched for an identifier followed by a '(', to see whether
the identifier is a function name, it didn't care that the input buffer
could be resized due to a long line, which had made the pointer 'tp'
invalid.  Fix this by stopping the search at the end of the line.  A
better approach would be to have an unlimited lookahead buffer for
situations like these.  The code that deals with character input has
already been extracted to io.c, so it's possible to implement that now.

While here, fix another access to undefined memory, after the loop.

There is still the issue of overwriting procname[0] with a blank, which
results in inconsistent formatting depending on the function name,
probably another case of accessing undefined memory, although the
results have been reproducible, but that may have been pure luck.

The formatted code looks clearly broken, but that's still better than
losing a token and destroying the whole file.

(rillig)

2021-11-19 18:25:50 UTC MAIN commitmail json YAML

indent: unexport inbuf

No functional change.

(rillig)

2021-11-19 18:23:59 UTC MAIN commitmail json YAML

indent: use character input API from pr_comment.c

No functional change.

(rillig)

2021-11-19 18:14:18 UTC MAIN commitmail json YAML

indent: remove all references to inbuf from indent.c

No functional change.

(rillig)

2021-11-19 17:59:16 UTC MAIN commitmail json YAML

indent: move character input handling from indent.c to io.c

No functional change.

(rillig)

2021-11-19 17:42:46 UTC MAIN commitmail json YAML

indent: move character input from indent.c to io.c

No functional change.

(rillig)

2021-11-19 17:30:10 UTC MAIN commitmail json YAML

indent: use character input API from the tokenizer

No functional change.

(rillig)

2021-11-19 17:20:57 UTC MAIN commitmail json YAML

indent: move character input handling from lexi.c to io.c

No functional change.

(rillig)

2021-11-19 17:11:46 UTC MAIN commitmail json YAML

indent: replace direct access to the input buffer

This is a preparation for abstracting away all the low-level details of
handling the input.  The goal is to fix the current bugs regarding line
number counting, out of bounds memory access, and generally unreadable
code.

No functional change.

(rillig)

2021-11-19 15:34:25 UTC MAIN commitmail json YAML

indent: add debug logging for input buffer handling

(rillig)

2021-11-19 15:32:13 UTC MAIN commitmail json YAML

indent: rename input buffer variables

From reading the names 'save_com' and 'sc_end', it was not obvious
enough that these two variables are the limits of the same buffer, the
names were just too unrelated.

No functional change.

(rillig)

2021-11-19 15:28:32 UTC MAIN commitmail json YAML

2021-11-19 07:04:27 UTC MAIN commitmail json YAML

PR port-evbarm/50416

Redo the previous change.  The  "snps,..." properties are on the ethernet
node and the "reset-..." properties are on the phy node.  Handle this by
creating a separate reset routine for each case.  Idea from Jared.

(jdc)

2021-11-18 23:26:58 UTC MAIN commitmail json YAML

indent: prevent use-after-free bug

Triggered by the following artificial program:

---- snip ----
int *
f
(                                                            void)
{
}
---- snap ----

(rillig)

2021-11-18 23:06:51 UTC MAIN commitmail json YAML

tests/indent: demonstrate disappearing function name

Since 2019-04-04, as usual.

(rillig)

2021-11-18 22:27:01 UTC MAIN commitmail json YAML

tests/indent: demonstrate another bug imported from FreeBSD

Side note: the newly added test crashes at least the following versions
of indent with a segmentation fault on x86_64:

2000.10.11.14.46.04
2000.10.14.18.07.10
2000.10.17.02.16.44
2000.10.19.14.48.53
2000.10.19.16.31.26
2001.03.16.06.23.20
2001.03.23.20.12.41
2001.06.16.21.47.42
2001.07.20.13.43.50
2001.08.20.12.00.55
2001.12.01.19.27.33
2002.05.26.22.53.38
2003.02.25.10.35.44

(rillig)

2021-11-18 21:19:19 UTC MAIN commitmail json YAML

tests/indent: add skeletons for testing tokens and parser symbols

The constants that were previously defined in indent_codes.h were a wild
mixture of tokens from the lexer and symbols on the parser stack.  They
were split into separate types starting at indent.h 1.49 from 2021-10-25
and finishing at 1.73 from 2021-10-31.

To match the tests with the new token names, the old tests need to be
migrated to the newly added tests.  This will take some time so first
add the skeletons and migrate them in smaller steps, cleaning them up
and extending them on the way.

(rillig)

2021-11-18 18:14:47 UTC MAIN commitmail json YAML

distrib/sets: sort mi file

(rillig)

2021-11-18 17:11:13 UTC MAIN commitmail json YAML

tests/indent: reorder code in test driver

No functional change.

(rillig)

2021-11-18 16:54:35 UTC MAIN commitmail json YAML

indent: replace old license discussion with a brief history section

(rillig)

2021-11-18 16:18:13 UTC MAIN commitmail json YAML

Fix crash because of NULL pointer reference

(manu)

2021-11-18 16:17:41 UTC MAIN commitmail json YAML

Do not pass BIOS geometry when booting using EFI

Recent Mac return garbage data that will crash the code handling it,
and EFI boot does not need it anyway.

(manu)

2021-11-18 15:03:19 UTC MAIN commitmail json YAML

2021-11-18 04:33:20 UTC MAIN commitmail json YAML

Decorate the MIPS signal trampoline with the appropriate .cfi
directives to allow exception unwind / backtrace across a signal
handler.

(thorpej)

2021-11-18 04:20:11 UTC MAIN commitmail json YAML

- Teach the LLVM-derived unwinder about the DWARF pseudo-registers defined
  by GCC for MIPS to hold the MDHI and MDLO registers, as well as the return
  address where the signal trampoline will resume.  XXX Same treatment is
  needed for MIPS64, but not done as part of this commit.
- In the MIPS validFloatVectorRegister(), compare against the internal
  register numbers, not the DWARF register numbers.

(thorpej)

2021-11-17 21:46:12 UTC MAIN commitmail json YAML

gicv3: add support for mbi-alias property

The mbi-alias property, if present, contains the base address of a GICD
alias frame that contains only SET/CLRSPI registers. Use this instead of
the GICD register frame if present.

(jmcneill)

2021-11-17 11:57:27 UTC MAIN commitmail json YAML

PR port-evbarm/50416

Also check the "reset_gpios", "reset-assert-us", and "reset-deassert-us"
properties for ethernet MAC reset information.  Makes the built-in ethernet
work on Odroid C1 and Odroid C2 (with mesongxbb_pinctrl.c >= r1.3).

Based on a hint from Jared.  C2 tested by Martin.

(jdc)

2021-11-17 11:31:12 UTC MAIN commitmail json YAML

Add missing GPIOZ direction / input / output register defs.

(jmcneill)

2021-11-17 06:37:44 UTC MAIN commitmail json YAML

s/dataseet/datasheet/ in comment.

(msaitoh)

2021-11-17 04:33:26 UTC MAIN commitmail json YAML

Adjust new libcurses test filenames to the ones atually installed.
Possibly the intent was that the names used here were correct, and
the error is where they're installed - if so, that can be corrected later.

Hopefully this will fix the remaining current build issue.

(kre)

2021-11-16 23:39:34 UTC MAIN commitmail json YAML

sh.1: fix typos

(rillig)

2021-11-16 23:23:02 UTC MAIN commitmail json YAML

Move 'i' into DEBUG only code (now there be three).
Hopefully unbreaks !DEBUG builds.

(kre)

2021-11-16 22:12:44 UTC MAIN commitmail json YAML

2021-11-16 22:03:12 UTC MAIN commitmail json YAML

2021-11-16 21:38:29 UTC MAIN commitmail json YAML

echo: fix lint error due to strict bool mode

No functional change.

(rillig)

2021-11-16 21:05:33 UTC MAIN commitmail json YAML

Add more check files for libcurses tests.

(blymn)

2021-11-16 21:02:06 UTC MAIN commitmail json YAML

2021-11-16 21:01:06 UTC MAIN commitmail json YAML

lint: fix check for function calls in strict bool mode

Previously, if a function call occurred in the controlling expression,
its return type could be any scalar, not just bool.  This was against
the goal of strict bool mode, which makes bool a separate and
incompabile type to all other types.  For example, it would allow
controlling expressions like 'strcmp(a, b)' without the usual '!= 0',
but only if at least one of 'a' and 'b' came from a macro definition
from a system header.

The fix is that the decision of whether the type of the controlling
expression may be scalar is no longer based on the operand types but on
the main operator of the controlling expression.

(rillig)

2021-11-16 21:00:50 UTC MAIN commitmail json YAML

Fix handling of the tab special character.

(blymn)

2021-11-16 20:42:47 UTC MAIN commitmail json YAML

games/caesar: fix error handling for I/O

The '!= 0' is needed for an upcoming fix to lint's strict bool mode.

The additional text in the error messages is necessary because errx only
outputs the given string, with no details from errno.  Since ferror does
not set errno, no such details are available, so just output a generic
message, which is still better than just "caesar: <stdout>".

(rillig)

2021-11-16 18:37:24 UTC MAIN commitmail json YAML

lint: remove outdated comment

The bug has been fixed in cgram.y 1.369 a few minutes ago.

(rillig)

2021-11-16 18:33:14 UTC MAIN commitmail json YAML

lint: finish renaming of fcon to lex_floating_constant

(rillig)

2021-11-16 18:27:04 UTC MAIN commitmail json YAML

lint: fix wrong error message in strict bool mode

This fix only affects the last token before a macro, as well as the last
token in the expanded macro.

(rillig)

2021-11-16 17:41:23 UTC MAIN commitmail json YAML

2021-11-16 16:57:15 UTC MAIN commitmail json YAML

Make pwd (both /bin/pwd and the /bin/sh built-in version) check for
write errors on stdout, and indicate an error if that happens.

(kre)

2021-11-16 11:28:29 UTC MAIN commitmail json YAML

PR bin/56491

Make "hash" exit(!=0) (ie: exit(1)) if it writes an error message to
stderr as required by POSIX (it was writing "not found" errors, yet
still doing exit(0)).

Whether, when doing "hash foobar", and "foobar" is not found as a command
(not a built-in, not a function, and not found via a PATH search), that
should be considered an error differs between shells.  All of the ksh
descendant shells say "no", write no error message in this case, and
exit(0) if no other errors occur.  Other shells (essentially all) do
consider it an error, write a message to stderr, and exit(1) when this happens.

POSIX isn't clear, the bug report:
    https://austingroupbugs.net/view.php?id=1460
which is not yet resolved, suggests that the outcome will be that
this is to be unspecified.  Given the diversity, there might be no
other choice.

Have a foot in both camps - default to the "other shell" behaviour,
but add a -e option (no errors ... applies only to these "not found"
errors) to generate the ksh behaviour.  Without other errors (like an
unknown option, etc) "hash -e anyname" will always exit(0).

See the PR for details on how it all works now, or read the updated man page.

While here, when hash is in its other mode (reporting what is in the
table) check for I/O errors on stdout, and exit(1) (with an error
message!) if any occurred.  This does not apply to output generated
by the -v option when command names are given (that output is incidental).

In sh.1 document all of this.  Also add documentation for a bunch of
other options the hash command has had for years, but which were never
documented.  And while there, clean up some other sections I noticed
needed improving (either formatting or content or both).

(kre)

2021-11-16 11:27:50 UTC MAIN commitmail json YAML

Detect write errors to stdout, and exit(1) from some built-in
commands which (primarily) are used just to generate output
(or with a particular option combination do so).

(kre)

2021-11-16 11:25:44 UTC MAIN commitmail json YAML

Fix value of ${LINENO} in "for" commands.

This affects (as best I can tell) only uses of ${LINENO} in PS4
when -x is enabled (and perhaps only when the list contains no
expansions).  "for" like "case" (which was already handled) is
special in that it generates trace output before actually executing
any kind of simple command.

(kre)

2021-11-16 11:15:26 UTC MAIN commitmail json YAML

Fix a test that has been (unnoticed) failing ever since printf(1) was
changed to exit(1) when it detects a write error to stdout.

Running printf with stdout closed is guaranteed to generate such a
condition.

Until the previous commit, while the test case was actually failing
(stderr was expected to be empty. and was not) this was unnoticed.
We don't want the output (obviously), we also don't want the error
message, so just direct the latter to /dev/null.

(kre)

2021-11-16 11:12:15 UTC MAIN commitmail json YAML

Correct a systematic atf_check usage error.  One must not pipe into
atf_check and simply expect it to work - the shell is permitted to,
and our shell currently does, run all commands in a pipeline in subshell
environments - when atf_check attempts to exit to indicate failure, it
only exits from that subshell, and the rest of the test continues, usually
to indicate success

Instead, when it is necessary (or just convenient) to pipe into atf_check
check the exit status of the pipeline (if atf_check is not last, which it
would usually be, then we would need the pipefail option set - there are
currently no such cases), and explicitly fail if atf_check did not exit(0).

(kre)

2021-11-16 09:25:52 UTC MAIN commitmail json YAML

2021-11-16 06:58:33 UTC MAIN commitmail json YAML

2021-11-16 06:55:03 UTC MAIN commitmail json YAML

tests/lint: explain the missing error message in strict bool mode

There are 2 separate bugs that lead to the missing error message.

The first bug is that when parsing a name, the information about whether
that name comes from a system header is not properly recorded for the
last token before switching from or to a system header.

The second bug is that for determining whether the type of a function
call expression is relaxed, the types of the function call arguments are
taken into account, even though the type only depends on the function
itself.  The same idea applies to the operators '<<' and '>>', as their
result type only depends on the left operand, at least since C90.

(rillig)

2021-11-16 06:46:41 UTC MAIN commitmail json YAML

Use 50Hz ticks so that time works accurately on hosts with 100Hz ticks.

Note: The 20Kc CPU isn't handled correctly by QEMU, use the 5Kc CPU for
a 64-bit guest for accurate time.

(simonb)

2021-11-16 06:44:40 UTC MAIN commitmail json YAML

Use CPU frequencies defined in QEMU for mipssim - 6 MHz for 64-bit
guests and 12 MHz for 32-bit guests.

(simonb)

2021-11-16 06:15:48 UTC MAIN commitmail json YAML

Use the register define MIPS_HWR_ULR instead of a magic number.

(simonb)

2021-11-16 06:11:52 UTC MAIN commitmail json YAML

Use the architecture documented name ULR for the RDHWR user local
register.

(simonb)

2021-11-16 06:04:53 UTC MAIN commitmail json YAML

Add some comments for the RDHWR register numbers.

(simonb)

2021-11-16 06:04:00 UTC MAIN commitmail json YAML

Only need one #define for MIPS_HWR_CPUNUM.

(simonb)

2021-11-16 05:16:47 UTC MAIN commitmail json YAML

2021-11-16 04:48:43 UTC MAIN commitmail json YAML

Added a kernel option to set SYNC bit of LACP
while the lagg interface is in STANDBY state

(yamaguchi)

2021-11-16 04:01:11 UTC MAIN commitmail json YAML

Set SYNC bit of LACPDU when the interface is on STANDBY state

(yamaguchi)

2021-11-15 21:45:47 UTC MAIN commitmail json YAML

Add handling for backspace special character (\b)

(blymn)

2021-11-15 17:41:20 UTC MAIN commitmail json YAML

Explain the state of ASU and ACOMPAT.

(christos)

2021-11-15 16:00:25 UTC MAIN commitmail json YAML

More cleanups and typo corrections.

(kre)

2021-11-15 14:07:30 UTC MAIN commitmail json YAML

2021-11-15 14:06:50 UTC MAIN commitmail json YAML

2021-11-15 14:01:51 UTC MAIN commitmail json YAML

2021-11-15 13:59:16 UTC MAIN commitmail json YAML

2021-11-15 12:38:41 UTC MAIN commitmail json YAML

2021-11-15 07:26:23 UTC MAIN commitmail json YAML

Sprinkle const (and fix build)

(skrll)

2021-11-15 07:07:06 UTC MAIN commitmail json YAML

2021-11-15 06:34:05 UTC MAIN commitmail json YAML

Add new check files for curses atf.

(blymn)

2021-11-15 06:31:22 UTC MAIN commitmail json YAML

2021-11-15 06:27:06 UTC MAIN commitmail json YAML

Fix for PR lib/55433

Correct the behaviour for ins_wstr:
* Properly check the string will fit by processing any special
  characters present when preforming the check.
* Simplify the routine by removing code that duplicates the code in
  _cursesi_addwchar and just call _cursesi_addwchar.

(blymn)

2021-11-14 21:18:30 UTC MAIN commitmail json YAML

tpm@acpi: Require only one locality's worth of register space.

We don't actually use the registers for the other localities, and
some older TPMs only have the first locality exposed via ACPI.

(riastradh)

2021-11-14 20:51:57 UTC MAIN commitmail json YAML

2021-11-14 18:36:13 UTC MAIN commitmail json YAML

Fix some regressions that were introduced.

One must make sure that you release the i2c bus if you acquire.

One must not try to release the i2c bus if you failed to acquire it.

One can't leave too early from the single-shot refresh without
checking the status register as there may have been a reset
and releasing the i2c bus.

(brad)

2021-11-14 16:56:32 UTC MAIN commitmail json YAML

arm: Fix CPU startup synchronization.

- Use load-acquire instead of (wrong) membar_consumer then load in
  cpu_boot_secondary_processors and cpu_hatched_p.

  => (Could use load then membar_consumer instead but load-acquire is
    shorter.)

- Issue  dmb ish  before setting or clearing the bit in
  cpu_set_hatched and cpu_clr_mbox to effect a store-release.

  => (Could use membar_exit, which is semantically weaker than  dmb ish
    but on arm is just implemented as  dmb ish.)

  => (Could use stlr except we don't have atomic_ops(9) to do that.)

This way, everything before cpu_set_hatched or cpu_clr_mbox is
guaranteed to happen before everything after
cpu_boot_secondary_processors, which was previously not guaranteed.

(riastradh)

2021-11-14 15:48:02 UTC MAIN commitmail json YAML

Make dtc on riscv

(skrll)

2021-11-14 15:12:01 UTC MAIN commitmail json YAML

2021-11-14 11:23:52 UTC MAIN commitmail json YAML

tests/lint: demonstrate missing errors for strict bool mode

Seen in bin/echo/echo.c.

(rillig)

2021-11-14 11:16:28 UTC MAIN commitmail json YAML

UPDATING: note dts update causing things to be renumbered

(nia)

2021-11-14 08:32:07 UTC MAIN commitmail json YAML

revert bPreferedVersion rename. It's named like the by spec (from jmcneill).

(andvar)

2021-11-14 07:27:25 UTC MAIN commitmail json YAML

Use BITS(3) some more.  Same nvme.o before and after.

(skrll)

2021-11-13 21:38:48 UTC MAIN commitmail json YAML

firmware ver1 doesn't seem to work with linkstat interrupt, so in this case also set it to polling mode.

- Make the version acquisition (aq_fw_reset) timing earlier.
- Unmap registers when terminating with attach after failing to set interrupt

(ryo)

2021-11-13 21:13:41 UTC MAIN commitmail json YAML

s/bPreferedVersion/bPreferredVersion/ in struct property definition.

(andvar)

2021-11-13 20:59:13 UTC MAIN commitmail json YAML

Better display in monochrome.

(nat)

2021-11-13 19:02:08 UTC MAIN commitmail json YAML

tests/make: extend test for undefined variable in doubly indirect ':='

Just to prevent a half-baked fix to the current behavior that would
concatenate the modifiers of the two expressions, leading to
${LATER:value=sysv:tl} in this case.  That expression would be
interpreted as having only a single modifier that would replace the
suffix 'value' with 'sysv:tl'.  This is because the SysV modifier
':from=to' spans until the end of the expression.

(rillig)

2021-11-13 18:37:42 UTC MAIN commitmail json YAML

tests/make: test double indirection in ':=' with undefined variable

Reported by Simon J Gerraty via private mail.

This edge case has been handled in essentially the same way since at
least 2000-05-30, probably several years earlier as well.  The test file
is:

---- snip ----
.undef LATER
.undef later
INDIRECT:= ${LATER:S,value,replaced,}
indirect:= ${INDIRECT:C,S,s,}
# expect+1: Unknown modifier "s,value,replaced,"
.if ${indirect} != ""
.  error
.else
.  warning XXX Neither branch should be taken.
.endif
LATER= uppercase-value
later= lowercase-value
# expect+1: Unknown modifier "s,value,replaced,"
.if ${indirect} != "uppercase-replaced"
.  warning XXX Neither branch should be taken.
.else
.  error
.endif

all:
@:;
---- snap ----

The output from 'make -r -f later.mk' is:

make-2000.05.30.02.32.21
| make: Unknown modifier 's'
|
| "later.mk", line 9: Need an operator
| make: Unknown modifier 's'
|
| "later.mk", line 15: Need an operator
| Fatal errors encountered -- cannot continue
| exit status 1
make-2000.12.30.16.38.22

The pathnames in the error message gets absolute:

make-2001.01.23.02.48.05
| make: Unknown modifier 's'
|
| ".../later.mk", line 9: Need an operator
| make: Unknown modifier 's'
|
| ".../later.mk", line 15: Need an operator
| Fatal errors encountered -- cannot continue
| exit status 1
make-2001.01.23.02.48.05

All error messages get 'make:' as a common prefix:

make-2001.02.23.21.11.38
| make: Unknown modifier 's'
|
| make: ".../later.mk" line 9: Need an operator
| make: Unknown modifier 's'
|
| make: ".../later.mk" line 15: Need an operator
| make: Fatal errors encountered -- cannot continue
| exit status 1
make-2001.05.29.17.37.52

The 'stopped in' gets added:

make-2001.06.12.23.36.18
| make: Unknown modifier 's'
|
| make: ".../later.mk" line 9: Need an operator
| make: Unknown modifier 's'
|
| make: ".../later.mk" line 15: Need an operator
| make: Fatal errors encountered -- cannot continue
|
| make: stopped in ...
| exit status 1
make-2002.02.21.22.21.34

The empty lines between the error messages get removed.

make-2002.03.21.11.42.21
| make: Unknown modifier 's'
| make: ".../later.mk" line 9: Need an operator
| make: Unknown modifier 's'
| make: ".../later.mk" line 15: Need an operator
| make: Fatal errors encountered -- cannot continue
|
| make: stopped in ...
| exit status 1
make-2009.10.15.02.27.44

The error message for unknown directives gets more helpful:

make-2009.11.19.06.48.37
| make: Unknown modifier 's'
| make: ".../later.mk" line 9: Unknown directive
| make: Unknown modifier 's'
| make: ".../later.mk" line 15: Unknown directive
| make: Fatal errors encountered -- cannot continue
|
| make: stopped in ...
| exit status 1
make-2010.02.22.19.20.33

The directives '.error', '.warning' and '.info' get added:

make-2010.04.29.23.12.21
| make: Unknown modifier 's'
| make: ".../later.mk" line 9: warning: XXX Neither branch should be taken.
| make: Unknown modifier 's'
| make: ".../later.mk" line 15: warning: XXX Neither branch should be taken.
| exit status 0
make-2020.12.20.19.37.23

The error message about an unknown variable modifier gets line number
information:

make-2020.12.20.19.47.34
| make: ".../later.mk" line 6: Unknown modifier 's'
| make: ".../later.mk" line 9: warning: XXX Neither branch should be taken.
| make: ".../later.mk" line 14: Unknown modifier 's'
| make: ".../later.mk" line 15: warning: XXX Neither branch should be taken.
| make: Fatal errors encountered -- cannot continue
| make: stopped in ...
| exit status 1
make-2021.02.23.15.07.58

The error message about an unknown variable modifier gets more context
than only a single letter:

make-2021.02.23.15.19.41
| make: ".../later.mk" line 6: Unknown modifier "s,value,replaced,"
| make: ".../later.mk" line 9: warning: XXX Neither branch should be taken.
| make: ".../later.mk" line 14: Unknown modifier "s,value,replaced,"
| make: ".../later.mk" line 15: warning: XXX Neither branch should be taken.
| make: Fatal errors encountered -- cannot continue
| make: stopped in ...
| exit status 1

(rillig)

2021-11-13 18:30:28 UTC MAIN commitmail json YAML

2021-11-13 15:34:39 UTC MAIN commitmail json YAML

2021-11-13 15:17:22 UTC MAIN commitmail json YAML

Write back and invalidate cache before starting secondary CPUs.

(jmcneill)

2021-11-13 14:52:08 UTC MAIN commitmail json YAML

If lookup_fastforward() loses an intermediate searchdir, has to roll
back and retry it must use the initial searchdir from *searchdir_ret
for lookup_parsepath().

(hannken)

2021-11-13 13:36:43 UTC MAIN commitmail json YAML

Brad wants the __did_not_work code back :-)

(christos)

2021-11-13 11:46:32 UTC MAIN commitmail json YAML

2021-11-13 10:34:00 UTC MAIN commitmail json YAML

Release interrupt lock while allocating ressources in trigger
functions.

Also be more verbose about errors.

(mlelstv)

2021-11-13 10:13:43 UTC MAIN commitmail json YAML

2021-11-13 09:41:15 UTC MAIN commitmail json YAML

2021-11-13 08:35:54 UTC MAIN commitmail json YAML

Update notes and import riscv dts

(skrll)

2021-11-13 01:48:12 UTC MAIN commitmail json YAML

2021-11-13 01:29:21 UTC MAIN commitmail json YAML

2021-11-13 01:29:08 UTC MAIN commitmail json YAML

2021-11-13 01:09:51 UTC MAIN commitmail json YAML

2021-11-13 01:08:15 UTC MAIN commitmail json YAML

Match rockchip,rk3288-i2c

(jmcneill)

2021-11-13 01:07:09 UTC MAIN commitmail json YAML

Fix width of aclk_cpu_pre divider field

(jmcneill)

2021-11-13 00:34:24 UTC MAIN commitmail json YAML

2021-11-13 00:34:07 UTC MAIN commitmail json YAML

rk3288: add watchdog and rng clocks

(jmcneill)

2021-11-13 00:13:17 UTC MAIN commitmail json YAML

2021-11-12 22:53:21 UTC MAIN commitmail json YAML

Fix register accesses to PMU registers. Unlike the GRF ones, a RMW cycle
is required to update settings here.

(jmcneill)

2021-11-12 22:16:28 UTC MAIN commitmail json YAML

simplify the code and remove unused (it is in CVS anyway). Try to merge
duplicate code. Follow KNF. Brad, please test!

(christos)

2021-11-12 22:02:49 UTC MAIN commitmail json YAML

evbarm: Add support for Rockchip RK3288 SoCs.

(jmcneill)

2021-11-12 22:02:08 UTC MAIN commitmail json YAML

2021-11-12 21:59:05 UTC MAIN commitmail json YAML

gtmr: Add support for arm,cpu-registers-not-fw-configured property.

On armv7, arm,cpu-registers-not-fw-configured means that firmware hasn't
bothered to configure any generic timer registers and we need to
initialize cntfrq ourselves.

(jmcneill)

2021-11-12 21:57:44 UTC MAIN commitmail json YAML

dw_apb_uart: Honour reg-io-width property

(jmcneill)

2021-11-12 21:57:13 UTC MAIN commitmail json YAML

com: Add support for 32-bit IO accesses.

(jmcneill)

2021-11-12 21:55:46 UTC MAIN commitmail json YAML

2021-11-12 21:55:17 UTC MAIN commitmail json YAML

Build rockchip dtb files for armv7.

(jmcneill)

2021-11-12 19:01:19 UTC MAIN commitmail json YAML

2021-11-12 18:58:14 UTC MAIN commitmail json YAML

crude beginnings of a driver for the Southland Media / Quantum 3D MGX
basic acceleration mostly works in 24bit colour
needs native hw cursor code
windowmaker produces visible artifacts, but it's good enough to run amiwm and
a few xterms

(macallan)

2021-11-12 15:12:11 UTC MAIN commitmail json YAML

Fix the serial number handling of the HTU21D chip and probably others.
Increase the number of read attempts as the HTU21D and probably others
do not respond as fast the actual SI70xx chip can.

(brad)

2021-11-12 07:41:55 UTC MAIN commitmail json YAML

Explain cd9660 and udf exceptions on the rule that the default sectorsize is
512.

(reinoud)

2021-11-12 07:18:53 UTC MAIN commitmail json YAML

Trailing whitespace

(skrll)

2021-11-12 07:06:06 UTC MAIN commitmail json YAML

Fix the conditional for failed interrupt establishment

(skrll)

2021-11-12 06:56:50 UTC MAIN commitmail json YAML

2021-11-12 06:53:49 UTC MAIN commitmail json YAML

Trailing whitespace

(skrll)

2021-11-12 06:51:04 UTC MAIN commitmail json YAML

Trailing whitespace

(skrll)

2021-11-12 06:44:46 UTC MAIN commitmail json YAML

Print a big warning about trying to run on early ThunderX parts

(skrll)

2021-11-12 05:56:54 UTC MAIN commitmail json YAML

Configure vlan to an added interface after setting ifnet::if_lagg

The configuration uses ioctl of the interface, and the ioctl
for port (lagg_port_ioctl) needs ifnet:::if_lagg setting.

(yamaguchi)

2021-11-12 05:48:58 UTC MAIN commitmail json YAML

lagg: Add vid to vlanid_list in ethercom

(yamaguchi)

2021-11-12 05:40:44 UTC MAIN commitmail json YAML

Fix the wrong check of interface type

- lp->lp_iftype: original ifnet::if_type
- lp->lp_ifp->if_type: current ifnet::if_type
    - always IFT_IEEE8023ADLAG

(yamaguchi)

2021-11-12 05:34:46 UTC MAIN commitmail json YAML

lagg: Notify the changes of capenables of interface
to child interfaces

(yamaguchi)

2021-11-11 19:37:30 UTC MAIN commitmail json YAML

provide an endian-flipped view of the framebuffer via mmap() if we know how
for now this is sparc64 only

(macallan)

2021-11-11 17:32:46 UTC MAIN commitmail json YAML

2021-11-11 14:24:25 UTC MAIN commitmail json YAML

new sentence, new line.

(wiz)

2021-11-11 14:16:05 UTC MAIN commitmail json YAML

Some HTU21D chips do not have a heater register and apparently no
heater element.  Disable the heater features in the driver when that
condition is detected and let the attachment succeed.  Also mention
that the SHT21 is another clone.

(brad)

2021-11-11 07:38:21 UTC MAIN commitmail json YAML

The nfs_autoload test case has now been broken for more than four years.
Mark it as an expected failure with a reference to PR kern/54184.

(gson)

2021-11-11 07:26:41 UTC MAIN commitmail json YAML

2021-11-11 06:56:56 UTC MAIN commitmail json YAML

Fixed a panic problem at attach with aq(4) F/W version 1.

- Don't use cprng(9) when attaching, since it's not available yet.
- Wait up to 10 seconds because delay is not enough.
- Even if the delay is not enough, it will fail attach without panic.
- Checked on the actual card D107 (F/W version 1.5.58)

(ryo)

2021-11-11 01:10:09 UTC MAIN commitmail json YAML

lagg: Use promiscuous mode instead of if_init() to avoid panic
when the interface has no if_init()

(yamaguchi)

2021-11-10 18:25:52 UTC MAIN commitmail json YAML

Ensure that all of the POSIX standard utilities are correctly
identified with the -u flag (that is, I hope I identified all
the ones that were missing it).

This change is a no-op (NFC) as the -u flag does nothing.

Still, just in case we find a use for it one day, and just as a
matter of general principle, we should get this correct.

(kre)

2021-11-10 17:38:11 UTC MAIN commitmail json YAML

2021-11-10 17:35:45 UTC MAIN commitmail json YAML

With -Wall compiling this was giving:

echo.c: In function 'main':
echo.c:74:1: warning: control reaches end of non-void function

This raises 2 issues.

First, why with WARNS set to 6, which should include just about
everything, was this not causing problems with everyday builds?
Surely falling off the end of a non-void function without returning
a specific value is one of the more basic errors that should be fixed.
(Whatever the name of the function).  Is there a missing -Wxxx option?

And second, does C99 really promise:
Remove unnecessary call to exit(0); returning from main is equivalent
since C99.
in the sense that simply falling out of main() is exit(0)?  Or is it
simply saying that the return value of main() is the exit status (which
has been true for much longer than since c99)?

(kre)

2021-11-10 17:23:46 UTC MAIN commitmail json YAML

s/intialize/initialize/

(msaitoh)

2021-11-10 17:19:30 UTC MAIN commitmail json YAML

2021-11-10 16:57:39 UTC MAIN commitmail json YAML

s/configuraiton/configuration/ in comment.

(msaitoh)

2021-11-10 16:55:20 UTC MAIN commitmail json YAML

s/assocciation/association/ in comment.

(msaitoh)

2021-11-10 16:53:28 UTC MAIN commitmail json YAML

2021-11-10 16:47:41 UTC MAIN commitmail json YAML

2021-11-10 16:44:42 UTC MAIN commitmail json YAML

s/structre/structure/ in comment.

(msaitoh)

2021-11-10 16:42:47 UTC MAIN commitmail json YAML

s/struture/structure/ in comment.

(msaitoh)

2021-11-10 16:40:55 UTC MAIN commitmail json YAML

s/procesing/processing/ in comment.

(msaitoh)

2021-11-10 16:22:44 UTC MAIN commitmail json YAML

s/Asychronous/Asynchronous/ in comment.

(msaitoh)

2021-11-10 16:19:49 UTC MAIN commitmail json YAML

2021-11-10 16:17:34 UTC MAIN commitmail json YAML

2021-11-10 16:08:17 UTC MAIN commitmail json YAML

s/avaliable/available/

(msaitoh)

2021-11-10 16:02:49 UTC MAIN commitmail json YAML

2021-11-10 16:02:14 UTC MAIN commitmail json YAML

s/offseting/offsetting/ in comment.

(msaitoh)

2021-11-10 15:59:08 UTC MAIN commitmail json YAML

2021-11-10 15:58:39 UTC MAIN commitmail json YAML

Add a couple of macro definitions for dealing with shell I/O errors.
(Macros akin to stdio's ferror() and clearerr()).

NFC: the macros are defined, but not yet used anywhere.  Uses coming soonish.

(kre)

2021-11-10 15:56:39 UTC MAIN commitmail json YAML

s/derefernce/dereference/ in comment.

(msaitoh)

2021-11-10 15:55:35 UTC MAIN commitmail json YAML

s/Erorr/Error/ in comment.

(msaitoh)

2021-11-10 15:49:42 UTC MAIN commitmail json YAML

s/streror/strerror/ in comment.

(msaitoh)

2021-11-10 15:41:41 UTC MAIN commitmail json YAML

2021-11-10 15:39:03 UTC MAIN commitmail json YAML

2021-11-10 15:36:44 UTC MAIN commitmail json YAML

s/unoticable/unnoticeable/ in comment.

(msaitoh)

2021-11-10 15:33:26 UTC MAIN commitmail json YAML

2021-11-10 15:26:34 UTC MAIN commitmail json YAML

DEBUG mode changes only.  NFC (NC) for any normally compiled shell.

Mostly adding DEBUG mode tracing (when appropriate verbose tracing
is enabled generally) whenever a shell (including sushell) process
exits, so shells that the tracing should indicate why ehslls that
vanish did that.

Note for future investigators: if the relevant tracing is enabled,
and a (sub-)shell still simply seems to have vanished without trace,
the likely cause is that it was killed by a signal - and of those,
the most common that occurs is SIGPIPE.

(kre)

2021-11-10 15:21:43 UTC MAIN commitmail json YAML

s/certian/certain/ in comment.

(msaitoh)

2021-11-10 14:36:28 UTC MAIN commitmail json YAML

Support 64bit BAR.

(msaitoh)

2021-11-10 07:58:44 UTC MAIN commitmail json YAML

iwm.4: rework caveat for more relevance to this driver

(nia)

2021-11-10 07:57:29 UTC MAIN commitmail json YAML

Update the list of supported devices for iwm(4) and add a CAVEAT.

(nia)

2021-11-10 07:08:47 UTC MAIN commitmail json YAML

ODMR on-demand mail relay

(plunky)

2021-11-09 09:41:05 UTC MAIN commitmail json YAML

spell(1): convert realloc(x * y) to reallocarr

(nia)

2021-11-09 09:21:31 UTC MAIN commitmail json YAML

edquota(8): convert realloc(x * y) to reallocarr

(nia)

2021-11-09 09:19:02 UTC MAIN commitmail json YAML

systat(1): convert realloc(x * y) to reallocarr, eliminate a temp var

(nia)

2021-11-09 09:18:02 UTC MAIN commitmail json YAML

systat(1): convert free(x); x = malloc(x * y) to reallocarr.

free on NULL is a guaranteed non-op.

(nia)

2021-11-08 23:57:23 UTC MAIN commitmail json YAML

irq_entry(): Do not clobber fp (= r11), in order not to confuse DDB.

Use r10 instead; no need to preserve saipic_base, previous content of
r10, throughout this function, except for the case of INTR_DEBUG.

For INTR_DEBUG, load saipic_base to scratch register every time it
becomes necessary. This is no performance penalty compared with
subsequent printf() calls.

XXX
Rewrite this function by C. There seems no particular reason to
use assembler, and no major performance regression is expected.

(rin)

2021-11-08 23:35:43 UTC MAIN commitmail json YAML

For DDB, generate APCS stack frame so that db_stack_trace_print() works.

XXX
Copy-paste from arm/conf/Makefile.arm.
Convert to ${MACHINE}/conf/Makefile.${MACHINE}.inc.

(rin)

2021-11-08 17:58:27 UTC MAIN commitmail json YAML

This H6 pin (PL9) function is called s_cir_rx, not s_cir.

(jakllsch)

2021-11-08 16:50:06 UTC MAIN commitmail json YAML

Don't classify dropped packets that we don't understand as errors, for
example etype 0x88CA (TIPC (Transparent Inter Process Communication,)
or 0x893A (IEEE 1905).
Classify them as dropped like Linux does (FreeBSD just ignores them). From RVP.

(christos)