indent: condense lexi_alnum

No functional change.

(rillig)

libcrypt: Compile with USE_FORT, for this is cryptographic software.

(nia)

Annotate some cpu_info members

(skrll)

Update networking roadmap.

(nia)

drm++

(nia)

Sprinkle some const

(skrll)

remove accidentially committed debug goop
thanks ryo@

(macallan)

PR bin/45390

Be explicit about what happens to PWD after a successful cd command.
Also be very clear  that "cd" and "cd -P" are the same thing, and
the only cd variant implemented.

Also, when it is appropriate to print the new directory after a cd
command, note that it happens if interactive (as it always has here)
and also if the posix option is set (for POSIX compat, where "interactive"
is irrelevant).  Mention that "cd -" is a case where the new directory
is printed (along with paths relative to a non-empty CDPATH entry,
and where the "cd old new" (string replacement in curdir) is used.

While here document the new -e option to cd.

XXX pullup -9

(kre)

PR bin/45390 - fix for folly four

In the pwd builtin, verify that curdir names '.' before
simply printing it.  Never alter PWD or OLDPWD in the
pwd command.

Also while here, implement the (new: coming in POSIX, but has existed
for a while in several other shells) -e option to cd (with -e, cd -P
will exit(1) if the chdir() succeeds, but PWD cannot be discovered).

cd now prints the directory name used (if different from that given,
or cdprint is on) if interactive or (the new bit)in posix mode.

Some additional/changed comments added, and a DEBUG mode trace call
that was accidentally put inside an #if 0 block moved to where it
can do some good.

XXX pullup -9

(kre)

options<space><tab>

(simonb)

indent: push down variable comment_buffered

No functional change.

(rillig)

indent: move debugging functions to a separate section

(rillig)

indent: rename prev_newline and prev_col_1 to curr

These two flags describe the token that is currently processed.

In process_binary_op, curr_newline can never be true since newline is
not a binary operator, so remove that condition.

No functional change.

(rillig)

indent: in debug output, list the new token first

(rillig)

indent: clean up lexical analyzer

Use traditional type for small unsigned numbers instead of uint8_t; the
required header was not included.

Remove assertion for debug mode; lint takes care of ensuring that the
enum constants match the length of the names array.

Constify a name array.

Move the comparison function for bsearch closer to its caller.

No functional change.

(rillig)

lint: warn if an enum name is used for mismatched array access

This helps to keep the enum definition and the straight-forward
implementation of a to_string or name function in sync.

The test for message 241 had to be adjusted because of exactly this bug.
That test defined a bit mask enum but accessed it like a value enum
type.

(rillig)

Put back the sigcontext sigtramp code.

(christos)

"no affect" -> "no effect" in man pages and comments.

(andvar)

Add __HAVE_PREEMPTION support to gic_splfuncs asm funcs.

"looks right to me" - thorpej

(jmcneill)

indent: reorder assignments in switch_buffer

No functional change.

(rillig)

Fix the previous to only apply to the non-AArch64 case.

(thorpej)

- In vec_restore_from_mcontext() and vec_save_to_mcontext(), allows the
  mcontext argument to be NULL.
- In sendsig_sigcontext(), don't set PSL_VEC in the saved MSR; we can't
  actually round-trip the AltiVec registers.  At least get them saved
  into the PCB by calling vec_save_to_mcontext() (with a NULL mcontext
  argument).
- In compat_16_sys___sigreturn14(), call vec_restore_from_mcontext()
  with a NULL mcontext argument, which will force any subsequent use
  of AltiVec to re-load the AltiVec registers from the PCB.

This isn't ideal, but it's the best we can do with the limited capability
of sigcontext.

Fixes PR port-powerpc/56471.

(thorpej)

Enable GIC_SPLFUNCS again. Hopefully stable now.

(jmcneill)

indent: move buffer functions further up

No functional change.

(rillig)

Add CI_SPLX_SAVEDIPL and CI_HWPL

(jmcneill)

indent: group variables by topic

No functional change.

(rillig)

Implement gic_splraise and the gic_splx fast path in asm (armv8).

(jmcneill)

indent: fix bounds check for sc_buf

Some years ago, save_com was an array of characters, used as temporary
storage. When sc_buf was added, this code was forgotten. The bounds
check must be on the array itself, not on an iterator that points
somewhere in that array.

(rillig)

indent: prevent buffer overflow in search_stmt_comment

printf '{ if (%010000d) /*comment*/ ; }' '0' | indent

(rillig)

indent: add debug logging for save_com

This will help in finding the proper fix for the assertion failure in
search_stmt_comment.

Add an assertion in search_stmt_lbrace to prevent the previous,
incomplete fix from being applied again.

(rillig)

indent: fix assertion in fits_in_one_line

(rillig)

tests/indent: demonstrate assertion failure in fits_in_one_line

(rillig)

indent: prevent buffer overflows in 'if (expr) ... stmt'

(rillig)

Define __HAVE_STRUCT_SIGCONTEXT regardless of its current visibility.

(thorpej)

indent: revert previous fix of assertion failure

The strange code with the out of bounds memory access is needed to
transform 'if (expr) /* comment */ {' to 'if (expr) { /* comment */',
that is, to move the comment to the right.

Add a test that prevents "repairing" this code again.

(rillig)

Adjust the rules for sigcontext visibility on MIPS:
- Define __HAVE_STRUCT_SIGCONTEXT if _KERNEL (because it's needed for
  32-bit binary compatibility) or if the O32 ABI is active (because
  that's the only ABI that ever used sigcontext for signal delivery).
- For _KERNEL, define a "struct sigcontext" suitable only for 32-bit
  compatible signal delivery.
- For userspace, define a "struct sigcontext" appropriate for any ABI
  if _LIBC is defined (it's used for setjmp / longjmp) or if O32 is
  the active ABI (because it was part of the old BSD signal API).

(thorpej)

Delete trailing whitespace

(gson)

Obvious typo ':' -> ';'.

(hannken)

indent: fix assertion failure in search_stmt_comment

I have no idea why the code was written in such a convoluted way before.
By removing all the code that didn't make sense, everything just works
as expected, and the existing tests all pass, especially those in
token_comment.c that mention search_stmt_comment.

(rillig)

tests/indent: add more tests for the assertion in search_stmt_comment

(rillig)

tests/indent: test preserving the internal layout of box comments

(rillig)

tests/lint: explain and extend the tests for box comments

These tests are in preparation of removing the magic number 4 from
search_stmt_comment.

(rillig)

indent: inline macro label_offset

No functional change.

(rillig)

For the DW APB busy bit workaround, only attempt to re-apply LCR and DLB
settings for non-console devices. In the console case, simply clear the
busy bit and continue. Fixes an interrupt storm observed on Macchiatobin.

(jmcneill)

tests/indent: document why declaration lines are broken unnecessarily

(rillig)

rpcbind(8): restore previous behaviour. Wait instead of breaking from
the loop if svc_fdset_getmax fails.

thanks rin.

(nia)

indent: replace tabsize with hardcoded 8 in process_comma

On 2018-07-25, FreeBSD added the option '-ts' to make the tabulator size
configurable, replacing several constants 7, 8, 9 with tabsize. The 8 in
the expression 'max_col - 8' was not related to the tabulator size but
instead represents the typical width of a variable name. Subtracting a
tab from the right margin doesn't make sense since the right margin need
not be aligned on a tabstop.

See the test fmt_decl.c, where the declaration 'struct s0 a,b;' is split
into several lines because the estimate for the variable name following
the comma is too high. There would have been plenty of space to the
right to keep the whole declaration in a single line.

No functional change.

(rillig)

telnet(1): use reallocarr instead of malloc(x * y)

(nia)

pam_exec: Convert realloc(x * y) to reallocarr.

Eliminate a now-redundant temporary variable.

(nia)

netstat(1): use reallocarr instead of realloc(x * y)

(nia)

su(1): use reallocarr instead of malloc(x * y)

(nia)

netstat(1): convert malloc(x * y) and realloc(x * y) to reallocarr

(nia)

If a path is not specified, assume /. This makes "ls" and "ls hd0b:" work
as expected.

(jmcneill)

indent: don't risk a buffer overflow in code_add_decl_indent

The buffers have a safety margin of 5 characters, so the bounds check is
not strictly necessary. It makes the code more uniform though.

No functional change.

(rillig)

indent: clean up code_add_decl_indent

In layout computations, it is helpful for human readers to list the
summands in logical order. In this case, the expression 'code_len +
base_ind' was rather confusing, so replace it with 'base_ind +
code_len'. This makes the code straight-forward enough that it doesn't
need any comments anymore.

No functional change.

(rillig)

rpcbind(8): Use reallocarr, fix reallocation logic.

In my_svc_run(), only update the fd count _after_ the allocation
succeeds (which may be after waiting in the loop). This function
previously tried to go to a label that doesn't exist. I wonder why
GCC didn't catch this before but does now.

(nia)

indent: remove confusing modulo from code_add_decl_indent

The only effects of the modulo operation was to make indent slower and
to confuse human readers.

During the computation of the indentation, the main focus is on the
difference between the current indentation, as computed from the base
indentation and the current code, and the target indentation. All these
computations take opt.tabsize into account. When looking only at the
difference, whether or not a multiple of opt.tabsize is added does not
matter.

No functional change.

(rillig)

tests/indent: test variable indentation with exotic options

(rillig)

G/C MD_CPU_HATCH. It's old evbarm (<= armv7)

(skrll)

libtelnet: convert malloc(x * y) to reallocarr

(nia)

ndbootd(8): Rework allocation macros to add integer overflow checking.

(nia)

puffs(3): Replace realloc(x * y) with reallocarr

(nia)

indent: inline bloated call to 'parse' during initialization

No functional change.

(rillig)

With the recent "centralize vnode kevent handling" kevent(2) no
longer raises NOTE_LINK when removing a hard linked node.

It now behaves as FreeBSD and raises NOTE_DELETE.

Adapt the test to the new behaviour.

(hannken)

indent: condense code for parsing command line arguments

Previously, the cascade of 'if' statements suggested that there were 6
different cases to be handled when in reality there are only 3: no
arguments, 1 argument, 2 arguments. Let the code express this directly.

No functional change.

(rillig)

indent: extract main_load_profiles from main_parse_command_line

No functional change.

(rillig)

style. NFCI.

(skrll)

Remove an item

(skrll)

tests/indent: test several options '-P'

(rillig)

traceroute(8): Convert realloc usage to reallocarr.

Eliminate a temporary variable.

(nia)

Remove stale comment

(skrll)

finger(1): convert malloc(x * y) to reallocarr

(nia)

refuse(3): Simplify reallocation logic with reallocarr.

(nia)

ypcat(1): Convert realloc(x * y) to reallocarr.

We can eliminate a temporary variable here too.

(nia)

KNF and remove (some) unnecessary #includes

(skrll)

Use designated initialisers for static handlers and reduce the kernel size
a little.

(skrll)

Fix thinko in tlb_record_asids memset size calculation.

(skrll)

actually mmap() the blitter registers when asked to, while there do some
magic number reduction

(macallan)

indent: remove redundant comments, remove punctuation from debug log

The comment about 'null stmt' between braces probably meant 'no
statements between braces'.

The comments at psym_switch_expr only repeated what the code says or had
been outdated 29 years ago already since opt.case_indent does not have
to be 'one level down'.

In the debug log, the quotes around the symbol names are not necessary
after a ':'. The parse stack also does not need this much punctuation.

Reducing a do-while loop to nothing instead of a statement saves a few
CPU cycles. It works because after each lbrace, a stmt is pushed to the
parser stack. This stmt can only ever be reduced to a stmt_list but
never be removed.

(rillig)

Correct an off by one degree error in the temperature conversion.

(brad)

indent: remove redundant comments

The comments only repeated what the constants for the parser symbols
already express in their names. In the past, the names of these
constants were inconsistent and misleading; back then, it made sense to
make the comments express the actual meaning of the constants.

(rillig)

indent: reduce indentation in parse, extract decl_level

No functional change.

(rillig)

tests/indent: test binary operators for tokens in column 1

(rillig)

indent: fix missing blank before binary operator

(rillig)

Define __HAVE_STRUCT_SIGCONTEXT regardless of its current visibility.

(thorpej)

indent: in debug mode, log only differences for most ps members

(rillig)

indent: add detailed debug logging for the parser state

(rillig)

indent: merge isblank and is_hspace into ch_isblank

No functional change.

(rillig)

indent: replace segmentation fault with assertion

(rillig)

indent: parse options in a platform-independent way

Previously, on an ILP32 platform, the option '-ts30000000000000000'
resulted in the error message 'must be an integer', on LP64 platforms it
resulted in the error message 'must be between 1 and 80'. Remove this
unnecessary difference.

(rillig)

tests/indent: demonstrate segmentation fault in search_stmt_comment

(rillig)

indent: initialize 'ps' via code

This saves 3 kB of binary size since the parser state is rather large
and only very few members are initialized to non-zero values.

No functional change.

(rillig)

Add "--" 'options end' parameter to the sh -c call that runs the
command, so that the command cannot appear to be more options
(which always then fails, as there would be no arg for "-c" to
treat as the command string in that case).

For the full (LONG) explanation, see:
  http://mail-index.netbsd.org/current-users/2021/10/29/msg041629.html

(kre)

indent: clean up main_init_globals

No functional change.

(rillig)

indent: fix undefined behavior in buffer handling

Adding an arbitrary integer to a pointer may result in an out of bounds
pointer, so replace the addition with a pointer subtraction.

In the buffer handling functions, handle 'buf' and 'l' before 's' and
'e', since they are pairs.

In inbuf_read_line, use 's' instead of 'buf' to make the code easier to
understand for human readers.

No functional change.

(rillig)

add mgxreg.h

(macallan)

install mgxreg.h so we can use it from Xorg

(macallan)

indent: mark obviously broken code

(rillig)

indent: reorder global variables to be more intuitive

The buffer 'inp' comes first. From there, a single token is read into
the buffer 'token'. From there, it usually ends up in 'code'. The buffer
'token' does not belong to the group of the other 3 buffers, which
together make up a line of formatted output.

No functional change.

(rillig)

indent: use prev/curr/next to refer to the current token

The word 'last' just didn't match with 'next'.

No functional change.

(rillig)

indent: group members of parser_state by topic

No functional change.

(rillig)

indent: rename ps.dumped_decl_indent and indent_declaration

The word 'dump' in 'ps.dumped_decl_indent' was too close to dump_line,
which led to confusion since the variable controls whether the
indentation has been added to the code buffer, which happens way before
actually dumping the current line to the output file.

The function name 'indent_declaration' was too unspecific, it did not
reveal where the indentation of the declaration actually happened.

No functional change.

(rillig)

Define __HAVE_STRUCT_SIGCONTEXT regardless of its current visibility.

(thorpej)

indent: keep p_l_follow nonnegative, use consistent comparison

No functional change.

(rillig)

indent: spell 'parentheses' properly in messages and comments

(rillig)

tests/indent: provoke the third occurrence of 'unbalanced parens'

(rillig)

tests/indent: provoke error messages for unbalanced parentheses

(rillig)

libcrypt: Fix a floating point exception when a low number of HMAC-SHA1
iterations are specified.

(nia)

cgram(6): realloc(x * y) -> reallocarr

(nia)

atc(6): simplify reallocation logic

(nia)

sail(6): convert realloc(x * y) to reallocarr

(nia)

huntd(6): convert malloc(x * y) and realloc(x * y) to reallocarr

(nia)

reallocarr does not set errno.

(nia)

citrus: Use calloc instead of malloc'ing and clearing the array manually

(nia)

scandir(3): Convert malloc(x * y) and realloc(x * y) to reallocarr

(nia)

radixsort(3): use reallocarr instead of malloc(x * y)

(nia)

pdcsata.4: Add HISTORY section, fix stray space.

(nia)

Add some missing device drivers to the lists.

From bobs at thelibertytree.org, thanks!

(nia)

wcsdup(3): use reallocarr to catch integer overflow

(nia)

Fix length of memset in tlb_record_asids

(skrll)

Define __HAVE_STRUCT_SIGCONTEXT regardless of its current visibility.

(thorpej)

Define __HAVE_STRUCT_SIGCONTEXT regardless of its current visibility.

(thorpej)

Define __HAVE_STRUCT_SIGCONTEXT regardless of its current visibility.

(thorpej)

Define __HAVE_STRUCT_SIGCONTEXT regardless of its current visibility.

(thorpej)

Making "struct sigcontext" visible only to _LIBC || _KERNEL is too
restrictive for sparc (it's accessed by libasan).

(thorpej)

indent: clean up indentation, comments, reduce

No functional change.

(rillig)

indent: remove unused local variable in lexi

Since the previous commit, lexi is always called with the same argument,
so remove that parameter.

The previous commit broke the debug logging by not printing "transient
state" anymore. Replace this with "rolled back parser state" at the
caller's site.

No functional change.

(rillig)

indent: reduce negations in search_stmt_lookahead

No functional change.

(rillig)

indent: clean up comments and function names

Having accurate names for the lexer symbols and the parser symbols makes
most of the comments redundant. Remove these.

Rename process_decl to process_type, to match the name of the
corresponding lexer symbol. In this phase, it's just a single type
token, not a whole declaration.

No functional change.

(rillig)

indent: fix error message for buffer overflow during option parsing

At this early time, the input file has not been opened yet, so there is
no reason to output either the input file name or the line number.

(rillig)

indent: make error messages for option parsing more precise

(rillig)

indent: parse option '-cli' strictly

(rillig)

Fix typo in comment: allows, not alows.

I don't know what an alow is, maybe some cousin of the alot.
Awaiting a nature documentary by Allie Brosh about these perhaps more
elusive beasts.

PR misc/56473, from jschauma

(riastradh)

indent: topologically sort functions

No functional change.

(rillig)

indent: change product name, update version number

NetBSD's indent has deviated enough from FreeBSD's indent to warrant a
different product name. When indent was copied from FreeBSD in 2019,
that update introduced several new bugs, some of which have been fixed
in the NetBSD version.

NetBSD indent, unlike FreeBSD indent, supports C99 comments and C99
initializer designators.

(rillig)

Use defined constant instead of direct value (Etienne Brateau)

(christos)

Fix build with -Werror=array-parameter (Etienne Brateau)

(christos)

new acpica

(christos)

merge conflicts between 2021-06-04 and 2021-09-30

(christos)

more underscore

(christos)

Finish restoring the compat code.

(christos)

fix sparc: use mcontext to fetch pc and sp

(christos)

The genassym code in libc also needs struct sigcontext13

(christos)

put back the compat signal code; still have the stubs for it in libc

(christos)

We still need struct sigcontext for longjmp.

(christos)

x86: Move RNG initialization to after consinit.

This ensures we have the opportunity to get feedback about early
entropy.

(riastradh)

x86: Process bootloader rndseed much sooner.

(riastradh)

Use .Sq instead of a dangling .So

(kim)

Support devices that the PCI subclass is not PCI_SUBCLASS_MULTIMEDIA_HDAUDIO.

- Not tested well.
- If audioX is not attached, add HDAUDIO_ENABLE_DISPLAYPORT and
  HDAUDIO_ENABLE_HDMI to your kernel config.

(msaitoh)

Fix grammar in comment (affect vs. effect)

(kim)

Make "0 seconds" overwrite the countdown also when enter is pressed

Fixes PR misc/56486.

(kim)

virtio: stop reinit for safety when a device resetting is failed

(yamaguchi)

@thorpej wrote that sigcontext was never used on hppa; remove kernel handling
signal code. discussed also with @skrll

(christos)

getaddrinfo(3): malloc + memset -> calloc

(nia)

Add more Jasper Lake and Elkhart Lake devices.

(msaitoh)

Fix merge mishap from previous (ticket #1704)

(martin)

Add Elkhart Lake support.

(msaitoh)

Regen.

(msaitoh)

Add Intel Elkhart Lake devices.

(msaitoh)

Need frame.h

(christos)

There is no sigcontext in ppc64

(christos)

fix pic build

(christos)

Use __SIGTRAMP_SIGCODE_VERSION rather than hard-coding 0.

(thorpej)

Add many Intel I2C devices.

(msaitoh)

Hacks to get zdb working on NetBSD:
- Force accessing raw device but we're passed the block device.
- Deal with wedges not returning their size on a stat(2) and use
  the DIOCGMEDIASIZE ioctl instead.

Ok chs@.

(simonb)

fix problem with uninitialized variable on malformed 32 bit time.

(christos)

Regen.

(msaitoh)

Add Intel Gemini Lake TXE HECI 1.

(msaitoh)

TAB police.

(simonb)

t_pwhash: Don't assume default cipher is SHA1. Add Argon2 tests.

(nia)

When adjusting the max ASID count, check if ti->ti_asid_max == 0 as
well.  This defaults to 0 for the non-PMAP_TLB_NUM_PIDS case, so would
skip the updated test.

Fix for port-pmax/56466 (which affects all MIPS).

ok srkll@

(simonb)

The stupid CPP has proven me too clever by half.

(thorpej)

- Use the signal trampoline version constants from <sys/signal.h>.
- Declare the sigtramp externs as as char arrays, not int arrays; not all
  platforms have fixed-sized 32-bit instructions.

(thorpej)

- In sendsig() and sigaction1(), don't hard-code signal trampoline
  versions.  Instead, use the version constants from <sys/signal.h>
  and automatically (and correctly) handle cases where multiple versions
  of a particular trampoline flavor exist.  Conditionalize support
  for sigcontext trampolines on __HAVE_STRUCT_SIGCONTEXT.
- aarch64 and amd64 don't use sigcontext natively, but do need to
  support it for 32-bit compatibility; define __HAVE_STRUCT_SIGCONTEXT
  conditionally on _KERNEL.

(thorpej)

decode SMT parts for AMD family >= 0x17, not just 0x17.

now zen3 systems are properly identified by cpu topology for the
scheduler and cpuctl identify.

(mrg)

Use the signal trampoline version constants from <sys/signal.h>.

(thorpej)