Link [ NetBSD | NetBSD OpenGrok source search | PR fulltext-search | Summary of daily snapshot builds | history of daily build result | pkgsrc commit viewer ]


   
        usage: [branch:branch] [user:user] [path@revision] keyword [... [-excludekeyword [...]]] (e.g. branch:MAIN sys/arch/arm, if_wm.c@1.234 )




switch to index mode

recent branches: MAIN (4h)  netbsd-8 (6d)  netbsd-10 (6d)  netbsd-9 (12d)  thorpej-ifq (176d)  thorpej-altq-separation (178d) 

2024-05-10 19:06:04 UTC Now

2021-03-15 16:45:30 UTC MAIN commitmail json YAML

make: fix documentation of Lst_MoveAll

In CLEANUP mode, was originally meant to track memory allocations but is
useful during debugging as well, initialize the list.  There is no
distinct constant representing an invalid pointer, otherwise that would
have been an even better choice.

(rillig)

2021-03-15 16:06:05 UTC MAIN commitmail json YAML

make: indent inline functions for lists

No functional change.

(rillig)

2021-03-15 16:00:05 UTC MAIN commitmail json YAML

make: clean up header for runtime type information for enums

An enum with 32 bits would lead to signed integer overflow anyway, so
that definition is not worth keeping even if it works on typical
2-complement platforms.

The definitions for 2, 4 and 8 enum have been unused for several months
now.

No functional change.

(rillig)

2021-03-15 15:39:13 UTC MAIN commitmail json YAML

2021-03-15 12:15:03 UTC MAIN commitmail json YAML

make: replace enum bit-field with struct bit-field for VarEvalFlags

This makes the code easier to read, especially in var.c.  It also makes
debugging sessions easier since some debuggers don't show enum
bit-fields symbolically as soon as more than one bit is set.

The code outside var.c is basically unchanged, except that instead of
passing the individual flags, there are 4 predefined evaluation modes.
These suffice for all practical use cases.  Only in the implementation
deep inside var.c, the value of the flags keepDollar and keepUndef
differs.

There is no way of passing the struct to EnumFlags_ToString, which means
the ToString function has to be spelled out explicitly.  This allows for
fine-tuning the representation in the debug log, to reduce the amount of
uppercae letters.

No functional change.

(rillig)

2021-03-15 11:41:07 UTC MAIN commitmail json YAML

make: rename VARE_NONE to VARE_PARSE_ONLY

The name 'NONE' described the bit pattern, which was not useful to
understand its meaning.  Omitting VARE_WANTRES only parses the
expression, without evaluating any part of it.

No functional change, not even in debug mode since Enum_FlagsToString
always returns "none" for all-bits-unset.

(rillig)

2021-03-15 10:58:05 UTC MAIN commitmail json YAML

ossv4 mixer API: be extra careful with the inputs to AUDIO_MIXER_READ.

some drivers (not hdaudio(4), but uaudio(4), eap(4), sb(4), various other
old cards) will return error if a AUDIO_MIXER_VALUE is requested and the
number of channels is not specified as input. this is not documented as
well as it should be, unfortunately.

(nia)

2021-03-15 07:30:40 UTC MAIN commitmail json YAML

2021-03-15 07:29:27 UTC MAIN commitmail json YAML

correct usb device id for BELKIN F5D7050E

matches freebsd / openbsd (sources of urtw driver), various online
sources

PR kern/56056

(nia)

2021-03-14 22:58:11 UTC MAIN commitmail json YAML

2021-03-14 22:56:39 UTC MAIN commitmail json YAML

2021-03-14 22:24:24 UTC MAIN commitmail json YAML

tests/lint: document how lint discards the typedef name in 247

(rillig)

2021-03-14 21:44:35 UTC MAIN commitmail json YAML

tests/lint: add test for message 247 for pointer to unnamed struct

(rillig)

2021-03-14 20:41:39 UTC MAIN commitmail json YAML

2021-03-14 20:23:29 UTC MAIN commitmail json YAML

make: fix documentation of VarFreeEnv

No functional change.

(rillig)

2021-03-14 20:18:33 UTC MAIN commitmail json YAML

make: skip variable lookup for '::=' modifiers in parse-only mode

This is just to keep the code consistent among the various variable
modifiers.  The performance gain is negligible.

The actual assignment to the variable had already been skipped
previously.

No functional change.

(rillig)

2021-03-14 20:12:16 UTC MAIN commitmail json YAML

make: separate parsing and evaluating for modifier '::='

No functional change.

(rillig)

2021-03-14 20:09:26 UTC MAIN commitmail json YAML

make: in parse-only mode, do not update the expression value in ':sh'

No functional change outside debug mode.  The other variable modifiers
behave in the same way.

(rillig)

2021-03-14 20:03:56 UTC MAIN commitmail json YAML

make: do not evaluate the ':O' modifiers in parse-only mode

No functional change in practical usage.  Theoretically this change can
be observed by looking at the generated random numbers for the ':Ox'
modifier, but the quality or exact sequence of these random numbers is
not guaranteed anyway.

(rillig)

2021-03-14 20:00:48 UTC MAIN commitmail json YAML

make: separate parsing and evaluating in the ':O' modifiers

No functional change.

(rillig)

2021-03-14 19:29:37 UTC MAIN commitmail json YAML

make: do not evaluate modifier ':[...]' in parse-only mode

In parse-only mode, variable expressions in the argument to that
modifier are not resolved.  This led to the error message about the 'Bad
modifier' in var-eval-short.mk.

(rillig)

2021-03-14 19:25:05 UTC MAIN commitmail json YAML

make: do not evaluate modifiers ':M' and ':N' in parse-only mode

No functional change outside debug mode (-dv for ModifyWord_Match).

(rillig)

2021-03-14 19:21:29 UTC MAIN commitmail json YAML

make: do not return unevaluated 'else' part from the ':?' modifier

No functional change outside debug mode.

(rillig)

2021-03-14 19:16:41 UTC MAIN commitmail json YAML

tests/make: add test for the ':?' modifier in parse-only mode

The debug output for this scenario will change a bit in an upcoming
commit, but that will not affect anything outside the debug log.

(rillig)

2021-03-14 18:30:24 UTC MAIN commitmail json YAML

make: do not evaluate ':gmtime' and ':localtime' in parse-only mode

No functional change.

(rillig)

2021-03-14 18:23:44 UTC MAIN commitmail json YAML

make: don't evaluate several simple modifiers in parse-only mode

This affects the modifiers ':E', ':H', ':P', ':Q', ':R', ':T', ':hash',
':q', ':range', ':tl', ':ts', ':tu', and ':u'.  All these modifiers are
side-effect free.

Skipping the evaluation for these modifiers is purely for code
consistency and performance.

No functional change.

(rillig)

2021-03-14 18:10:57 UTC MAIN commitmail json YAML

make: skip strdup when parsing an irrelevant ':L' modifier

No functional change.

(rillig)

2021-03-14 18:08:25 UTC MAIN commitmail json YAML

make: skip memcpy when parsing but not evaluating ':D' and ':U'

No functional change, just a tiny bit of performance improvement,
probably not even measurable.  Having the code nevertheless serves as a
copy-and-paste template for implementing other modifiers that might
perform more costly tasks.

(rillig)

2021-03-14 18:02:44 UTC MAIN commitmail json YAML

make: only evaluate the ':@' modifier if the result is actually used

The test 'var-eval-short' had produced the output 'unexpected' before,
on stderr.  It had been generated by '${:Uword:@${FAIL}@expr@}' by
combining the following obscure "features" of make:

1.  the ':@' modifier loops over the words of the variable.  This
    modifier is not really obscure, it still takes some time to get used
    to it.

2.  the ':@' modifier allows a '$' sign in the variable name, which is
    useless in practice.

3.  the ':@' modifier creates a temporary loop variable in the global
    namespace.  Luckily there are only few collisions with other
    variable names since their naming conventions differ.

4.  after looping over the words of the expression, the temporary global
    loop variable is deleted, and at that point the '$' is expanded,
    being interpreted as the start of a variable expression.

5.  The ':@' modifier deleted the global variable even when it was
    called in parse-only mode (without VARE_WANTRES).

When the modifier ':@' was initially added to make in var.c 1.40 from
2000-04-29, Var_Delete didn't expand the variable name.  That feature
was added in var.c 1.174 from 2013-05-18, probably without thinking of
this very edge-casey combination of features.

This commit fixes item 5 from the above list.  The other obscurities
remain for now.

(rillig)

2021-03-14 17:38:24 UTC MAIN commitmail json YAML

make: eliminate common subexpression in ApplyModifier_Remember

No functional change.

(rillig)

2021-03-14 17:34:50 UTC MAIN commitmail json YAML

make: merge duplicate code in ApplyModifier_Remember

This way, parsing and evaluating the modifier is only written once in
the code.  The downside is that the variable name is allocated even if
VARE_WANTRES is not set, but since this modifier is so obscure and
seldom used this doesn't matter in practice.

(rillig)

2021-03-14 17:27:28 UTC MAIN commitmail json YAML

make: do not expand the variable name in the ':_' modifier

This edge case had been so obscure that even discovering this takes
quite some time and requires reading the source code of make.

The manual page doesn't document whether the variable name is expanded
or not, it doesn't even give an example.  When this obscure modifier was
initially added in var.c 1.210 from 2017-01-30, Var_Set always expanded
the variable name once, and there was no way around it.  Therefore this
expansion has probably been unintentional.

(rillig)

2021-03-14 17:14:16 UTC MAIN commitmail json YAML

tests/make: demonstrate unintended edge case for the ':_' modifier

(rillig)

2021-03-14 17:07:11 UTC MAIN commitmail json YAML

2021-03-14 16:43:31 UTC MAIN commitmail json YAML

make: only evaluate the ':_' modifier if the expression is needed

See var-eval-short.mk:46 for the test demonstrating this change.
Previously, the expression ${:Uword:_=VAR} was evaluated including all
its side effects even though it was in an irrelevant branch of the
condition.

(rillig)

2021-03-14 16:03:04 UTC MAIN commitmail json YAML

make: return failure in TryParseIntBase0 for empty string

No functional change since the only caller of TryParseIntBase0 already
handles all possible parse errors.  Without this check, the code just
looked wrong though.

(rillig)

2021-03-14 16:00:07 UTC MAIN commitmail json YAML

make: add test for edge case in modifier ':[...]'

TryParseIntBase0 wrongly returns successful for a string that does not
start with a number at all.  Its only caller, ApplyModifier_Words,
already handles all error cases properly.

No functional change.

(rillig)

2021-03-14 15:43:31 UTC MAIN commitmail json YAML

make: separate parsing from evaluating for several modifiers

This aligns the implementation of these modifiers with the requirements
in the long comment starting with 'The ApplyModifier functions'.

No functional change.

(rillig)

2021-03-14 15:24:37 UTC MAIN commitmail json YAML

make: reduce indentation in ApplyModifier_SunShell

No functional change.

(rillig)

2021-03-14 15:22:21 UTC MAIN commitmail json YAML

make: separate parsing and evaluating for modifier ':u'

No functional change.

(rillig)

2021-03-14 15:19:15 UTC MAIN commitmail json YAML

make: separate parsing and evaluating for modifiers ':Q' and ':q'

No functional change.

(rillig)

2021-03-14 15:15:29 UTC MAIN commitmail json YAML

make: extract duplicate code for parsing ':S' and ':C'

No functional change.

(rillig)

2021-03-14 15:06:19 UTC MAIN commitmail json YAML

make: extract duplicate code for detecting a modifier's end

No functional change.

(rillig)

2021-03-14 15:04:13 UTC MAIN commitmail json YAML

make: document how error handling should be done correctly

Right now, when a variable expression cannot be parsed, the result of
calling Var_Subst is a string containing garbage, and no error is
reported.  In addition, there are some silent errors that are not
reported at all.  This combination makes it difficult to change the
error handling without introducing subtle breakage in some edge cases.

An example for garbage output is in varmod-subst-regex.mk, in target
mod-regex-compile-error.

No functional change.

(rillig)

2021-03-14 13:11:59 UTC MAIN commitmail json YAML

Build rump for PPC_OEA64 on evbppc64.

(rin)

2021-03-14 11:49:37 UTC MAIN commitmail json YAML

2021-03-14 11:15:37 UTC MAIN commitmail json YAML

make: sort modifiers in ApplyModifier alphabetically

No functional change.

(rillig)

2021-03-14 10:57:13 UTC MAIN commitmail json YAML

make: fix wrong expression evaluation in -dL mode

The modifier ':C' now only compiles the regular expression if the result
of the expression is actually needed.

Several other modifiers have the same bug of evaluating the expression
in cases where this is not needed.  It just doesn't show up because they
don't have any noticeable side effects, other than wasting CPU time.
This affects irrelevant conditions as well.

(rillig)

2021-03-14 10:45:51 UTC MAIN commitmail json YAML

2021-03-14 10:36:46 UTC MAIN commitmail json YAML

Sprinkle kpreempt_{dis,en}able ready for when preemption gets turned on.

(skrll)

2021-03-14 08:16:57 UTC MAIN commitmail json YAML

2021-03-14 08:13:58 UTC MAIN commitmail json YAML

No need to have an MD #ifdef in an MI file, so remove it.

(skrll)

2021-03-14 08:10:23 UTC MAIN commitmail json YAML

Remoave an extra space from a comment

(skrll)

2021-03-14 08:09:20 UTC MAIN commitmail json YAML

Remove an unnecessary if statement in gic_v2m_msi_alloc when finding a
'count' that fits the available.

(skrll)

2021-03-14 05:26:42 UTC MAIN commitmail json YAML

indent: clean up check_size_comment

The additional parameter last_bl_ptr was only necessary because the last
blank was stored as a pointer into the buffer.  By storing the index in
the buffer instead, it doesn't need to be updated all the time.

No functional change.

(rillig)

2021-03-14 04:52:10 UTC MAIN commitmail json YAML

indent: remove trailing whitespace

(rillig)

2021-03-14 04:42:17 UTC MAIN commitmail json YAML

indent: clean up target column computation in process_comment

No functional change.

(rillig)

2021-03-14 03:35:39 UTC MAIN commitmail json YAML

Enable NFS_BOOT_UDP; on-board NIC seems to be too slow for overhead due to
NFS over TCP. Some scores of pkgsrc/benchmarks/bonnie improve nearly x2.

(rin)

2021-03-14 03:25:01 UTC MAIN commitmail json YAML

Fix DJMEMCMAX option for Quadra/Centris 650/800.

- Use jeq instead of jra for conditional branch.
- Use cmpl instead of cmp (= cmpw) for int variables.

Now, my Quadra 800 recognizes full 520MB memory!

(rin)

2021-03-14 03:14:42 UTC MAIN commitmail json YAML

Initialize dp->rd_cmap_{red,green,blue} in radeonfb_init_palette() for 8bpp,
so that color map can be obtained by WSDISPLAYIO_GETCMAP ioctl(2).

Now, mlterm-fb from pkgsrc/x11/mlterm works just fine on radeonfb(4).

(rin)

2021-03-14 02:56:51 UTC MAIN commitmail json YAML

Fix typo: s/--r/-r/

(rin)

2021-03-14 02:56:07 UTC MAIN commitmail json YAML

Document NFS_BOOT_UDP instead of NFS_BOOT_TCP; We've switched to
NFS over TCP by default.

Bump date.

(rin)

2021-03-14 02:53:57 UTC MAIN commitmail json YAML

Comment on CTASSERT() in COND_SET_STRUCT(); this is a sanity check to
avoid hashing/assigning large structure. Upper-bound is arbitrary, but
be carefully for performance penalty if bumping.

Thanks christos for discussion.

(rin)

2021-03-14 01:44:37 UTC MAIN commitmail json YAML

indent: make compute_code_indent more readable

The '?:' operator computing the factor was too hard to read.  When
quickly scanning the code, the 1 in the expression looked too much like
it would be added to the indentation, which would turn the indentation
length into a column number, and that again would smell like an
off-by-one error.

No functional change.

(rillig)

2021-03-14 01:34:13 UTC MAIN commitmail json YAML

indent: fix off-by-one error in comment wrapping

The manual page says that the default maximum length of a comment line
is 78.  The test 'comments.0' wrongly assumed that this 78 would refer
to the maximum _column_ allowed, which is off by one.

Fix the wording in the test 'comments.0' and remove the (now satisfied)
expectation comments in the test 'token-comment.0'.

Several other tests just happened to hit that limit, fix these as well.

(rillig)

2021-03-14 00:50:39 UTC MAIN commitmail json YAML

tests/indent: demonstrate off-by-one error in comment processing

(rillig)

2021-03-14 00:33:25 UTC MAIN commitmail json YAML

indent: give indent a try at formatting its own code

Formatting indent.h required the following manual corrections
afterwards:

The first tab in the comment in line 1 was replaced with a space but
shouldn't be.

The spacing around the '...' in function prototypes was completely
wrong.  It looked like 'const char *,...)__printflike', without any
spaces.

The '*' of the return type 'const char *' was tied to the function name,
even though this declaration was only for a single function.  In such a
case, it's more appropriate to line up the function names.

The function-like macros were not indented to -di.  This is something
that I would not expect from indent, so it's ok to do that manually.

(rillig)

2021-03-14 00:22:16 UTC MAIN commitmail json YAML

2021-03-13 23:42:23 UTC MAIN commitmail json YAML

indent: remove disabled duplicate RCS ID from header

By convention, headers don't record their RCS ID.

(rillig)

2021-03-13 23:36:10 UTC MAIN commitmail json YAML

indent: fix documentation of parser_state.paren_indents

The column position is not the same as the indentation (off-by-one).

(rillig)

2021-03-13 23:26:47 UTC MAIN commitmail json YAML

Enable block count only for count > 0.
Don't enable autostop when command sets new flag SCF_NO_STOP.

(mlelstv)

2021-03-13 23:22:44 UTC MAIN commitmail json YAML

2021-03-13 20:21:37 UTC MAIN commitmail json YAML

sun4v: vnet - reception and transmission of eternet frames seems to work now (it is possible to ping 8.8.8.8 from inside a sun4v ldom). Still cleanup of debug code to be done.

(palle)

2021-03-13 18:46:39 UTC MAIN commitmail json YAML

indent: add debug logging for switching the input buffer

No functional change outside debug mode.

(rillig)

2021-03-13 18:24:56 UTC MAIN commitmail json YAML

indent: align comments in indent's own code

No functional change.

(rillig)

2021-03-13 18:11:31 UTC MAIN commitmail json YAML

indent: remove the '+ 1' from right margin calculation in comment

No functional change.

(rillig)

2021-03-13 17:14:12 UTC MAIN commitmail json YAML

s/pfi_faultpte/&p/ for consistency with arm / other uses of ptep

(skrll)

2021-03-13 16:46:49 UTC MAIN commitmail json YAML

record the libblocklist dependency

(christos)

2021-03-13 15:46:54 UTC MAIN commitmail json YAML

Handle \t too (RVP)

(christos)

2021-03-13 15:29:56 UTC MAIN commitmail json YAML

2021-03-13 15:29:13 UTC MAIN commitmail json YAML

Don't use %jx for 0 or 1 - just use %jd in UVMHIST_LOG format.

(skrll)

2021-03-13 13:55:42 UTC MAIN commitmail json YAML

indent: rename local variable in dump_line

This clarifies that the variable names a column, not an indentation.

(rillig)

2021-03-13 13:54:01 UTC MAIN commitmail json YAML

indent: in dump_line, reduce scope of local variable

This allows the variable 'target' in the lower half of the function to
get a more specific name.

No functional change.

(rillig)

2021-03-13 13:51:08 UTC MAIN commitmail json YAML

indent: distinguish between 'column' and 'indentation'

column == 1 + indentation.

In addition, indentation is a relative distance while column is an
absolute position.  Therefore, don't confuse these two concepts, to
prevent off-by-one errors.

No functional change.

(rillig)

2021-03-13 13:25:23 UTC MAIN commitmail json YAML

indent: rename pr_comment to process_comment, clean up documentation

No functional change.

(rillig)

2021-03-13 13:14:14 UTC MAIN commitmail json YAML

indent: fix handling of '/*' in string literal in preprocessing line

Previously, the '/*' in the string literal had been interpreted as the
beginning of a comment, which was wrong.  Because of that, the variable
declaration in the following line was still interpreted as part of the
comment.  The comment even continued until the end of the file.

Due to indent's forgiving nature, it neither complained nor even
mentioned that anything had gone wrong.  The decision of rather
producing wrong output than failing early is a dangerous one.

At least, there should have been an error message that at the end of the
file, the parser was still in a a comment, expecting the closing '*/'.

(rillig)

2021-03-13 13:04:13 UTC MAIN commitmail json YAML

tests/indent: add another test case for preprocessing directives

In process_preprocessing, the variable 'quote' is not used, which makes
the code suspicious of not handling the combination of string literals
and comments properly.

(rillig)

2021-03-13 12:52:24 UTC MAIN commitmail json YAML

indent: split 'main_loop' into several functions

No functional change.

(rillig)

2021-03-13 11:47:22 UTC MAIN commitmail json YAML

indent: split 'main' into manageable parts

Since several years (maybe even decades) compilers know how to inline
static functions that are only used once.  Therefore there is no need to
have overly long functions anymore, especially not 'main', which is only
called a single time and thus does not add any noticeable performance
degradation.

No functional change.

(rillig)

2021-03-13 11:27:01 UTC MAIN commitmail json YAML

2021-03-13 11:19:43 UTC MAIN commitmail json YAML

indent: fix confusing variable names

The word 'col' should only be used for the 1-based column number.  This
name is completely inappropriate for a line length since that provokes
off-by-one errors.  The name 'cols' would be acceptable although
confusing since it sounds so similar to 'col'.

Therefore, rename variables that are related to the maximum line length
to 'line_length' since that makes for obvious code and nicely relates to
the description of the option in the manual page.

No functional change.

(rillig)

2021-03-13 10:47:59 UTC MAIN commitmail json YAML

indent: document undefined behavior in processing of comments

No functional change.

(rillig)

2021-03-13 10:32:25 UTC MAIN commitmail json YAML

indent: inline calls to count_spaces and count_spaces_until

These two functions operated on column numbers instead of indentation,
which required adjustments of '+ 1' and '- 1'.  Their names were
completely wrong since these functions did not count anything, instead
they computed the column.

No functional change.

(rillig)

2021-03-13 10:20:54 UTC MAIN commitmail json YAML

indent: replace column computation with indentation computation

No functional change.

(rillig)

2021-03-13 10:06:47 UTC MAIN commitmail json YAML

indent: replace compute_code_column with compute_code_indent

The goal is to only ever be concerned about the _indentation_ of a
token, never the _column_ it appears in.  Having only one of these
avoids off-by-one errors.

No functional change.

(rillig)

2021-03-13 09:54:12 UTC MAIN commitmail json YAML

indent: replace compute_label_column with compute_label_indent

Using the invariant 'column == 1 + indent'.  This removes several overly
complicated '+ 1' from the code that are not needed conceptually.

No functional change.

(rillig)

2021-03-13 09:48:04 UTC MAIN commitmail json YAML

indent: manually fix indentation in indent's own source code

(rillig)

2021-03-13 09:21:57 UTC MAIN commitmail json YAML

indent: add debug logging for actually writing to the output file

Together with the results of the tokenizer and the 4 buffers for token,
label, code and comment, the debug log now provides a good high-level
view on how the indentation happens and where to look for the many
remaining bugs.

(rillig)

2021-03-13 09:06:12 UTC MAIN commitmail json YAML

indent: remove strange debugging code that went in the output file

Whenever the code to be output contained the magic byte 0x80, instead of
writing this byte, indent wrote the column number at the beginning of
the code snippet, times 7.  Especially the 'times 7' does not make any
sense at all.

In ISO-8859-1, this character position is not assigned.  In Microsoft
Codepage 1252 it is the Euro sign.  In UTF-8 (which was probably not on
the author's list when the code was originally written) it occurs as the
middle byte for code points like U+2026 (horizontal ellipsis) from the
block General Punctuation.

Remove this strange code, thereby fixing indent for UTF-8 code.  The
code had been there since at least 1993-04-09, when it was first
imported to NetBSD.

(rillig)

2021-03-13 00:26:56 UTC MAIN commitmail json YAML

indent: replace pad_output with output_indent

Calculating the indentation is simpler than calculating the column,
since that saves the constant addition and subtraction of the 1.

No functional change.

(rillig)

2021-03-13 00:03:30 UTC MAIN commitmail json YAML

indent: clean up verbose documentation comments from the 1970s

Since C90, there is no need to repeat the type of the function
parameters.

In the whole code of indent, there is a lot of confusion between the
concepts of a 'column' (which is a position on the screen, counting
starts at 1) and 'indentation' (which is a length, not a position).  To
avoid this confusion, the code will be rewritten anyway very soon.

Repeatedly adding and subtracting 1 from the 'current column' is not
elegant, this should rather be done by consistently measuring only the
indentation from the left border (at offset 0), as a distance, not as an
absolute position.

(rillig)

2021-03-12 23:27:41 UTC MAIN commitmail json YAML

indent: add 'const', rename variables, reorder formula for tab width

Column counting starts at 1.  This 1 should rather be at the beginning
of the formula since it is thought of being added at the very beginning
of the line, not at the end.

When adding a tab, the newly added tab is added at the end of the
string, therefore that '+ 1' should be at the end of the formula as
well.

No functional change.

(rillig)

2021-03-12 23:16:00 UTC MAIN commitmail json YAML

indent: replace 'target' with 'indent' in function names

The word 'target' was not as specific as possible.

No functional change.

(rillig)

2021-03-12 23:10:18 UTC MAIN commitmail json YAML

indent: use consistent indentation for 'else'

Half of the code used -ce, the other half the opposite -nce.

No functional change.

(rillig)

2021-03-12 22:53:18 UTC MAIN commitmail json YAML

2021-03-12 21:07:08 UTC MAIN commitmail json YAML

Update Spleen wscons fonts to version 1.9.0, bringing the following
improvements:

- Enlarge vertical line for consistency with other small sizes (5x8 version)
- Add full support for the Latin-1 Supplement Unicode block (6x12 version)

(fcambus)

2021-03-12 19:14:18 UTC MAIN commitmail json YAML

indent: make output_string inline

GCC 9.3.0 didn't notice that the argument to this function is always a
string literal, which makes it worthwhile to inline the call.

(rillig)

2021-03-12 19:11:29 UTC MAIN commitmail json YAML

indent: add helper functions for doing the actual output

This allows to add debug logging to these few functions instead of all
other places that might output something.

Reducing the possible output formats to a few primitives makes dump_line
simpler, especially the fprintf calls.  It also removes the non-constant
printf string.

The call to output_int may be meant for debugging, as the character 0x80
is unlikely to appear in any real-world code.

No functional change.

(rillig)

2021-03-12 18:28:08 UTC MAIN commitmail json YAML

2021-03-12 18:11:50 UTC MAIN commitmail json YAML

indent: fix misleading indentation in indent's own code

No functional change.

(rillig)

2021-03-12 18:10:00 UTC MAIN commitmail json YAML

2021-03-12 17:46:49 UTC MAIN commitmail json YAML

indent: move code for tokenizing numbers further up

Having it directly below the table makes it easier understandable.

I also tried to omit this function entirely by moving the code into the
initializer itself, but that made the code redundant and furthermore
increased the size of the resulting binary, probably because of the new
relocation records.

No functional change.

(rillig)

2021-03-12 17:41:11 UTC MAIN commitmail json YAML

2021-03-12 17:03:06 UTC MAIN commitmail json YAML

Update Spleen kernel fonts to version 1.9.0, bringing the following
improvements:

- Enlarge vertical line for consistency with other small sizes (5x8 version)
- Add full support for the Latin-1 Supplement Unicode block (6x12 version)

(fcambus)

2021-03-12 11:43:12 UTC MAIN commitmail json YAML

Update Spleen fonts to version 1.9.0, bringing the following improvements:

- Set WEIGHT_NAME property to "Medium" for all sizes
- Increment STARTPROPERTIES to account for WEIGHT_NAME addition
- Enlarge vertical line for consistency with other small sizes (5x8 version)
- Add full support for the Latin-1 Supplement Unicode block (6x12 version)

(fcambus)

2021-03-12 10:48:29 UTC MAIN commitmail json YAML

Use inline cross-references.

(nia)

2021-03-12 10:45:43 UTC MAIN commitmail json YAML

Use inline cross-references

(nia)

2021-03-12 10:00:32 UTC MAIN commitmail json YAML

Retire the paragraph from 1983 that says this file can be "created
from the official host data base maintained at the Network Information
Control Center (NIC)".  Suggested by Henry Bent.

(uwe)

2021-03-12 08:28:20 UTC MAIN commitmail json YAML

s/Disk and tape/Storage/g, more relevant cross-references

(nia)

2021-03-12 08:19:29 UTC MAIN commitmail json YAML

2021-03-12 08:03:24 UTC MAIN commitmail json YAML

2021-03-12 04:57:42 UTC MAIN commitmail json YAML

Re-factor the code in pmap_extract() that checks the 601 I/O segment
table and the BAT tables into separate functions that can be called
from outside of the pmap module.

(thorpej)

2021-03-12 01:54:29 UTC MAIN commitmail json YAML

Refactor rxr->next_to_check updating.

(knakahara)

2021-03-12 01:53:36 UTC MAIN commitmail json YAML

Remove extra unlock/lock processing around if_percpuq_enqueue().

same as if_wm.c:r1.700

(knakahara)

2021-03-12 00:15:34 UTC MAIN commitmail json YAML

indent: manually fix indentation

No functional change.

(rillig)

2021-03-12 00:13:06 UTC MAIN commitmail json YAML

tests/indent: add test templates for testing specific parser symbols

The basic idea of indent is to split the input into tokens and then
reassemble them, reformatting them on the way.  These tokens determine
how the output is formatted, therefore add tests for each of the
terminal tokens and nonterminal parser symbols, to cover more common
cases, and edge cases as well.

(rillig)

2021-03-11 22:32:06 UTC MAIN commitmail json YAML

indent: reduce indentation of check_size functions

No functional change.

(rillig)

2021-03-11 22:31:19 UTC MAIN commitmail json YAML

remove extra increment; fixes: echo o | sed -e 's/o/\a/'

(christos)

2021-03-11 22:28:30 UTC MAIN commitmail json YAML

indent: remove redundant cast after allocation functions

No functional change.

(rillig)

2021-03-11 22:15:44 UTC MAIN commitmail json YAML

indent: use consistent array indexing

No functional change.

(rillig)

2021-03-11 21:47:36 UTC MAIN commitmail json YAML

indent: merge duplicate code for reading from the input buffer

No functional change.

(rillig)

2021-03-11 19:36:11 UTC MAIN commitmail json YAML

add basic support for iMac G5 audio:
- match AOAShasta
- deal with headphone gpios labeled as lineout in OF
- set sc_mode to SNAPPER_IS_PCM3052 - OF makes it look like an unlabeled
  TAS3004
TODO:
- actually support pcm3052 instead of treating it like a sw codec

(macallan)

2021-03-11 19:34:11 UTC MAIN commitmail json YAML

sun4v: vnet - reception of ethernet frames seems to work now (WIP and code is  still full of debug code)

(palle)

2021-03-11 18:49:18 UTC MAIN commitmail json YAML

Underscore is a word character (thanks uwe@)

(christos)

2021-03-11 18:16:50 UTC MAIN commitmail json YAML

Fix missing Xr

(nia)

2021-03-11 17:42:14 UTC MAIN commitmail json YAML

Mention that formats with >16-bit precision cannot yet be used

(nia)

2021-03-11 17:14:35 UTC MAIN commitmail json YAML

Remove trailing whitespace.

(wiz)

2021-03-11 17:13:29 UTC MAIN commitmail json YAML

Remove trailing whitespace.

(wiz)

2021-03-11 17:12:42 UTC MAIN commitmail json YAML

Remove dead references

(nia)

2021-03-11 17:01:55 UTC MAIN commitmail json YAML

Use inline cross-references.

Remove dead reference.

(nia)

2021-03-11 16:59:04 UTC MAIN commitmail json YAML

Use inline cross-references

(nia)

2021-03-11 16:56:50 UTC MAIN commitmail json YAML

Use inline cross-references.

Remove reference to no-longer-existing FDDI driver.

(nia)

2021-03-11 16:53:14 UTC MAIN commitmail json YAML

Use inline cross-references.

(nia)

2021-03-11 16:50:08 UTC MAIN commitmail json YAML

Use inline cross-references.

Remove dead references that mandoc complains about.

(nia)

2021-03-11 16:43:01 UTC MAIN commitmail json YAML

2021-03-11 16:39:58 UTC MAIN commitmail json YAML

Use inline cross-references.

(nia)

2021-03-11 16:36:41 UTC MAIN commitmail json YAML

2021-03-11 16:34:12 UTC MAIN commitmail json YAML

Use inline references.

(nia)

2021-03-11 16:17:46 UTC netbsd-8 commitmail json YAML

2021-03-11 16:17:14 UTC netbsd-9 commitmail json YAML

2021-03-11 16:04:25 UTC netbsd-8 commitmail json YAML

Pull up the following (all via patch), requested by msaitoh in ticket #1663:

sys/dev/pci/ixgbe/ixgbe.c 1.259, 1.278-1.279
sys/dev/pci/ixgbe/ixgbe.h 1.75
sys/dev/pci/ixgbe/ixgbe_netbsd.h 1.12
sys/dev/pci/ixgbe/ixgbe_vf.c 1.24-1.26
sys/dev/pci/ixgbe/ixgbe_x550.c 1.17
sys/dev/pci/ixgbe/ixv.c 1.155-1.156
sys/dev/pci/ixgbe/ix_txrx.c 1.64-67
sys/dev/pci/files.pci 1.436
share/man/man4/ixg.4 1.13-1.14
share/man/man4/ixv.4 1.3, 1.6-1.7

- Fix a problem that the RX path stalled when the mbuf cluster is
  exhausted.
- Modify some parameters to reduce packet dropping. See also the
  manual's OPTIONS section for the detail.
- ixv(4): The max number of queue(pair) is not 7 but 8. Correctly
  reset the hardware.
- Add "TX " to "Queue No Descriptor Available" evcnt(9) name to make
  it more understandable.
- Fix a bug that some advertise speeds can't be set with
  hw.ixgN.advertise_speed if both 2.5G and 5G are set. Fix the error
  message, too.
- Fix typo in comment or debug message.

(martin)

2021-03-11 16:00:25 UTC netbsd-9 commitmail json YAML

Pull up the following (all via patch) requested by msaitoh in ticket #1231:

sys/dev/pci/ixgbe/ixgbe.c 1.259, 1.278-1.279
sys/dev/pci/ixgbe/ixgbe.h 1.75
sys/dev/pci/ixgbe/ixgbe_netbsd.h 1.12
sys/dev/pci/ixgbe/ixgbe_vf.c 1.24-1.26
sys/dev/pci/ixgbe/ixgbe_x550.c 1.17
sys/dev/pci/ixgbe/ixv.c 1.155-1.156
sys/dev/pci/ixgbe/ix_txrx.c 1.64-67
sys/dev/pci/files.pci 1.436
share/man/man4/ixg.4 1.13-1.14
share/man/man4/ixv.4 1.6-1.7

- Fix a problem that the RX path stalled when the mbuf cluster is
  exhausted.
- Modify some parameters to reduce packet dropping. See also the
  manual's OPTIONS section for the detail.
- ixv(4): The max number of queue(pair) is not 7 but 8. Correctly
  reset the hardware.
- Add "TX " to "Queue No Descriptor Available" evcnt(9) name to make
  it more understandable.
- Fix a bug that some advertise speeds can't be set with
  hw.ixgN.advertise_speed if both 2.5G and 5G are set. Fix the error
  message, too.
- Fix typo in comment or debug message.

(martin)

2021-03-11 15:46:03 UTC MAIN commitmail json YAML

Use inline cross-references.

(nia)

2021-03-11 15:45:55 UTC MAIN commitmail json YAML

Use the same options like m4 (-g turns on GNU, -G turns off GNU) Suggested
by uwe@

(christos)

2021-03-11 15:44:50 UTC MAIN commitmail json YAML

cross-reference pci(9)

(nia)

2021-03-11 15:41:32 UTC MAIN commitmail json YAML

Be less redundant in the DESCRIPTION

(nia)

2021-03-11 15:40:02 UTC MAIN commitmail json YAML

Put cross-references in a useful place, copying usb(4)

Caught a few drivers in the list that no longer exist this way.

(nia)

2021-03-11 15:27:40 UTC MAIN commitmail json YAML

2021-03-11 15:15:05 UTC MAIN commitmail json YAML

Add -G to support GNU extensions

(christos)

2021-03-11 15:12:51 UTC MAIN commitmail json YAML

Document the "C" language escapes supported in GNU mode.

(christos)

2021-03-11 15:00:29 UTC MAIN commitmail json YAML

recognize the "C" language backslash escapes like gnu does (except b which
is already taken)

(christos)

2021-03-11 14:19:43 UTC MAIN commitmail json YAML

delint by removing Tn macros

(nia)

2021-03-11 14:08:18 UTC MAIN commitmail json YAML

2021-03-11 13:12:34 UTC MAIN commitmail json YAML

Avoid polluting console on non-fatal errors.

(tsutsui)

2021-03-11 12:08:57 UTC MAIN commitmail json YAML

2021-03-11 11:54:41 UTC MAIN commitmail json YAML

2021-03-11 11:10:22 UTC MAIN commitmail json YAML

flowlabel will never return anything other than 1 or 0.
s/&&/&/

(ryo)

2021-03-11 10:45:33 UTC MAIN commitmail json YAML

2021-03-11 10:34:34 UTC MAIN commitmail json YAML

Numeric modifiers conflict with the syntax interpretation of ddb, so use 'b', 'w', 'l', 'q' instead.
Also, change load/store('l','s') to 'r','w' like the other arch.

>db{0}> machine watch/1 hostname
>Bad modifier

>db{0}> machine watch/s1 hostname
>add watchpoint 0 as ffffc00001087848

(ryo)

2021-03-11 10:33:36 UTC MAIN commitmail json YAML

Move nvme where I expected to find it (disk controllers section)

(nia)

2021-03-11 10:28:54 UTC MAIN commitmail json YAML

Split wifi cards into a separate section, add many more.

(nia)

2021-03-11 09:48:40 UTC MAIN commitmail json YAML

- fixed a problem where hardware {break,watch}points other than #0 could not be cleared
- hardware {break,watch}point addresses are now strictly checked

(ryo)

2021-03-11 08:33:34 UTC MAIN commitmail json YAML

Use ifdef _KERNEL_OPT instead of ifdef _KERNEL before including
"opt_ppcarch.h".

(simonb)

2021-03-11 04:43:47 UTC MAIN commitmail json YAML

Tidy up initialization of the kernel SRs just a bit.

(thorpej)

2021-03-11 02:30:47 UTC MAIN commitmail json YAML

Add "TX " to "Queue No Descriptor Available" to make it more understandable.
Same as ixgbe.c rev. 1.278.

(msaitoh)

2021-03-11 01:23:34 UTC MAIN commitmail json YAML

Whitespace fixes. No functional change.

(msaitoh)

2021-03-11 01:13:11 UTC MAIN commitmail json YAML

2021-03-10 22:28:27 UTC MAIN commitmail json YAML

byte-flipping a random number is not very useful.

(christos)

2021-03-10 22:18:17 UTC MAIN commitmail json YAML

remove htons, it is pointless (thanks joerg@)

(christos)

2021-03-10 21:36:29 UTC MAIN commitmail json YAML

Update to upstream elftoolchain revision r3933.

(jkoshy)

2021-03-10 19:45:41 UTC MAIN commitmail json YAML

switch G5 iMacs to full speed

(macallan)

2021-03-10 18:29:07 UTC MAIN commitmail json YAML

- In pmap_bootstrap1(), make sure to initialize pmap_kernel()->pm_vsid
  with the kernel's base VSID.
- In va_to_vsid(), always compute the VSID from the base VSID in the
  pmap and the effective segment ID (ESID), rather than extracting it
  from the pmap's segment register value for that ESID.  Not only does
  this make the code the same between OEA and OEA64, but is also lets
  us compute the correct VSID for that pmap/ESID even if the cached SR
  for that ESID currently contains something else, such as an I/O segment
  mapping (as might be the case on a 601).

With this change, we can temporarily toggle between an I/O segment and
and HTAB-mapped segment if needed (e.g. when calling OpenFirmware on
a 601-based system).

(thorpej)

2021-03-10 18:26:16 UTC MAIN commitmail json YAML

remove extra arguments

(christos)

2021-03-10 15:21:11 UTC MAIN commitmail json YAML

remove args from ip_randomid() (John D. Baker). When does this file get built?

(christos)

2021-03-10 15:05:11 UTC MAIN commitmail json YAML

Use __pthread_volatile for ptc_waiters (Greg A. Woods)

(christos)

2021-03-10 13:30:34 UTC MAIN commitmail json YAML

Add manpage links for asysctl(3) and asysctlbyname(3), already described
in sysctl(3).

(simonb)

2021-03-10 13:27:51 UTC MAIN commitmail json YAML

2021-03-10 11:03:49 UTC MAIN commitmail json YAML

Add PCIe driver to build.

You still need:

bcm2838pcie* at fdt?                        # STB PCIe host controller

in kernel config, and DTB entries like:

        pci@7d500000 {
                compatible = "brcm,bcm2711-pcie\0brcm,pci-plat-dev";
                device_type = "pci";
                #address-cells = <0x03>;
                #size-cells = <0x02>;
                bus-range = <0x00 0x01>;
                reg = <0x00 0x7d500000 0x80000>;
                ranges = <0x2000000 0x00 0xf8000000 0x06 0x00 0x00 0x4000000>;
                #interrupt-cells = <0x01>;
                interrupt-map = <0x00 0x00 0x00 0x01 0x01 0x00 0x8f 0x04>;
                interrupt-map-mask = <0x00 0x00 0x00 0x07>;
                linux,pci-domain = <0x00>;
                phandle = <0x90>;
        };

and
                pcie0 = "/scb/pci@7d500000";

in __symbols__

(mlelstv)

2021-03-10 07:23:42 UTC MAIN commitmail json YAML

drm(4): allow limiting maximum X/Y resolution

With some drivers (at least radeon(4)), in some cases the driver
does not choose the resolution correctly.  The options
DRM_MAX_RESOLUTION_HORIZONTAL and DRM_MAX_RESOLUTION_VERTICAL allow
limiting the maximum resolution in X and Y direction.

(wiz)

2021-03-10 06:38:44 UTC MAIN commitmail json YAML

2021-03-10 00:32:16 UTC MAIN commitmail json YAML

Remove Network ATM soft intr queue reporting, we don't have that in the
kernel anymore.

(simonb)

2021-03-10 00:02:00 UTC MAIN commitmail json YAML

lint: disable check for enum type mismatch in switch statement

This check has been too quick and broke the lint build.  Among others,
lib/libpuffs has -w included in LINTFLAGS, which means that the build
can fail even for new warnings, not only for errors.

libpuffs compares a uint16_t with constants from an unnamed enum type.
Since the enum type is completely unnamed (neither a tag nor a typedef),
there is no way to define a struct member having this type. This was a
scenario that I just didn't consider when I added the check to lint.

For now, disable the new check completely.  The previously existing lint
checks stay enabled, including the one that warns about mismatched
anonymous enum types in the '==' operator, which is very similar to the
now disabled check.

(rillig)

2021-03-09 23:40:43 UTC MAIN commitmail json YAML

tests/lint: add example for anonymous enum type in switch expression

(rillig)

2021-03-09 23:09:48 UTC MAIN commitmail json YAML

tests/lint: add tests for comparison between unnamed enums

Since unnamed enum types cannot be used in type casts, there is no
sensible way that this type mismatch could be resolved, without changing
the definition of the enum type itself, but that may be in a
non-modifiable header.

Therefore, comparisons with enum constants of unnamed types cannot be
sensibly warned about.

(rillig)

2021-03-09 20:43:20 UTC MAIN commitmail json YAML

2021-03-09 19:46:28 UTC MAIN commitmail json YAML

indent: extract search_brace from main

No functional change.

(rillig)

2021-03-09 19:32:41 UTC MAIN commitmail json YAML

indent: extract capsicum code out of the main function

No functional change.

(rillig)

2021-03-09 19:23:08 UTC MAIN commitmail json YAML

indent: rename a few more token types

The previous names were either too short or ambiguous.

No functional change.

(rillig)

2021-03-09 19:14:39 UTC MAIN commitmail json YAML

indent: make token names more precise

The previous 'casestmt' was wrong since a case label is not a statement
at all.

The previous 'swstmt' was overly short, and wrong as well, since it
represents only the 'switch (expr)' part, which is not a complete switch
statement.  Same for 'ifstmt', 'whilestmt', 'forstmt'.

The previous word 'head' was not precise enough since it didn't specify
exactly where the head ends and the body starts.  Especially for
handling the dangling else, this distinction is important.

No functional change.

(rillig)

2021-03-09 18:28:10 UTC MAIN commitmail json YAML

indent: rename a few tokens to be more obvious

For casual readers it is not obvious whether the 'sp' meant 'special' or
'space' or something entirely different.

(rillig)