Pull up following revision(s) (requested by simonb in ticket #1646):

external/bsd/ipf/Makefile.inc: revision 1.6
compat/exec.mk: revision 1.5

Use the compat machinery to build "native" IPF binaries as ipfilter
doesn't use compat32 64-bit alignment/size safe structures.

Fixes IPF on at least mips64.

(martin)

Ticket #1183

(martin)

Pull up following revision(s) (requested by simonb in ticket #1183):

external/bsd/ipf/Makefile.inc: revision 1.6
compat/exec.mk: revision 1.5

Use the compat machinery to build "native" IPF binaries as ipfilter
doesn't use compat32 64-bit alignment/size safe structures.

Fixes IPF on at least mips64.

(martin)

Rename man-util-* to comp-c-*

(uki)

Set wantToken when none available.

PR: 53285
Reviewed by: gson

(sjg)

lint: fix function as controlling expression (since 2020-12-31)

It's perfectly valid to directly use a function name as the controlling
expression of an if statement.  That function name is converted
implicitly to a pointer to that function, and that is a scalar value
then.

Spotted by christos in lib/libpthread/pthread.c:634.

(rillig)

lint: demonstrate wrong message 204 (since 2020-12-31)

In func.c 1.39 from 2020-12-31 18:51:28, the check that controlling
expressions are indeed scalar was extended from while and for loops to
if statements as well.  It just seemed to have been an oversight.

This revealed a bug in lint, which didn't accept the following valid
code snippet from lib/libpthread/pthread.c:634:

void _malloc_thread_cleanup(void) __weak;
...
if (_malloc_thread_cleanup)
_malloc_thread_cleanup();

Testing a function (instead of a function pointer) for truthiness is
probably rare since most functions are defined unconditionally.  For
weak functions it comes in handy though.

Clang-Tidy suggests to prefix the function with '&' to silence its
warning.  Doing that revealed a non-obvious behavior in build_ampersand,
which does not add the AMPER node to the expression even though it is
clearly mentioned in the code.  That is left for further research.

Once the original bug is fixed, it probably doesn't matter whether the
AMPER is discarded or retained since check_controlling_expression would
add it back.  There's probably a reason though to sometimes discard the
AMPER and sometimes retain it.

(rillig)

bc(1): Consistently use "parentheses" in plural.

(uwe)

bc(1): Prettify PostScript output some more.

Don't set BNF in all bold .Ic, instead use .Ar for "expr" and "var" so
that only the literal stuff that is being defined is bold.  Arrange
for subscripts to actually be subscripted in PostScript.  Make sure
meta-syntactic [] are set differently than literal (). Etc...

(uwe)

shut up a clang warning about snprintf() called with a variable as format
string
NFCI

(macallan)

bc(1): Replace one last missed \f with semantic markup.

(uwe)

bc(1): Use more .Ql, misc related fixes.

(uwe)

bc(1): Use .Fn and .Fa for functions and their arguments.

(uwe)

bc(1): Indent displays with code examples.

(uwe)

bc(1): Misc fixes in the DIFFERENCES section.

Make "last" an item, as intended.
Make operators literal.

(uwe)

bc(1): small mdoc fixes to improve PostScript output.

The length/scale example at the beginning is not all literal.
Fix remaining "quoted" words to use .Dq
Fix a few small inline code snippets to be literal.

(uwe)

lint: revert test for message 11

That test only produced other messages, but not message 11.

(rillig)

lint: add tests for some messages

(rillig)

Remove .MAKE from nested target which is not a sub-make

This does not fix the issue, just makes the unit-test more accurate.

PR: 55578
Reviewed by: rillig

(sjg)

Fix build for non-_MIPS_NEED_BUS_DMA_BOUNCE platforms

(skrll)

Optimize nbperf

- add fudge mode which gives a slightly slower hash function, but works
  almost always in the first iteration by avoiding degenerate edges
- avoid keeping incidence lists around reducing the memory foot print by
  30%
- split edge processing from hashing as in the non-fudge case it is a
  reasonable costly part that often gets thrown away
- merge graph2 and graph3 routines now that they are mostly the same

(joerg)

Optimize CPU and memory use of cdbw(3)

Reduce memory footprint and processing time by dropping the vertex parts
of the edges kept during the peeling. Hook up the
division-by-multiplication logic to help older platforms.

(joerg)

More converstion from usbd_status to int for function error reporting.
This time it's the turn of usb_allocmem.

(missed in previous commit)

(skrll)

progress: handle EINTR in writes. PR/55914

(lukem)

The "available" property requires a variable length buffer, so
leave free(9) until prom_getprop is changed to use kmem_alloc(9)
instead of malloc(9).

(nakayama)

lint: add tests for messages 93, 94, 95, 96, 97, 98, 99

(rillig)

df: bump man page date

(ginsbach)

psycho: explicit allocation of memory using kmem(9) instead of using the buffer indirectly allocted in the prom_getprop() function (which is still using malloc(9) for memory allocation

(palle)

Simplify macro usage.

(wiz)

Grammar fix for the grammer fix.  Plural subject needs plural verb.  :)

(pgoyette)

Minor grammar fix, more markup, and update date (Dd).

(kre)

Add some paragraph breaks.

(wiz)

Implement the WSDISPLAYIO_GET_FBINFO ioctl, needed by X wsfb driver.

(jandberg)

Markup improvements and typo fixes.

(wiz)

lint: fix test for message 324 on i386

i386 is an ILP32 platform (arch/i386/targparam.h).  On these platforms,
int and long have the same size, and even with the -p option for
portability checks, INT_RSIZE in inittyp.c is defined to 4, not 3.

Because of this, in check_integer_conversion, psize(nt) was not greater
than psize(ot), and the warning was not issued.

To make the test behave the same on all platforms, changed the long
variables to long long, since long long is 64-bit on all platforms, and
int is 32-bit.

(rillig)

ftp(1): fix description of "debug"

"debug" command and documentation got accidentally renamed
to "ftp_debug" 13 years ago, and was only partially fixed.

(lukem)

Drop unused headers. No functional changes intended.

(rin)

Switch DDB for powerpc/booke into SOFTWARE_SSTEP.

SR_SINGLESTEP aka PSL_SE bit in MSR is only available for oea, and HW
debug facilities for booke are significantly different from oea.

(rin)

Sort headers. No functional changes intended.

(rin)

Sort headers. Also, use <ddb/ddb.h> instead of db_interface.h and
db_machdep.h in order not to be bothered by subtle include order.

No functional changes intended.

(rin)

Fix pmap_procwr() for powerpc/booke:

- Use PAGE_MASK, not PAGE_SIZE, to calculate page offset.
- Do not drop page offset of target address.

(rin)

ftp: don't use restartable signals

Refactor to not rely upon restartable signals (SA_RESTART),
possibly fixing intermittent failures with -q QUITTIME.

ftp transfers: handle EINTR/EAGAIN in copy_bytes(),
instead of relying upon restartable signals.

http/https transfers: Explicitly print an error similar to
progressmeter() when timing-out for -Q QUITTIME in fetch_wait(),
and set errno to ETIMEDOUT so that the warn() in fetch_url()
prints a more accurate error message.

PR/55857

(lukem)

lint: clean up generation of the operator tables

Instead of running a shell program that runs an AWK program that
generates the two files ops.c and ops.h, just define the operator tables
once in ops.def and use these definitions flexibly in ops.c and op.h.

(rillig)

lint: remove redundant symbolic operator names

These symbolic names for INCBEF, INCAFT, DECBEF and DECAFT were
non-standard and thus confusing.  All other operators were as expected.
Now that the operator names from ops.def are very similar, there is no
need to keep to almost identical lists around.

No change to the user-visible messages since the only place where these
operator names were used was in 324, and that message was restricted to
PLUS, MINUS, MULT and SHL.

(rillig)

lint: clean up symbolic operator names that are used in the messages

Including the "p" in the symbolic operator names was questionable, for
several reasons:

1.  The "p" could be taken to mean an actual variable name, which is
    confusing if the function doesn't have such a variable, or even more
    so if the line contains an unrelated variable called "p".

2.  For the binary operators, having the "p" mentioned on both sides of
    the operator (such as in "p + p") wrongly suggested that both
    operands of the expression were the same.

3.  The name "p" often stands for a pointer.  Most of the operators
    don't accept pointers, therefore the name was misleading.

For these reasons, the "p" was removed from the symbolic name of all
operators.  This makes several pairs of operators indistinguishable:

    INCBEF == INCAFT
    DECBEF == DECAFT
    UPLUS == PLUS
    UMINUS == MINUS
    STAR == MULT
    AMPER == AND

This is not expected to create any confusion since C programmers are
expected to know these double meanings.

The symbolic names for SHLASS and SHRASS were missing the '=' before.
This was added since omitting it was probably an oversight.

(rillig)

lint: add test for "suggest cast" [324]

This warning is the only one that calls print_tnode, which in turn uses
the redundant operator names in str_op_t.

There is another list of operator names in ops.c, but those names
include more clutter, for example "p + p" instead of a simple "+".
Using those operator names would therefore rather be confusing. These
two lists should be merged, to remove unnecessary redundancy.

(rillig)

Explain wedge auto discovery.

(mlelstv)

lint: swap columns 1 and 2 in ops.def

List the ID of a record first, followed by the describing fields.

(rillig)

lint: make generating the operators table simpler

The generated files are exactly the same as before.

(rillig)

More converstion from usbd_status to int for function error reporting.
This time it's the turn of usb_allocmem.

(skrll)

lint: make check_precedence_confusion simpler

In C, only binary operators have possibly confusing precedence.  All
binary operators have lower precedence than an explicit cast.  When an
expression is parsed, the parentheses are associated with the innermost
possible node.  This means that as soon as a cast operator is
parenthesized, its contained expression can no longer have confusing
precedence.

This allows the code to be written more succinct since the local
variables are no longer necessary.

(rillig)

lint: in debug mode, log every newline

This helps to quickly see where in the source file the parser currently
is.  Previously, the parsing position was only printed after each
declaration, as part of "clear flags".

(rillig)

lint: fix inconsistent whitespace in ops.def

(rillig)

Misc KNF.  NFCI.

(skrll)

Replace home grown #ifdef DIAGNOSTIC check with ASSERT_SLEEPABLE

(skrll)

Use the compat machinery to build "native" IPF binaries as ipfilter
doesn't use compat32 64-bit alignment/size safe structures.

Fixes IPF on at least mips64.

(simonb)

lint: add missing strings for operators

It's difficult to keep these lists in sync when they are spread over
several files.  The lists had been inconsistent since 2008-04-26.  The
inconsistency didn't lead to undefined behavior though since the
operator names are only used in 2 places:

1. check_integer_conversion in message 324 only calls that function with
a few selected operators, all of which are above the missing ones.

2. mkinit prints the node including its operator, but only in debug
mode.  Furthermore I'm not sure whether any of the broken operator names
could ever be accessed at this place since mkinit is only called for
expressions, and the node types are INIT, CASE, FARG, which are all
special.

(rillig)

lint: clean up comments

(rillig)

lint: extract code for determining possible precedence confusion

The function check_precedence_confusion was pretty long, and right in
the middle of that function was the complicated part of determining
which of the operand combinations are confusing and which aren't.

Extract this part into a separate function to document on which
information this decision is based.  This makes it easier to understand
the code since there are fewer local variables around.

As a left-over from a previous commit, rop and rparn don't need to be
initialized twice, now that the assertion for a binary operator is in
place.

Remove the large and useless switch statement over all operator types.
This list was completely unsorted, for no apparent reason.  To see the
list of operators, better look them up in ops.def, there was no need to
have this list duplicated here.

(rillig)

lint: remove unused TBUILTIN_SIZEOF from the C grammar

This token is not generated by the lexer, and it was misspelled anyway.
All other token names start with "T_", this one was missing the
underscore.

(rillig)

lint: precedence confusion is only possible with binary operators

No functional change.

The operator table in ops.def states that every operator that has
possibly confusing precedence is also a binary operator, so assert that
instead of having two different code paths.

(rillig)

lint: fix bug in "precedence confusion possible [169]"

(rillig)

lint: document and demonstrate the bug in check_precedence_confusion

It took quite a while to get to the correct interpretation of this small
piece of code and to draw the right conclusions from it.  Now the bug is
finally ready to be fixed, as already announced in the test.

(rillig)

lint: add more rationale for removing effect-less code

(rillig)

lint: finish the comments in check_precedence_confusion

(rillig)

lint: replace LERROR with lint_assert in check_expr_misc

This reduces the visual clutter.  There is no reason for anyone to
modify the code around the CALL operator, therefore the assertion is not
expected to fail anytime soon.

(rillig)

lint: reduce comment for xgetblk to the actually interesting part

(rillig)

lint: fix typos and other minor stylistic issues

(rillig)

Rename tsl256x.c -> tsllux.c.  No other changes are made by this commit.

(thorpej)

Tweak register bit names, in preparation for supporting younger siblings
of this chip.

(thorpej)

lint: fix bugs in dprint_node in debug mode (since today)

The node was dereferenced before the null check.  GCC 5.5 didn't warn
about this obvious bug, not even with -Wall -Wextra -O2.  Such a case
didn't occur though in the few tests that this function was used in.

The indentation for the nested nodes only needs to be set for a few
lines of code, make this region as small as possible.

There are nodes that use both tn_left and tn_right, even though they are
not defined as binary operators.  An example is CALL, for which tn_left
is the address of the function name and tn_right, which are the
arguments, linked via PUSH nodes.  CALL is not a binary operator since
it doesn't do any calculations with its arguments.

(rillig)

lint: move dprint_node to the top of the file

It now resides right below dumpnode, which implements the same idea but
uses a fixed-size output buffer and prints everything in a single line,
which quickly gets hard to read.  Maybe that's the reason why it had
been commented out since it got added in 2014.

(rillig)

Better grammar.

(pgoyette)

dev/ic/tpm: Take advantage of entropy source if available.

If the tpm is deactivated, though, detach the entropy source so we
don't continue to try polling it -- it can't be activated without a
reboot anyway.

(riastradh)

dev/ic/tpm: Add missing line break in attach output.

(riastradh)

malloc(9) -> kmem(9)

(thorpej)

dev/ic/tpm: Tidy up headers.

- Add include guards.
- Add necessary includes.
- Sort includes.
- Use _BYTE_ORDER, not BYTE_ORDER, for public header.

(riastradh)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

malloc(9) -> kmem(9)

(thorpej)

lint: in debug mode, print node tree for precedence

>From the code alone, it is too difficult to see how the various internal
operators are combined and what properties they have.  A simple tree
visualization helps to see all the details.

This is used to track down the typo in check_precedence_confusion, to
see whether it could have possibly had any influence at all.

(rillig)

Fix calculation of cylinder count from medium size.
Pullups needed.

(mlelstv)

malloc(9) -> kmem(9)

(thorpej)

lint: add test for "precedence confusion possible [169]"

(rillig)

Use sel{record,remove}_knote().

(thorpej)

Use sel{record,remove}_knote().

(thorpej)

KNF

(skrll)

Trailing whitespace

(skrll)

Spell interrupts correctly

(skrll)

malloc(9) -> kmem(9) -- just the simple, straightforward conversions for now.

(thorpej)

sync cpuids[] of sys/arch/aarch64/aarch64/cpu.c r1.43

(ryo)

lint: revert previous commit, except for the typo

(rillig)

lint: fix typo in comment

(rillig)

lint: use consistent indentation for C grammar

(rillig)

make(1): remove anonymous union from struct ListNode

Anonymous structs and unions have been introduced in C11.  The code of
make is supposed to be compatible with C90 though.

The additional members were intended to be used during an interactive
debugging session only and were thus not relevant to running the actual
code.

(rillig)

lint: fix code generation from err.c

That file does not need to be in the current directory.

(rillig)

lint: rename funcarg and funccall to longer names

>From the previous short names, it was no obvious that these functions
create a new tree node.

The function named funccall in lint2 has been left as-is, since it has a
completely different prototype.

(rillig)

lint: rename functions that create nodes

(rillig)

lint: add test for 265 "c89 C does not support 'long long'"

(rillig)

lint: rename prflstrg to printflike_argnum, likewise for scflstrg

(rillig)

lint: rename cstk to cstmt

Most of the code that deals with control statements is only interested
in the innermost control statement, and not if that is a stack or not.
Therefore, emphasize that part in the variable name.

The member c_next was confusing since the "direction" of this "next
element" was ambiguous.  In a sequence of if statements, the "next"
element could have equally been the following one, not the surrounding
one.

(rillig)

lint: rename t_ispacked to t_packed and d_ispacked to d_packed

It's shorter, and the other flags of the type or declaration also don't
have "is" in their names.  Except for t_isenum, but that's because there
is a macro named t_enum that would interfere with that name.

(rillig)

lint: rename type.t_isfield to t_bitfield

(rillig)

lint: in DEBUG mode, verify printf parameters for messages

Since several years GCC validates printf-style strings, and there is no
reason not to let GCC do that work.  This prevents bugs like the
segmentation fault that was fixed in tree.c 1.109 from 2021-01-01.

By default, lint is compiled with DEBUG off, but it's easy enough to
compile it in debug mode once in a while.

(rillig)

lint: remove redundant include of externs1.h

It is already included by lint1.h.

(rillig)

lint: let gnuism and c99ism return void instead of int

The return value was only used in a single case.  Duplicating the
condition for printing a message is ok in that case, since it makes all
other places in the code simpler.

The occasional "(void)" or "msg = " before the function call had hidden
the calls from check-msgs.lua, which didn't check the message texts in
such cases.

(rillig)

malloc(9) -> kmem(9)

(thorpej)

Use sel{record,remove}_knote().

(thorpej)

lint: separate error and warning for 27 and 58

Even though this results in more lines of code, the benefit is that the
message text in the comment is verified by check-msgs.lua.  The code is
also easier to read, the parentheses and asterisk were not needed.

(rillig)

lint: fix spelling of message 308

All other messages are lowercase as well.

(rillig)

Sync w/ HEAD.

(thorpej)

Sync w/ HEAD.

(thorpej)

Handle timerfd ioctls.

(thorpej)

Regen for preadv(2) and pwritev(2).

(thorpej)

Add preadv(2) and pwritev(2).

(thorpej)

lint: add detailed type information for functions

(rillig)

lint: add type information to message 124 "illegal pointer combination"

(rillig)

lint: add test for message 124 "illegal pointer combination"

The message may be correct, but it is not helpful in any way.  There are
just too many function pointers that may differ in a very small detail.

Before tyname.c 1.20 from 2021-01-02, the string representation of type
names was often limited to only 63 characters.  Because of this, it made
sense to omit any detail that could need more space than this.  Now that
this limitation is gone, it's reasonable to add more detail to the type
information, especially since that information is readily available.

(rillig)

lint: add tests for some of the messages

(rillig)

ntp: respect user's wishes to disable interface scanning

While here, disable periodic scanning by default on NetBSD as it's
no longer needed.
The user can still enable it though with a positive number to the -U
option.

kardel@ So far I see no other issues from the pitfalls I know of

(roy)

Ticket #1177

(martin)

Apply patch, requested by khorben in ticket #1177 (issue solved differently
in -current):

sys/kern/init_main.c (apply patch)

PR kern/55906: create the aiodone workqueue before running mountroothooks.

(martin)

Misc whitespace

(skrll)

df: add grand total option

Add a grand total option, -c, similar to the du(1) -c option. Adapted from
the same option (-c) in FreeBSD df(1).

(ginsbach)

route(8): group RTF_GATEWAY and ~RTF_GATEWAY (-iface).

While here, tweak RTF_GATEWAY description.  Passive voice elsewhere in
this table is used to talk about the routes themselves, while here
it's about packets.

(uwe)

route(8): be consistent about capitalization.

(uwe)

make(1): add a few remarks to JobOutput

That function is not used in practice.  Still, there are a lot of subtle
details that can get wrong in that code.

(rillig)

route(8): don't split -blackhole and -noblackhole.

(uwe)

lint: fix integration test

The body of an ATF test must never return 1 but instead report failure
via atf_fail.  Otherwise the following error message appears:

    Failed: Test case body returned a non-ok exit code, but this is
    not allowed

The test program t_integration intentionally bypasses the official ATF
API for performance reasons.  But even then, it should stick to the API
as close as possible.

(rillig)

lint: convert bitfieldtype_ok from int to bool

No functional change intended, except for the output in debug mode.

(rillig)

lint: fix lint warning 161 "constant in conditional context"

(rillig)

lint: add a few more tests

No serious bugs found this time.

(rillig)

lint: fix message 308 "Invalid type for _Complex"

Previously, lint aborted since it didn't expect tspec_name to be called
with NOTSPEC, which at that point was the only possible value of
dcs->d_cmod.

(rillig)

lint: add test for message 308 "Invalid type %s for _Complex"

(rillig)

lint: allow _Bool for bit-fields

(rillig)

lint: fix and document test for illegal bit-fields

The _Complex bit-field should have been commented out.

(rillig)

lint: add test for message 35: illegal bit-field type

Bug: _Bool is not accepted as a bit-field, but it should be.

Bug: lint aborts in a controlled manner with message "common/tyname.c,
190: tspec_name(0)" when it sees a declaration of a _Complex bit-field.
(Not that a _Complex bit-field would make any sense.)

(rillig)

Use USBMALLOC_ZERO to ensure that all DMA memory is zero initialized.

(jmcneill)