Link [ NetBSD | NetBSD OpenGrok source search | PR fulltext-search | Summary of daily snapshot builds | history of daily build result | pkgsrc commit viewer ]


   
        usage: [branch:branch] [user:user] [path@revision] keyword [... [-excludekeyword [...]]] (e.g. branch:MAIN sys/arch/arm, if_wm.c@1.234 )




switch to index mode

recent branches: MAIN (21m)  netbsd-8 (6d)  netbsd-10 (6d)  netbsd-9 (12d)  thorpej-ifq (176d)  thorpej-altq-separation (178d) 

2024-05-10 19:51:47 UTC Now

2023-04-20 14:15:22 UTC netbsd-9 commitmail json YAML

2023-04-20 14:13:27 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by tsutsui in ticket #1629):

usr.sbin/npf/npfd/npfd.8: revision 1.7

Fix tcpdump example from "-i npflog0.pcap" to "-i npflog0"

(martin)

2023-04-20 14:08:07 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by tsutsui in ticket #1628):

sys/arch/dreamcast/dev/microcode/aica_armcode.h: revision 1.5
sys/arch/dreamcast/dev/microcode/aica_arm_locore.S: revision 1.4
sys/arch/dreamcast/dev/microcode/aica_arm_locore.S: revision 1.5
sys/arch/dreamcast/dev/microcode/Makefile: revision 1.6
sys/arch/dreamcast/dev/microcode/aica_arm.c: revision 1.7
sys/arch/dreamcast/dev/microcode/aica_arm.c: revision 1.8

arm side of aica(4) sometimes became unresponsive when audioplay was performed several times.
- disabled data cache at startup.
- compiled with cross-arm-none-eabi-gcc-8.3.0nb4 of pkg.
- added memset() in asm because gcc8 (and later) detects the zero clear part in
  own bzero function and calls memset internally, and bzero were replaced with memset.
improve comment, update mailaddr, and remove clause 3 from my licenses.

(martin)

2023-04-20 13:50:12 UTC netbsd-8 commitmail json YAML

2023-04-20 13:49:11 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by tsutsui in ticket #1821):

sys/arch/luna68k/conf/Makefile.luna68k: revision 1.30

Fix missing locore.d dependency output on make depend.
Reported from isaki@.  Looks missed in rev 1.13 (22 years ago):

https://cvsweb.netbsd.org/bsdweb.cgi/src/sys/arch/luna68k/conf/Makefile.luna68k#rev1.13

(martin)

2023-04-20 13:47:03 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by tsutsui in ticket #1627):

sys/arch/luna68k/conf/Makefile.luna68k: revision 1.30

Fix missing locore.d dependency output on make depend.
Reported from isaki@.  Looks missed in rev 1.13 (22 years ago):

https://cvsweb.netbsd.org/bsdweb.cgi/src/sys/arch/luna68k/conf/Makefile.luna68k#rev1.13

(martin)

2023-04-20 13:45:20 UTC netbsd-10 commitmail json YAML

Pull up following revision(s) (requested by tsutsui in ticket #143):

sys/arch/luna68k/conf/Makefile.luna68k: revision 1.30

Fix missing locore.d dependency output on make depend.
Reported from isaki@.  Looks missed in rev 1.13 (22 years ago):

https://cvsweb.netbsd.org/bsdweb.cgi/src/sys/arch/luna68k/conf/Makefile.luna68k#rev1.13

(martin)

2023-04-20 10:43:17 UTC MAIN commitmail json YAML

optstr(9): markup fixes

While here, wrap long .Fn lines for readability and make the
optstr_get_item list compact.

(uwe)

2023-04-20 09:06:02 UTC MAIN commitmail json YAML

Update to include value conversion routines.

(skrll)

2023-04-20 09:04:45 UTC MAIN commitmail json YAML

Extend optstr(9) to provide some functions to convert the value.

Proposed on tech-kern some time ago.

(skrll)

2023-04-20 08:28:06 UTC MAIN commitmail json YAML

2023-04-20 00:42:24 UTC MAIN commitmail json YAML

Add reloc keyworkd to let EFI bootstrap load amd64 kernel at any address

EFI bootstrap assumes it can copy the amd64 kernel to its ELF load
address (that is KERNTEXTOFF - KERNBASE = 0x200000), but it can
clash with previous UEFI memory allocation, as described here:
http://mail-index.netbsd.org/tech-kern/2023/04/07/msg028833.html

This change adds a reloc keyword for controling where the EFI
boostrap will copy the kernel image. Possible values are:
default - the default and prior behavior, copy at 0x200000.
none - do not copy and use the kernel image where it was loaded.
address - specify an explicit address where to copy the kernel.

This comes with an amd64 kernel patch that makes it self-relocatable.
It first discover where it was loaded in memory, and if this is
different than the expected 0x200000, hhe the kernel relocates
itself and start over at the right address.

(manu)

2023-04-19 22:00:18 UTC MAIN commitmail json YAML

Again allow multicast packets to be sent from unnumbered interfaces.

(mlelstv)

2023-04-19 18:39:18 UTC MAIN commitmail json YAML

Install /boot/boot.cfg with EFI bootloaders.

On ARM ports, the EFI boot loader handles a boot.cfg file if it
exists, but one is not installed by default.  In contrast, both the
i386 and amd64 ports do install boot.cfg by default.  Bring these
ports into agreement by installing boot.cfg on ARM ports with EFI boot
loaders.

(brook)

2023-04-19 16:45:37 UTC netbsd-9 commitmail json YAML

Backout accidental commit (branch/ticket mismatch)

(martin)

2023-04-19 16:43:23 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by tsutsui in ticket #1627):

sys/arch/luna68k/luna68k/mainbus.c: revision 1.20

Fix device name for xpbus at mainbus for LUNA-II, missed on psgpam merge.

Fortunately harmless because xpbus_match() doesn't check ma_name in
mainbus_attach_args.

(martin)

2023-04-19 16:41:18 UTC netbsd-10 commitmail json YAML

2023-04-19 16:40:19 UTC netbsd-10 commitmail json YAML

Pull up following revision(s) (requested by tsutsui in ticket #142):

sys/arch/luna68k/luna68k/mainbus.c: revision 1.20

Fix device name for xpbus at mainbus for LUNA-II, missed on psgpam merge.

Fortunately harmless because xpbus_match() doesn't check ma_name in
mainbus_attach_args.

(martin)

2023-04-19 16:24:51 UTC netbsd-10 commitmail json YAML

Pull up following revision(s) (requested by hannken in ticket #140):

external/gpl3/gcc/dist/libsanitizer/sanitizer_common/sanitizer_mutex.h: revision 1.3

Fix StaticSpinMutex::CheckLocked() on sparc32.

The lock gets set with atomic_exchange() -> __sync_lock_test_and_set()
which sets the value to 255 instead of 1.  Check for a taken lock
with "!= 0" instead of "== 1".  This should work on all architectures.

Ok: Matthew Green

(martin)

2023-04-19 09:39:29 UTC MAIN commitmail json YAML

Another err message typo!  (found this one myself!!)

(kre)

2023-04-19 07:40:49 UTC MAIN commitmail json YAML

Typo in an error message (pointed out by RVP; Thanks)

(kre)

2023-04-19 02:43:40 UTC MAIN commitmail json YAML

Revert "Fix panic on packet sending via a route with rt_ifa of AF_LINK."

The fix is mistakenly upstreamed.

(ozaki-r)

2023-04-19 00:40:30 UTC MAIN commitmail json YAML

virtio(4): change variable name, nfc

(yamaguchi)

2023-04-19 00:38:30 UTC MAIN commitmail json YAML

Fix not to allocate unnecessary descriptor

fixes PR/57358

(yamaguchi)

2023-04-19 00:23:45 UTC MAIN commitmail json YAML

Use enumeration for state of a child driver instead of flags
and check its detaching by using sc->sc_child in virtio_softc

pointed out by riastradh, thanks.
fixes PR/57357

(yamaguchi)

2023-04-18 23:05:51 UTC MAIN commitmail json YAML

Move date setting into cd9660_populate_iso_dir_record so there is no
path that leaves it unset.

From FreeBSD https://reviews.freebsd.org/D39258

(christos)

2023-04-18 23:02:51 UTC MAIN commitmail json YAML

We previously attempted to emit Rock Ridge NM records only when the name
represented by the Rock Ridge extensions would actually differ. We would
omit the record for an all-upper-case directory name, however Linux (and
perhaps other operating systems) map names with no NM record to
lowercase.

This affected only directories, as file names have an implicit ";1"
version number appended and thus always differ.  To solve, just emit NM
records for all entries other than DOT and DOTDOT .

We could continue to omit the NM record for directories that would avoid
mapping (for example, one named 1234.567) but this does not seem worth
the complexity.

From FreeBSD https://reviews.freebsd.org/D39258

(christos)

2023-04-18 23:00:02 UTC MAIN commitmail json YAML

The boot catalog pointer is a DWord, but we previously populated it via
cd9660_bothendian_dword which overwrote four unused bytes following it.
See El Torito 1.0 (1995) Figure 7 for details.

Found by Coverity on FreeBSD

(christos)

2023-04-18 22:58:14 UTC MAIN commitmail json YAML

See RRIP 4.1.4 Description of the "NM" System Use Entry for details.

From FreeBSD

(christos)

2023-04-18 22:56:41 UTC MAIN commitmail json YAML

The bit definitions for the TF_* timestamp bits (TF_MODIFY, etc.) were
incorrect, and timestamps were written in the wrong order.

See RRIP 4.1.6 Description of the "TF" System Use Entry for details.

From: https://reviews.freebsd.org/D39221

(christos)

2023-04-18 22:42:52 UTC MAIN commitmail json YAML

2023-04-18 20:11:34 UTC MAIN commitmail json YAML

switch everyone to openssl.old

(christos)

2023-04-18 20:11:00 UTC MAIN commitmail json YAML

2023-04-18 18:42:20 UTC MAIN commitmail json YAML

mount_procfs(8): Document the format of the region descriptor
lines contained in the 'map' and 'maps' special files.

(jkoshy)

2023-04-18 16:48:45 UTC MAIN commitmail json YAML

The SysV ABI specifies that the symbol hash function should return only 32
bits of hash. Unfortunately due to an implementation bu and the fact that
the return type is unsigned long which is 64 bits in LP64, this can fail
in some cases: "\xff\x0f\x0f\x0f\x0f\x0f\x12". See:
    https://maskray.me/blog/2023-04-12-elf-hash-function
From Ed Maste @ FreeBSD:
    https://cgit.freebsd.org/src/commit/\
?id=29e3a06510823edbb91667d21f530d3ec778116d
Need to write Unit Tests for this.

(christos)

2023-04-18 15:02:22 UTC MAIN commitmail json YAML

Correct some unfortunate behaviour in extreme cases pointed out by RVP.
(Very long worms in a smallish window could result in the max number of
worms being 0...)

While here (also suggested by RVP) seed the random number generator,
also add a -S option to set the seed (note: while this is documented
in the updated man page, it does not appear in the usage message in
case of an error ... not likely to be used often enough to include there).

Also some minor improvements suggested by RVP:
delete the prototype for main()
exit curses mode before abort() (which should not happen, but...)
no need to return (->exit) after abort() as modern abort() can
never return.

In addition, check for extraneous (ignored) (non-option) args.
Check for absurdly small or big screens (the worm placement algorithm
doesn't work well for lines of columns < 3, and the abort() mentioned
above actually happens if one of those is == 1).

More flavours of worms added.

Some minor man page wording improvements.

(kre)

2023-04-18 14:24:25 UTC MAIN commitmail json YAML

2023-04-18 14:07:04 UTC MAIN commitmail json YAML

lua: mention patches with commit IDs in README.import for now.

(nikita)

2023-04-18 11:06:57 UTC MAIN commitmail json YAML

G/C unnecessary

extern paddr_t physical_start, physical_end;

(skrll)

2023-04-18 09:56:57 UTC MAIN commitmail json YAML

Mention applied bugfixes for Lua.

(nikita)

2023-04-18 07:53:31 UTC MAIN commitmail json YAML

2023-04-18 06:37:25 UTC MAIN commitmail json YAML

sb(4): Fix missing mutex initialization at isapnp and ofisa.

PR kern/57363

XXX pullup-8
XXX pullup-9
XXX pullup-10

(riastradh)

2023-04-18 00:21:24 UTC MAIN commitmail json YAML

tprof.8: fix typo, s/speficied/specified/

(gutteridge)

2023-04-17 21:51:40 UTC MAIN commitmail json YAML

tprof(8): fix markup nits

(uwe)

2023-04-17 21:46:12 UTC MAIN commitmail json YAML

tprof.8: new sentence, new line

(gutteridge)

2023-04-17 21:17:58 UTC MAIN commitmail json YAML

lua: apply upstream bugfix for "Loading a corrupted binary file can segfault."

(nikita)

2023-04-17 20:37:43 UTC MAIN commitmail json YAML

lua: apply upstream bugfix for "Wrong line in error message for arithmetic errors."

It also causes 'L->top' to be wrong when the error happens,
triggering an 'assert'.

(nikita)

2023-04-17 20:33:45 UTC MAIN commitmail json YAML

Input and output codecs produce and consume internal audio data, so
don't byteswap it.

(mlelstv)

2023-04-17 20:33:12 UTC MAIN commitmail json YAML

lua: apply ustream bugfix for "C-stack overflow with deep nesting of coroutine.close."

(nikita)

2023-04-17 20:27:40 UTC MAIN commitmail json YAML

lua: apply upstream bugfix for "'utf8.codes' does not raise an error on spurious continuation bytes."

(nikita)

2023-04-17 20:17:58 UTC MAIN commitmail json YAML

lua: apply upstream bugfix for "GC not setting a proper target for next cycle after a full collection in generational mode."

(nikita)

2023-04-17 20:07:32 UTC MAIN commitmail json YAML

lua: apply upstream bugfix for "'break' may not properly close variable in a 'for' loop."

Function 'leaveblock' was generating "break" label before removing
variables from the closing block. If 'createlabel' created a 'close'
instruction (which it did when matching a goto/break that exited
the scope of an upvalue), that instruction would use the wrong level.

(nikita)

2023-04-17 19:54:19 UTC MAIN commitmail json YAML

lua: aply upstream bugfix for "'lua_settop' may use a pointer to stack invalidated by 'luaF_close'."

(nikita)

2023-04-17 19:35:36 UTC MAIN commitmail json YAML

lua: apply upstream bugfix for "Lua-stack overflow when C stack overflows while
handling an error." (CVE-2022-33099)

Save stack space while handling errors

Because error handling (luaG_errormsg) uses slots from EXTRA_STACK,
and some errors can recur (e.g., string overflow while creating an
error message in 'luaG_runerror', or a C-stack overflow before calling
the message handler), the code should use stack slots with parsimony.

This commit fixes the bug "Lua-stack overflow when C stack overflows
while handling an error".

(nikita)

2023-04-17 19:19:00 UTC MAIN commitmail json YAML

lua: apply upstream bugfix for "Wrong code generation for constants in bitwise operations."

(nikita)

2023-04-17 19:17:49 UTC MAIN commitmail json YAML

lua: apply upstream bugfix for "Lua can generate wrong code when _ENV is <const>."

(nikita)

2023-04-17 19:16:38 UTC MAIN commitmail json YAML

lua: Apply upstream bugfix for "lua.c assumes that argv has at least one element."

(nikita)

2023-04-17 18:34:56 UTC netbsd-10 commitmail json YAML

2023-04-17 18:24:52 UTC netbsd-10 commitmail json YAML

Pull up following revision(s) (requested by he in ticket #138):

tests/lib/libc/stdio/t_printf.c: revision 1.9
tests/lib/libc/stdio/t_printf.c: revision 1.10

Add a test for PR/57250 from Havard Eidnes

Fix the test for "inf" output, also include newline in printf format...

(martin)

2023-04-17 18:22:20 UTC netbsd-10 commitmail json YAML

Pull up following revision(s) (requested by he in ticket #137):

lib/libc/stdio/Makefile.inc: revision 1.48
lib/libc/stdio/vfwprintf.c: revision 1.40
lib/libc/include/extern.h: revision 1.27

PR/57250: Martin Husemann: dtoa mishandles infinite doubles on 32bit big
endian machines. When long double support was added, the old code was kept
for the regular double code. This code was never used because WIDE_DOUBLE
was always defined in the Makefile. Remove that old code, and conditionalize
the WIDE_DOUBLE code based on if long doubles are different than doubles on
the specific platform.

(martin)

2023-04-17 18:13:44 UTC netbsd-8 commitmail json YAML

Fix merge mishap in applying the changes from rev 1.171 in ticket #1804:
patch accidently applied the change to a nearby very similar function
(aprint_verbose_internal instead of aprint_error_internal).

(martin)

2023-04-17 10:27:38 UTC MAIN commitmail json YAML

doc: Various changes in the last month.

(nia)

2023-04-17 08:37:24 UTC MAIN commitmail json YAML

Use the default counter if -e argument is not specified.

monitor command:
    The default counter is selected if -e argument is not specified.
list command:
    Print the name of the default counter for monitor and top command.

(msaitoh)

2023-04-17 08:14:51 UTC MAIN commitmail json YAML

2023-04-17 07:13:36 UTC MAIN commitmail json YAML

Add two note to the tprof(8)'s manual page.

- "list" command prints the maximum number of counters that can be used
  simultaneously.
- multiple -e arguments can be specified.

(msaitoh)

2023-04-17 06:57:02 UTC MAIN commitmail json YAML

(missed in pervious commit)

Rename VM_KERNEL_IO_ADDRESS to VM_KERNEL_IO_BASE to match RISC-V

It's less letters, matches other similar variables and will help with
sharing code between the two architectures.

NFCI.

(skrll)

2023-04-17 06:48:07 UTC MAIN commitmail json YAML

2023-04-17 06:46:53 UTC MAIN commitmail json YAML

2023-04-17 00:37:04 UTC MAIN commitmail json YAML

share/misc/style: Don't prescribe using "extern.h" for all prototypes.

That's very 80s.

No objection (or even response, amazingly enough) on tech-userlevel in
two weeks.

(dholland)

2023-04-16 20:46:18 UTC MAIN commitmail json YAML

2023-04-16 20:37:59 UTC MAIN commitmail json YAML

Fix parsing a locale string with multiple components.
Also check for truncation of a long locale string.

(mlelstv)

2023-04-16 19:26:20 UTC MAIN commitmail json YAML

Handle packet scheduling for high/super speed.
More UAC2 handling for input/output/feature/selector units.
Setting sample rate for UAC2 now works, still no support for clock selectors
and multipliers.
Added sysctl to set debug level.
Minor fixes.

(mlelstv)

2023-04-16 18:37:16 UTC MAIN commitmail json YAML

viocon(4): Show error in assertion failure.

(riastradh)

2023-04-16 17:57:08 UTC MAIN commitmail json YAML

virtio@pci: Fix assertion on detach.

If the child never attached in the first place, it's OK for it to not
have detached.

XXX This should not be a set of flags; this should be a state
enumeration, because some flags make no sense, like FINISHED|FAILED.

XXX This should not be asserted separately in each bus; there should
be a single place in virtio.c to assert this, uniformly in all buses.

PR kern/57357

XXX pullup-10

(riastradh)

2023-04-16 17:16:45 UTC MAIN commitmail json YAML

Do not create the sysctl tree if the initial setup of the chip fails.

(brad)

2023-04-16 16:55:02 UTC MAIN commitmail json YAML

2023-04-16 16:51:38 UTC MAIN commitmail json YAML

2023-04-16 14:01:51 UTC MAIN commitmail json YAML

2023-04-16 11:18:25 UTC MAIN commitmail json YAML

autoconf(9): Assert alldevs_lock held in config_unit_nextfree.

The one caller, config_unit_alloc, guarantees it through
config_alldevs_enter/exit.

(riastradh)

2023-04-16 11:14:58 UTC MAIN commitmail json YAML

autoconf(9): Avoid potential ABA bug in config_makeroom.

When we unlock alldevs_lock to allocate a new cd_devs array nsp,
other threads may have:

1. freed the old one (osp),
2. done some other memory allocation,
3. allocated a new _larger_ array whose address happens to concide
  with osp (e.g., in (2) the page was recycled for a different pool
  cache), and
4. updated cd_devs back to osp but increased cd_ndevs.

In that case, the memory may be corrupted: we try to copy the wrong
number of device_t pointers into nsp and we free osp with the wrong
(stale) length.

Avoid this by checking whether cd_ndevs has changed too -- if not,
osp might have been recycled but at least the lengths we're about to
copy and free are still correct so there's no harm in an ABA
situation.

XXX pullup-8
XXX pullup-9
XXX pullup-10

(riastradh)

2023-04-16 04:52:19 UTC MAIN commitmail json YAML

pserialize(9): Fix buggy assertion inside assertion.

If there has been a context switch, then we can't be in a pserialize
read section -- _and_ whatever we read out of curcpu() is stale, so
we can't assert anything based on it.  So just delete the assertion.

Reported-by: syzbot+d7065ab16d7cd9cc09af@syzkaller.appspotmail.com
https://syzkaller.appspot.com/bug?id=0c63db890575d29c6a51fb24b003d3bab1f7f04b

(riastradh)

2023-04-15 18:16:28 UTC MAIN commitmail json YAML

Fix a wrong year in r1.168.  Pointed out by Nishi.

(tsutsui)

2023-04-15 16:54:39 UTC MAIN commitmail json YAML

Revert accidentially committed part. The 'latency' report isn't ready
to be useful.

(mlelstv)

2023-04-15 15:21:56 UTC MAIN commitmail json YAML

When worms default delay was changed from 0, to 20ms (Oct 2020)
it lost the ability to run flat out (no sleeps) - which while not
very useful for actually observing the behaviour of various Nematoda,
can be useful when 'worms' is being used to generate cpu heat - it
turns out to be a simple tool to make all of the app itself, the
xterm it runs in (when running under X) and the X server, all more
or less continuously busy - a trivial perpetual CPU load generator.

Changing that was not a simple matter of just allowing -d 0..1000
rather than -d 1..1000 which had always been the limits on -d, as
previously, simply by excluding 0, common error checking wasn't
essential.  -djunk would return 0 which was invalid, and so an error
- that it was invalid because 0 < 1, rather than because "junk" is not
a number wasn't material.

Now we need some slightly more elaborate error checking code for the
-d value, and if we're going to do that, may as well do the same for
the -l and -n options, which also take numeric values.  That is, it
will no longer be possible to say:
worms -n "5 worms"
Just the number is allowed (but -d now allows a "ms" or "us" suffix).

While here, place a reasonable upper limit (depending upon the
screen size, and worm length) upon the number of worms, so they
have somewhere to go, rather than just on top of each other.

exit(1) from the errx() rather than 0, in the case that curses
initscr() fails (doesn't seem right that it should appear as a
successful run of worms, if it never managed to start).

A couple more minor 80 column violations are handled, without
further penalty, in this update (one simply vanishes, the other
is wrapped).

Note that this sounds like a lot, but it is really all just minor
internal bookkeeping updates - the only real advertised user visible
change is the ability to use -d0 which just restores that which was
the default (though it could never be set via the option) until Oct 2020
- so really all that's happening is replacing minor functionality lost
then, while leaving the change of the default delay that that change
made, untouched.

No man page update required (that never excluded -d0).

(kre)

2023-04-15 13:40:23 UTC MAIN commitmail json YAML

80 column police.

If this code were just a few chars over the limit, it might get
let off with a warning, but 214 in an 80 zone is way beyond that.

Six months loss of coding licence, and a 214000 character fine.

NFCI.

(I verified the the code was unchanged by joining the resulting
lines back into one again, and then diff'ing that line against
the original - it is identical).

(kre)

2023-04-15 13:00:30 UTC MAIN commitmail json YAML

Garbage collect "char *mp" - it used to point at memory malloc()'d
to hold the termcap entry, back when worms used termcap rather than
curses, and termcap was termcap, rather that a terminfo wannabe.

This should have been removed when worms was converted to curses in
1999, but wasn't, so worms has been doing a meaningless malloc(1024)
and never using the result, ever since.

While here, since the line needed changing anyway to remove mp,
change a malloc() of a product into calloc() so it can deal with
any possible (admittedly extremely unlikely here) integer overflows.

NFCI

(kre)

2023-04-15 12:59:02 UTC MAIN commitmail json YAML

tests/lint: remove wrong comment

GCC 10 does warn about returning a temporary object, but only when
optimizations are enabled.

(rillig)

2023-04-15 12:47:32 UTC MAIN commitmail json YAML

tests/lint: add more tests for returning local objects

(rillig)

2023-04-15 12:39:44 UTC MAIN commitmail json YAML

2023-04-15 12:29:43 UTC MAIN commitmail json YAML

lint.1: remove extra space from -q option

(rillig)

2023-04-15 12:22:37 UTC MAIN commitmail json YAML

style: fix spelling of plural parentheses

(rillig)

2023-04-15 12:09:08 UTC netbsd-10 commitmail json YAML

2023-04-15 12:08:42 UTC netbsd-10 commitmail json YAML

Pull up the following revision (requested by martin in ticket #127):

        tests/sbin/envstat/t_envstat.sh: revision 1.2

PR 57284: rewrite test to extract all temperaturs from all local sensors
and test them (instead of only one temperature from a tiny list of hard
coded possible devices).

(jdc)

2023-04-15 11:34:45 UTC MAIN commitmail json YAML

2023-04-15 10:53:59 UTC MAIN commitmail json YAML

tests/lint: extend test for returning local address

(rillig)

2023-04-15 10:32:46 UTC MAIN commitmail json YAML

lint: extract checking the return value to separate function

No functional change.

(rillig)

2023-04-14 18:42:31 UTC MAIN commitmail json YAML

lint: document suppressed LDBL_MAX warning more accurately

The crucial point is not that lint is cross-compiled but that tools/lint
is run on the usr.bin/xlint code, and in that situation, the platform
mismatch happens.

(rillig)

2023-04-14 17:46:00 UTC MAIN commitmail json YAML

In preparation of imx6sx support, move imx6q-specific definitions from
imx6_ccm.c to imx6_clk.c, and prefix with IMX6Q/imx6q:
- Clock IDs and related struct imx_clock_id
- Clock Parents and Divider Tables
- struct imx6_clk
and related static functions

Add a pointer to struct imx6_clk, and it's size to imx6ccm_softc
Pass a pointer to imx6ccm_softc to all functions from imx6_ccm.c

NFCI

(bouyer)

2023-04-14 16:53:14 UTC MAIN commitmail json YAML

style: don't require sorting variables in functions

Sorting the variables by size would be platform-dependent and thus is
not possible.

Sorting the variables alphabetically may or may not make the code easier
to read, and the example given below that rule doesn't follow it,
otherwise the correct order would be 'eight, eleven, nine, ten,
thirteen, twelve'.

https://mail-index.netbsd.org/tech-userlevel/2023/04/11/msg013749.html

(rillig)

2023-04-14 16:51:46 UTC MAIN commitmail json YAML

pserialize(9): Fix bug in recent micro-optimization.

curcpu() is always a valid struct cpu_info pointer, but curlwp->l_cpu
is not necessarily -- early at boot on some architectures (like x86,
apparently) it may be null.

Not clear that l->l_cpu is always a cost win over curcpu(): on some
architectures curcpu() is basically a macro for curlwp->l_cpu, while
on others it is a fixed VA.  So let's use the one that always works
instead of the one that's sometimes cheaper and sometimes crashier.

(riastradh)

2023-04-13 13:07:48 UTC MAIN commitmail json YAML

initialize the diagnostic register with the value suggested by the SunOS
header. This sets a bunch of undocumented bits and yields a 10% speed increase
when rendering antialiased text.

(macallan)

2023-04-13 11:44:10 UTC MAIN commitmail json YAML

Fix device name for xpbus at mainbus for LUNA-II, missed on psgpam merge.

Fortunately harmless because xpbus_match() doesn't check ma_name in
mainbus_attach_args.

(tsutsui)

2023-04-13 08:30:41 UTC MAIN commitmail json YAML

dk(4): Explain why dk_rawopens can't overflow and assert it.

(riastradh)

2023-04-13 07:03:32 UTC MAIN commitmail json YAML

sys/modules/Makefile: Use MACHINE_CPU, not MACHINE_ARCH, for aarch64.

This way it covers both little-endian and big-endian.

(riastradh)

2023-04-13 06:39:23 UTC MAIN commitmail json YAML

powerpc/ddb: Fix one more load to use db_read_bytes.

Fix some typos in crash(8) comments too.

XXX pullup-8
XXX pullup-9
XXX pullup-10

(riastradh)

2023-04-12 19:47:41 UTC MAIN commitmail json YAML

powerpc/ddb: Use db_read_bytes, not direct pointer access.

Mark some powerpc-variant ifdefs with XXX crash(8), not sure yet what
to do about them.

XXX pullup-8
XXX pullup-9
XXX pullup-10

(riastradh)

2023-04-12 19:09:48 UTC MAIN commitmail json YAML

lint: suppress warnings about LDBL_MAX in cross-build mode

This fixes the cross build for sparc64 on x86_64, in which lint
complained:
warning: floating-point constant out of range [248]
warning: floating point overflow on operator '-' [142]
warning: floating-point constant out of range [248]

(rillig)

2023-04-12 17:53:32 UTC MAIN commitmail json YAML

2023-04-12 06:57:28 UTC MAIN commitmail json YAML

Use CACHE_LINE_SIZE instead of magic number 128.

(skrll)

2023-04-12 06:49:17 UTC MAIN commitmail json YAML

Welcome to 10.99.3!

Courtesy of:
- deleted ttycheckoutq parameter
- deleted mutex_owner symbol
- tco(4) at ichsmb(4)
- new m_get_n, m_gethdr_n symbols

(riastradh)

2023-04-12 06:48:08 UTC MAIN commitmail json YAML

mbuf(9): New m_get_n, m_gethdr_n.

m_get_n(how, type, alignbytes, nbytes) returns an mbuf with no packet
header having space for nbytes, with an internal buffer pointer
aligned by alignbytes (typically ETHER_ALIGN or similar, if not
zero).

m_gethdr_n(how, type, alignbytes, nbytes) does the same but for an
mbuf with a packet header.

These return NULL on failure, which can happen either:
(a) because how is M_DONTWAIT and allocating memory would sleep, or
(b) because alignbytes + nbytes > MCLBYTES.

On exit, m_len is set to nbytes, as is m_pkthdr.len for m_gethdr_n.

These should be used to systematically replace all calls to m_get,
m_gethdr, MGET, MGETHDR, and m_getcl.  Most calls to m_clget and
MCLGET will probably evaporate as a consequence.

Proposed on tech-net last year:
https://mail-index.netbsd.org/tech-net/2022/07/16/msg008285.html

(riastradh)

2023-04-12 06:39:16 UTC MAIN commitmail json YAML

ichsmb(4), tco(4): Add support for TCO on newer Intel chipsets.

TCO (`Total Cost of Ownership', Intel's bizarre name for a watchdog
timer) used to hang off the Intel I/O platform controller hub's (ICH)
low-pin-count interface bridge (LPC IB), or ichlpcib(4).  On newer
devices, it hangs off the ICH SMBus instead.

Tested on INTEL 100SERIES_SMB (works) and INTEL 100SERIES_LP_SMB
(doesn't work, still not sure why).

XXX kernel revbump: This breaks the module ABI -- tco(4) modules
older than the change to make ta_has_rcba into ta_version will
incorrectly attach at buses they do not understand.  (However, the
tco(4) driver is statically built into GENERIC, so maybe it's safe
for pullup since the module wouldn't have worked anyway.)

(riastradh)

2023-04-12 06:35:41 UTC MAIN commitmail json YAML

kern: Nix mutex_owner.

There is no valid reason to use this except in assertions of the form

KASSERT(mutex_owner(lock) == curlwp),

which is more obviously spelled as

KASSERT(mutex_owned(lock)).

Exception: There's one horrible kludge in zfs that abuses this, which
should be eliminated.

XXX kernel revbump -- deleting symbol

PR kern/47114

(riastradh)

2023-04-12 06:35:26 UTC MAIN commitmail json YAML

ttycheckoutq(9): wait=0 always, parameter no longer useful, nix it.

XXX kernel revbump

(riastradh)

2023-04-12 02:15:51 UTC MAIN commitmail json YAML

KNF. No functional change.

(msaitoh)

2023-04-11 19:40:05 UTC MAIN commitmail json YAML

lint: fix converting a complex floating-point constant

The complex '+' in msg_142 line 27 led to an invalid floating point
value when converting from 'double' to '_Complex double'.

(rillig)

2023-04-11 19:07:08 UTC MAIN commitmail json YAML

lint: fix wrong warning about overflow in floating constant expressions

(rillig)

2023-04-11 19:02:19 UTC MAIN commitmail json YAML

2023-04-11 18:23:42 UTC MAIN commitmail json YAML

PR misc/57343 (Jim Spath) - fixed a typo in atf_tc_skip message.

(kre)

2023-04-11 17:52:11 UTC MAIN commitmail json YAML

lint: in debug mode, use different names for macro and function

No functional change.

(rillig)

2023-04-11 14:50:47 UTC MAIN commitmail json YAML

lfs: Assert page identity doesn't change.

Forgot what I was debugging when I inserted a relookup in my local
tree months or years ago, but whatever it was, if that solved a
problem, this KDASSERT will make the problem more obvious.

(riastradh)

2023-04-11 14:22:10 UTC MAIN commitmail json YAML

style(5): Omit redundant proscription against .c externs in previous.

(riastradh)

2023-04-11 14:03:46 UTC MAIN commitmail json YAML

Give scope and additional details to wg(4) diagnostic messages.

(jakllsch)

2023-04-11 13:26:19 UTC MAIN commitmail json YAML

Fix missing locore.d dependency output on make depend.

Reported from isaki@.  Looks missed in rev 1.13 (22 years ago):
http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/arch/luna68k/conf/Makefile.luna68k#rev1.13

Should be pulled up to netbsd-8, netbsd-9, and netbsd-10.

(tsutsui)

2023-04-11 13:17:32 UTC MAIN commitmail json YAML

rndctl(8): Take omitted name/type as empty device name.

This can now be used to change flags for all sources at once.

XXX pullup-10

(riastradh)

2023-04-11 13:11:01 UTC MAIN commitmail json YAML

x86: Omit needless membar_sync in intr_disestablish_xcall.

Details in comments.

(riastradh)

2023-04-11 13:06:21 UTC MAIN commitmail json YAML

thmap(9): kmem_zalloc(KM_SLEEP) never fails.  Prune dead branch.

(riastradh)

2023-04-11 13:01:42 UTC MAIN commitmail json YAML

com(4): Note ttylock in comment, not tty_lock.

(riastradh)

2023-04-11 12:58:03 UTC MAIN commitmail json YAML

evbarm/plcom(4): Note ttylock in comment, not tty_lock.

(riastradh)

2023-04-11 12:56:08 UTC MAIN commitmail json YAML

evbarm/plcom(4): Sync some recent changes from com(4).

- Nix quirky `integrate' macro.
- Omit needless spltty in plcomstart.
- Comment on lock order.
- Update confusing comment about hangup delay.
- Add include guards.

(riastradh)

2023-04-11 12:55:59 UTC MAIN commitmail json YAML

com(4): Note timecounter_lock in lock order comments.

(riastradh)

2023-04-11 10:34:52 UTC MAIN commitmail json YAML

Make vacation(1) check 'Auto-Submitted:' (RFC 3834) in addition to
'Precedence:' (RFC 2076), and set 'Precedence:' in addition to
'Auto-Submitted:'.

Update the man page accordingly.

(hauke)

2023-04-11 10:30:41 UTC MAIN commitmail json YAML

2023-04-11 10:23:47 UTC MAIN commitmail json YAML

ttwrite(9): Assert we mangle uio_resid only if we also return error.

(riastradh)

2023-04-11 10:22:04 UTC MAIN commitmail json YAML

uiomove(9): Stronger assertions about iov array.

(riastradh)

2023-04-11 10:19:56 UTC MAIN commitmail json YAML

kmsan: Format exact instruction addresses relative to symbols.

(riastradh)

2023-04-11 10:07:12 UTC MAIN commitmail json YAML

2023-04-11 09:53:28 UTC MAIN commitmail json YAML

Test cpuid_level in tprof_intel_ncounters().

This function is called before tprof_intel_ident().

(msaitoh)

2023-04-11 08:50:07 UTC MAIN commitmail json YAML

usb(9): Assert ud_ifaces is null before we clobber it.

(riastradh)

2023-04-11 08:40:20 UTC MAIN commitmail json YAML

arm/rockchip: Omit needless functions.

(riastradh)

2023-04-11 06:42:30 UTC MAIN commitmail json YAML

2023-04-11 02:47:01 UTC MAIN commitmail json YAML

Obtain the number of general counters from CPUID 0xa.

(msaitoh)

2023-04-11 02:44:06 UTC MAIN commitmail json YAML

Add CPUID 0x07 %ecx bit 24 BUS_LOCK_DETECT.

(msaitoh)

2023-04-11 02:42:15 UTC MAIN commitmail json YAML

Add Intel lam and AMD vnmi.

(msaitoh)

2023-04-11 00:03:42 UTC MAIN commitmail json YAML

lint: don't wrongly warn about overflow in complex constants

Seen in lib/libm.

(rillig)

2023-04-10 23:56:30 UTC MAIN commitmail json YAML

lint: add debug logging for values that differ between trad and C90

(rillig)

2023-04-10 23:52:49 UTC MAIN commitmail json YAML

tests/lint: demonstrate wrong warning with complex numbers

(rillig)

2023-04-10 19:23:02 UTC MAIN commitmail json YAML

libm: suppress lint warning about '>>' on signed integer

GCC has implementation-defined behavior for that case.

(rillig)

2023-04-10 15:27:51 UTC MAIN commitmail json YAML

Reduce excessive settle delay.

(mlelstv)

2023-04-10 15:26:57 UTC MAIN commitmail json YAML

Better descriptor parsing.
Add sanity check if no default format is found.

(mlelstv)

2023-04-10 15:14:51 UTC MAIN commitmail json YAML

Handle more UAC2 descriptors and add debug output.
Fix handling of clock sources (mix.wIndex wasn't set).

UAC2 can use separate clock sources (and thus sample rates) for each terminal.
That doesn't match the audio(4) model where sample rates are part of an audio
format and global. For now, try to match clocks for input and output terminals
separately.

(mlelstv)

2023-04-10 15:04:49 UTC MAIN commitmail json YAML

Write slinear_le 16bit samples, independent from platform and
AUDIO_INTERNAL_BITS.

(mlelstv)

2023-04-10 06:08:56 UTC MAIN commitmail json YAML

2023-04-09 20:41:29 UTC MAIN commitmail json YAML

xhci(4): Avoid crash in suspend/resume/resume if first resume fails.

Rather than try to recover from this, just make new commands fail so
at least we don't deadlock.

XXX pullup-9
XXX pullup-10

(riastradh)

2023-04-09 17:24:48 UTC MAIN commitmail json YAML

ld.elf_so powerpc: remove bogus ldscript

This ldscript is not needed and actually makes things worse by putting
everything in one LOAD section, which then needs to have rwx permission.
Remove it so that we get two LOAD sections with better permissions.
Fixes PR 57323.

(chs)

2023-04-09 12:37:12 UTC MAIN commitmail json YAML

uvm: Simplify assertion in uvn_get.

No functional change intended.

(riastradh)

2023-04-09 12:33:58 UTC MAIN commitmail json YAML

nfs: Simplify assertion.  No functional change intended.

(riastradh)

2023-04-09 12:31:10 UTC MAIN commitmail json YAML

dwc2: KASSERT(A && B) -> KASSERT(A); KASSERT(B)

(riastradh)

2023-04-09 12:29:26 UTC MAIN commitmail json YAML

compat_linux32: KASSERT(A && B) -> KASSERT(A); KASSERT(B)

(riastradh)

2023-04-09 12:26:36 UTC MAIN commitmail json YAML

genfs: KASSERT(A && B) -> KASSERT(A); KASSERT(B)

(riastradh)

2023-04-09 12:22:00 UTC MAIN commitmail json YAML

pool(9): Tweak branch prediction in pool_cache_get_paddr assertion.

No functional change intended.

(riastradh)

2023-04-09 12:16:42 UTC MAIN commitmail json YAML

kpause(9): Simplify assertion.  No functional change intended.

(riastradh)

2023-04-09 12:16:34 UTC MAIN commitmail json YAML

pool(9): Simplify assertion in pool_update_curpage.

Add message while here.

(riastradh)

2023-04-09 09:18:10 UTC MAIN commitmail json YAML

2023-04-09 09:00:56 UTC MAIN commitmail json YAML

2023-04-09 08:50:20 UTC MAIN commitmail json YAML

kmem(9): Tweak branch predictions in fast paths.

(riastradh)

2023-04-09 08:28:25 UTC MAIN commitmail json YAML

pserialize(9): Micro-optimize pserialize_read_exit.

Most of the time we're not cold, so let's convince gcc to make that a
statically predicted-not-taken branch.

(riastradh)

2023-04-09 08:18:03 UTC MAIN commitmail json YAML

i386: Make curlwp and curcpu() flushable.

The only effect of the `volatile' qualifier on an asm block with
outputs is to force the instructions to appear in the generated code,
even if the outputs end up being unused.  Since these instructions
have no (architectural) side effects -- provided %fs is set
correctly, which must be the case here -- there's no need for the
volatile qualifier, so nix it.

(riastradh)

2023-04-09 08:17:56 UTC MAIN commitmail json YAML

amd64: Make curlwp and curcpu() flushable.

The only effect of the `volatile' qualifier on an asm block with
outputs is to force the instructions to appear in the generated code,
even if the outputs end up being unused.  Since these instructions
have no (architectural) side effects -- provided %gs is set
correctly, which must be the case here -- there's no need for the
volatile qualifier, so nix it.

(riastradh)

2023-04-09 08:17:45 UTC MAIN commitmail json YAML

pserialize(9): Micro-optimize pserialize_not_in_read_section_p.

Load l_ncsw to test whether we have been preempted, rather than
loading and storing l_nopreempt (via function call) to prevent it.

(riastradh)

2023-04-09 08:17:36 UTC MAIN commitmail json YAML

ASSERT_SLEEPABLE(9): Micro-optimize this a little bit.

This convinces gcc to do less -- make a smaller stack frame, compute
fewer conditional moves in favour of predicted-not-taken branches --
in the fast path where we are sleepable as the caller expects.

Wasn't able to convince it to do the ncsw loop with a
predicted-not-taken branch, but let's leave the __predict_false in
there anyway because it's still a good prediction.

(riastradh)

2023-04-09 06:57:25 UTC MAIN commitmail json YAML

2023-04-09 06:49:34 UTC MAIN commitmail json YAML

tnftp 20230409 release

Changes since tnftp 20210827
* Validate SSL certificates by default, disabled with
  FTPSSLNOVERIFY=1 in the environment, or option sslnoverify.
* Add netrc processing to fetch-mode (URL on command line)
  to enable options and autologin via netrc.
* Handle relative URLs in fetch.
* Improve formatting of manual page.
* Update to NetBSD-ftp 20230225.

(lukem)

2023-04-09 06:30:14 UTC MAIN commitmail json YAML

2023-04-09 06:23:20 UTC MAIN commitmail json YAML

2023-04-09 06:17:55 UTC MAIN commitmail json YAML

ssl.c: sync from upstream 1.14

Simplify includes
Include "ftp_var.h" instead of various system headers and "extern.h"

(lukem)

2023-04-09 06:10:03 UTC MAIN commitmail json YAML

Simplify includes

Include "ftp_var.h" instead of various system headers and "extern.h".

(lukem)

2023-04-09 01:18:28 UTC MAIN commitmail json YAML

2023-04-09 01:06:10 UTC MAIN commitmail json YAML

THANKS: add recent NetBSD committers

(lukem)

2023-04-09 00:59:30 UTC MAIN commitmail json YAML

todo: move most entries to "Old items"

(lukem)

2023-04-09 00:56:07 UTC MAIN commitmail json YAML

2023-04-07 12:09:13 UTC MAIN commitmail json YAML

2023-04-07 11:08:31 UTC MAIN commitmail json YAML

lint: reduce clutter in parsing preprocessor lines

No functional change.

(rillig)

2023-04-07 10:42:28 UTC MAIN commitmail json YAML

Remove an end of file trailing blank line that served no purpose.

NFCI

(kre)

2023-04-07 10:34:13 UTC MAIN commitmail json YAML

2023-04-07 09:39:48 UTC MAIN commitmail json YAML

xhci(4): Defer root intr xfers while polling.

Root intr xfers require taking adaptive locks, which is forbidden
while polling.

This is not great -- any USB transfer completion callbacks might try
to take adaptive locks, not just uhub_intr, and that will always
causes trouble.  We get lucky with ukbd_intr because it's not
MP-safe, so it relies only on the kernel lock (a spin lock) anyway.
But this change brings xhci in line with ehci.

PR kern/57326

XXX pullup-8
XXX pullup-9
XXX pullup-10

(riastradh)

2023-04-07 08:55:31 UTC MAIN commitmail json YAML

2023-04-07 06:44:08 UTC MAIN commitmail json YAML

Select virtual address as sender if backing interface is anonymous.
Use correct scope for IPv6.

(mlelstv)

2023-04-07 05:54:16 UTC MAIN commitmail json YAML

2023-04-07 03:01:21 UTC MAIN commitmail json YAML

2023-04-06 09:49:12 UTC MAIN commitmail json YAML

Fix StaticSpinMutex::CheckLocked() on sparc32.

The lock gets set with atomic_exchange() -> __sync_lock_test_and_set()
which sets the value to 255 instead of 1.  Check for a taken lock
with "!= 0" instead of "== 1".  This should work on all architectures.

Ok: Matthew Green

(hannken)

2023-04-06 04:44:09 UTC MAIN commitmail json YAML

2023-04-06 04:43:43 UTC MAIN commitmail json YAML

The SAATA device ID for Apollo Lake is not 0x5ae0 but 0x5ae3.

(msaitoh)

2023-04-05 21:53:57 UTC MAIN commitmail json YAML

2023-04-05 21:46:09 UTC MAIN commitmail json YAML

s/esssentially/essentially/ in comment.

(andvar)

2023-04-05 20:17:30 UTC MAIN commitmail json YAML

2023-04-05 20:13:01 UTC MAIN commitmail json YAML

2023-04-05 19:56:27 UTC MAIN commitmail json YAML

s/termintaed/terminated/ in comment.

(andvar)

2023-04-05 07:41:38 UTC MAIN commitmail json YAML

Fix StaticSpinMutex::CheckLocked() on sparc32.

The lock gets set with atomic_exchange() -> __sync_lock_test_and_set()
which sets the value to 255 instead of 1.  Check for a taken lock
with "!= 0" instead of "== 1".  This should work on all architectures.

Ok: Matthew Green

(hannken)

2023-04-04 20:39:36 UTC MAIN commitmail json YAML

mount_portal: fix lint warnings about extern and empty declarations

(rillig)