lint: unabbreviate some fields in sym_t

No functional change.

(rillig)

lint: encode lifetime of allocated memory in function names

No functional change.

(rillig)

lint: encode lifetime of allocated memory in the function names

No functional change.

(rillig)

lint: clean up memory management for string buffers

There is no reason to duplicate all the work that is already done by the
memory allocator.

No functional change.

(rillig)

lint: clean up memory allocation

No functional change.

(rillig)

lint: remove custom free list for memory blocks

Trust the system memory allocator to do its thing, including marking the
memory as fresh or freed.  One less thing to worry about.

(rillig)

lint: rename ARG to OLD_STYLE_ARG

Pre-C90 argument declarations have been old for more than 30 years now,
so mention that fact in the constant name.  This reduces potential
confusion with other occurrences of the words 'arg' or 'argument'.

No functional change.

(rillig)

lwp.h: correct grammar in a comment

(gutteridge)

lint: improve debug logging for symbol kinds

(rillig)

lint: fix memory corruption in statement expressions (since 2021-12-17)

The commit that introduced the assertion failure looks innocent, it only
adds a few predefined functions for GCC mode.  Nevertheless, before that
commit, lint consistently complained about 'error: void type illegal in
expression [109]', which doesn't make sense either.

This fix also removes the creative use of the initialization stack to
store the type of the statement expression.  Having a separate stack for
these statement expressions makes the code easier to understand.

(rillig)

lint: extract code for handling statement expressions from the grammar

This prepares the fix of the memory corruption bug that is demonstrated
in t_integration.sh, test case assertion_failures.

No functional change.

(rillig)

don't require arc4random_buf for tools build

(christos)

lint: enable memory debugging

Filling deallocated memory with 0x00 may hide errors, so rather fill
with 0xA5.

While this doesn't change anything about the test about the assertion
failure after a do-while loop (see t_integration.sh, test case
assertion_failures), it may detect other similar bugs earlier.

(rillig)

explain CRON_WITHIN better.

(christos)

tests/lint: demonstrate assertion failure in GCC compound expression

(rillig)

Mark randomly failing test cases as expected failures with a reference
to PR bin/56506.

(gson)

drm2: do not try to return a value from a void function

lint complained:
vmalloc.h(79): error: void function vfree cannot return value [213]

No functional change.

(rillig)

re-enable getrandom for the non-tools build (thanks martin)

(christos)

if_wm.c: fix value return from void function

lint complained:
if_wm.c(10028): error:
    void function wm_txrxintr_disable cannot return value [213]
if_wm.c(10049): error:
    void function wm_txrxintr_enable cannot return value [213]

No functional change.

(rillig)

if_wm.c: remove stray semicolons from struct declaration

C99 does not allow 'struct { int member;; }'.

No binary change.

(rillig)

fix merge botch and reduce diff from upstream.

(christos)

ah, wiz added another endif.

(christos)

remove stray #if 0

(christos)

make: fix memory leak in Lst_Remove (since 2020-10-23)

The code to free the list node (as opposed to the node data) was
accidentally removed in lst.c 1.83 from 2020-10-23 as part of cleaning
up an unnecessarily complicated function for traversing linked lists.

The memory leak only affected a few lists that actually used Lst_Remove.
Most lists are append-only and are freed using Lst_Done or Lst_Free at
the end, which correctly free the memory.

(rillig)

tests/lint: sync tests for platform-dependent character comparisons

(rillig)

Try to fix the build: HAVE_GETRANDOM does not compile

(martin)

unmask interrupt bits leading to other interrupt registers
now hardware interrupts actually fire instead of being found pending by the
timer interrupt
with this SCSI throughput on my c360 is what you'd expect from an UW esiop

(macallan)

libexpat: add matching #endif for #if 0

(wiz)

Update to latest (thanks rillig)

(christos)

fix ati_drv version after switching to newer sources for everyone.

(mrg)

Ticket #1736

(martin)

Pull up following revision(s) (requested by kre in ticket #1736):

bin/sh/histedit.c: revision 1.60

After (a few days short of) 21 years, revert 1.25, which did nothing except
make the -e option to "fc" fail to work (the commit message was about some
other changes entirely, so I an only assume this was committed by mistake).

It says a lot about the use of the fc command that no-one noticed that
this did not work properly for all this time.

Internally in sh, it is possible for built in commands to use either
getopt(3) (from libc) or the much simpler internal shell nextopt() routine
for option (flag) parsing.    However it makes no sense to use getopt()
and then access a global variable set only by nextopt() instead of the
one getopt() sets (which is what the code had used previously, forever).

Use the correct variable again.

XXX pullup -9 -8  (-7 -6 -5 ...)

(martin)

whitespace

(skrll)

Add more -I to find expat_config.h

(martin)

enable blkdiscard(8) build.

(mrg)

Add constrain arguments

(christos)

fix various typos in comments, mainly immediatly/immediately/,
as well shared and recently fixed typos in OpenBSD code by Jonathan Grey.

(andvar)

bump libssh

(christos)

new OpenSSH

(christos)

Add more -I so that expat_config.h is found

(martin)

Merge differences between openssh-8.8 and openssh-8.9

(christos)

build the newer version of the ati driver frontend, that knows how
to load amdgpu if that is found.

(mrg)

new expat and fold long line

(christos)

merge conflicts between expat-2.2.8 and expat-2.4.6

(christos)

openssh 8.9 out

(wiz)

sqlite-3.38 out

(wiz)

Sort a bit. NFC

(skrll)

API naming consistency.  NFC.

(skrll)

libXi: Fixup libmansuffix in manual pages.

The manpages use unadorned libmansuffix instead of __libmansuffix__ or
@libmansuffix@ that the standard transformations handle.

Add ad-hoc s/// command for it.  It has "3" hardcoded because there's
no easy way to look up that mapping, but then that very same "3" is
hardcoded in the file names anyway.

(uwe)

libXi: Bring back manual pages.

(uwe)

Incllude POWERMAC_G5.local if it exists

(martin)

libXxf86vm: Add missing XF86VidModeAddModeLine.3 mlink.

(uwe)

libXv: add missing man pages added in libXv-1.0.5

While here, split MAN and MLINKS into individual += assignments and
sort them.

(uwe)

Ticket #1429

(martin)

Pull up following revision(s) (requested by kre in ticket #1429):

bin/sh/histedit.c: revision 1.60

After (a few days short of) 21 years, revert 1.25, which did nothing except
make the -e option to "fc" fail to work (the commit message was about some
other changes entirely, so I an only assume this was committed by mistake).

It says a lot about the use of the fc command that no-one noticed that
this did not work properly for all this time.

Internally in sh, it is possible for built in commands to use either
getopt(3) (from libc) or the much simpler internal shell nextopt() routine
for option (flag) parsing.    However it makes no sense to use getopt()
and then access a global variable set only by nextopt() instead of the
one getopt() sets (which is what the code had used previously, forever).

Use the correct variable again.

XXX pullup -9 -8  (-7 -6 -5 ...)

(martin)

Fix wrong assertion, the negatiopn of "a && b" is "!a || !b" so we
need "DIP(ip, blocks) != 0" here.

Should fix PR kern/56725 (Panic when ls directory with device nodes
on an older ffs)

(hannken)

new expat 2.4.6 available

(wiz)

libXext: Fix MLINKS for XShape.3

XShapeQueryExtension.3 and XShapeQueryVersion.3 are not conjoined twins.
While here split XShape.3 links into separate MLINKS += src dst assignments
and sort them.

(uwe)

Convert assembly to something both gcc and clang understand.

(christos)

Validate basic fcntl(2) behavior for eventfd and timerfd.

(thorpej)

Document critical_filesystems_zfs.

(alnsn)

Enable critical_filesystems_zfs.

(alnsn)

Document zfs variable.

(alnsn)

Be less optimistic about i386 system reqirements. Remove extremely outdated
list of support devices.

(nia)

expat-2.4.5 out (security fix release)

(wiz)

PR/56695: Walter Lozano: Correct declaration of hook functions.

(christos)

Backout previous and fix the correct macro magic

(martin)

pmap_pv_protect is not STATIC

(martin)

revert "drm: Respect is_console property on main drm device, not fb child."

breaks booting on some machines

ok riastradh@

(wiz)

Don't crash when reporting an undefined symbol.

(mlelstv)

Implement eventfd_ioctl() and handle FIONBIO so that fcntl(O_NONBLOCK)
works.  While here, also implement FIONREAD and FIONWRITE, and document
why we don't implement FIONSPACE.

Also implement FIONBIO and FIONREAD for in timerfd_ioctl() (for the same
reason).

PR kern/56718

(thorpej)

include pmap_pvt.c in bridge mode as well

(macallan)

Do the space accounting before VOP_INACTIVE() so we may
unlock the vnode after VOP_INCATIVE().

This was the last call from vrelel() to VOP_UNLOCK() with v_interlock held.

(hannken)

Add a marker VUSECOUNT_VGET to v_usecount that gets set whenever
vcache_vget() or vache_tryvget() succeeds.

Use it to rerun VOP_INACTIVE() if another thread ran a vget()..vrele()
cycle while we inactivated our last reference.

(hannken)

If the vnode to vrelel() is already reclaimed there is no need
to lock or defer it.  Jump straight to decrement usecount and requeue.

(hannken)

remove one whitespace to align report, misalignment occured after typo fix.

(andvar)

drm: Fix membars around dma_buf_put reference count release.

(riastradh)

drm/vmwgfx: First draft.  Passes make depend, doesn't build yet.

(riastradh)

evbppc: fix typo from cfargs rototill.

(riastradh)

powerpc: Sprinkle "memory" clobbers on eieio and nearby asm blocks.

Otherwise the compiler may reorder these around loads and stores,
which mostly defeats the purpose.  `asm volatile' just ensures the
instruction isn't _deleted_; it may still move around.

(riastradh)

powerpc: Implement pv-tracking for unmanaged pages.

Needed for drm.

(riastradh)

powerpc: Implement bus_dmamap_load_raw.

Can probably delete some of the round-trips between bus addresses and
physical addresses -- did these only to copy the logic already in
_bus_dmamap_load_buffer.

(riastradh)

drm: Respect is_console property on main drm device, not fb child.

The MD device enumeration sets the property on, e.g., PCI devices --
not on drm framebuffer children, which are mostly a software
abstraction.  Not sure examining the nouveaufb, intelfb, &c., device
properties is worthwhile at all, but in case it breaks something
let's just leave it in while we're fixing other things.

(riastradh)

macppc: Support *macppc* GENERIC.local, not evbarm GENERIC64.local.

Managed to fumble with a copypasta error of local commits, and
committed the one that didn't work instead of the one that did.

(riastradh)

fix various typos, mainly in comments.

(andvar)

s/baord/board/

(andvar)

macppc: Support GENERIC.local.

(riastradh)

sys: Include files.acpica unconditionally.

This way acpica.h always exists unconditionally, so MI code can be
conditional on NACPICA.

It is not great to have such conditionals, but it's better to have

#include "acpica.h"

#ifdef NACPICA > 0

than to have

#if defined(__i386__) || defined(__x86_64__) || defined(__arm__)
#include "acpica.h"
#endif

#ifdef NACPICA > 0

and we can still grep for NACPICA to find places that could be
factored better.

(riastradh)

pmap_pvt.h: Fix bogus include.

(riastradh)

uvm: MI declaration of pmap_pv_protect.

(riastradh)

Ticket #1428

(martin)

Pull up following revision(s) (requested by jakllsch in ticket #1428):

sys/dev/usb/uhidev.c: revision 1.82

Do not explicitly set the HID Report Protocol upon attach, some devices
don't like it and should be in Report Protocol after enumeration/reset
anyway.

May address PR kern/55019.

(martin)

Print Printed Board Assembly (PBA) number.

(msaitoh)

Remove duplicated break. No functional change.

(msaitoh)

Add missing cat pages to fix MKCATPAGES build.

(uwe)

Fix typo, use Nm instead of Xr to itself.

(wiz)

drm: Use KM_SLEEP to allocate reservation fence arrays.

Except as a fast path in an RCU reader.

The array sizes appear to be reasonably small and not trivially
controlled by userland, from what I can tell, so if my impression is
accurate, it is reasonable to sleep for allocation here.

(riastradh)

membar_ops(3): xref bus_dma, bus_space in SEE ALSO section too

(riastradh)

KERNEL_LOCK(9): New man page for old not-dead-yet hack.

I'm not documenting this to encourage anyone to use it.  I'm only
documenting this to remind myself what the semantics is, because it's
kind of confusing and not at all like mutex(9).

(riastradh)

Document the calculation of CC64FSZ

(palle)

... and point merkletree at the correct test directory

(agc)

clean up old test files

do the path and directory test in a different way (cvs has issues with
symlinks, yay - create the test directory on the fly each time

remove the hardcoded test directory

(agc)

This is the updated version of the Merkletree code, version 20220204

Digests supported are a bit more up to date:

blake2b
blake2s
sha256
sha3_256
sha3_512
sha512

The default algorithm is sha512, with an input blocksize of 1024.
Input can either be in the form of files, other directory entries, or
from standard input.

Output is in either standard format (similar to digest(1)),

% merkletree 1.in
sha512/1024 (1.in) 902387724175187f42a6bce7ab7f1a88a4ce536662880747347dc5ea761fed5a7dac5e98962c60b5c3d7988258c0c9e2a14e37cfeb7972fe9086e693381324c8
% merkletree < 1.in
902387724175187f42a6bce7ab7f1a88a4ce536662880747347dc5ea761fed5a7dac5e98962c60b5c3d7988258c0c9e2a14e37cfeb7972fe9086e693381324c8
%

or can be in JSON format:

{"name":"1.in","blocksize":1024,"digest":"sha512","1:0":"902387724175187f42a6bce7ab7f1a88a4ce536662880747347dc5ea761fed5a7dac5e98962c60b5c3d7988258c0c9e2a14e37cfeb7972fe9086e693381324c8"}

(or, run through jq):

% jq . < dist/tests/11.expected
{
  "name": "1.in",
  "blocksize": 1024,
  "digest": "sha512",
  "1:0": "902387724175187f42a6bce7ab7f1a88a4ce536662880747347dc5ea761fed5a7dac5e98962c60b5c3d7988258c0c9e2a14e37cfeb7972fe9086e693381324c8"
}
%

The input blocksize can be specified by the user, but must be twice
the size of the selected digest's algorithm in raw bytes.

It is possible to run merkletree on a hierarchy by using the "-p path"
argument:

% merkletree -a sha3_256 -p / bin
sha3_256/1024 (bin/chgrp) 39e8cc74388ffe34469b1ca91f63d49982662b1c942c9afbd32f48185c3df5ca
sha3_256/1024 (bin/cat) edc35ffbe3ee8c022bb7914530562a3da46680a5e7f3b37749f04ee04cb87cdb
sha3_256/1024 (bin/chmod) c58fca83a80c83f645e80365374be1d9191324cd490a78b99e3ab33fedebacb5
sha3_256/1024 (bin/chio) d8a00ff730bc8a4a108d170ab6f2d690e7f6c201b164b23f256f6013ee08ffef
sha3_256/1024 (bin/domainname) b04a2dafa1a9b14257f63e49acac8c91150c09649519daa3fc0e2f6add79644e
sha3_256/1024 (bin/cp) 7c97f28d4257e6743e315b46d8119baa3718adf6b1b25e4221016dd90db266c6
sha3_256/1024 (bin/cpio) 7e2371ff80c900f31783e147ded8a5a2b87cebdff6eda3638d52611aefe63243
sha3_256/1024 (bin/csh) 16e4e9acd76b3ca6de71a796c77a0593e365048037d0e433cba96d5a8d2b27d4
sha3_256/1024 (bin/date) 05891939e39d7180e8bf252b8b8fc087b309a46e4845b4980bbc3fea1f5307ae
sha3_256/1024 (bin/dd) 67b28e1d3399a2edef52b39683a0d8b56f812fa37b56aeda92a427b0db50dfb8
sha3_256/1024 (bin/df) a360c756b2d64003247140924b8223b1dbe161f9b70ce96a915c85d9bab23e51
sha3_256/1024 (bin/hostname) ddba878bc063a3123cdb4cf8d272a0438ab2f6a4141618e70726fda45f41b1cb
sha3_256/1024 (bin/echo) cd3c415f168bb4a8df2e2f12b1238137b7004453affa5497741175761e516cc0
sha3_256/1024 (bin/ed) 7a915104df73a5682d091fb0214af110e4c1c6bec306d9ccf2ffd527c09c856e
sha3_256/1024 (bin/expr) aaf51c742e02ca40abc402a6fdd283488c11d3e549039d0d62e7c29795987185
sha3_256/1024 (bin/mkdir) e425ae2f2c7771d4e4bfae0f335c44016548a37eb1915b5ed665ba4e4feeb1b6
sha3_256/1024 (bin/kill) 999a17e8c03e022180fe842e92273f7656719027618bb9de90b46ada48ab518f
sha3_256/1024 (bin/ksh) a862c37708a7417a4e35ed04363ef3d83c141efc5659eb04c141063fe0ec7ba2
sha3_256/1024 (bin/ln) a0e93d49eba74b0b48a712fa143faaf9735cf7a82343e992cb12b3cc8fa485c2
sha3_256/1024 (bin/ls) 006d65534a13845efa9af7c252174e54a75c142a1db4dfd86c78f95c7f5297b6
sha3_256/1024 (bin/pax) 0fb2c7557feb33ea9073b36db01a44ef4b2609386a4fb771db21ad44fd48064f
sha3_256/1024 (bin/sleep) d548731fc8b401d2070ab4eeeeab84c012d69c96a0a71dd8b7f882862b481ff0
sha3_256/1024 (bin/mt) 8223efa972949ebe508ca066bc9e9b7ee0c8f3dbec42b68919134bf2c38cdf2e
sha3_256/1024 (bin/mv) 65c5830326958f85165d49e673935df4305dff3802c86010e8c7efbccb084a33
sha3_256/1024 (bin/rmdir) 5b785cfb9594247f5772b15e6946e7546929679c170b40fcd0275a68ffa95eac
sha3_256/1024 (bin/ps) 8d5e766181cfa5d2174bd558994b773eddfdd126474b06bf9f4e1a87fc93dde0
sha3_256/1024 (bin/pwd) 5fd7c3c5e9af7135248afa1e01a3a431536ffc9363c26d74cd2ba95e44bb13dc
sha3_256/1024 (bin/rcmd) a6fde1189f80f354f024621954ec2630589384268182f458737a7d0820193d7d
sha3_256/1024 (bin/rcp) 9863785c1f95449150dddf634c4d0485b12fcd33f3fff85a268805b13665fc09
sha3_256/1024 (bin/rm) ba9f8bf91fb070db7aaccccbe21a79263810a6e7ce65dff93932fce569effb57
sha3_256/1024 (bin/tar) 5441da55b4db7ee6b5acd603edad069a1fa8a61643b1b6e6b4c14eb75e4239ec
sha3_256/1024 (bin/rump.dd) a15b1a5aa3b6b59568e2cae5cbfb2979abf0d73734f0b049fa1e13426b2cf035
sha3_256/1024 (bin/sh) 29b86c7f8fa34ac6d8a4e04e4b9280ca986f1e99906743eea2c4fe96b9cd16fc
sha3_256/1024 (bin/stty) 4b33e1afb82cabf8c93fe96bb419b6449d25ed28dc4e9a8afb94736f6922e087
sha3_256/1024 (bin/sync) 5b454179f10e47af9a49d6d4b473c1c833878f50dba49bb664a5b36a8e12ee36
sha3_256/1024 (bin/tcsh) 9ec17e221e01fea34b67e1c8db27dcd6360f749fa1ab64d1d4405e966cd7c6b2
sha3_256/1024 (bin/test) e04425b059ff599cc672d9e0dc81e887630c6243ae0e13461a5158fea4740a64
sha3_256/1024 (bin/[) e04425b059ff599cc672d9e0dc81e887630c6243ae0e13461a5158fea4740a64
sha3_256/1024 (bin/getfacl) 5bb9a9e1ffed1624dd9a2560e2378ac6c5ac3b071ff263b87a67160764244934
sha3_256/1024 (bin/setfacl) 1b098acf1fa48cada519a1f1e84fd87566462ae939a7976db88bdfed179287b8
%

(agc)

Revert "i915: Defer final wakeup on active until after retirement."

This reverts i915_active.c 1.11.  ref->retire might free the object,
so touching it is not allowed -- that would use-after-free.  Linux
uses the object only for its address with wake_up_var.

The reason I made this change was that I guessed i915_active_wait has
to wait until after ref->retire finishes -- after all, Linux seems to
defer the wakeup until then.  However, even the Linux code doesn't
guarantee this, because i915_active_wait could be called _during_
ref->retire, and would witness ref->count == 0, and would not wait
until it has completed in that case.  So maybe my guess was wrong,
and it is OK for i915_active_wait to return while ref->retire is
still in flight -- I don't see any logic that obviously requires it
to wait for ref->retire, in any case.

Or maybe something does rely on i915_active_wait to wait for
ref->retire to finish, in which case we need a different mechanism
for i915_active_release itself to wait until i915_active_retire has
woken up, without dereferencing ref since it might be dead after
ref->retire.

(riastradh)

Define becquerels in base units (like curies and rutherfords already are),
rather than in terms of curies.

Add symbol Bq for becquerel.

(jakllsch)

fix inconsistent whitespace in units.lib

(jakllsch)

Regen.

(msaitoh)

Add VMware AHCI and NVMe.

(msaitoh)

i915: Defer final wakeup on active until after retirement.

Not sure what I was thinking when I moved this earlier!

(riastradh)

linux: Don't skip the last node in rbtree iteration.

(riastradh)

drm/mm: Find nearest geq/leq, not matching, holes in first_hole.

(riastradh)

drm/mm: Allow hole address range queries.

(riastradh)

drm/mm: Assert invariant of another rb lookup.

This one looks a little more questionable.

(riastradh)

drm/mm: Assert invariant of rb lookup.

Just to make sure I didn't get the sense of the lookup reversed,
which is quite likely, because I've done it probably more than once
in this code before...

(riastradh)

drm/ttm: Avoid uninitialized mem in error branch.

Not sure why this error branch is getting hit, but let's not make the
problem worse by choking on stack garbage.

Candidate fix for symptom of PR kern/56565, PR kern/56711.
Underlying problem -- that ttm_bo_mem_space fails with ENOMEM --
remains.

(riastradh)

usbdi(9): Add some missing header include guards.

(riastradh)

usbdi(9): Fix missing includes in usbdi.h.

(riastradh)

hppa: Membar audit in cpu.c.

(riastradh)

Ticket #1427.

(msaitoh)

Pull up following revision(s) (requested by martin in ticket #1427):
usr.sbin/sysinst/defs.h: revision 1.80
usr.sbin/sysinst/target.c: revision 1.18
usr.sbin/sysinst/arch/i386/md.c: revision 1.35
x86: fix previous: in the UEFI case copy the bootloaders from install
media during initial installation, but use the (by then: updated)
files from the target disk for system upgrades.

(msaitoh)

drm: Delete mmiowb.

This no longer exists in Linux.

(riastradh)

s/APCI/ACPI/

(andvar)

fix few typos in comments and log message.

(andvar)

1. restore the previous finish() logic to make:
script -e -c /usr/bin/true
script -e -c /usr/bin/false
  exit with the proper exit code.
2. handle system return value correctly (nabijaczleweli)
3. factor out the conversion of wait status -> shell return code.

(christos)

x86: Membar audit in idt.c.

- idt_vec_free/alloc are obviously supposed to synchronize with a
  happens-before relation, so use release/acquire.

- There is no store-before-load ordering needed, so omit membar_sync.

(riastradh)

rump: Omit unused EIEIO #define, vestige of powerpc bus_dma.c.

(riastradh)

thmap(9): Omit needless fences and use membar_exit for release fence.

It is the caller's responsibility to arrange that thmap_create, and,
if THMAP_SETROOT is set, thmap_root, happen before any use of the
thmap.  No need for them to issue fences internally.

(riastradh)

npf(4): Use atomic_store_release and atomic_load_consume for conn_db.

...or atomic_load_relaxed, when npf->conn_lock is held, for the sake
of C11.

No need for store-before-load implied by membar_sync.

(riastradh)

npf(4): Use atomic_store_release and atomic_load_consume for config.

...or atomic_load_relaxed, when the config is locked.  (Not necessary
to use atomic_* at all in NetBSD, but in C11 it will be cheaper to
say atomic_load_relaxed explicitly so an _Atomic-qualified object
doesn't cause the load to be surrounded by unnecessary membars.)

No need for store-before-load ordering here, so no need to
membar_sync.

(riastradh)

vmx(4): Omit needless membar_sync wrapper.

Nothing uses this, and it is unlikely that any part of this driver
will need store-before-load ordering to synchronize with the host.

(riastradh)

iscsi(4): Fix config_found usage -- needs kernel lock.

Candidate fix for PR kern/56709.

(riastradh)

eqos(4): Nix trailing whitespace.  No functional change.

(riastradh)

eqos(4): membar_* is not appropriate here; use bus_dmamap_sync.

(riastradh)

Fix typo

(pgoyette)

hppa: __cpu_simple_lock membar audit.

ok skrll

(riastradh)

alpha: __cpu_simple_lock audit.

Add missing "cc" and "memory" asm clobbers to the compiler can't
reorder memory access around these.  The necessary memory barrier
instructions, mb, already appear in all the right places.

(riastradh)

vax: __cpu_simple_lock audit.

Fix missing "memory" asm clobber so the compiler can't reorder memory
access around __cpu_simple_lock/lock_try/unlock.

(riastradh)

or1k: __cpu_simple_lock membar audit.

(riastradh)

sh3: __cpu_simple_unlock needs __insn_barrier.

No multiprocessor support here but the compiler can still reorder
memory access.

(riastradh)

m68k: __cpu_simple_unlock audit.

- Use `cc' clobbers in asm volatile because they touch the condition
  codes.

- Use `memory' clobbers in asm volatile so the compiler doesn't move
  up loads and stores in the critical section at _other_ addresses
  than the lock so they happen before __cpu_simple_lock or
  __cpu_simple_lock_try.

- Not sure if we have any (or if there even are any?) multicore m68k
  systems out there, but __cpu_simple_unlock needs __insn_barrier
  either way so the compiler doesn't delay loads and stores prior to
  __cpu_simple_unlock so they happen after it.

(riastradh)

acorn32: Partial __cpu_simple_lock membar audit.

For __cpu_simple_unlock, __insn_barrier is absolutely required.
Whether we need a stronger memory barrier, I don't know offhand and
I'm not sure what the right architecture manual to consult is -- it's
not clear why this isn't just using the generic arm lock.h.

(riastradh)

sparc: __cpu_simple_lock membar audit.

No functional change -- comments only, to justify the absence of
barriers with reference to chapter & verse.

(riastradh)

remove dup assignments (RVP)

(christos)

indent: consistently use nparen for indexing parser_state.paren

No binary change.

(rillig)

indent: rename parser_state.p_l_follow and paren_level

The previous variable names were misleading.

Paren_level is not the current level of parentheses but the one from the
beginning of the current output line.  For better accuracy, rename it to
line_start_paren_level.

P_l_follow is not the level of parentheses that will be active at some
point in the future, as the previous name suggested.  Instead, it is the
level of parentheses right now.  For better accuracy, rename it to
nparen.  This nicely matches its main usage, which is as index to the
parser_state.paren array.

No binary change.

(rillig)

PR port-macppc/56091: on G5 macs we currently can not easily make
early serial console work, so keep the OF based "failsafe" console
but note that we would like to switch over.
Once zs attaches, use the new device mapping and do a belated init
of the zs console globals, and then switch over to real zs based
serial console.

(martin)

indent: replace bitmasking code with struct

The struct directly represents the properties of a pair of parentheses,
without forcing the human reader to decode any bitset.  This makes it
easier to find the remaining bugs in the heuristic for determining the
kind of parentheses.

No functional change outside debug mode.

(rillig)

indent: change parser_state.cast_mask to 0-based indexing

Having 1-based indexing was completely unexpected, and it didn't match
the 0-based indexing of parser_state.paren_indents.

No functional change.

(rillig)

tests/indent: test token '('

There are already some tests in token_lparen.c that need to be merged.

(rillig)

tests/indent: demonstrate the poor handling of compound literals

(rillig)