make(1): in lint mode, exit with error status on errors

Calling Parse_Error during parsing has always led to a nonzero exit
status.  Calling Parse_Error later, when expanding the shell commands,
has had no effect on the exit status.  Neither had calling Error.

To make make a reliable tool, it has to report errors as they occur.
Enable this strict behavior in lint mode for now.  Lint mode has to be
enabled explicitly, preserving the default behavior.

(rillig)

make(1): clean up StrContainsWord

(rillig)

make(1): fix out-of-bounds pointer in ParseTrackInput

(rillig)

make(1): rename parameter of Var_Value

(rillig)

make(1): improve local variable name in ParseTrackInput

By the way, the Address Sanitizer that ran over this code on 2015-11-26
didn't find the other out-of-bounds bug.  Most probably the Address
Sanitizer only detected obvious bugs in the actual test data, and there
was no test case in which .MAKE.MAKEFILES was shorter than the newly
added makefile.

(rillig)

make(1): fix off-by-one bug in ParseTrackInput (since 2015-11-26)

(rillig)

make(1): add test for off-by-one bug in ParseTrackInput

(rillig)

Install ddb(9).  Xref it from ddb(4).

(uwe)

make(1): document possible undefined behavior in trace.c with .CURDIR

(rillig)

make(1): document local variable in parse.c more precisely

(rillig)

recognize some more G4 model names produced by config.guess
now native tools builds on ppc7447 and ppc7455 work again

(macallan)

make(1): make parsing of the :gmtime and :localtime modifiers stricter

These variable modifiers accept an optional timestamp in seconds, to
select which date to print.  This feature is only used very rarely.  The
NetBSD build doesn't use it at all, and the FreeBSD build mainly uses
the plain modifiers :gmtime and :localtime, but not their optional
argument :gmtime=1500000000.

Therefore, this change is not going to affect many builds.  Those that
are indeed affected had been wrong all the time anyway.

At parse time, these errors stop the build, as intended.  After that,
when the actual shell commands of the targets are expanded and run,
these errors don't stop anything, the build just continues as if nothing
had happened.  This is a general problem with Var_Parse, see the many
"handle errors" markers in the code.  Another problem is that on parse
errors, parsing continues and spits out spurious strings of the form
"mtime" and "ocaltime".  This as well is a general problem with error
handling in make.

ok sjg

(rillig)

make(1): add test for debug log for expansion of curly braces

(rillig)

make(1): mark the output in test dir.mk with a prefix

This is needed to distinguish it from the debug log, which will be added
in the next commit.

(rillig)

Main_SetObjdir is first called for curdir which may be readonly

Skip access check if path is curdir.
This ensures that all proper initialization is done at least once.

If path is not curdir it should be writable to be useful.

Reviewed by: rillig

(sjg)

make(1): add more tests for the variable modifier :localtime

(rillig)

make(1): add test for :gmtime with space before the number of seconds

(rillig)

make(1): add tests for error handling in the :gmtime variable modifier

(rillig)

make(1): format #include directives consistently

(rillig)

make(1): remove unused code from needshell

Since usr.bin/xinstall no longer uses this code, there is no need to
keep the second parameter.

(rillig)

make(1): rename ismeta to is_shell_metachar

The old name was too broad.

(rillig)

make(1): remove debug logging for the :Q variable modifier

The same information is already logged in LogAfterApply.

(rillig)

make(1): fix local variable names in ParseModifierPart

(rillig)

make(1): remove dead code for filename expansion using curly braces

Any string containing curly braces is already handled in the very first
if statement.

(rillig)

make(1): revert requiring a writable objdir

The change in main.c 1.413 broke the NetBSD build.sh if it uses a
read-only source tree, as in the daily builds.

Original commit:
https://mail-index.netbsd.org/source-changes/2020/10/31/msg123560.html

Build log:
make warning: /home/source/ab/HEAD/src: Permission denied.
[1]  Segmentation fault      "${make}" -m ${T...

(rillig)

document f_touch

(christos)

Revert (REPE) CMPS support per request of Maxime, it is incorrect.

(reinoud)

make(1): rewrite VarIsDynamic to VarnameIsDynamic

The condition for the context is the same for both short and long names,
therefore move that condition to the only caller.

Clean up the comment and move its parts to the appropriate places.  The
"with the dollar sign escaped" part had been wrong already in 1993, and
it didn't get better over time.

(rillig)

Use the 'mv' pseudo-instruction instead of the 'move' equivalent as 'mv'
is mentioned in the ISA documentation and it's used elsewhere.  That is,
let's use 'mv' everywhere for consistency.

(skrll)

Avoid hard-coding names and limits so this will not break again.

(christos)

Add an array of filter names.

(christos)

make(1): rename local variable freePtr in Var_Parse

(rillig)

make(1): use consistent parameter order in varname parsing functions

(rillig)

make(1): extract ParseVarnameLong from Var_Parse

(rillig)

Detach led's and sysmon in our detach routine.

(jdc)

Detach led's in our detach routine.

(jdc)

add missing sentence.

(christos)

make(1): extract ParseVarnameShort from Var_Parse

With its more than 200 lines, the latter has too much code to be read
easily.

(rillig)

Fix armv6 builds by providing an armv6 is macro

(skrll)

make(1): add test for recursion detection with short variable names

(rillig)

mesa: re-enable GLX TLS to help i386

mesa's assembly code for i386 only seems to be position independent
when compiled with ELF TLS, so having it disabled causes worse problems
than the edge cases ELF TLS causes.

potentially the assembly code could be fixed (it looks like it not
being safe is a bug), it could also be disabled, but i don't currently
have the means to measure the impact of that.

(nia)

Call sysmon_envsys_unregister() not sysmon_envsys_destroy() when
detaching.  Pointed out by Michael van Elst.

(jdc)

make(1): fix function names in test for variable debugging

(rillig)

make(1): fix type of ParseModifierPart parameter delim

(rillig)

make(1): extract IsEscapedModifierPart from ParseModifierPart

(rillig)

make(1): clean up ModifyWords

Reorder the parameters to match the documentation comment, and the
remaining parameters in chronological order.  Remove the unused
parameter ctxt.  The callbacks that need it pass it in their
modifyWordArgs instead.

(rillig)

make(1): add test for combining the :@ and :? variable modifiers

(rillig)

make(1): remove redundant condition for regmatch_t.rm_eo being -1

If rm_so is -1, rm_eo is guaranteed to be -1 as well.

(rillig)

make(1): add tests for edge cases in the :C variable modifier

(rillig)

make(1): make memory allocation simpler in meta_create and meta_oodate

Since there is only a single variable left that needs to be freed at the
end (and probably never actually needs to be freed since nobody defines
an environment variable named .OBJDIR), there is no need to loop over
these variables.

(rillig)

make(1): do not look up local variables like .TARGET anywhere else

Nobody defines a global variable named .TARGET since that would have
many unpredictable effects, applying to all targets at once.

Nobody defines an environment variable named .TARGET since that's
against the naming conventions for environment variables and would have
the same effect.

Because of this, there is no point looking up the variables that are
local to a GNode anywhere else.  This means they cannot come from the
environment and thus their value doesn't need to be freed after use,
which makes the code simpler.

The newly added accessor functions in make.h refer to external
functions, but since that header is not used anywhere outside of
usr.bin/make, it doesn't matter.  Between 2020-08-25 and 2020-10-30,
that header had been referenced by usr.bin/xinstall.

(rillig)

make(1): reduce the scope where recursive expressions are detected

Only the call to Var_Subst needs to be protected since the other
functions have nothing to do with expanding variables.

(rillig)

make(1): add test for recursive variable expressions

(rillig)

make(1): merge the SysV modifier tests into varmod-sysv

(rillig)

use the same indentation for all libcurses test files

(rillig)

Remove trailing whitespace.

(wiz)

Improve wording.

(wiz)

make(1): add tutorial for the :from=to variable modifier

(rillig)

make(1): fix indentation in source code

(rillig)

make(1): extract loadedfile_mmap from loadfile

(rillig)

make(1): remove redundant :tl from getBoolean

Uppercase and lowercase letters are already handled the same by
s2Boolean, which makes the :tl modifier redundant.

(rillig)

make(1): remove redundant null check from s2Boolean

(rillig)

make(1): write s2Boolean in a more compact form

(rillig)

make(1): clean up mkTempFile

(rillig)

make(1): remove redundant code branch in SysVMatch

The general code path of parsing :from=to achieves the same effect.

(rillig)

make(1): merge duplicate code in ModifyWord_Subst

(rillig)

make(1): explain tests for the SysV variable modifier

(rillig)

Do not use an objdir that is not writable.

(sjg)

Match linux here and wait without interrupts.

>From David H. Gutteridge in PR port-amd64/55555
There's a second part to the patch, but "make our code behave the way
the upstream code does" is very welcome.
Also PR kern/54515 and possibly others.

(maya)

PR/55663: Ruslan Nikolaev: Add support for EVFILT_USER in kqueue(2)

(christos)

Fix directive-unexport to focus only on the variables we care about

(sjg)

make(1): rename Str_SYSVMatch and its parameters

(rillig)

use c99 initializers

(christos)

make(1): improve variable name in Var_Value, document callback

(rillig)

make(1): remove unsatisfiable conditions in Var_Set_with_flags

(rillig)

make(1): document where the variable name is expanded

(rillig)

Add a few missing articles.

(uwe)

c99 struct initializers

(christos)

fix indentation

(christos)

fix indentation

(christos)

ddb(9) - first cut at the documentation for writing and adding new DDB
commands.  Not yet complete and not hooked into the build.

(uwe)

Update the test a little so that is possible to pass
(if date fails, because of bad or out of range input
to parsedate, it cannot be expected to output the
expected result).

Remove the atf-expect-fail now that parsedate() should
detect overflows, and fail, causing date to fail, rather
than simply producing bogus results.

(kre)

PR lib/46542

Add checks to detect overflow, and also detect other invalid
(out of range) inputs for parsedate().

There could be more, and some of what is being added is not
perfect, but many calculation overflows will be detected now
(and cause an error return) and some of the most bizarre
inputs that were previously accepted no longer will be.

(kre)

ossaudio(3): Simplify setting rate (try to supply the nearest one possible)

(nia)

Implement missing (REPE) CMPS instruction support in NVMMs x86_decode().

In apparently rare cases the (REPE) CMPS instruction can trigger an memory
assist. NVMM wouldn't recognize the instruction and thus couldn't assist and
Qemu would abort.

(reinoud)

make(1): demonstrate double expansion when appending to a variable

(rillig)

make(1): change char * to void * in Var_Value

The only purpose of the parameter freeIt is to free the memory
associated with the return value.  To do this, no pointer arithmetic is
needed.  Therefore, change to a void pointer, to catch accidental use of
that pointer.

(rillig)

install(1): copy metachar table from usr.bin/make

It is not worth having a dependency on usr.bin/make just for including
this small table.  The header file usr.bin/make/make.h, which is
included for consistency with the rest of the usr.bin/make code, is
using inline functions a lot and refers to several parts of make that
are completely irrelevant to usr.bin/install.

(rillig)

make(1): remove comment about adding is_shell_metachar to ctype.h

This function is so specialized that it would be wrong to have it in a
general-purpose C header.

(rillig)

Retire arm_[di]sb in favour of the isb() and dsb(sy) macro invocations.

(skrll)

PR 55769: avoid the module set if we do not build any

(martin)

make(1): add test for an edge case of .unexport

(rillig)

make(1): clean up comments and local variables in var.c

(rillig)

make(1): fix documentation for VARP_SUB_ONE

The pattern is only replaced a single time, not everywhere in the first
matching word.

(rillig)

make(1): make iterating over HashTable simpler

(rillig)

make(1): rename VAR_EXPORTED_YES to VAR_EXPORTED_SOME

The "yes" sounded too much like "all".

(rillig)

Remove "also;"

(skrll)

make(1): document VAR_READONLY, now that it is really read-only

(rillig)

make(1): prevent appending to read-only variables

(rillig)

Add a "show fdt" ddb command

(skrll)

make(1): fix indentation in source code

(rillig)

support screen blanking of r5xx
somewhat crude but works

(macallan)

make(1): extract MayExport from Var_Export1

(rillig)

make(1): demonstrate how to append to a read-only variable

(rillig)

make(1): move test flags for varname-dot-shell to the test itself

(rillig)

make(1): clean up is_separator

(rillig)

make(1): fix comments in test for string literals in conditions

(rillig)

make(1): fix parse error in string literal in conditional

The string literal "${VAR} " had produced a "Malformed conditional", at
least since 2003.  (That's the oldest make I have available for testing.)
Strange that nobody else noticed that in the last 17 years.

(rillig)

make(1): add more test cases that fail in condition string literals

(rillig)

make(1): add test for two variable expressions in a string literal

(rillig)

Use the same macro used before for avoiding too large floats on vax.

This has the advantage of not changing the number for non-vax, so is a
safer change for those architectures.
(Might not actually matter).

(maya)

Add bigger console font for modern displays.

(rin)

Add smscphy(4).

(rin)

Fix tcpdump example from "窶進 npflog0.pcap" to "窶進 npflog0"

(abs)

libsqlite3 now requires -lm

(martin)

make(1): demonstrate parse error in string interpolation in condition

(rillig)

make(1): remove redundant evaluations in VarFind

(rillig)

make(1): replace VarFindFlags with a simple Boolean

Either all flags had been given or none.  Except in Var_Append, but
since the ctxt was VAR_GLOBAL anyway, adding FIND_GLOBAL there did not
make a difference.

(rillig)

make(1): rename FIND_CMD to FIND_CMDLINE, to match VAR_CMDLINE

While here, use a consistent order for the enum constants.  This is both
the declaration order and at the same time the usual lookup order,
unless the -e option is given.

(rillig)

make(1): rename VAR_CMD to VAR_CMDLINE

Since make has to do with both the command line and child commands, the
former name was confusing.

(rillig)

Sort the db_show_cmd entries

(skrll)

Put the 'added from all sub cmds' comment above the four commands that
were added as part of the work in r1.98

(skrll)

Whitespace

(skrll)

make(1): rename SAVE_DOLLARS to follow the naming conventions

(rillig)

Trailing whitespace

(skrll)

make(1): clean up and update module comment in var.c

(rillig)

Add pcagpio and pcf8574io - hardware status monitors on V210/V240 and E250.

(jdc)

Add WMPHY_I350. Not used yet.

(msaitoh)

Add new sysctl hw.wmN.debug_flags. This sysctl can be used if WM_DEBUG is set.
OK'd by knakahara.

% sysctl -d hw.wm0.debug_flags
hw.wm0.debug_flags: Debug flags:
        0x01 LINK
        0x02 TX
        0x04 RX
        0x08 GMII
        0x10 MANAGE
        0x20 NVM
        0x40 INIT
        0x80 LOCK

(msaitoh)

Instead of a random 'prohibitively high' value, use DBL_MAX so it builds on VAX

(martin)

Add one.

(simonb)

make(1): move comment from Parse_DoVar to Parse_IsVar

(rillig)

G/c spurious whitespace.

(uwe)

lib: Move sqlite, since it depends on libm

(nia)

make(1): add test for the :Q modifier

(rillig)

make(1): add test for default format of the :localtime modifier

(rillig)

make(1): add test for default time format of the :gmtime modifier

(rillig)

make(1): add test for ignoring assignment to read-only variable

(rillig)

make(1): move MAKEFLAGS handling in vardebug test to the test itself

(rillig)

make(1): add test for .export and Var_Delete

(rillig)

sqlite: fts5 extension requires we link with -lm

(nia)

sqlite3: Turn on extensions that default-on using the configure script

Includes json1 and fts5, which are both needed by various things in pkgsrc

(nia)

wscons(4): WSKBD_TYPE_PC_AT is automatically translated to
WSKBD_TYPE_PC_XT in modern kernels

(nia)

Fix obvious copy&pasto

(martin)

Add a driver for the PCF8574 I/O expander, used as a GPIO in some sparc64
hardware.
The driver currently handles pins configured as LED or INDICATOR and adds
them to the LED and sysmon_envsys subsystems, respectively.

(jdc)

Handle the change in the sparc64 OFW patching, where we now encode the
GPIO pin type in the pin name (only LED types are currently handled).

(jdc)

Add information about GPIO pin assignments and drive bays in the E250 and
v240.  Consolidate common code for v210/v240 and E250.
Modify the GPIO pin names to include a type (currently LED or INDICATOR)
which we can then handle in the driver.

(jdc)

Disable the wgetch test as it appears to be missing at the moment.

(blymn)

add missing vmt_fdt.c.

sorry, I forgot to commit vmt_fdt.c in http://mail-index.netbsd.org/source-changes/2020/10/27/msg123452.html

(ryo)

xorg: retire XTrap library and sample clients

the DEC-XTRAP extension is deprecated since 1994, so modern X servers do
not support it

the library was removed from pkgsrc last year and is not required by
anything not-sample-client related in src

if you try to query the protocol on netbsd, you get the following:

$ xtrapproto
Display:  :0.0
Warning: Can't load DEC-XTRAP extension
xtrapproto: could not initialize extension

(nia)

Add smscphy(4) found on some RPI models.

(rin)

Add missing drain for pcq in wm_stop_locked(). OK'd by knakahara.

This change fixes two problems:
1. If the pcq is full and watchdog timer is fired, the full state of the
    pcq is kept and wm_transmit() returns with ENOBUFS.
2. ifconfig down doesn't free mbufs in the pcq.

(msaitoh)

make(1): rename defIncPath to defSysIncPath

There are two variables, parseIncPath and sysIncPath, which made the
name defIncPath ambiguous.

(rillig)

make(1): merge curFile into includes

This makes GetActuallyIncludingFile simpler since it no longer needs the
special case for curFile.

The type of 'includes' has changed from Vector<IFile *> to
Vector<IFile>, to avoid a few extra memory allocations and because
Vector is easier to use with structs than with pointers (see
GetInclude).

(rillig)

make(1): inline Vector_Get

It is simple enough that it neither bloats the code nor warrants the
extra function call.

(rillig)

make(1): rename predecessor to order_pred

The new name aligns nicely with the GNode field of the same name.

(rillig)

s/USENET/USBNET/ in another place i just happened to find by
typo-ing "UBS" as "USE".

(mrg)

make(1): sort ParseSpecial alphabetically

(rillig)

make(1): remove unused, undocumented .NOEXPORT

(rillig)

make(1): rename ParseSpecial enum values consistently

The previous naming scheme was inconsistent in that dotError started
with a lowercase character and ExObjdir and ExPath had a distracting
prefix.

(rillig)

make(1): rename some fields of struct IFile

The initial "P_" of these field names didn't match anything else.  The
documentation was missing the purpose of the buffer.  The start of the
buffer is only needed to free it later, so reflect that in the variable
name.

(rillig)

make(1): clean up API comment in parse.c

(rillig)

Add additional debugging output.
Track more chip state in the softc and check the chip state via a timer.
This allows us to easily observe changes caused by external events
(e.g. disk removal or PSU failure).

(jdc)

make(1): extract InitMaxJobs from main

(rillig)

make(1): extract InitObjdir from main

(rillig)

make(1): make InitVarMake simpler and document its intention

(rillig)

make(1): extract InitVarMake from main

(rillig)

Update mopd for 4k VAX page size and support 1k page a.out binaries

>From dreamlayers

(abs)

make(1): extract InitRandom from main

(rillig)

Fix Linux pfInit() parameter order for mopd

>From dreamlayers

(abs)

When we did not magically find any CD medium with sets, offer a manual
override (so ISO images on USB sticks or Xen's xbd(4) work).

(martin)

Report HW DMA capability and if the DMA tag limits it.

(skrll)

s/UBS/USB/ in a macro and its use.

pointed out by nisimura@.

(mrg)